November 2007 - Wine-devel - list.winehq.org

Re: msvcrt heap: fix _aligned_offset_realloc (move correct block of memory); add a comment to explain why. [1/2]
by Alexandre Julliard 27 Nov '07

27 Nov '07

Lionel Debroux <lionel_debroux(a)yahoo.fr> writes: > + Therefore, "size" bytes of actual data have to be moved from the offset > + they were at in the old block (temp + old_padding) to the offset they > + have to be in the new block (temp + new_padding == memblock). > +*/ > if (new_padding != old_padding) > - memmove((char *)memblock + old_padding, (char *)memblock + new_padding, size); > + memmove((char *)memblock, (char *)temp + old_padding, size); You also have to take into account the fact that the size may have changed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Reading Registry Example
by James McKenzie 27 Nov '07

27 Nov '07

All: I would like to work on the eventlog.c and would like pointers to an example of reading a registry example under Wine. Thank you. James

2 1

Re: USER32: win16 applications should not see long filenames returned from dialog control (try 4) (RESEND)
by Alexandre Julliard 27 Nov '07

27 Nov '07

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > Changelog: > * Win16 applications should not see long filenames. Change directory > listbox to return short names when called from the 16-bit wrappers. You are still calling GetShortPathName on potentially uninitialized data. You simply can't do this with a wrapper around the 32-bit DlgDirSelect, you have to duplicate the code. But first it would be worth checking if the listbox shouldn't rather be populated with short path names in the first place. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: David Adam : d3dx8: Implement D3DXQuaternionInverse.
by Robert Shearman 27 Nov '07

27 Nov '07

Alexandre Julliard wrote: > /*_________________D3DXQUATERNION________________*/ > > -D3DXQUATERNION* WINAPI D3DXQuaternionMultiply(D3DXQUATERNION * pout, CONST D3DXQUATERNION *pq1, CONST D3DXQUATERNION * pq2) > +D3DXQUATERNION* WINAPI D3DXQuaternionInverse(D3DXQUATERNION *pout, CONST D3DXQUATERNION *pq) > +{ > + D3DXQUATERNION temp; > + FLOAT norm; > + > + norm = D3DXQuaternionLengthSq(pq); > + if ( !norm ) > + { > + pout->x = 0.0f; > + pout->y = 0.0f; > + pout->z = 0.0f; > + pout->w = 0.0f; > + } > + else > + { > + D3DXQuaternionConjugate(&temp, pq); > + pout->x = temp.x / norm; > + pout->y = temp.y / norm; > + pout->z = temp.z / norm; > + pout->w = temp.w / norm; > + } > + return pout; > +} > + > +D3DXQUATERNION* WINAPI D3DXQuaternionMultiply(D3DXQUATERNION *pout, CONST D3DXQUATERNION *pq1, CONST D3DXQUATERNION *pq2) > { > pout->x = pq2->w * pq1->x + pq2->x * pq1->w + pq2->y * pq1->z - pq2->z * pq1->y; > pout->y = pq2->w * pq1->y - pq2->x * pq1->z + pq2->y * pq1->w + pq2->z * pq1->x; This change causes the following warnings for me: math.c: In function ‘D3DXQuaternionInverse’: math.c:695: warning: ‘temp.x’ may be used uninitialised in this function math.c:695: warning: ‘temp.y’ may be used uninitialised in this function math.c:695: warning: ‘temp.z’ may be used uninitialised in this function math.c:695: warning: ‘temp.w’ may be used uninitialised in this function $ gcc --version gcc (GCC) 4.0.3 (Ubuntu 4.0.3-1ubuntu5) Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. I believe that this is causes by D3DXQuaternionConjugate not writing to temp in one case (pq being NULL) and the compiler not recognising that this case is already covered by the !norm branch above, since D3DXQuaternionLengthSq will return 0.0f if pq is NULL. The attached patch works around the warning. However, there are currently no tests for the case of pq being NULL so I don't know whether it is correct. -- Rob Shearman diff --git a/dlls/d3dx8/math.c b/dlls/d3dx8/math.c index 04072bf..8edd1d3 100644 --- a/dlls/d3dx8/math.c +++ b/dlls/d3dx8/math.c @@ -696,7 +696,7 @@ D3DXQUATERNION* WINAPI D3DXQuaternionInverse(D3DXQUATERNION *pout, CONST D3DXQUA FLOAT norm; norm = D3DXQuaternionLengthSq(pq); - if ( !norm ) + if ( !norm || !pq ) { pout->x = 0.0f; pout->y = 0.0f;

2 1

Re: [dbghelp 1/11] Update some mscvpdb.h definitions and descriptions
by Alexandre Julliard 27 Nov '07

27 Nov '07

"Jason Green" <jave27(a)gmail.com> writes: > The Original Author for the following set of patches is Eric van > Beurden from TransGaming, Inc. When submitting patches written by someone else please include a valid From: line in the patch header with his full name and email. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [dbghelp 2/11] Return TRUE in SymInitializeW if process is already initialized and add a number of TRACEs
by Alexandre Julliard 27 Nov '07

27 Nov '07

"Jason Green" <jave27(a)gmail.com> writes: > @@ -216,11 +216,17 @@ static BOOL WINAPI process_invade_cb(PCSTR name, ULONG base, ULONG size, PVOID u > char tmp[MAX_PATH]; > HANDLE hProcess = (HANDLE)user; > > - if (!GetModuleFileNameExA(hProcess, (HMODULE)base, > - tmp, sizeof(tmp))) > + > + TRACE("found module %s {base = 0x%08x, size = 0x%08x, user = %p}\n", debugstr_a(name), base, size, user); > + > + if (!GetModuleFileNameExA(hProcess, (HMODULE)base, tmp, sizeof(tmp))){ > + WARN("could not find the full path name of the module. Using the base name of %s instead\n", debugstr_a(name)); > lstrcpynA(tmp, name, sizeof(tmp)); > + } > > + TRACE("loading the module %s {base = 0x%08x}\n", debugstr_a(name), base); > SymLoadModule(hProcess, 0, tmp, name, base, size); > + TRACE("done loading the module\n"); > return TRUE; You are adding way too many traces, most of which are not necessary. Here for instance, SymLoadModule already contains traces, so there's no need to add traces around the call. It's fine to do that sort of thing to help following things when you are trying to understand the code, but afterwards they should be removed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: d3dx8: Implementation of D3DXAssembleShaderFromFileA
by Dmitry Timoshkov 27 Nov '07

27 Nov '07

<luis.busquets(a)ilidium.com> wrote: > else eliminated Did you actually compile it? If you did, did you see a warning you introduced? -- Dmitry.

1 0

modified: dlls/d3dx8/d3dx8_main.c modified: include/d3dx8core.h
by luis.busquets＠ilidium.com 27 Nov '07

27 Nov '07

else eliminated. --- dlls/d3dx8/d3dx8_main.c | 18 +++++++++++++----- include/d3dx8core.h | 2 +- 2 files changed, 14 insertions(+), 6 deletions(-)

2 1

Re: ole32: Add tests for WdtpInterfacePointer_* functions.
by Juan Lang 26 Nov '07

26 Nov '07

Hi Rob, + ok(*(DWORD *)wireip == 0x44, "wireip + 0x0 should be 0x4c instead of 0x%08x\n", *(DWORD *)wireip); + wireip += sizeof(DWORD); + ok(*(DWORD *)wireip == 0x44, "wireip + 0x8 should be 0x4c instead of 0x%08x\n", *(DWORD *)wireip); Shouldn't these be "should be 0x44 instead of..."? --Juan

1 0

Re: [PATCH 3/3] advapi32: Add support for using the Mac Keychain services as a backend for the credential functions instead of the registry.
by Juan Lang 26 Nov '07

26 Nov '07

Hi Rob, @@ -232,6 +239,198 @@ static DWORD registry_read_credential(HKEY hkey, PCREDENTIALW credential, return ret; } +static DWORD mac_read_credential_from_item(SecKeychainItemRef item, BOOL require_password, + PCREDENTIALW credential, char *buffer, + DWORD *len) You're missing compilation protection here (and elsewhere) on non-Apple systems. --Juan

2 1