December 2007 - Wine-devel - list.winehq.org

Re: gdi32: Update fontsubstitutes and add ms shell dlg 2
by Huw Davies 07 Dec '07

07 Dec '07

On Fri, Dec 07, 2007 at 01:20:59PM +0100, Maarten Lankhorst wrote: > --- > dlls/gdi32/freetype.c | 34 ++++++++++++++++++---------------- > 1 files changed, 18 insertions(+), 16 deletions(-) > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index e9fb663..1542e29 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -1884,83 +1884,83 @@ static const struct nls_update_font_list > const char *oem, *fixed, *system; > const char *courier, *serif, *small, *sserif; > /* these are for font substitute */ > - const char *shelldlg, *tmsrmn; > + const char *shelldlg, *shelldlg2, *tmsrmn; > } nls_update_font_list[] = > { > /* Latin 1 (United States) */ > { 1252, 437, "vgaoem.fon", "vgafix.fon", "vgasys.fon", > "coure.fon", "serife.fon", "smalle.fon", "sserife.fon", > - "Tahoma","Times New Roman", > + "MS Sans Serif", "Tahoma","Times New Roman", > }, I'm fairly sure we don't want to map MS Shell Dlg to MS Sans Serif. Which version of Windows has this mapping? Some map it to Microsoft Sans Serif, but that's a completely different font... Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: [2/2] msxml3: Register Missing Components
by Huw Davies 07 Dec '07

07 Dec '07

On Fri, Dec 07, 2007 at 02:07:44PM +1100, Alistair Leslie-Hughes wrote: > diff --git a/dlls/msxml3/regsvr.c b/dlls/msxml3/regsvr.c > index 9a0d938..1beed5b 100644 > --- a/dlls/msxml3/regsvr.c > +++ b/dlls/msxml3/regsvr.c > @@ -465,13 +465,13 @@ static LONG register_key_defvalueA( > */ > static struct regsvr_coclass const coclass_list[] = { > { &CLSID_DOMDocument, > - "XML DOM Document", > - NULL, > - "msxml3.dll", > - "Both", > - "Microsoft.XMLDOM", > - "1.0" > - }, > + "XML DOM Document", > + NULL, > + "msxml3.dll", > + "Both", > + "Microsoft.XMLDOM", > + "1.0" > + }, There are a lot of white-space changes in this patch. Please re-submit without them. Thanks, Huw. -- Huw Davies huw(a)codeweavers.com

1 0

d3d fill caps oddity
by Christoph Frick 07 Dec '07

07 Dec '07

Hi wined3d devs, i get this message on my notebook (Quadro 570m): fixme:d3d:IWineD3DImpl_FillGLCaps OpenGL implementation supports 32 vertex samplers and 32 total samplers fixme:d3d:IWineD3DImpl_FillGLCaps Expected vertex samplers + MAX_TEXTURES(=8) > combined_samplers does anyone want some traces or other infos? or is this a problem most likely going away with the next nvidia driver update? -- cu

2 1

Re: [1/2] msxml3: Implement IPersistStream
by Robert Shearman 07 Dec '07

07 Dec '07

Alistair Leslie-Hughes wrote: > + hr = CreateStreamOnHGlobal(NULL, TRUE, &This->stream); > + if (FAILED(hr)) > + return hr You need to free This->stream somewhere. -- Rob Shearman

1 0

Re: [5/5] WineD3D: Use the disabled opengl extension string
by H. Verbeet 07 Dec '07

07 Dec '07

The clearest way to do this would probably be to simply do the disabling in a separate loop over the disabled extensions string, similarly to how we detect the extensions.

2 1

Re: wine 0.9.5 IO completion port questions
by Andrey Turkin 07 Dec '07

07 Dec '07

Marius Slyzius wrote: > > Hello all. > > > > I am trying to run ScimoreDB database which uses fibers, non-blocked > IO for sockets and files, and completion port. It did started ok > under 0.9.5 and seems it is working!!!:), so I would like to verify > few things about async IO with completion ports before recompiling it > with winelib. > You mean 0.9.50, right? > > > > 1) will write/read file/socket with completion port is true > asynchronous operation. I am asking because every time write/read > operation returns true, and never IO pending error. > Not sure it is asynchronous for files, should be asynchronous for sockets. > > > > 2) possible bug: the server sends 1500 bytes with WsaSend ( with 2 > WSABUFFER ) and the client receive only 1452 bytes and calls WsaRecv > again. Also on the server, the completion port receive event that > transferred 1452 bytes. However, the last 8 bytes are never sends nor > completion port event arrives. Is it perhaps something to do with the > VMWare tool where I run Ubuntu 7.10? > WsaSend can send partial data when operating on non-blocking socket; from your description it looks like this is the case. Is this error reproducible with the same numbers every run? Your both questions are actually not about IOCP but about asynchronous I/O support. > > Please, send me an info also to my mail: marius(a)scimore.com , because > I might miss the answer here. > > > > Thank you! > > Marius Slyzius > > Scimore UAB > > (+45) 40862122 > > > > ------------------------------------------------------------------------ > > >

3 2

replying to wine-devel?
by King InuYasha 07 Dec '07

07 Dec '07

I have noticed some unusual behavior in the wine-devel mailing list compared to others (e.g. fedora's, etc.). Wine's wine-devel mailing list does not automatically set the reply to wine-devel(a)winehq.org. Why is that? If other mailing lists do so, how come Wine's doesn't? Personally, I find myself making a mistake sometimes and not adding in the wine-devel part because I am used to seeing it automatically set. If I remember how emails are set up, isn't there a hidden field called reply-to? AFAICT, other mailing lists either override or rewrite this field and replace it with the email address of the mailing list.

6 8

Re: [5/5] WineD3D: Use the disabled opengl extension string
by Chris Robinson 07 Dec '07

07 Dec '07

On Thursday 06 December 2007 02:05:52 pm Stefan Dösinger wrote: > + if(wined3d_settings.disabled_extensions && > + strstr(wined3d_settings.disabled_extensions, > ThisExtn)) { You need to be careful with this. I read somewhere that using strstr to check for an opengl extension in an extension list is discourage because it can find false positives. Especially in this case, if you have, say: wined3d_settings.disabled_extensions = "GL_NV_texture_shader3 GL_NV_vertex_program2_option GL_NV_vertex_program3" Then if you check for "GL_NV_texture_shader", "GL_NV_vertex_program2", or "GL_NV_vertex_program", they'll all show up as being disabled, when they're not. Which is a double problem because "GL_NV_vertex_program1_1" would still be enabled, which requires "GL_NV_vertex_program". AFAIK, the proper way to check for OpenGL extensions in a space-delimitted list is like this: const char *ptr = strstr(wined3d_settings.disabled_extensions, ThisExtn); if(ptr) { if(ptr == wined3d_settings.disabled_extensions || isspace(ptr[-1])) { int len = strlen(ThisExtn); if(!ptr[len] || isspace(ptr[len])) { /* is disabled */ } } }

1 0

Re: d3dx8 [2/2]: add basic functions for MatrixStack
by Stefan Dösinger 06 Dec '07

06 Dec '07

Am Mittwoch, 5. Dezember 2007 18:13:30 schrieb David.Adam(a)math.cnrs.fr: > This is my first attempt with ICOM objects. So, all the advices are > welcome. A few suggestions: +HRESULT WINAPI ID3DXMatrixStackImpl_QueryInterface(ID3DXMatrixStack *iface, REFIID riid, void **ppvObject) + ... + IClassFactory_AddRef(iface); It is better to use ID3DXMatrixStack_AddRef(iface) here. It is essentially the same, but it looks more consistent The AddRef() and Release() methods should have a TRACE which write either the new or old refcount, otherwise tracking refcounting bugs is hell.

3 3

Re: msxml3: Implement cloneNode (resend)
by Alexandre Julliard 06 Dec '07

06 Dec '07

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > +static void test_cloneNode(void ) > +{ > + // NOTE TO SELF - r = IXMLDOMNode_selectSingleNode(node, _bstr_("br"), &node); //test Please cleanup that sort of thing before submitting. -- Alexandre Julliard julliard(a)winehq.org

1 0