December 2007 - Wine-devel - list.winehq.org

Re: system.sfd: make 18 pixel strike with Japanese jvgasys glyphs
by Dmitry Timoshkov 06 Dec '07

06 Dec '07

"Aric Stewart" <aric(a)codeweavers.com> wrote: > fonts/system.sfd | 1407 > ++++++++++++++++++++++++++++++++++++++++++++++-------- > 1 files changed, 1213 insertions(+), 194 deletions(-) For some reason widths of many glyphs are changed by this patch, that doesn't look correct. -- Dmitry.

3 3

Re: quartz: move current tests into its own test case [1/5]
by James Hawkins 06 Dec '07

06 Dec '07

On Dec 5, 2007 10:35 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > I'm moving the current tests into their own function in preparation to > write more tests. > When submitting a numbered patch series, can you put the numbers [x/y] right after the module name? That makes it easier to spot the ordering of the patches. Thanks, James Hawkins

1 0

Re: secur32: Remove the SECUR32_ALLOC() macro around HeapAlloc().
by Michael Stefaniuc 05 Dec '07

05 Dec '07

Juan Lang wrote: > On Dec 5, 2007 12:52 PM, Michael Stefaniuc <mstefani(a)redhat.de> wrote: >> Checked with Kai and Dmitry and there is nothing special about >> SECUR32_ALLOC(). There are more direct usages of HeapAlloc() >> than of the macro so instead of replacing SECUR32_ALLOC() with >> heap_alloc() just remove it altogether. > > No prob. I introduced those macros some years ago before valgrind was > usable with wine, it made debugging memory leaks (via redefinition of > the macros with special leak-tracking ones) easier. Valgrind is > certainly better. I thought that was still the reason why those $dll_alloc() and now heap_alloc() wrappers are used. I mean the main reason cause we all know that the HeapAlloc() API just sucks. bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

1 0

A small question regarding cpuid
by Vijay Kiran Kamuju 05 Dec '07

05 Dec '07

Hi, I was going through dlls/kernel32/cpu.c and stumbled upon the functions do_cpuid and have_cpuid. It seems the assembly code for both the Intel and AMD 64 bit processors. Is it possible to remove the ifdefs or add the x86_64 ifdef. And one more question does this change help 64 bit windows support? Thanks, VJ

1 0

Re: wined3d:context.c Check for a context is added
by Stefan Dösinger 05 Dec '07

05 Dec '07

Am Mittwoch, 5. Dezember 2007 17:25:55 schrieb Anatoly Lyutin: > We need to check context before than refer it. > > Changelog: > Check for a context is added Does that happen to fix any game? The idea was that the activeContext pointer never points to NULL, so a check like that only workaround a bug somewhere else

1 0

Re: wined3d:context.c Check for a context is added
by Roderick Colenbrander 05 Dec '07

05 Dec '07

> We need to check context before than refer it. > > Changelog: > Check for a context is added > > -- > Best regards > Anatoly Lyutin. > Hi, I'm not sure if your patch is correct. The block of code in front of the if-statement you added should have found or else created a context. If afterwards there is no context it sounds like something went wrong. Returning NULL isn't correct then. When we just return we keep using the old context (if one was around) which might work for your program but it isn't guaranteed to work at all. So what is the real problem? Regards, Roderick -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

2 1

Re: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 (RESEND)
by Michael Stefaniuc 05 Dec '07

05 Dec '07

Gerald Pfeifer wrote: > On Wed, 5 Dec 2007, Alexandre Julliard wrote: >> Looks ok, please submit the patch with a proper Changelog entry. > > Thanks for looking into this! Here we go! :-) > ChangeLog: > Correctly handle underflow in IcmpSendEcho(); bug introduced in rev 1.30. Still using cvs? I guess nobody else can do anything with rev 1.30. bye michael > Index: dlls/icmp/icmp_main.c > =================================================================== > RCS file: /home/wine/wine/dlls/icmp/icmp_main.c,v > retrieving revision 1.30 > diff -u -3 -p -r1.30 icmp_main.c > --- dlls/icmp/icmp_main.c 6 Nov 2006 11:51:07 -0000 1.30 > +++ dlls/icmp/icmp_main.c 22 Nov 2007 21:28:59 -0000 > @@ -433,8 +433,9 @@ DWORD WINAPI IcmpSendEcho( > * Decrease the timeout so that we don't enter an endless loop even > * if we get flooded with ICMP packets that are not for us. > */ > - Timeout -= (recv_time - send_time); > - if (Timeout < 0) Timeout = 0; > + DWORD t = (recv_time - send_time); > + if (Timeout > t) Timeout -= t; > + else Timeout = 0; > continue; > } else { > /* This is a reply to our packet */ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Consulting Communications Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

1 0

Re: [3/5] shell32: fix buffer sizes
by Alexandre Julliard 05 Dec '07

05 Dec '07

Vitaly Lipatov <lav(a)etersoft.ru> writes: > lstrcpynW needs size in TCHARS > RegEnumKey needs size in TCHARS It would be better to change the HCR_GetDefaultVerbW function to take a len in WCHARs since it's returning a string in all cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 (RESEND)
by Alexandre Julliard 05 Dec '07

05 Dec '07

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > Since Alexandre has asked me to take care of overflow in some other > context, I figured I could ping this underflow patch in return. ;-) Looks ok, please submit the patch with a proper Changelog entry. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 (RESEND)
by Steven Edwards 05 Dec '07

05 Dec '07

Hello, On Dec 4, 2007 7:34 PM, Gerald Pfeifer <gerald(a)pfeifer.com> wrote: > Since Alexandre has asked me to take care of overflow in some other > context, I figured I could ping this underflow patch in return. ;-) > > Gerald > > ---------- Forwarded message ---------- > From: Gerald Pfeifer <gerald(a)pfeifer.com> > To: <wine-patches(a)winehq.org>, Damjan Jovanovic <damjan.jov(a)gmail.com> > Date: Thu, 22 Nov 2007 22:32:08 +0100 (CET) > Subject: dlls/icmp/icmp_main.c -- attempt at fixing regression in r1.30 > > I believe revision 1.30 of dlls/icmp/icmp_main.c > > date: 2006-11-06 11:51:07 +0000; author: julliard; state: Exp; lines: +10 -15; > Damjan Jovanovic <damjan.jov(a)gmail.com> > icmp: Changed select to poll. Could we just revert this patch? I think poll is not a valid api on win32 so this breaks the windows port. I don't really see the need in this change here in the first place. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0