March 2007 - Wine-devel - list.winehq.org

Re: [PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit
by Stefan Dösinger 29 Mar '07

29 Mar '07

Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: > This patch sets the conditional NPOT bit only when required. If an > implementation has full support for NPOT textures through the > ARB_texture_non_power_of_two extension, then support for the subset of > capabilities provided by the ARB_texture_rectangle extension is implied. > --- > dlls/wined3d/directx.c | 7 +++++-- > 1 files changed, 5 insertions(+), 2 deletions(-) I am not sure if we shouldn't set NONPOWER2CONDITIONAL unconditionally if POW2 is set. WineD3D emulates np2 textures by using a texture of the next pow2size and adjusting the texture matrix accordingly. This doesn't work for shaders though, but mipmapping and other things are supported.

2 1

Re: [PATCH 3/3] wined3d: Correctly set conditional NPOT caps bit (try 2)
by H. Verbeet 29 Mar '07

29 Mar '07

On 29/03/07, Vitaly Budovski <vbudovski(a)gmail.com> wrote: > This patch sets the conditional NPOT bit only when required. If an > implementation has full support for NPOT textures through the > ARB_texture_non_power_of_two extension, then support for the subset of > capabilities provided by the ARB_texture_rectangle extension is implied. > > Add additional check for the equivalent NV extension. > --- Do you know what ARB_texture_rectangle is? It's not a subset of ARB_texture_non_power_of_two, and it doesn't correspond to WINED3DPTEXTURECAPS_NONPOW2CONDITIONAL in any way. Please read http://www.opengl.org/registry/specs/ARB/texture_rectangle.txt

1 0

Nine good SoC propsals!
by Dan Kegel 29 Mar '07

29 Mar '07

Wow. We have 29 or so total proposals, of which nine or ten seem like contenders. It's an embarrassment of riches! I wish we could pick them all. Time for the mentors to start arm-wrestling...

4 3

Re: [PATCH 2/3] wined3d: Add ARB_texture_rectangle extension
by Stefan Dösinger 29 Mar '07

29 Mar '07

Am Donnerstag 29 März 2007 14:09 schrieb Vitaly Budovski: > Add support for ARB_texture_rectangle extension. > --- > dlls/wined3d/directx.c | 3 +++ > include/wine/wined3d_gl.h | 9 +++++++++ > 2 files changed, 12 insertions(+), 0 deletions(-) There is also GL_NV_texture_rectangle. Is that one related?

1 0

Re: gdi32: Implement the fake_bold for one faced fonts.
by Huw Davies 29 Mar '07

29 Mar '07

On Thu, Mar 29, 2007 at 10:00:12PM +0900, Byeong-Sik Jeon wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index f7b1220..427def4 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > + memcpy(&gmetrix, &ft_face->glyph->metrics, sizeof(FT_Glyph_Metrics)); > + if ( font->fake_bold ) > + { > + /* fitting values to MS-Windows */ > + strength = pFT_MulFix( ft_face->units_per_EM, ft_face->size->metrics.y_scale ) / 42; > + if ( strength < 64) > + { > + gmetrix.width += strength; > + gmetrix.height += strength; > + gmetrix.horiBearingY += strength; > + gmetrix.horiAdvance += strength; > + } > + else if ( strength < 77) > + { > + gmetrix.width += 63; > + gmetrix.height += 63; > + gmetrix.horiBearingY += 63; > + gmetrix.horiAdvance += 63; > + } > + else > + { > + gmetrix.width += strength; > + gmetrix.height += strength; > + gmetrix.horiBearingY += strength; > + } This needs more investigation. I can't believe Windows uses this algorithm... Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: imm32: Change the default IME window to better reflect applications request
by Byeong-Sik Jeon 29 Mar '07

29 Mar '07

It looks good to me. Thanks to Aric :) Aric Stewart wrote: > First part of this change was proposed by Byeong-Sik Jeon > <wjsqudtlr(a)gmail.com> > Use a tooltip window instead to avoid stealing focus from the application. > Additionally respect parameters give to us by ImmSetCompositionWindow > for placement of the composition window.

1 0

re: Improvement of WSAIoctl
by Dan Kegel 29 Mar '07

29 Mar '07

Hi Axel, > some days ago, I tried to run the retail management software, we are developing in our > company now for over 15 years, with Wine on Linux. Unfortunatly it didn't work. > > The reason was not our product itself, but the ODBC driver form MS for MS-SQL-Server. > It uses a command for WSAIoctl in ws2_32.dll, wich isn't implemented in Wine yet. > Because of the lack of this command, the driver fails and our software does not work. > > With other databases it works great, but unfortunatly most of our customers prefer using > MS-SQL-Server, so this piece of MS-Software is a must for us. I'm thrilled you're doing this. What's your software called? > + case WS_SIO_KEEPALIVE_VALS: > + { > + /* FIXME: not fully implemented */ > + BOOL value; > + > + if (cbInBuffer < sizeof(struct tcp_keepalive) || !lpvInBuffer) > + { > + WSASetLastError(WSAEFAULT); > + return SOCKET_ERROR; > + } > + > + value = ((struct tcp_keepalive *)lpvInBuffer)->onoff; > + return WS_setsockopt(s, WS_SOL_SOCKET, WS_SO_KEEPALIVE, (char *)&value, sizeof(BOOL)); > + } I think that looks great. If your patch isn't accepted in the next couple of days, consider adding a simple conformance test and resubmitting. But you can't do this: > + * Copyright (C) the Wine project as there's no legal entity called "the Wine project". You have to use your company's name, I think. (And be sure they've granted permission.) Or if you have the rights to what you do in your spare time, your own name is fine. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

3 2

Re: ntdll: "add" ZwAreMappedFilesTheSame to ntdll.spec
by Dmitry Timoshkov 29 Mar '07

29 Mar '07

"Louis. Lenders" <xerox_xerox2000(a)yahoo.co.uk> wrote: > diff --git a/dlls/ntdll/ntdll.spec b/dlls/ntdll/ntdll.spec > index e315057..3377db3 100644 > --- a/dlls/ntdll/ntdll.spec > +++ b/dlls/ntdll/ntdll.spec > @@ -948,7 +948,7 @@ > # @ stub ZwAllocateUserPhysicalPages > @ stdcall ZwAllocateUuids(ptr ptr ptr) NtAllocateUuids > @ stdcall ZwAllocateVirtualMemory(long ptr ptr ptr long long) NtAllocateVirtualMemory > -# @ stub ZwAreMappedFilesTheSame > +@ stub ZwAreMappedFilesTheSame > # @ stub ZwAssignProcessToJobObject > @ stub ZwCallbackReturn > # @ stub ZwCancelDeviceWakeupRequest It seems you haven't read an introducing comment in the first lines of ntdll.spec before changing it. -- Dmitry.

1 0

What is the X11 lock?
by Shachar Shemesh 29 Mar '07

29 Mar '07

Hi list, Can anyone please explain to me what the x11 lock is used for? I can see that SOME X11 functions (e.g. - read description on X11DRV_KEYBOARD_DetectLayout) require a lock, while others seem to call X11 functions with no lock. I can see that sometimes the x11 lock is obtained around a single X11 call. Is there any guideline I can follow that will tell me whether I need a lock for code I'm writing? What is the race this lock was designed to fix? Thanks, Shachar

1 0

Undocumented function syssetup.dll.SetupQueryRegisteredOsComponent
by Dan Kegel 28 Mar '07

28 Mar '07

Any suggestions as to how to discover the prototype of the apparently undocumented function syssetup.dll.SetupQueryRegisteredOsComponent ? It seems to be needed to install mdac-2.8. ( http://bugs.winehq.org/show_bug.cgi?id=5824 ) - Dan

5 5