March 2007 - Wine-devel - list.winehq.org

Re: netapi32/tests: Add a missing '\n' to a trace().
by Kai Blin 28 Mar '07

28 Mar '07

On Wednesday 28 March 2007 10:00, Francois Gouget wrote: > - trace("Deleting the test user failed. You might have to manually > delete it."); > + trace("Deleting the test user failed. You might have > to manually delete it.\n"); } Whoops, thanks for the catch. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: setupapi [5/7]: The Inf file should be copied regardless of the destination buffer
by Alexandre Julliard 27 Mar '07

27 Mar '07

"James Hawkins" <truiken(a)gmail.com> writes: > Changelog: > * The Inf file should be copied regardless of the destination buffer. It doesn't seem right to copy the file and then return an error when the buffer is too small. -- Alexandre Julliard julliard(a)winehq.org

3 2

Localization resources
by Ann & Jason Edmeades 27 Mar '07

27 Mar '07

Hiya, If adding files for translation to a new directory (xcopy), can anyone confirm of deny whether the following is all I need to do: 1. Add rsrc.rc containing (* - see below) #include <windows.h> #include "resources.h" LANGUAGE LANG_NEUTRAL, SUBLANG_NEUTRAL #include "En.rc" 2. Add En.rc containing LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US STRINGTABLE DISCARDABLE LANGUAGE LANG_ENGLISH, SUBLANG_DEFAULT { id1, "string" id2, "string2" etc } 3. Modify Makefile.in to contain RC_SRCS = rsrc.rc (*) Do I need add other languages or do I let translators add their own? If I look at programs\start vs programs\winecfg, one has 18 languages and one has 14, so I am not quite sure what to do here Thanks! jason

2 1

Re: [PATCH 4/6] ole32: Display the testname for the test for display name in test_moniker.
by Juan Lang 27 Mar '07

27 Mar '07

Hi Rob, + ok(!lstrcmpW(display_name, expected_display_name), "%s: display name wasn't what was expected\n", testname); Can you pass a WCHAR * when the string format is %s? --Juan ____________________________________________________________________________________ The fish are biting. Get more visitors on your site using Yahoo! Search Marketing. http://searchmarketing.yahoo.com/arp/sponsoredsearch_v2.php

2 1

Re: Summer of code
by Dan Kegel 27 Mar '07

27 Mar '07

On 3/27/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > Hi Dan! > I was curious how the SoC thing proceedes from now. The application deadline > is now over, but who got the applications? Did you get them, or are they > reviewed internally by Google? Who will be in charge for accepting them? Google received about 23 applications for Wine SoC projects. It's now up to the Wine GSoC mentors to rank the projects. See http://code.google.com/support/bin/answer.py?answer=60325&topic=10729 for the timeline. The mentors have something like two weeks to do the ranking. After that, Google will decide how many of the applications will be funded. I'll be in touch with the mentors shortly... - Dan

2 1

Re: setupapi [4/7]: Don't allow relative paths in SetupCopyOEMInf
by Alexandre Julliard 27 Mar '07

27 Mar '07

"James Hawkins" <truiken(a)gmail.com> writes: > @@ -5,7 +5,7 @@ SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = setupapi.dll > IMPORTLIB = libsetupapi.$(IMPLIBEXT) > -IMPORTS = user32 version advapi32 rpcrt4 kernel32 ntdll > +IMPORTS = user32 version advapi32 rpcrt4 kernel32 ntdll shlwapi It's a bit wasteful to import a whole bunch of shell stuff for a one-line function... -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: urlmon: Create one notif window per thread.
by Alexandre Julliard 27 Mar '07

27 Mar '07

Jacek Caban <jacek(a)codeweavers.com> writes: > I forgot to remove DestroyWindow form Release, sorry. This patch also > takes care of unloading DLL. It's really worth doing as it prevents > creating a lot of useless windows. It still won't work, because you cannot destroy a window belonging to another thread. And switching threads inside the dll detach would probably be a bit dangerous. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: PATCH: comctl32 fix for message loops with LVS_OWNERDATA (virtual listviews)
by Dimi Paun 26 Mar '07

26 Mar '07

On Mon, March 26, 2007 18:18, Tom Kistner wrote: > This fixes FlashFXP 3.x, a "most wanted" application. > > Patch attached. See Bugzilla #5131 for details. Can you please resubmit using 4-space indent as it is used in the rest of that function? -- Dimi Paun <dimi(a)lattica.com> Lattica, Inc.

1 0

Icon for wine
by Marcelo Boveto Shima 26 Mar '07

26 Mar '07

I created an svg version of wine's logo and then I created some icons for the wine applications based on wine's logo and tango's icons. wine-regedit.svg is based on a clipart found at openclipart.org: http://openclipart.org/media/files/nicubunu/2842 (license:public domain) They are temporarily hosted at http://200.181.205.134/wine/ Debdiff against the ubuntu's package to update the .desktop files is in this url too. Hope you enjoy. Marcelo Shima

2 1

Re: comctl32: Constify some variables (1 of 4)
by Alexandre Julliard 26 Mar '07

26 Mar '07

Andrew Talbot <Andrew.Talbot(a)talbotville.com> writes: > +++ b/dlls/comctl32/draglist.c 2007-03-24 10:29:36.000000000 +0000 > @@ -91,7 +91,7 @@ > } > > /* cleans up after dragging */ > -static void DragList_EndDrag(HWND hwnd, DRAGLISTDATA * data) > +static void DragList_EndDrag(HWND hwnd, DRAGLISTDATA const *data) Please use 'const DRAGLISTDATA *' instead, it's more standard and will avoid some confusion. -- Alexandre Julliard julliard(a)winehq.org

2 1