May 2007 - Wine-devel - list.winehq.org

Re: crypt32(5/5): Implement CryptSIPLoad
by Alexandre Julliard 15 May '07

15 May '07

Juan Lang <juan_lang(a)yahoo.com> writes: > +static struct list providers; > +CRITICAL_SECTION providers_cs; > + > +void crypt_sip_init(void) > +{ > + InitializeCriticalSection(&providers_cs); > + list_init(&providers); > + providers_cs.DebugInfo->Spare[0] = (DWORD_PTR)(__FILE__ ": providers_cs"); > +} Lists and critical sections can be initialized statically, this is more efficient and avoids having to export a bunch of init functions. -- Alexandre Julliard julliard(a)winehq.org

1 0

mentoring
by Tom Spear 15 May '07

15 May '07

Hi all, just wanted to know if anyone would _mind_ helping me with my (small) todo list. I know I've been somewhat of an annoyance lately, and for that I sincerely apologize. I'd really like to get the wine uninstaller program up to speed with the patch I have been working on, but it is not going as I had hoped. One person offered to review my patches, but I am admittedly impatient sometimes (I haven't been able to get a response from him since Thursday, and I had hoped for one by Friday night), and all in all, I just dont like having something so small take so long. I am making changes to code I didn't intend to change, which I don't mind doing, but then when I make the change, I get told to do it 3 different ways, and none of the ways I submit gets committed, even after being told that it looks ready to go in. I'd like someone who is really in touch with what Alexandre is looking for to help me. I only have 4 patches, all less than 50 lines each to get this thing in, and I will be done submitting patches for a while, until I learn more about the code (maybe months or even years).. I will take whatever advice is given me (unless it is to not bother with the patch), and really appreciate the help. If you dont mind helping me, please post a note on my bug about the patch http://bugs.winehq.org/show_bug.cgi?id=8364 -- Thanks Tom

5 8

Re: [tools] add winecfg to XDG menus
by Marcus Meissner 15 May '07

15 May '07

On Tue, May 15, 2007 at 07:36:38AM +0200, Damjan Jovanovic wrote: > Changelog: > * When installing wine, add an entry for winecfg to the XDG menus > > Damjan Jovanovic > diff -Nur a/tools/Makefile.in b/tools/Makefile.in > --- a/tools/Makefile.in 2007-05-03 08:46:44.000000000 +0200 > +++ b/tools/Makefile.in 2007-05-14 21:59:17.646137077 +0200 > @@ -82,7 +82,11 @@ > install install-lib:: wineprefixcreate $(INSTALLDIRS) > $(INSTALL_SCRIPT) wineprefixcreate $(DESTDIR)$(bindir)/wineprefixcreate > $(INSTALL_DATA) $(SRCDIR)/wine.inf $(DESTDIR)$(datadir)/wine/wine.inf > + mkdir -p /etc/xdg/menus &> /dev/null || true > + mkdir -p ~/.config/menus/applications-merged > + if ! $(INSTALL_DATA) $(SRCDIR)/wine.menu /etc/xdg/menus &> /dev/null; then $(INSTALL_DATA) $(SRCDIR)/wine.menu ~/.config/menus/applications-merged; fi Please do not use ~. You are not supposed to put stuff into any kind of $HOMEs. Please use $(DESTDIR) for global paths. Ciao, Marcus

2 1

Install fail on 64bit syst Q
by wkpickett0154＠comcast.net 14 May '07

14 May '07

Hello, I am aware that wine currently installs on 32 bit only according to numerous blogentries. Here is my congif.log on this attempt to better assist in a X86_64 generic compile. I suppose, on my ignorance- that this compile needs to be put in a different location to be called for? I am new to Linux/Ubuntu and programming language-speak, so any help here, non-tech type would be a help. William Pickett Albuquerque NM WINE Installer v0.75 Running configure... configure: creating cache config.cache checking build system type... x86_64-unknown-linux-gnu checking host system type... x86_64-unknown-linux-gnu checking whether make sets $(MAKE)... yes checking for gcc... gcc -m32 checking for C compiler default output file name... configure: error: C compiler cannot create executables See `config.log' for more details. Configure failed, aborting install. This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. It was created by Wine configure 0.9.37, which was generated by GNU Autoconf 2.61. Invocation command line was $ ./configure -C --prefix=/usr/local ## --------- ## ## Platform. ## ## --------- ## hostname = c21william-desktop uname -m = x86_64 uname -r = 2.6.20-15-generic uname -s = Linux uname -v = #2 SMP Sun Apr 15 06:17:24 UTC 2007 /usr/bin/uname -p = unknown /bin/uname -X = unknown /bin/arch = x86_64 /usr/bin/arch -k = unknown /usr/convex/getsysinfo = unknown /usr/bin/hostinfo = unknown /bin/machine = unknown /usr/bin/oslevel = unknown /bin/universe = unknown PATH: /usr/local/sbin PATH: /usr/local/bin PATH: /usr/sbin PATH: /usr/bin PATH: /sbin PATH: /bin PATH: /usr/bin/X11 PATH: /usr/games ## ----------- ## ## Core tests. ## ## ----------- ## configure:1737: creating cache config.cache configure:1888: checking build system type configure:1906: result: x86_64-unknown-linux-gnu configure:1928: checking host system type configure:1943: result: x86_64-unknown-linux-gnu configure:2008: checking whether make sets $(MAKE) configure:2029: result: yes configure:2086: checking for gcc configure:2113: result: gcc -m32 configure:2351: checking for C compiler version configure:2358: gcc -m32 --version >&5 gcc (GCC) 4.1.2 (Ubuntu 4.1.2-0ubuntu4) Copyright (C) 2006 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. configure:2361: $? = 0 configure:2368: gcc -m32 -v >&5 Using built-in specs. Target: x86_64-linux-gnu Configured with: ../src/configure -v --enable-languages=c,c++,fortran,objc,obj-c++,treelang --prefix=/usr --enable-shared --with-system-zlib --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --enable-nls --program-suffix=-4.1 --enable-__cxa_atexit --enable-clocale=gnu --enable-libstdcxx-debug --enable-mpfr --enable-checking=release x86_64-linux-gnu Thread model: posix gcc version 4.1.2 (Ubuntu 4.1.2-0ubuntu4) configure:2371: $? = 0 configure:2378: gcc -m32 -V >&5 gcc: '-V' must come at the start of the command line configure:2381: $? = 1 configure:2404: checking for C compiler default output file name configure:2431: gcc -m32 conftest.c >&5 /usr/bin/ld: skipping incompatible /usr/bin/../lib/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/bin/../lib/libc.a when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib/libc.so when searching for -lc /usr/bin/ld: skipping incompatible /usr/lib/libc.a when searching for -lc /usr/bin/ld: cannot find -lc collect2: ld returned 1 exit status configure:2434: $? = 1 configure:2472: result: configure: failed program was: | /* confdefs.h. */ | #define PACKAGE_NAME "Wine" | #define PACKAGE_TARNAME "wine" | #define PACKAGE_VERSION "0.9.37" | #define PACKAGE_STRING "Wine 0.9.37" | #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" | /* end confdefs.h. */ | | int | main () | { | | ; | return 0; | } configure:2479: error: C compiler cannot create executables See `config.log' for more details. ## ---------------- ## ## Cache variables. ## ## ---------------- ## ac_cv_build=x86_64-unknown-linux-gnu ac_cv_env_CCC_set= ac_cv_env_CCC_value= ac_cv_env_CC_set= ac_cv_env_CC_value= ac_cv_env_CFLAGS_set= ac_cv_env_CFLAGS_value= ac_cv_env_CPPFLAGS_set= ac_cv_env_CPPFLAGS_value= ac_cv_env_CPP_set= ac_cv_env_CPP_value= ac_cv_env_CXXFLAGS_set= ac_cv_env_CXXFLAGS_value= ac_cv_env_CXX_set= ac_cv_env_CXX_value= ac_cv_env_LDFLAGS_set= ac_cv_env_LDFLAGS_value= ac_cv_env_LIBS_set= ac_cv_env_LIBS_value= ac_cv_env_XMKMF_set= ac_cv_env_XMKMF_value= ac_cv_env_build_alias_set= ac_cv_env_build_alias_value= ac_cv_env_host_alias_set= ac_cv_env_host_alias_value= ac_cv_env_target_alias_set= ac_cv_env_target_alias_value= ac_cv_host=x86_64-unknown-linux-gnu ac_cv_prog_ac_ct_CC='gcc -m32' ac_cv_prog_make_make_set=yes ## ----------------- ## ## Output variables. ## ## ----------------- ## ALSALIBS='' AR='' AS='as --32' AUDIOIOLIBS='' BISON='' BUILTINFLAG='' CARBONLIB='' CC='gcc -m32' CFLAGS='' COREAUDIO='' COREFOUNDATIONLIB='' CPP='' CPPBIN='' CPPFLAGS='' CROSSCC='' CROSSTEST='' CROSSWINDRES='' CRTLIBS='' CXX='' CXXFLAGS='' DEFS='' DEPENDENCIES='' DISKARBITRATIONLIB='' DLLEXT='' DLLFLAGS='' DLLTOOL='' DLLWRAP='' ECHO_C='' ECHO_N='-n' ECHO_T='' EGREP='' ESDCONFIG='' ESDINCL='' ESDLIBS='' EXEEXT='' EXTRACFLAGS='' EXTRA_BINARIES='' FLEX='' FONTFORGE='' FONTSSUBDIRS='' FREETYPEINCL='' FREETYPELIBS='' GLU32FILES='' GPHOTO2INCL='' GPHOTO2LIBS='' GREP='' HALINCL='' ICULIBS='' IMPLIBEXT='' INSTALL_DATA='' INSTALL_PROGRAM='' INSTALL_SCRIPT='' IOKITLIB='' LCMSLIBS='' LD='ld -m elf_i386' LDAPLIBS='' LDCONFIG='' LDD='' LDDLLFLAGS='' LDEXECFLAGS='' LDFLAGS='' LDPATH='' LDSHARED='' LIBDL='' LIBEXT='' LIBOBJS='' LIBPOLL='' LIBPTHREAD='' LIBS='' LIBWINE_LDFLAGS='' LINT='' LINTFLAGS='' LN='' LN_S='' LTLIBOBJS='' MAIN_BINARY='' MINGWAR='' NASLIBS='' OBJEXT='' OPENGLFILES='' OPENGL_LIBS='' PACKAGE_BUGREPORT='wine-devel(a)winehq.org' PACKAGE_NAME='Wine' PACKAGE_STRING='Wine 0.9.37' PACKAGE_TARNAME='wine' PACKAGE_VERSION='0.9.37' PATH_SEPARATOR=':' PKG_CONFIG='' PRELINK='' QUARTZFILES='' RANLIB='' RESOLVLIBS='' SANEINCL='' SET_MAKE='' SHELL='/bin/bash' SOCKETLIBS='' STRIP='' TOOLSDIR='' WIN16_FILES='$(WIN16_FILES)' WIN16_INSTALL='$(WIN16_INSTALL)' WINDRES='' XFILES='' XLIB='' XMKMF='' XML2INCL='' XML2LIBS='' XSLTINCL='' XSLTLIBS='' X_CFLAGS='' X_EXTRA_LIBS='' X_LIBS='' X_PRE_LIBS='' ac_ct_AS='' ac_ct_CC='gcc -m32' ac_ct_CXX='' bindir='${exec_prefix}/bin' build='x86_64-unknown-linux-gnu' build_alias='' build_cpu='x86_64' build_os='linux-gnu' build_vendor='unknown' datadir='${datarootdir}' datarootdir='${prefix}/share' docdir='${datarootdir}/doc/${PACKAGE_TARNAME}' dvidir='${docdir}' exec_prefix='NONE' ft_devel2='' ft_devel='' gphoto2_devel='' gphoto2port_devel='' host='x86_64-unknown-linux-gnu' host_alias='' host_cpu='i386' host_os='linux-gnu' host_vendor='unknown' htmldir='${docdir}' includedir='${prefix}/include' infodir='${datarootdir}/info' libdir='${exec_prefix}/lib' libexecdir='${exec_prefix}/libexec' localedir='${datarootdir}/locale' localstatedir='${prefix}/var' mandir='${datarootdir}/man' oldincludedir='/usr/include' pdfdir='${docdir}' prefix='/usr/local' program_transform_name='s,x,x,' psdir='${docdir}' sane_devel='' sbindir='${exec_prefix}/sbin' sharedstatedir='${prefix}/com' sysconfdir='${prefix}/etc' target_alias='' ## ------------------- ## ## File substitutions. ## ## ------------------- ## MAKE_DLL_RULES='' MAKE_IMPLIB_RULES='' MAKE_PROG_RULES='' MAKE_RULES='' MAKE_TEST_RULES='' ## ----------- ## ## confdefs.h. ## ## ----------- ## #define PACKAGE_NAME "Wine" #define PACKAGE_TARNAME "wine" #define PACKAGE_VERSION "0.9.37" #define PACKAGE_STRING "Wine 0.9.37" #define PACKAGE_BUGREPORT "wine-devel(a)winehq.org" configure: exit 77

5 4

OpenAL32 dll thunk test
by Chris Robinson 14 May '07

14 May '07

After the previous attempt by Nick Burns was more or less abandoned, I decided to try making an acceptable version myself. This is the current result. I used the original version Nick had and got rid a lot of the macro abuse. It still uses macros to declare/define and load the functions, but it isn't nearly as bad as it was. I know AJ isn't very thrilled with macro use, but I believe the current method is a nice balance between flexibility and clarity. Note that this IS NOT FINISHED. It should be good enough to work, however. The main reason for this is to get some testing to make sure it works as expected on other machines (especially OSX). The things I still need to work on are: a) Skip building the DLL if OpenAL headers aren't found on the system durring ./configure (any autotools experts want to help?) b) Properly handle the autotools stuff (any autotools experts want to help?) c) Fix up extension handling to use al[c]GetProcAddress instead of dlsym (for the sake of being proper; I don't believe this would pose a problem currently) The OpenAL lib is dynamicly loaded, so the lib doesn't need to be present when building. If the lib is not present when the DLL is loaded however, then the DLL will fail to load. Because of this, it might be a good idea to include OpenAL headers with Wine, so they will always be available to build the DLL with (the headers are LGPL licensed, AFAIK). Won't have to worry about skipping building or configure checking that way. On my Linux machine, the OpenAL 1.1 SDK demos work*. I'm curious about how they work for other people on other machines, and for other apps. * Not quite true. EnumerateWin32.exe doesn't wait for a key press before exiting, and OpenALDemo.exe won't wait for key presses when trying to pick a test (it loops endlessly on the "main menu"). These problems are not related to OpenAL. PlayStaticWin32.exe and PlayStreamWin32.exe both work perfectly, and EnumerateWin32.exe does do what it's supposed to, with the exception of the wait-for-key-before-exit problem. Note that if you're using the Sample Implementation, you must get a recent (as in today/yesterday) SVN checkout of it. It was missing a couple somewhat obscure 1.1 functions I sent in a patch for and got applied. After patching, you'll need to run autoconf (or autogen if you use that script) to generate a new configure. Reconfigure, then rebuild Wine. PS. I did get permission from Nick before posting this as I used his "un-licensed" patch as a starting point. It's all okay with him. PPS. I know not everyone likes the idea of this thunk, because the native implementations aren't "up to par" with the Windows version that backends on DSound. However, the only way they'll get better is with use (they've already got several patches from me because of this thunk, with more pending, and more in planning), and if worse comes to worse, you can use a DLL override to use the Windows native OpenAL. Creative is planning on releasing hardware OpenAL Linux drivers for some of their cards later this year, and this would be the best way to take advantage of them.

3 2

How works pGetAsyncKeyState?
by Rafał Miłecki 14 May '07

14 May '07

Hello, It's my first time I look into source of Wine. I found a bug near dlls/user32/input.c. You can find here this code: SHORT WINAPI GetAsyncKeyState(INT nKey) { return USER_Driver->pGetAsyncKeyState( nKey ); } The problem is that this function don't return right value in every case. Could someone explain me how it works, please? I can not find anywhere code writing any value to "pGetAsyncKeyState" nor function that is executed when "pGetAsyncKeyState" is called. -- Rafał Miłecki

1 0

Re: [PATCH 2/8] msi/tests: automation: Add test for Installer::InstallProduct.
by James Hawkins 14 May '07

14 May '07

On 5/14/07, Misha Koshelev <mk144210(a)bcm.edu> wrote: > --- > dlls/msi/tests/automation.c | 307 ++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 300 insertions(+), 7 deletions(-) > + /* Installer::ProductState for our product code, which has been installed */ + hr = Installer_ProductState(szProductCode, &iValue); + ok(SUCCEEDED(hr), "Installer_ProductState failed, hresult 0x%08x\n", hr); + if (SUCCEEDED(hr)) + todo_wine ok(iValue == INSTALLSTATE_DEFAULT, "Installer_ProductState returned %d, expected %d\n", iValue, INSTALLSTATE_DEFAULT); If you're assuming that hr SUCCEEDED (which you are by putting that check in ok), then you shouldn't condition the next ok on SUCCEEDED(hr). -- James Hawkins

2 1

Re: dinput: Prevent race between destroying the hook window and unloading the dll.
by Alexandre Julliard 14 May '07

14 May '07

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > else ERR("Error creating message window\n"); > > + UnregisterClassW(classW, DINPUT_instance); > return 0; You need to clear the class atom if you unregister the class, otherwise the next window creation will fail. -- Alexandre Julliard julliard(a)winehq.org

1 0

LinuxConf Europe
by Kai Blin 13 May '07

13 May '07

Hi folks, I'm considering to send in a paper proposal for LinuxConf Europe 2007 (http://www.linuxconf.eu/2007/cfp/) talking about (my plans for) Wine / Samba integration. Is there anybody else planning to go there? How about a small meeting there, to practice for WineConf? ;) As far as my plans go, the wiki already lists some of the things, I'm planning to flesh this out a little more. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: [PATCH] some alsa midi fixes
by James Hawkins 13 May '07

13 May '07

On 5/13/07, Ralf Beck <musical_snake(a)gmx.de> wrote: > Hello, > this patch fixes: > - Bug 8096 > - incorrect handling of pitchbender on midi-in > - add midi-in midiclock/start/stop/continue/spp/song sel > - make midi-out midiclock/start/stop/continue/spp/song sel handling same > style as on midi-in > One fix per patch please. -- James Hawkins

1 0