May 2007 - Wine-devel - list.winehq.org

RE: advapi32: Route all 4 EnumServicesStatus[Ex] calls to a single stubto avoid code duplication
by Rolf Kalbermatter 18 May '07

18 May '07

Paul Chitescu wrote: >Changelog: advapi32: Route all 4 EnumServicesStatus[Ex] calls to a single >stub to avoid code duplication > >Most of the actual enumeration is common code so it makes sense to implement it only once. This is a possible approach. I had intended to just make use of EnumServicesStatusExW from all other functions with some translation in them. Your approach avoids translations at the cost of making the common enumeration function quite a bit more complicated. I'm not sure which one I like more. Rolf Kalbermatter

1 0

Re: RegDeleteTree [5]
by Juan Lang 18 May '07

18 May '07

Hi Stefan, + if (ret) return ret; + + ret = RegDeleteTreeW(hSubKey, lpszName); + if (ret) return ret; you've followed James's advice, but now you leak hSubKey (when it isn't hKey) and lpszName (when it isn't szNameBuf.) A goto would be better. --Juan ____________________________________________________________________________________Got a little couch potato? Check out fun summer activities for kids. http://search.yahoo.com/search?fr=oni_on_mail&p=summer+activities+for+kids&…

1 0

Re: ntdll: Protect RtlAllocateHeap and RtlReAllocateHeap against integer overflows with large values of size.
by Chris Robinson 18 May '07

18 May '07

On Friday 18 May 2007 04:01:19 am Robert Shearman wrote: > + ULONGLONG llret = (ULONGLONG)a + b; > + if ((sizeof(SIZE_T) < sizeof(ULONGLONG)) && (llret > 0xffffffff)) > + return FALSE; WOuldn't this be more correct (as well as function when sizeof(SIZE_T) >= sizeof(ULONGLONG)): SIZE_T res = a + b; return (res >= a);

2 3

Re: wininet: Add support for SSPI authentication for HTTP.
by Alexandre Julliard 18 May '07

18 May '07

Robert Shearman <rob(a)codeweavers.com> writes: > + if (strncmpiW(pszAuthValue, szBasic, sizeof(szBasic)/sizeof(szBasic[0])-1)) > + { When using strncmp you need to also check that you reached the end of the first string. > + /* compare against last character to be set to avoid a race */ > + if (HTTP_Base64Dec['/'] != 63) > + { This won't avoid the race, you'll still get garbage if two threads get here at the same time. -- Alexandre Julliard julliard(a)winehq.org

2 4

Re: 3/4 setupapi: Correctly handle an empty filename in SetupGetSourceFileLocationA.
by James Hawkins 18 May '07

18 May '07

On 5/18/07, Hans Leidekker <hans(a)it.vu.nl> wrote: > > -Hans > > Changelog > Correctly handle an empty filename in SetupGetSourceFileLocationA. > Please add a test case. -- James Hawkins

2 1

Re: 2/4 setupapi: Don't return ERROR_WRONG_INF_STYLE when there is no version section.
by James Hawkins 18 May '07

18 May '07

On 5/18/07, Hans Leidekker <hans(a)it.vu.nl> wrote: > > -Hans > > Changelog > Don't return ERROR_WRONG_INF_STYLE when there is no version section. > This is a change that is begging for a test case. -- James Hawkins

1 0

Re: hhctrl.ocx: Parse HTML entities in the table of contents.
by Alexandre Julliard 18 May '07

18 May '07

Robert Shearman <rob(a)codeweavers.com> writes: > + /* hexadecimal entity */ > + while ((*p >= '0' && *p <= '9') || (*p >= 'a' && *p <= 'f') || > + (*p >= 'A' && *p <= 'F') || (*p == ';')) > + p++; You should exit the loop at the first ';'. Also you have to increment p first. > + while (isalpha(*p)) > + p++; You can't use ASCII ctype functions on Unicode chars. > + for (i = 0; i < sizeof(char_refs)/sizeof(char_refs[0]); i++) > + if (p - start - 1 <= sizeof(char_refs[i].name)) > + { > + if (!strncmpW(char_refs[i].name, start + 1, p - start - 1)) > + break; > + } The sizeof check doesn't make much sense, especially inside the loop. What you need is to check that you reached the end of the string if the strncmpW succeeded. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: mshtml: Change the binding flags when silent operation is requested by the DISPID_AMBIENT_SILENT property.
by Alexandre Julliard 18 May '07

18 May '07

Robert Shearman <rob(a)codeweavers.com> writes: > The binding flags should be have BINDF_SILENTOPERATION and BIND_NO_UI added. This breaks the tests: ../../../tools/runtest -q -P wine -M shdocvw.dll -T ../../.. -p shdocvw_test.exe.so webbrowser.c && touch webbrowser.ok webbrowser.c:197: Test failed: unexpected call Invoke_AMBIENT_DLCONTROL make[2]: *** [webbrowser.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: wininet: Add support for SSPI authentication for HTTP.
by Juan Lang 18 May '07

18 May '07

Hi Rob, +static UINT HTTP_DecodeBase64(LPCWSTR base64, LPSTR bin); Do we really have to keep proliferating base64 implementations? Could you not implement CryptStringToBinaryW instead? Should be mostly a copy-paste job.. --Juan ____________________________________________________________________________________Get the Yahoo! toolbar and be alerted to new email wherever you're surfing. http://new.toolbar.yahoo.com/toolbar/features/mail/index.php

2 1

New winetricks: added pdh, cc580; msxml3 now supports -q
by Dan Kegel 18 May '07

18 May '07

Thanks to Hans Leidekker for the pdh and common controls hunks! And thanks to Rob and James for whipping the msxml3 installer into shape; it now works even with -q. As always, it's up at http://kegel.com/wine/winetricks

1 0