May 2007 - Wine-devel - list.winehq.org

GDI+: headers and one test
by Evan Stade 01 Jun '07

01 Jun '07

Changelog: *Added public GDI+ headers in include/ *Added private GDI+ headers in dlls/gdiplus *Added small implementation of GDI+ pens in dlls/gdiplus/pen.c *Added (first) GDI+ test dlls/gdiplus/Makefile.in | 3 + dlls/gdiplus/gdip_defines.h | 43 +++++++++++++++++++ dlls/gdiplus/gdip_enumerations.h | 57 ++++++++++++++++++++++++++ dlls/gdiplus/gdiplus.c | 27 ++++++++++++ dlls/gdiplus/gdiplus.spec | 8 ++-- dlls/gdiplus/gdiplus_private.h | 43 +++++++++++++++++++ dlls/gdiplus/pen.c | 84 ++++++++++++++++++++++++++++++++++++++ dlls/gdiplus/pen.h | 30 ++++++++++++++ dlls/gdiplus/tests/Makefile.in | 13 ++++++ dlls/gdiplus/tests/pen.c | 44 ++++++++++++++++++++ include/Gdiplus.h | 10 +++++ include/GdiplusEnums.h | 39 ++++++++++++++++++ include/GdiplusFlat.h | 23 ++++++++++ include/GdiplusGpStubs.h | 10 +++++ include/GdiplusInit.h | 26 ++++++++++++ include/GdiplusTypes.h | 7 +++ 16 files changed, 462 insertions(+), 5 deletions(-) -Evan Stade

6 5

Re: mshtml #2: Added warning if a wrong Wine Gecko package version was found.
by Alexandre Julliard 01 Jun '07

01 Jun '07

Jacek Caban <jacek(a)codeweavers.com> writes: > @@ -212,8 +213,10 @@ static BOOL load_wine_gecko(PRUnichar *gre_path) > if(res != ERROR_SUCCESS || type != REG_SZ) > return FALSE; > > - if(TRACE_ON(mshtml)) > - check_version(gre_path); > + /* We may consider message box here */ > + if(ERR_ON(mshtml) && !check_version(gre_path)) > + MESSAGE("Found a version of Wine Gecko package that is not dedicated " > + "to your Wine version. Reinstalation is recommended.\n"); If you want to check versions, there needs to be a way to specify in the URL which version you want to download, and old versions need to be kept available. The target CPU should also be part of the URL so we can support multiple platforms. -- Alexandre Julliard julliard(a)winehq.org

2 5

Bug triage, or spam?
by Tom Spear 01 Jun '07

01 Jun '07

Hi all, I just have a quick question.. I got a message from someone last night asking me to stop closing bugs because I'm spamming the list, however I also received a message from someone a couple of nights ago thanking me for doing bug triage.. Which is it, and if it is both, then what draws the line between triage and spam, and how do I close stale bugs without it being considered spam? -- Thanks Tom

6 17

The ddraw tests don't compile with Visual C++ 2005.
by Francois Gouget 01 Jun '07

01 Jun '07

Visual C++ 2005 does not like the way we compute the infinity and NaN values. I've tried replacing the current divisions by zero with arithmetic on FLT_MAX (at least for the infinity calculations), but it did not like that either. Does anyone know how to make these calculations portable? How does one get at these values on Windows? diff --git a/dlls/ddraw/tests/d3d.c b/dlls/ddraw/tests/d3d.c [...] light.dvAttenuation0 = -1.0 / 0.0; /* -INFINITY */ [...] light.dvAttenuation0 = 1.0 / 0.0; /* +INFINITY */ [...] light.dvAttenuation0 = 0.0 / 0.0; /* NaN */ -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 1 + e ^ ( i * pi ) = 0

4 4

FPS tool for wine
by Tomas.Zijdemans＠student.uib.no 01 Jun '07

01 Jun '07

The largest gaming site in Norway recently did an extensive review of gaming on Linux, but Wine was left out of the benchmark because "no FPS tool exists for Wine". Surely this can't be true?

10 11

Re:wine.inf: Create fake dll for iexplore.exe.
by Louis. Lenders 01 Jun '07

01 Jun '07

>wine.inf: Create fake dll for >iexplore.exe. >Vitaliy Margolen wine-patches at kievinfo.com >Thu May 24 08:50:10 CDT 2007 >Some older programs check if IE is installed looking for c:\Program >Files\Internet Explorer\iexplore.exe --- tools/wine.inf | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)

2 1

Re: [d3drm/tests] d3drm is removed from Windows Vista
by H. Verbeet 31 May '07

31 May '07

On 11/05/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > d3drm is removed from Windows Vista and thus we have to check if it can be loaded. > I suppose that implies that any application using d3drm won't work on Vista?

3 2

re: Whitespace changes in an indentation patch, is it acceptable?
by Dan Kegel 31 May '07

31 May '07

Tom wrote: >Hi all, just curious, in my work on uninstaller, I am writing my >patches to where when indentation is changed, due to adding a for >loop, it is done in a separate patch file. I was wondering if it is >acceptable to make whitespace changes to other parts of the file in >that same patch. In general, mixing large whitespace changes with small functional changes make it hard to code review the functional change. But either way can be fine, it just depends on the situation. Now that you've fixed a couple bugs in your uninstall patch, I think you should post the very simplest form of it possible, without any other change mixed in. In this case, I think that means you should do the whitespace changes in a second patch. - Dan

3 2

Whitespace changes in an indentation patch, is it acceptable?
by Tom Spear 31 May '07

31 May '07

Hi all, just curious, in my work on uninstaller, I am writing my patches to where when indentation is changed, due to adding a for loop, it is done in a separate patch file. I was wondering if it is acceptable to make whitespace changes to other parts of the file in that same patch.. For example, there is: int somevariable; do something; (there are 2 spaces in the blank line). Would it be acceptable to remove those spaces in a patch that changes the following code (which is introduced by the first patch in the series): for blah { do something; for something else { do another thing; } } to: for blah { do something; for something else { do another thing; } } or should I just leave those extra whitespaces in the blank line alone? -- Thanks Tom

1 0

winefile/explorer hardcoded? HKEY_CLASSES_ROOT\Folder\shell\open\command ignored
by RusH 31 May '07

31 May '07

Repost from wine-users(no answer there). Winefile seems to be hardcoded when it comes to opening folders. No matter what I do it always pops up. I tried deleting HKEY_CLASSES_ROOT\Folder and nothing changed. What can I do to convince wine to open folders with /usr/bin/nautilus ? I allready made it open ordinary files with gnome-open. Should I made a bug report? Are DDE registry keys for folder opening only a prop? -- Who logs in to gdm? Not I, said the duck.

2 1