May 2007 - Wine-devel - list.winehq.org

Re: (try 2) ws2_32: getsockname should fail for unbound sockets
by Dmitry Timoshkov 31 May '07

31 May '07

"Damjan Jovanovic" <damjan.jov(a)gmail.com> wrote: > + case AF_INET6: > + { > + static const struct sockaddr_in6 emptyAddr; > + const struct sockaddr_in6 *in6 = (struct sockaddr_in6*) uaddr; > + return in6->sin6_port || memcmp(&in6->sin6_addr, &emptyAddr.sin6_addr, sizeof(struct in6_addr)); > + } > + case AF_INET: > + { > + static const struct sockaddr_in emptyAddr; > + const struct sockaddr_in *in = (struct sockaddr_in*) uaddr; > + return in->sin_port || memcmp(&in->sin_addr, &emptyAddr.sin_addr, sizeof(struct in_addr)); > + } You should add 'const' to the casting if the target you create is 'const'. -- Dmitry.

1 0

Re: headers, two tests
by Dmitry Timoshkov 31 May '07

31 May '07

This time it's just the nit picks, I see no serious problems. "Evan Stade" <estade(a)gmail.com> wrote: > +void WINGDIPAPI GdipFree(void* ptr) > +{ > + if(ptr) > + HeapFree(GetProcessHeap(), 0, ptr); > +} There is no need to check a pointer for NULL before HeapFree call, there is even a janitorial project in Wine to remove such checks. > +static void test_constructor_destructor(void) > +{ > + GpStatus status; > + GpGraphics *pen; > + > + status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel, &pen); GdipCreatePen1 takes a pointer to GpPen in the last parameter, not GpGraphics. > + expect(Ok, status); > + ok(pen, "Expected pen to be initialized"); If you are testing returned pen pointer for NULL, you need to initialize it to NULL before the call. -- Dmitry.

1 0

Re: crypt32: implement CryptSIPLoad (resend)
by Juan Lang 30 May '07

30 May '07

Hi Paul, > Please correct me if I'm wrong but aren't you filling pSipDispatch > with the function pointers of the given dll (as indicated by the GUID) > instead of the function pointers of crypt32 (as the tests show it > should)? I am. I couldn't find any reason that the behavior needs to be that way, so I do this until such time as a reason can be found. The tests don't fail, as you check the function pointers from msisip.dll, which isn't present on wine. If you know a good reason native does it that way (or an app that depends on it,) by all means enlighten me. The implementation I sent allows native wintrust to get a bit further. --Juan ____________________________________________________________________________________ Get your own web address. Have a HUGE year through Yahoo! Small Business. http://smallbusiness.yahoo.com/domains/?p=BESTDEAL

2 1

Pretty Build System (Take 3)
by Robert Shearman 30 May '07

30 May '07

Hi, Attached is a patch that reduces the verbosity of the build system by printing the build commands in one of two formats: COMMAND output_file or COMMAND input_file -> output_file I hope it meets Alexandre's requirements of not reducing portability of Wine to other platforms (including Windows). -- Rob Shearman

3 5

Looking for Dev to help with BSD Port
by Kris Moore 30 May '07

30 May '07

Hey all! We're looking for a Wine dev to assist us with some porting issues over to PC-BSD / FreeBSD. We've recently begun to embrace making packages with wine embedded, making the process of loading windows programs a snap. The end user only needs to double-click, insert their CD, and click next a few times. This allowed us to make some packages for programs such as PhotoShop & Dreamweaver which even a non-linux/BSD user could install. We really want to expand these packages, to include things such as games, and others, but there are a few problems with running Wine on BSD at the moment. If anybody is willing to help us out with this, please let me know! Here's a list of some of the porting issues were aware of: http://wiki.freebsd.org/Wine Thanks! -- Kris Moore PC-BSD Software http://www.pcbsd.com

1 0

Ownerdraw listview font patch...
by Markus Gömmel 30 May '07

30 May '07

Hi, one of our windows application is using an OWNERDRAW_FIXED listview. With the current version of Wine I mentioned that when the listview is loosing its focus, the selected item will be repainted in a wrong front (System 12 instead of my MS Shell Dlg 11)... after the focus comes back, the item is redrawn again, now with correct font settings again. After searching for a while my idea is that the LISTVIEW_ShowFocusRect function is missing a SelectObject call to the font stored in the item-structure for this particular listview item. So the hdc transfered over WM_DRAWITEM to the application contains the wrong font. I created the attached patch, which looks like this: --- snipp --- diff -u -u -r1.485 listview.c --- dlls/comctl32/listview.c 25 May 2007 19:46:02 -0000 1.485 +++ dlls/comctl32/listview.c 30 May 2007 12:28:44 -0000 @@ -1770,6 +1770,9 @@ { DRAWITEMSTRUCT dis; LVITEMW item; + + HFONT hFont = infoPtr->hFont ? infoPtr->hFont : infoPtr->hDefaultFont; + HFONT hOldFont = SelectObject(hdc, hFont); item.iItem = infoPtr->nFocusedItem; item.iSubItem = 0; @@ -1788,6 +1791,8 @@ dis.itemData = item.lParam; SendMessageW(infoPtr->hwndNotify, WM_DRAWITEM, dis.CtlID, (LPARAM)&dis); + + SelectObject(hdc, hOldFont); } else { --- snipp --- Before sending this to wine.patches, I wanted to ask if anyone here can tell me if the above is ok or total bullshit. Thanks and regards Markus

2 1

Re: Implement the WriteEnvironmentStrings standard action
by Dmitry Timoshkov 30 May '07

30 May '07

"James Hawkins" <truiken(a)gmail.com> wrote: > + HKEY env, root = HKEY_CURRENT_USER; ... > + if (flags & ENV_MOD_MACHINE) > + root = HKEY_LOCAL_MACHINE; It looks like root is not used. -- Dmitry.

2 1

Re: crypt32: implement CryptSIPLoad (resend)
by Paul Vriens 30 May '07

30 May '07

On 5/30/07, Juan Lang <juan_lang(a)yahoo.com> wrote: > Hi, I fixed the test failures - anything wrong with it this time? > > ChangeLog: implement CryptSIPLoad > > Thanks, > --Juan > Hi Juan, Please correct me if I'm wrong but aren't you filling pSipDispatch with the function pointers of the given dll (as indicated by the GUID) instead of the function pointers of crypt32 (as the tests show it should)? Cheers, Paul.

1 0

Call for Ubuntu-wine admin
by Tomas.Zijdemans＠student.uib.no 30 May '07

30 May '07

If someone is interested in leading the Ubuntu-wine team, please contact me.

4 3

Re: [ws2_32] getsockname should fail on unbound socket
by Kai Blin 30 May '07

30 May '07

On Wednesday 30 May 2007 07:56:31 Damjan Jovanovic wrote: > + case AF_INET: { > + const struct sockaddr_in *in = (struct sockaddr_in*) uaddr; > + return in->sin_port != 0; > + } Talking to Alexandre about this in IRC, he wanted me to check for all-null returns, so you probably should check if the IP address is 0.0.0.0 (or :: for IPv6), too. Also, I had the impression that the Wine convention was that case block braces go onto a new line, too. You might want to consider that for the switch you addded. Thanks for doing the work for me otherwise :) Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 0