May 2007 - Wine-devel - list.winehq.org

re: winscard: add pcsc-lite helpers for upcoming implementation
by Dan Kegel 24 May '07

24 May '07

James wrote: > This would be a lot cleaner as: > > if (!(liteSCardEstablishContext = (SCardEstablishContextPtr) > wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr))) > { > ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); > goto error; > } I think in C you can skip the cast from void *, can't you? e.g. liteSCardEstablishContext = wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr)); if (!liteSCardEstablishContext) { ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); goto error; } -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: winscard: add pcsc-lite helpers for upcoming implementation
by Juan Lang 24 May '07

24 May '07

+BOOL InitializePCSCLite(void) You don't use the return value: @@ -42,9 +43,11 @@ BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) { DisableThreadLibraryCalls(hinstDLL); WINSCARD_hModule = hinstDLL; + InitializePCSCLite(); break; } I suspect it's safer not to fail loading winscard if PCSC-Lite isn't available. Instead, the functions such as SCardListCards should probably return empty lists. But knowing to do so relies on knowing that PCSC-Lite couldn't be initialized, so the return value shouldn't be thrown away. Or, remove the return value, and have every function check the function pointers it needs. --Juan ____________________________________________________________________________________Sick sense of humor? Visit Yahoo! TV's Comedy with an Edge to see what's on, when. http://tv.yahoo.com/collections/222

2 1

Re: help: test subprogram can't be console app
by Misha Koshelev 24 May '07

24 May '07

Ok, never mind. I found a way to fool the Windows shell into allowing me to actually execute the appropriate console app while at the same time picking up the DDE string in a separate server (fail connection when it tries to connect first time in the DDE server in the process calling ShellExecute, then succeed the next time after it has launched the app, thus getting both the command line params and the DDE string; yay) Misha

1 0

Re: winscard: add pcsc-lite helpers for upcoming implementation
by James Hawkins 24 May '07

24 May '07

On 5/23/07, Mounir IDRASSI <mounir.idrassi(a)idrix.fr> wrote: > Hi, > This patch adds helper variables and functions that exposes pcsc-lite > functionalities for the use of the upcoming implementation. > + /* loading entry points*/ + bSuccess = TRUE; + if (bSuccess && + !(liteSCardEstablishContext = (SCardEstablishContextPtr) wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr)))) + { + bSuccess = FALSE; + ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); + } This would be a lot cleaner as: if (!(liteSCardEstablishContext = (SCardEstablishContextPtr) wine_dlsym(g_pcscliteHandle,"SCardEstablishContext",szErr,sizeof(szErr))) { ERR("Failed to get SCardEstablishContext from pcsclite library. Error = %s\n",szErr); goto error; } .... return TRUE; error: wine_dlclose(g_pcscliteHandle,NULL,0); g_pcscliteHandle = NULL; return FALSE; } -- James Hawkins

1 0

help: test subprogram can't be console app
by Misha Koshelev 24 May '07

24 May '07

Hi all, So I have run into a weird problem. I was writing a conformance test for ShellExecute logic of when to use DDE and a little about how it uses it, as currently the logic is incorrect and fails for some apps, e.g., Vector NTI (the fix is pretty easy, but I'd like to make a nice conformance test to go with it). Anyhow, shlexec.c conformance tests in shell32 have a nice framework where the test program itself is associated with an extension, and I just extended that to also allow a DDE execute and save the results. It didn't seem to work (FILENOTFOUND error) except when the program was already running, and then it worked fine. Just to see what was going on, I made a very simple program (attached) and used the following simple compile script to make 2 versions, one a console program and one a regular windows program (with the -mwindows switch). The -mwindows one allows DDE-based ShellExecute (or just "start" command) opening just fine, whereas withotu -mwindows the shell complains right away that the file trying to be started is not found. So it looks like I need to somehow start a non-console test program from within a test, any ideas on this? Thanks Misha --- Script: i386-mingw32-gcc -o console.exe -lshell32 -lole32 -loleaut32 -lshlwapi -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid -I. -I../../../include console.c i386-mingw32-gcc -o gui.exe -lshell32 -lole32 -loleaut32 -lshlwapi -luser32 -lgdi32 -ladvapi32 -lkernel32 -luuid -I. -I../../../include console.c -mwindows

1 0

Hello all
by Matthew Larsen 24 May '07

24 May '07

Hello all, I just joined up to the mailing list so thought I would say hello to everyone :-) I am a student studying Computer Science at Manchester University (UK) and am interested in helping the development of Wine. I decided the first step was to hop on the mailing lists and see whats going on! I have experience in writing basic Operating Systems (In ARM Assembler, as well as making ARM's work with FPGA's if your interested) and knowledge of fundamental OS functions so I hope they will come in useful at some stage. Also got a good grasp of C/C++, UNIX and Windows / Windows Server. My motivation with joining Wine was primarily to one-day get Counterstrike:Source working properly. Secondary is the fact I am fed-up completely with Windows but unfortunately have apps that are not supported in Linux / Unix and would like to get them ported onto Wine. Hope to get talking with you all soon, Regards, -- Matthew G Larsen > mat.larsen(a)gmail.com > +44(0)7739 785 249

2 1

tests: show summary and last executed test in case of a crash
by Peter Oberndorfer 23 May '07

23 May '07

Some tests on http://test.winehq.org/data/ seem to crash silently. This patch might be useful for debugging such crashes. It prints out the last ok/trace that was executed before the crash, the exception address and the type of the crash. It also print out the summary that is normally printed at the end of the test instead of exiting silently[1]. On wine it still executes winedbg for better debugging after dumping out the info. My concern now is that it requires a change to the parser which accepts the test reports, so those crashes are not lost. And don't know much about this parser. Suggestions, ideas anyone? Greetings Peter [1] example output: file.c:1228:FileSize: 0 file.c:1229:Unknown2[0]: 0 Test crashed at B7D0DF47 with error c0000005 Last test before crash: file.c:1239 file: 19 tests executed (0 marked as todo, 3 failures), 0 skipped. wine: Unhandled page fault on write access to 0x00001234 at address 0xb7d0df47 (thread 0009), starting debugger... Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b ...

2 2

Re: Bugzilla outcome?
by Robert Shearman 23 May '07

23 May '07

Tom Spear wrote: > Just curious to see if anything was ever done with the offer to > upgrade bugzilla? > > On a side note, it would be nice if there was a crash keyword to make > finding crashes easier Searching for "Unhandled exception" is too hard? -- Rob Shearman

5 8

Re: crypt32: implement CryptSIPLoad (resend)
by Alexandre Julliard 23 May '07

23 May '07

Juan Lang <juan_lang(a)yahoo.com> writes: > Hi, any problems with this one? It's causing test failures: ../../../tools/runtest -q -P wine -M rsaenh.dll -T ../../.. -p rsaenh_test.exe.so rsaenh.c && touch rsaenh.ok rsaenh.c:64: Test failed: 0, 00000057 rsaenh.c:68: Test failed: 00000057 make: *** [rsaenh.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 3

RE: Application deletion!
by EA Durbin 23 May '07

23 May '07

Someone using Molle Bestefich's account has been attacking the AppDB. I've lost my AppDB admin privileges as well as a bunch of things are being deleted. >From: James Bond <tehstealth(a)yahoo.com> >To: appdb(a)winehq.org >Subject: Application deletion! >Date: Wed, 23 May 2007 04:40:49 -0700 (PDT) > >I'm sorry, I do not know who to contact for this, but the 2 apps I've been >maintaining Soldat, and Battlefield 2 have BOTH been completely deleted! >At first it was Soldat, and I thought maybe since it was a small game made >by a lone developer, it was removed. I e-mailed the person resposnible, toa >ask why. But I just got another mass spam of e-mails this morning saying >this and that were deleted from Battlefield 2, a very popular game! I think >something is wrong. Molle Bestefich (molle.bestefich(a)gmail.com) is the one >whose deleted all of that stuff. What is going on? > >-Brian > > > >____________________________________________________________________________________Ready >for the edge of your seat? >Check out tonight's top picks on Yahoo! TV. >http://tv.yahoo.com/ _________________________________________________________________ More photos, more messages, more storageget 2GB with Windows Live Hotmail. http://imagine-windowslive.com/hotmail/?locale=en-us&ocid=TXT_TAGHM_migrati…

2 1