May 2007 - Wine-devel - list.winehq.org

Re: RegDeleteTree [8]
by Alexandre Julliard 23 May '07

23 May '07

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + /* Recursively delete all the subkeys */ > + for (i = 0; i < dwKeyCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumKeyExW(hSubKey, 0, lpszName, &dwSize, NULL, > + NULL, NULL, NULL); There's no reason to use the key count, you should enum until you get an error, it's more reliable. > + for (i = 0; i < dwValCount; i++) { > + dwSize = dwMaxLen; > + ret = RegEnumValueW(hKey, 0, lpszName, &dwSize, NULL, NULL, NULL, NULL); Same here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] DDraw: Hold the dll lock in IDirectDrawSurfaceX methods
by Alexandre Julliard 23 May '07

23 May '07

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > @@ -810,8 +841,12 @@ IDirectDrawSurfaceImpl_AddAttachedSurface(IDirectDrawSurfaceImpl *This, > { > TRACE("(%p)->(%p)\n", This, Surf); > > + EnterCriticalSection(&ddraw_cs); > if(Surf == This) > + { > + LeaveCriticalSection(&ddraw_cs); > return DDERR_CANNOTATTACHSURFACE; /* unchecked */ > + } Parameter checks can be done outside the section, it simplifies the code. There are many more such cases in the patch. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] check return code of ICreateDevEnum_CreateClassEnumerator
by Alexandre Julliard 23 May '07

23 May '07

Marcus Meissner <marcus(a)jet.franken.de> writes: > diff --git a/dlls/quartz/filtermapper.c b/dlls/quartz/filtermapper.c > index 6adce61..841b130 100644 > --- a/dlls/quartz/filtermapper.c > +++ b/dlls/quartz/filtermapper.c > @@ -966,6 +966,9 @@ static HRESULT WINAPI FilterMapper2_Enum > if (SUCCEEDED(hr)) > hr = ICreateDevEnum_CreateClassEnumerator(pCreateDevEnum, &CLSID_ActiveMovieCategories, &pEnumCat, 0); > > + if (!SUCCEEDED(hr)) > + return hr; You are potentially leaking an object here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] basetsd.h: Fix a typo in the parameter name
by Marcus Meissner 23 May '07

23 May '07

On Wed, May 23, 2007 at 04:35:33PM +0900, Dmitry Timoshkov wrote: > Hello, > > Changelog: > basetsd.h: Fix a typo in the parameter name. > > --- > include/basetsd.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/basetsd.h b/include/basetsd.h > index e0d04f6..fe3639f 100644 > --- a/include/basetsd.h > +++ b/include/basetsd.h > @@ -219,7 +219,7 @@ typedef unsigned short UHALF_PTR, *PUHALF_PTR; > #define HandleToULong(h) ((ULONG)(ULONG_PTR)(h)) > #define HandleToLong(h) ((LONG)(LONG_PTR)(h)) > #define ULongToHandle(ul) ((HANDLE)(ULONG_PTR)(ul)) > -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) > +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I do not think this is right. Ciao, Marcus

2 1

[1/5] basetsd.h: Fix a typo in the parameter name
by Vijay Kiran Kamuju 23 May '07

23 May '07

Hi I think this patch is not correct. -#define LongToHandle(h) ((HANDLE)(LONG_PTR)(h)) +#define LongToHandle(h) ((HANDLE)(LONG_PTR)(l)) I dont see 'l' defined or sent to this macro any where. Thanks, VJ

3 2

APPDB ROGE USER
by Vitaliy Margolen 23 May '07

23 May '07

ANYONE WITH appdb admin rights check into IRC!!!

1 0

Re: winscard: small stub implementation of winscard dll (Try 2)
by Mounir IDRASSI 22 May '07

22 May '07

Hi Alexandre, You are completely right...these variables are definitely useless!! I don't remember when I coded that but it must have been very late at night! Anyway, I'll purge them from the patch. Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Alexandre Julliard wrote: > Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: >> Thank you for your comments Alexandre. >> Concerning the SCARD_PCI_xxx , I implemented them as variables instead >> of defines because it's impossible using winelib to link against the >> exported variables g_rgSCardXXX (please see my discussion with Eric >> Pouech about that). Well, I should create variables with other names to >> achieve the same goal. >> > Linking against SCARD_PCI_xxx would be just as impossible, so I still > don't understand why you need any extra variables. Could you give an > example? >

1 0

Re: RegDeleteTree [7] [resend]
by Laurent Vromman 22 May '07

22 May '07

There is a few tabs in the file : Here (line 92), first blank character : + &dwValCount, NULL, NULL, NULL, NULL); Here (line 103) + } Laurent > Hello, > > any comment on the current version of this patch? > > ChangeLog > ------------- > added implementation of RegDeleteTreeA/W > >

2 2

Re: Bugzilla outcome?
by Tom Spear 22 May '07

22 May '07

I sent this to the wrong list before, sorry for that.. Just curious to see if anything was ever done with the offer to upgrade bugzilla? On a side note, it would be nice if there was a crash keyword to make finding crashes easier -- Thanks Tom

1 0

Re: winscard: small stub implementation of winscard dll (Try 2)
by Alexandre Julliard 22 May '07

22 May '07

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > +BOOL WINAPI DllMain (HINSTANCE hinstDLL, DWORD fdwReason, LPVOID lpvReserved) > +{ > + TRACE("%p,%x,%p\n", hinstDLL, fdwReason, lpvReserved); > + > + switch (fdwReason) > + { > + case DLL_PROCESS_ATTACH: > + { > + DisableThreadLibraryCalls(hinstDLL); > + WINSCARD_hModule = hinstDLL; > + /* initialize protocol requests pointers */ > + SCARD_PCI_T0 = &g_rgSCardT0Pci; > + SCARD_PCI_T1 = &g_rgSCardT1Pci; > + SCARD_PCI_RAW = &g_rgSCardRawPci; AFAICT these are supposed to be macros, not variables. Also your indentation is messed up. -- Alexandre Julliard julliard(a)winehq.org

1 0