July 2007 - Wine-devel - list.winehq.org

Re: wine3d3: Check the destination recangle when for FastBlt().
by Stefan Dösinger 02 Aug '07

02 Aug '07

Am Sonntag, 29. Juli 2007 21:28 schrieb Peter Dons Tychsen: > Hello Wine! > > I have fixed a small bug in FastBlt(), which caused Wine to crash if the > application tried to do FastBlt() to a surface using a bad destination > setup. The problem is already fixed in normal Blt(), but was broken for > FastBlt(). > > This fixes a crash for the little game "Treasure Mole Winter Vacations": This check should be in ddraw, not wined3d. ddraw, d3d8 and d3d9 have different ideas about such checks, that's why the check was moved from WineD3D to the client libs. Originally it was in LockRect, and when it was moved the check was lost in Blt and BltFast. There should be a check in ddraw already, maybe it is not sufficient. Also please write a test case to verify that the fix is correct(look at dlls/ddraw/tests/dsurface.c). This will also prevent the problem from coming back. Treasure Mole broke after the ddraw rewrite because exactly this check was missing. I implemented it in LockRect, like in old ddraw, but I forgot to write a test for BltFast. Then a d3d9 game was broken because d3d9 LockRect behaved differently, a test was written for Lock(Rect) in ddraw, d3d8 and d3d9, and the range check moved to ddraw, d3d8 and d3d9 to be able to implement different checking in each version. Since I forgot to write a test when I originally fixed Treasure Mole the bug could creep back in again :-(

2 4

Re: Add winhttp.dll.
by Vijay Kiran Kamuju 01 Aug '07

01 Aug '07

Hi Jacek, I think you can use the header I sent a while back to wine-patches for this. http://www.winehq.org/pipermail/wine-patches/2005-September/020901.html The original patch: http://www.winehq.org/pipermail/wine-patches/attachments/20050923/790dfab2/… This might require some re-work. It was rejected at that time, when I wanted to add winhttp.dll It might be of some help to you. Thanks, VJ

2 1

RPC questions
by Kai Blin 01 Aug '07

01 Aug '07

Hi folks, I will be getting into working on RPC soonish, and some of that I'd like to use for Wine. However, I don't know my way around that code so far, what would be a good starting point to tackle this? My goal is to set up a daemon that will take care of remote named pipes over smb and all of that stuff, while all that Wine needs to do is to access this daemon talking DCE-RPC. As we probably don't need to link anything, we will be able to use that daemon for other jobs, like doing netapi32 calls, etc. Where would I get started for this? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

2 1

Re: #4 pdh: Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime.
by Paul Vriens 01 Aug '07

01 Aug '07

Hans Leidekker wrote: > These APIs were introduced with Vista. > > -Hans > > Changelog > Implement and test PdhAddEnglishCounter{A, W} and PdhCollectQueryDataWithTime. > > > ------------------------------------------------------------------------ > > Hi Hans, I was going through some test failures (already sent a patch for missing defines). It appears that a lot of the used strings, like "System Up Time" is depending on the locale. Some Dutch tests show "Systeem ingeschakeld" instead. Any idea how to fix that? Another thing is that "pdh.dll" is not by default present on NT4 and below so the tests have to be changed to cope with that as well. Should I have a go at that? Cheers, Paul.

3 10

32bit winelib builds in x86_64
by Michael Ost 01 Aug '07

01 Aug '07

What's the command for building a 32bit winelib .dll.so and .exe.so with wineg++ in an x86_64 environment? I am used to doing dlls with: $ wineg++ -shared DLL.spec -o DLL.dll.so ... and exes with: $ wineg++ -o APP.exe.so ... Seems I need to use "-m32" for g++, "--32" for as, and "-m elf_i386" for ld. But with all the nested calls of wineg++ and winebuild I can't figure out how to get those options passed in everywhere they are needed. Any hints? Cheers... Michael Ost

2 1

Re: Implement LockWorkstation using xdg-screensaver from explorer
by Alexandre Julliard 01 Aug '07

01 Aug '07

"Steven Edwards" <winehacker(a)gmail.com> writes: > This time in explorer.... > > With this patch, Process Explorer no longer crashes when locking the > workstation from within the application. If xdg-screensaver is not > present on the system, explorer simply returns in which case > LockWorkstion thinks it still succeeded. I still like the idea of > having our own screensaver for Desktop mode and running that when > LockWorkstation is called. If this is accepted then I will either add > a check for desktop mode to avoid the call to xdg-screensaver or write > a wine scr that only runs in Desktop mode. To be able to do that you need to send the request to the existing explorer process, not start a new one. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: user32: Add a stub for GetAppCompatFlags2
by Michael Stefaniuc 31 Jul '07

31 Jul '07

Hello Detlef, Detlef Riekenberg wrote: > Fix a Crash in PDFCreator with native ps5ui.dll > > Changelog: > user32: Add a stub for GetAppCompatFlags2 > > ------------------------------------------------------------------------ > >>From c2e87ce86f59f8b4346e682fd16d0d7364ba1848 Mon Sep 17 00:00:00 2001 > From: Detlef Riekenberg <wine.dev(a)web.de> > Date: Tue, 31 Jul 2007 05:27:55 +0200 > Subject: [PATCH] user32: Addd a stub for GetAppCompatFlags2 > --- > dlls/user32/misc.c | 11 ++++++++++- > dlls/user32/user32.spec | 2 +- > 2 files changed, 11 insertions(+), 2 deletions(-) > > diff --git a/dlls/user32/misc.c b/dlls/user32/misc.c > index bd1c9f7..3b20d6d 100644 > --- a/dlls/user32/misc.c > +++ b/dlls/user32/misc.c > @@ -575,7 +575,16 @@ BOOL WINAPI UnregisterDeviceNotificatio > */ > DWORD WINAPI GetAppCompatFlags( HTASK hTask ) > { > - FIXME("stub\n"); > + FIXME("(%p) stub\n", hTask); > + return 0; > +} > + > +/*********************************************************************** > + * GetAppCompatFlags (USER32.@) The comment doesn't match the function name. > + */ > +DWORD WINAPI GetAppCompatFlags2( HTASK hTask ) > +{ > + FIXME("(%p) stub\n", hTask); > return 0; > } > > diff --git a/dlls/user32/user32.spec b/dlls/user32/user32.spec > index 8bf9ad1..d626053 100644 > --- a/dlls/user32/user32.spec > +++ b/dlls/user32/user32.spec > @@ -244,8 +244,8 @@ # @ stub EnterReaderModeHelper > @ stdcall GetAltTabInfoA(long long ptr ptr long) > @ stdcall GetAltTabInfoW(long long ptr ptr long) > @ stdcall GetAncestor(long long) > -# @ stub GetAppCompatFlags2 > @ stdcall GetAppCompatFlags(long) > +@ stdcall GetAppCompatFlags2(long) > @ stdcall GetAsyncKeyState(long) > @ stdcall GetCapture() > @ stdcall GetCaretBlinkTime() > > > ------------------------------------------------------------------------ > > bye michael -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111

2 1

msvcr80 support!
by Dan Kegel 31 Jul '07

31 Jul '07

It may be time to start revisiting bugs related to our lack of msvcr80 support ( cf. http://bugs.winehq.org/show_bug.cgi?id=6591 ), as it seems to have started working in the last week. I don't know if it's complete yet, but this is way cool... - Dan

6 7

Re: dlls/comctl32: According to the PSDK, DrawShadowText() takes a non-const RECT pointer.
by Andrew Talbot 31 Jul '07

31 Jul '07

Yes. It seems that the corresponding MSDN web page is out of step. -- Andy.

1 0

Outstanding regression in unicode since 0.9.41
by Scott Ritchie 31 Jul '07

31 Jul '07

Regressions are easiest to fix when caught quickly. Here's one that didn't get fixed in the latest version: http://bugs.winehq.org/show_bug.cgi?id=8948 If anyone needs help reproducing it, you can ask me for help. It should be as simple as the (scrolled down) part of the bug report though - install both installers, then launch the lobby with your desktop link. Thanks, Scott Ritchie

1 0