July 2007 - Wine-devel - list.winehq.org

Re: [PATCH] winecfg: Add menu font settings to desktop integration tab
by Vitaliy Margolen 30 Jul '07

30 Jul '07

Nigel Liang wrote: > diff --git a/programs/winecfg/En.rc b/programs/winecfg/En.rc > index 5972c3b..e61bf29 100644 > --- a/programs/winecfg/En.rc > +++ b/programs/winecfg/En.rc > @@ -200,6 +200,11 @@ BEGIN > CONTROL "Link to:",IDC_LINK_SFPATH,"Button",BS_AUTOCHECKBOX|WS_TABSTOP|WS_DISABLED,15,195,50,13 > EDITTEXT IDC_EDIT_SFPATH,65,195,145,13,ES_AUTOHSCROLL|WS_TABSTOP|WS_DISABLED > PUSHBUTTON "Browse",IDC_BROWSE_SFPATH,215,195,30,13,WS_DISABLED > + GROUPBOX " Menu Font ",IDC_STATIC,8,216,244,50 > + LTEXT "Font: ",IDC_STATIC,20,230,40,10 > + COMBOBOX IDC_MENUFONT_COMBO,55,228,186,30,CBS_DROPDOWNLIST|CBS_SORT|WS_VSCROLL|WS_TABSTOP > + LTEXT "Size: ",IDC_STATIC,20,249,40,10 > + COMBOBOX IDC_MENUFONT_SIZECOMBO,55,247,50,30,CBS_DROPDOWNLIST|WS_VSCROLL|WS_TABSTOP > END There is already a drop down list where you can select menu and the "Font" button. You should use those instead. Of course you will need to make it work for all other items that might have font as an option (like a caption, window, etc). Vitaliy.

2 3

build regression, GLX_RGBA_FLOAT_BIT_ARB undeclared?
by Dan Kegel 30 Jul '07

30 Jul '07

I just did a git pull, and compilation is failing with opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) I think that symbol reference was added just today: http://winehq.org/pipermail/wine-cvs/2007-July/034660.html and is supposed to come from glext.h. Do we need some #ifdef action here? I'm developing on dapper. $ cat /etc/issue Ubuntu 6.06.1 LTS \n \l $ dpkg-query -S glext.h mesa-common-dev: /usr/include/GL/glext.h $ dpkg-query -W mesa-common-dev mesa-common-dev 6.4.1-0ubuntu8

2 2

Re: oleaut32: Constify some variables
by Marcus Meissner 30 Jul '07

30 Jul '07

On Mon, Jul 30, 2007 at 09:27:45PM +0100, Andrew Talbot wrote: > Changelog: > oleaut32: Constify some variables. > > diff -urN a/dlls/oleaut32/typelib.c b/dlls/oleaut32/typelib.c > --- a/dlls/oleaut32/typelib.c 2007-07-30 17:23:19.000000000 +0100 > +++ b/dlls/oleaut32/typelib.c 2007-07-30 21:23:13.000000000 +0100 > @@ -147,7 +147,7 @@ > /* > * Find a typelib key which matches a requested maj.min version. > */ > -static BOOL find_typelib_key( REFGUID guid, WORD wMaj, WORD *wMin ) > +static BOOL find_typelib_key( REFGUID guid, const WORD *wMaj, WORD *wMin ) > { > static const WCHAR typelibW[] = {'T','y','p','e','l','i','b','\\',0}; > WCHAR buffer[60]; > @@ -172,7 +172,7 @@ > { > TRACE("found %s: %x.%x\n", debugstr_w(buffer), v_maj, v_min); > > - if (wMaj == v_maj) > + if (*wMaj == v_maj) > { > if (*wMin == v_min) > { > @@ -274,7 +274,7 @@ > > TRACE_(typelib)("(%s, %x.%x, 0x%x, %p)\n", debugstr_guid(guid), wMaj, wMin, lcid, path); > > - if (!find_typelib_key( guid, wMaj, &wMin )) return TYPE_E_LIBNOTREGISTERED; > + if (!find_typelib_key( guid, &wMaj, &wMin )) return TYPE_E_LIBNOTREGISTERED; > get_typelib_key( guid, wMaj, wMin, buffer ); Alexandre committed a fixed version of this part of the patch already. See: http://source.winehq.org/git/wine.git/?a=commitdiff;h=36720b4945f90896379e7… The const fixup is no longer necessary, since the value now gets passed as argument and not as pointer. The rest might be necessary. Ciao, Marcus

1 0

winex11.drv compile failure
by James Hawkins 30 Jul '07

30 Jul '07

Compile fails for me with today's git: opengl.c: In function 'ConvertAttribWGLtoGLX': opengl.c:676: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) opengl.c:676: error: (Each undeclared identifier is reported only once opengl.c:676: error: for each function it appears in.) opengl.c: In function 'get_render_type_from_fbconfig': opengl.c:845: error: 'GLX_RGBA_FLOAT_BIT_ARB' undeclared (first use in this function) opengl.c:846: error: 'GLX_RGBA_FLOAT_TYPE_ARB' undeclared (first use in this function) -- James Hawkins

3 2

tests/msi.c fails when run twice on Wine?
by Paul Vriens 30 Jul '07

30 Jul '07

Hi, The msi test currently fails for me on Wine when run the second time after getting a clean environment: rm -rf ~/.wine make msi.ok msi: 101 tests executed (0 marked as todo, 0 failures), 0 skipped. rm msi.ok make msi.ok msi.c:366: Test failed: Expected INSTALLSTATE_UNKNOWN, got 1 msi: 101 tests executed (0 marked as todo, 1 failure), 0 skipped. Anyone? Cheers, Paul.

3 10

Re: [inkobj 2/2] Add stub test for inkobj.dll Try #2 with attachment
by Paul Vriens 30 Jul '07

30 Jul '07

John Klehm wrote: > Adds directory, makefile.in, and c file for simple test. This test tries > to do LoadLibrary("inkobj.dll"). > > I apologize for forgetting the attachment. > > Regards, > John > > > > ------------------------------------------------------------------------ > > Hi, Are you planning on having more tests? It seems a lot of overkill if you just want to see if the library can be loaded/unloaded. The loadlibrary also doesn't make much sense as inkobj is already imported (Makefile.in). If it can't be loaded the test will not even run. Are you also sure that this dll exists on every platform we run tests on (win98....Vista)? Cheers, Paul.

2 1

Linuxworld BOF?
by Dan Kegel 30 Jul '07

30 Jul '07

Anyone going to Linuxworld in San Francisco next week? It's free to go to the exhibits and BOFs if you register in advance; go here to register (and scroll to the bottom for the exhibit-only free choice): http://linuxworldexpo.com/live/12/TB296182 I'm probably going to hang out in the exhibit hall on Wed Aug 8th. Maybe we could organize a lunch BOF of Wine developers... - Dan

1 0

Re: [PATCH] winecfg: Add trackbar to set screen resolution in graphics tab (try 2)
by Alexandre Julliard 30 Jul '07

30 Jul '07

Nigel Liang <ncliang(a)gmail.com> writes: > +/* Utility functions to convert between WCHAR and long */ > +long wcstolong(WCHAR * wcs) > +{ > + int i; > + long lRet = 0; > + BOOL bNeg = FALSE; > + > + for (i = 0; wcs[i] != '\0'; i++) { > + if (i == 0 && wcs[i] == '-') { > + bNeg = TRUE; > + continue; > + } > + > + lRet = lRet * 10 + (wcs[i] - '0'); > + } > + return (bNeg ? -lRet : lRet); > +} > + > +WCHAR *longtow(long num, WCHAR *wcs) > +{ > + static const WCHAR str[] = { '%', 'l', 'd', 0 }; > + wsprintfW(wcs, str, num); > + return wcs; > +} That's ugly. You should avoid using long if not really necessary, since it doesn't have the same size in MSVC. You shouldn't name a function wcs something since that's what wchar_t functions use. In any case we already have atoiW for that purpose. Also I don't think wrapping wsprintf is needed. -- Alexandre Julliard julliard(a)winehq.org

2 1

msvcr80 support!
by Luke Bratch 30 Jul '07

30 Jul '07

--- Stefan Dösinger <stefan(a)codeweavers.com> wrote: > Windows Live messenger still refuses to start. Do I have to do anything > special(other than updating wine), or should I report a bug for this: > > /usr/src/wine/linux/wine msnmsgr.exe > fixme:actctx:parse_depend_manifests Could not find dependent assembly > L"Microsoft.Windows.Common-Controls" > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\msnmsgr.exe") not found > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\MSNCore.dll") not found > err:module:import_dll Library MSNCore.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\msnmsgr.exe") not found > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\ContactsUX.dll") not found > err:module:import_dll Library MSVCR80.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\MSNCore.dll") not found > err:module:import_dll Library MSNCore.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\ContactsUX.dll") not found > err:module:import_dll Library ContactsUX.dll (which is needed by L"C: > \\Programme\\MSN Messenger\\msnmsgr.exe") not found > err:module:LdrInitializeThunk Main exe initialization for L"C:\\Programme\\MSN > Messenger\\msnmsgr.exe" failed, status c0000135 > > I ran it from its installation directory, not from C:\windows\winsxs\...\. > When running it from msvcr80's directory it pops up a message box saying that > the app tried to load the C runtime incorrectly. This used to work before. > (Live messenger failed to connect later, for some other reasons) Did you find a fix for this? As per Alexandre's suggestion I tried installing native common controls, and also copying all the manifest files from a Windows machine (even the whole winsxs directory), but I still get the same error as you when I try to run my application. ___________________________________________________________ Yahoo! Mail is the world's favourite email. Don't settle for less, sign up for your free account today http://uk.rd.yahoo.com/evt=44106/*http://uk.docs.yahoo.com/mail/winter07.ht…

2 1

Re: [advapi32/tests] Use skip when we don't have enough rights
by Edwin Smulders 30 Jul '07

30 Jul '07

This is a little offtopic, but the extra testresults might be because the test link was posted in the comments of a well-known dutch computer site (in dutch) http://tweakers.net/meuktracker/15817/Wine-0.9.42.html I thought you might want to know, and I'll try to link the test more often there :) (it wasnt me who posted it this time though) On 7/30/07, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > We suddenly have loads of new winetest results. Catched this one for Vista. > > Changelog > Use skip when we don't have enough rights > > Cheers, > > Paul. > > > > >

1 0