July 2007 - Wine-devel - list.winehq.org

Re: [advapi32/service #2] Fix buffersize calculations for GetServiceDisplayNameA
by Alexandre Julliard 26 Jul '07

26 Jul '07

Paul Vriens <paul.vriens.wine(a)gmail.com> writes: > diff --git a/dlls/advapi32/service.c b/dlls/advapi32/service.c > index 1ecaf70..7e4ac8e 100644 > --- a/dlls/advapi32/service.c > +++ b/dlls/advapi32/service.c > @@ -2298,7 +2298,7 @@ BOOL WINAPI GetServiceDisplayNameA( SC_HANDLE hSCManager, LPCSTR lpServiceName, > if (ret == ERROR_MORE_DATA) > { > SetLastError(ERROR_INSUFFICIENT_BUFFER); > - *lpcchBuffer = size - 1; > + *lpcchBuffer = (size - 1) * sizeof(WCHAR); That's not correct, the A function is not supposed to return WCHARs. What probably happens on Windows is that it calls the W function and doubles the size as an upper bound on the buffer size. -- Alexandre Julliard julliard(a)winehq.org

2 7

Re: winex11.drv: WM_SYSCOMMAND/SC_CLOSE should be posted not sent
by Alexandre Julliard 26 Jul '07

26 Jul '07

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > this patch fixes crash on exit reported in the bug #2918. > > In DefWindowProc we already use PostMessage for WM_SYSCOMMAND/SC_CLOSE > in response to Alt+F4. > > Changelog: > winex11.drv: WM_SYSCOMMAND/SC_CLOSE should be posted not sent. This is what we used to do, but it was changed to a SendMessage in commit 43b5576998aea7accd9f4fb791043d89e9b83cad because some apps depend on that. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Ukrainian translation of MSI
by Vitaliy Margolen 26 Jul '07

26 Jul '07

Reznikov Artyom wrote: > Hello! I'm translating ReactOS into Ukrainian. I was told in in ROS bugzilla > (http://www.reactos.org/bugzilla/show_bug.cgi?id=2420) that my MSI translation > should be sent to wine. So I'm sending it in this letter. Am I doing this correctly > and in right place? You are in the right place but you doing it wrong - the patch have to be in the unified diff format. In this case you should do: diff -u /dev/null dlls/msi/msi_Uk.rc > patch.diff Oh and make sure it is in UNIX format not dos. (line brakes are \n not \n\r). Vitaliy

1 0

Re: Michael Stefaniuc : winefile: Replace malloc with HeapAlloc.
by Martin Fuchs 26 Jul '07

26 Jul '07

Hello, may I ask why you are replacing the simple malloc/free calls by the more complicated HeapAlloc API? This just makes the source longer and less readable. There is no point in avoiding C library usage in Winefile. It is just a unix application using Wine libraries - not a Wine system library. Regards, Martin On 24.07.2007 07:06:08 Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 11bb71d3d6a34d301291b2d15c849a1381bd7789 > URL: > http://source.winehq.org/git/wine.git/?a=commit;h=11bb71d3d6a34d301291b2d15… > 49a1381bd7789 > Author: Michael Stefaniuc <mstefani(a)redhat.de> > Date: Mon Jul 23 22:25:20 2007 +0200 > winefile: Replace malloc with HeapAlloc. > - Entry* entry = (Entry*) malloc(sizeof(Entry)); > + Entry* entry = HeapAlloc(GetProcessHeap(), 0, sizeof(Entry)); > - free(entry); > + HeapFree(GetProcessHeap(), 0, entry); > } -- Martin Fuchs fuchs.martin(a)gmail.com

2 1

Re: Italian translation for ui_En.rc (more)
by Detlef Riekenberg 25 Jul '07

25 Jul '07

On Mi, 2007-07-25 at 16:55 +0200, Paolo Devoti wrote: > Attached is dlls/localui/ui_It.rc Oh, and it would be nice, when you create a Patch from your changes and please include the missing change in "localui.rc" in the Patchfile. git is prefered, but cvs should also work. Thanks for improving wine. We can help, when needed. -- By by ... Detlef

1 0

Re: Italian translation for ui_En.rc
by Detlef Riekenberg 25 Jul '07

25 Jul '07

On Mi, 2007-07-25 at 16:55 +0200, Paolo Devoti wrote: > /* > * English resources for localui Did you forgot to replace English with Italian? > * > * Copyright 2007 Detlef Riekenberg Your can add your Name here > ADDPORT_DIALOG DIALOG LOADONCALL MOVEABLE DISCARDABLE 6, 18, 245, 47 > DEFPUSHBUTTON "OK", IDOK, 199, 10, 40, 14, WS_VISIBLE > PUSHBUTTON "Annulla", IDCANCEL, 199, 27, 40, 14, WS_VISIBLE > END > > > LPTCONFIG_DIALOG DIALOG LOADONCALL MOVEABLE DISCARDABLE 6, 18, 220, 47 > DEFPUSHBUTTON "OK", IDOK, 164, 10, 50, 14, WS_VISIBLE > PUSHBUTTON "Annulla", IDCANCEL, 164, 27, 50, 14, WS_VISIBLE The buttons have the same Text, but a different Layout. I suggest to adjust a Dialog. I did this already for the German resource, but not for English. Thanks -- By by ... Detlef

1 0

[Fwd: Getting good debugging stack traces from wine apport crash reports]
by Scott Ritchie 25 Jul '07

25 Jul '07

1 0

Should Wine move to LGPL 3?
by Damjan Novak 25 Jul '07

25 Jul '07

Hi! I just stumbled on this list and discussion, and though to just mention a highly speculative, but potentially very rewarding advantage of using LGPLv3 for wine. According to this opinion at groklaw: http://www.groklaw.net/article.php?story=20070709101318827 Microsoft MIGHT end up being effectively forced to distribute GPLv3 code under the deal with Novell, and hence loose any chance to sue about patents any so licenced projects included in SuSE, and I suppose wine is included in that distro. Given the nature of the wine project, Im thinking it could benefit greatly from such potential shelding from Microsofts patent portfolio, if things happen to unfold in this very optimistic scenario.. just a thought...

4 6

Re: Greek resource files for Comctrl, user32 and oleaut32
by Alexander Nicolaysen Sørnes 25 Jul '07

25 Jul '07

Onsdag 25 juli 2007 09:49, skrev Dj Apal [GR]: > Hello. I work on Greek localization for ReactOS and the guys there told me > that I should send you the greek resource files for the modules that they > share with you. SO here there are some first resource files. > If I send something wrong, please let me know. > > TIA You need to send one patch per dll, and only send in patch format. For a new file you can do diff -urp /dev/null {path_to_file} > {patch.diff} Where patch.diff already holds the change to add the Greek .rc file. Alexander N. Sørnes

1 0

Re: Getting CA certificates into the registry
by Juan Lang 25 Jul '07

25 Jul '07

> Isn't that what the distro's add-on value should be? Sorry, I don't understand. You think the distros should put CA certs into Wine's registry? --Juan

1 0