September 2007 - Wine-devel

[AppDB] Bug: Let objectManager delete bug links
by Alexander Nicolaysen Sørnes 17 Sep '07

17 Sep '07

Bug: Let objectManager delete bug links Regards, Alexander N. Sørnes

1 0

Re: user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs [resend]
by Alexandre Julliard 17 Sep '07

17 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > Is there something wrong with this patch? > From 50eacd2465df53e5cfc15458ff5ab80f0cc07e7e Mon Sep 17 00:00:00 2001 > From: Mikolaj Zalewski <mikolaj(a)zalewski.pl> > Date: Mon, 10 Sep 2007 14:03:49 -0700 > Subject: [PATCH] user32: better fix how to handle GetWindowLongPtr[AW](..., GWLP_WNDPROC) for builtin winprocs There are several other places where winprocs are returned, like SetWindowLong or GetClassLong. You probably have to handle them too, or at least write test cases for them. -- Alexandre Julliard julliard(a)winehq.org

1 0

An enumeration of network resources
by Konstantin Kondratyuk 17 Sep '07

17 Sep '07

Hello! I try to organize an enumeration of network resources by means of functions WNetOpenEnum and WNetEnumResource. Function WNetOpenEnumW contains a line: " ret = providerTable->table[index].openEnum( dwScope, dwType, dwUsage, lpNet, &handle); " which addresses to function in dll. The information about loaded dll is absent in the wine registry. Whether it means, what there are no preparations of DLL's for work with a network (similar ntlanman.dll in Windows)? -- Best regards, Konstantin Kondratyuk.

2 1

Re: msi(1/3): Don't crash if rec is NULL
by James Hawkins 17 Sep '07

17 Sep '07

On 9/14/07, Juan Lang <juan.lang(a)gmail.com> wrote: > This series of patches is in response to Jeremy's troubles with > iTunes. They may or may not fix the installer for him, but they > prevent potential crashes. > --Juan > MSI_FormatRecordW is an internal function and we should be crashing if rec is NULL. -- James Hawkins

3 5

old dos/windows program crashing
by Joris Huizer 17 Sep '07

17 Sep '07

Hello, I have a program, that I got like ages ago. It effectively is an atari emulator for dos, by the name "pacifist", but I originally got it installed under windows ME. It has an old atari-basic program "installed" in it, (a simple game) written by a friend in it, which I wanted to play. I decided to try to get it to run again under Linux. The website it came from originally doesn't seem to have the program available for download anymore - so I just copied the files from the windows ME disc. I obviously tried WINE then, but it didn't work, however, dosbox works with it (though slow, obviously) so I know I'm not missing required files (though, perhaps, registry settings - not sure how likely that is, though) Anyway. This isn't such a big deal, though I'd like to look at what's going on in WINE, and possibly fix it - though I need help here. This program is, among things, a "PMODE W/DOS Extender" - so that means it probably does some obscure real-mode/protected-mode stuff. Console output is as follows, Warning: unprotecting memory to allow real-mode calls. NULL pointer accesses will no longer be caught. err:int:__wine_emulate_instruction mov cr0,eax at 0x00000544 err:int:DOSVM_Int33Handler int33: unknown/not implemented parameters: int33: AX 0015, BX 0003, CX 11f7, DX 1165, SI 0055, DI 03ac, DS 11df, ES 11e7 fixme:int:DOSVM_Int10Handler Select vertical resolution - not supported fixme:int:DOSVM_Int10Handler Load ROM 8x8 Double Dot Patterns - Not Supported fixme:int31:DOSVM_Int31Handler physical address mapping (0x00000000) - unimplemented wine: Unhandled page fault on read access to 0xffffffff at address 0x101f:0x0003ed71 (thread 002d), starting debugger... fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000002 (mode 0) fixme:dbghelp:addr_to_linear Failed to linearize address 08f0:00000000 (mode 0) Also I attached the visual display the "winevdm" shows as the program crashes. (It seems it crashes somewhere in generated code in kernel32.dll - in DPMI_PendingEventCheck() - written by the winebuild tool) I know some things about real-mode code, but not too much. Could you give me pointers on what to look at next? BTW, please CC me, I'm not on the mailing list currently. Thanks, Joris ____________________________________________________________________________________ Check out the hottest 2008 models today at Yahoo! Autos. http://autos.yahoo.com/new_cars.html

3 4

AppDB: cannot submit a screenshot even when logged in
by Vit Hrachovy 16 Sep '07

16 Sep '07

Hello everybody, I may missed something, but I cannot submit a screenshot to the application I maintain in AppDB and I'm logged in. There's always a nasty 'Log in to submit screenshots' instead of Submit button. Is it planned downtime? Regards Vit P.S. It's http://appdb.winehq.org/screenshots.php?iAppId=4025

2 2

DirectDraw opengl renderer
by Alexander Nicolaysen Sørnes 16 Sep '07

16 Sep '07

Hello everyone, I know this has been discussed before (and not that long ago), but I think I have some wonderful new information to add to the debate of whether or not to add an option for this in winecfg. As I understand it, there is still a long time before the opengl renderer will become the default one. With Wine 0.9.45, some bugs were fixed allowing the opengl renderer to be used for C&C Tiberian Sun, and I must say the speed improvements are dramatic! Without any FPS tools I would definitely say performance has increased by several hundred per cent. Now the game is so fast I may have to turn down the game speed setting. :) If you move the mouse it still slows down, though, as it does with the gdi renderer. Anyway, I think this should apply to several other games as well (and I will test more). But I was wondering is this is enough to add an option in winecfg? Alexander N. Sørnes

3 3

Re: RICHED20: additional tests plus RFC
by Alexander Nicolaysen Sørnes 16 Sep '07

16 Sep '07

On Sunday 16. September 2007 04:34:17 a_villacis(a)palosanto.com wrote: > I am tracking down a richedit bug in FACETS (bug #1713). > > Apparently, the OCX control used by this app expects a particular > SendMessage() > with the message EM_SETCHARFORMAT to return 1. Currently builtin returns 0 > unconditionally, making this app bail out with "Invalid property value". By > changing the return value to 1 unconditionally, the app gets "fixed", but > this > is not a proper solution, since other apps might break with this change. > > This patch adds additional testing of EM_SETCHARFORMAT. All todo_wine's > succeed > in an installation of WinXP SP2. Please confirm this is so for all of you. > > There are two code blocks commented out. The first one makes the app crash > on WinXP, and is listed for completeness. The other one was supposed to > test what > happens when the riched20 control receives a blanked-out CHARFORMAT2 > structure. > However this triggers an assertion in Wine at style.c line 63. WinXP > doesn't bat an eye, and possibly ignores these structure values. Unless > somebody objects, I will shortly send a patch that replaces the assertion > with a NULL return in style.c, plus a NULL check in editor.c . > > There are more riched20 tests that fail in WinXP SP2, unrelated to > EM_SETCHARFORMAT, but I would like confirmation that (1) somebody else sees > failing tests in native Windows, not just me, and (2) this patch does not > introduce any new failing tests in native Windows. > > Changelog: > * Add additional tests for EM_SETCHARFORMAT message of riched20 control Hey, great to see some work on EM_SETCHARFORMAT. If you're interested, Wine has a builtin WordPad (just type 'wine wordpad') which exposes some problems. Try to select a font in the font list when no text is selected, for instance. Alexander N. Sørnes

1 0

Re: [PATCH 2/7] gdi: Implement BiDi classification of characters
by Steven Edwards 16 Sep '07

16 Sep '07

Hi Maarten, Could you configure your git scripts to output different filenames when generating patches? Somehow they get managed for me in my gmail inbox. It makes it quite a pain for me to review. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

6 10

Re: patches to make wine compile on osx
by Roderick Colenbrander 16 Sep '07

16 Sep '07

Hi Daniel, A few comments regarding the patches. First of all you should use a single patch file for each patch (this makes tracking patches easier). Now over to the patches. Regarding wineosxtypeerrors.patch: - 'GLenum' should be 'unsigned int' instead of int. I don't understand why the casts are needed as it should just get the type info from gl.h. I think that using '%u' for unsigned data could fix most of your problems. Regarding wineosxglexterrors.patch: - Same comment regarding unsigned int data. (make this a separate patch) - GL_TEXTURE_RECTANGLE_NV should be handled in include/wine/wgl.h, strange that I didn't receive compile failures for linux about it .. perhaps it is already in the mesa headers. (make this a separate patch) Anyway I would define GL_TEXTURE_RECTANGLE_NV like this: #ifndef GL_NV_texture_rectangle #define GL_TEXTURE_RECTANGLE_NV 0x84F5 #define GL_TEXTURE_BINDING_RECTANGLE_NV 0x84F6 #define GL_PROXY_TEXTURE_RECTANGLE_NV 0x84F7 #define GL_MAX_RECTANGLE_TEXTURE_SIZE_NV 0x84F8 #endif The extension is fully compatible with GL_ARB_texture_rectangle which osx should have and GL_EXT_texture_rectangle is likely the same. (the constants between the ARB and NV one are also the same, I expect the same for EXT and ARB) Regards, Roderick Colenbrander

1 0