September 2007 - Wine-devel

Re: gdi32[2/4]: implement AddFontMemResourceEx (based on a patch of Byeong-Sik Jeon, helps with bug #5865) (resend)
by Alexandre Julliard 13 Sep '07

13 Sep '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > diff --git a/dlls/gdi32/font.c b/dlls/gdi32/font.c > index c516736..efc044b 100644 > --- a/dlls/gdi32/font.c > +++ b/dlls/gdi32/font.c > @@ -3214,8 +3214,18 @@ BOOL WINAPI RemoveFontResourceW( LPCWSTR > */ > HANDLE WINAPI AddFontMemResourceEx( PVOID pbFont, DWORD cbFont, PVOID pdv, DWORD *pcFonts) > { > - FIXME("(%p,%08x,%p,%p): stub\n", pbFont, cbFont, pdv, pcFonts); > - return NULL; > + PVOID pFontCopy = HeapAlloc(GetProcessHeap(), 0, cbFont); > + HANDLE ret; > + > + TRACE("Copying %d bytes of data from %p to %p\n", cbFont, pbFont, pFontCopy); > + memcpy(pFontCopy, pbFont, cbFont); > + ret = WineEngAddFontMemResourceEx(pFontCopy, cbFont, pdv, pcFonts); > + if (ret == NULL) > + { > + TRACE("Font create failed - freeing %p\n", pFontCopy); > + HeapFree(GetProcessHeap(), 0, pFontCopy); > + } > + return ret; > } The memory copy should be done in WineEngAddFontMemResourceEx since that's where the data is managed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [5/5] WineD3D: Pixel shader 1.x constants are clamped to [-1;1]
by Alexandre Julliard 13 Sep '07

13 Sep '07

Stefan Dösinger <stefandoesinger(a)gmx.at> writes: > It is hard to judge if this patch will fix anything. A problem is that > clamping the constants on loading makes constants loading more expensive. > Luckilly though there aren't many ps 1.x constants(8 max). It is hard to say > if there are any games that use constants > 1.0, but incorrect constant > loading can have many bad effects. This one fails make test for me: ../../../tools/runtest -q -P wine -M d3d9.dll -T ../../.. -p d3d9_test.exe.so visual.c && touch visual.ok visual.c:3068: Test failed: quad 1 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3070: Test failed: quad 2 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3073: Test failed: quad 3 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3077: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 visual.c:3207: Test failed: quad 1 has color 007f7f00, expected 0x00808000 visual.c:3209: Test failed: quad 2 has color 007f7f00, expected 0x00808000 visual.c:3211: Test failed: quad 3 has color 007f7f00, expected 0x00808000 visual.c:3214: Test failed: quad 4 has color 00bfbf7f, expected 0x00bfbf80 make[2]: *** [visual.ok] Error 8 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WGL: Fix a major ATI regression
by Joerg Mayer 13 Sep '07

13 Sep '07

On Thu, Sep 13, 2007 at 01:09:14AM +0200, Roderick Colenbrander wrote: > The change isn't a hack but more a workaround. I have submitted the bugreport to ATI but they likely won't fix it anytime soon. Well, if I understood the ATI development cycle correctly, even if they fixed it right away it will take another two releases (months) until it is released. ciao Joerg -- Joerg Mayer <jmayer(a)loplof.de> We are stuck with technology when what we really want is just stuff that works. Some say that should read Microsoft instead of technology.

1 0

Cvs update error.
by Anatoly Lyutin 13 Sep '07

13 Sep '07

Hi all!! Today I tried to make cvs update and cvs extradites a error: [vostok(a)windsor wine]$ cvs update cvs [update aborted]: unrecognized auth response from cvs.winehq.org: cvs pserver: /home/wine/CVSROOT/config [8]: warning: this CVS does not support PreservePermissions What happens? -- Best regards Anatoly Lyutin.

1 0

WineHQ Downtime
by Jeremy Newman 12 Sep '07

12 Sep '07

This is a reminder. WineHQ will be going offline for upgrades today at 14:00 CDT (19:00 GMT). I expect downtime to be no longer than one hour. Some services will appear to have sporadic outages even after the upgrade is complete. This will be due to changes in configs and upgraded versions of server software. I will post back to wine-devel when the upgrade is complete.

3 3

Re: WGL: Fix a major ATI regression
by Chris Robinson 12 Sep '07

12 Sep '07

On Wednesday 12 September 2007 04:09:14 pm Roderick Colenbrander wrote: > + visinfo = pglXGetVisualFromFBConfig(display, cfgs[i]); > + /* We have found an offscreen rendering format when there is no > visualinfo :) */ > + if(visinfo->visualid == visualid) { > pglXGetFBConfigAttrib(display, cfgs[i], GLX_FBCONFIG_ID, > &fmt_id); > fbconfig = cfgs[i]; > } You're using visinfo before making sure it's valid. And I think that comment is a little misleading talking about offscreen formats when checking for the default visual. > + if(!visinfo) { > nOffscreenFormats++; > } > + XFree(visinfo); I don't think we can rely on being able to safely XFree a NULL pointer. None of the other code in opengl.c relies in that behavior.

1 0

Re: [3/5] WineD3D: Fix the reflection calculation in texm3x3(v)spec
by H. Verbeet 12 Sep '07

12 Sep '07

On 12/09/2007, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > ...so what the patch *actually* does in a completely obfuscated way, is getting rid of the assumption that the normal is normalized. IOW, - shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, tmp0.xyz);\n"); + shader_addline(buffer, "tmp0.xyz = reflect(-tmp1.xyz, normalize(tmp0.xyz));\n"); would be just as effective. That also means that the change in the ARB implementation - /* Calculate reflection vector (Assume normal is normalized): RF = 2*(N.E)*N -E */ + /* Calculate reflection vector (Assume normal is normalized): + * See comment in the glsl implementation. is misleading at best.

1 0

Re: problem with silly CreateBitmap call
by Francois Gouget 12 Sep '07

12 Sep '07

On Thu, 6 Sep 2007, Deun wrote: [...] > The size of the bitmap seems crazy... So I've made a patch to > fix this in bitmap.c by setting 1x1 size in case of stupid > input instead of failing with BadAlloc. However, since it works > fine on real windows, so I'm not sure about the behaviour that > the function should have. Seems like a good candidate for a conformance test. Call the API with the crazy values and see what comes out... -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

4 3

iTunes 7
by Juan Lang 12 Sep '07

12 Sep '07

Folks, I just sent a series of wintrust patches that gets iTunes 7 to start, at least for me. I expect some will get rejected due to collision with Francois's patch - I'll resynch and resend. But if you want to play around with iTunes, grab those patches and give them a whirl. Known issues: 1. Your screen will go black when it starts. This is something QuickTime is doing. You can drag windows around to force some repainting to work around it. 2. You'll see lots of fixmes on the console, especially: "fixme:setupapi:CMP_WaitNoPendingInstallEvents 0", "fixme:setupapi:SetupDiGetClassDevsW returning empty list", and "fixme:htmlhelp:HtmlHelpW HH case HH_PRETRANSLATEMESSAGE not handled." 3. The main window will be transparent (and basically unusable) if you don't have GL support compiled in. Have fun, --Juan

4 5

Re: [PATCH] user32: edit control should respond to ctrl + z (try 3)
by Dmitry Timoshkov 12 Sep '07

12 Sep '07

"Lei Zhang" <thestig(a)google.com> wrote: > This patch lets users hit ctrl + Z in edit controls to trigger an > undo. The test case has been improved to check for both the return > values and the content of the edit control. In the tests still there is no actual edit contents/selection changes tracking after every message. -- Dmitry.

2 6