January 2008 - Wine-devel - list.winehq.org

Re: ntdll: Do not perform base relocation if an image is not a DLL
by Alexandre Julliard 16 Jan '08

16 Jan '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Hello, > > this patch fixes the problem reported in the bug 11170. It appears that > LoadLibrary in Windows doesn't attempt to relocate .exe files. > > Changelog: > ntdll: Do not perform base relocation if an image is not a DLL. This will break the relocation of the main exe. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: GDI32.dll.NamedEscape
by Robert Shearman 16 Jan '08

16 Jan '08

Luis C. Busquets Pérez wrote: > I am having problems with a bunch of three games that came together in > the same pack. They all abort qhen asking for installation with the > following line > > wine: Call from 0x73ba1895 to unimplemented function > GDI32.dll.NamedEscape, aborting > > Does anybody know what GDI32.dll.NamedEscape does? > It appears to be undocumented. Are you using some native DLLs by any chance? -- Rob Shearman

4 3

Re: advpack: Skip some tests if not in interactive mode because they pop up dialogs.
by Saulius Krasuckas 15 Jan '08

15 Jan '08

* On Tue, 13 Nov 2007, Francois Gouget wrote: > > This was causing the advpack:install test to time out on my Win98, WinXP > and Win2003 VMs. Would it be nice to create some closer-thread for closing poped up dialogs in places of code known for that behaviour? (Probably, for non interactive mode only)

2 1

SVN usage for Wine
by James McKenzie 15 Jan '08

15 Jan '08

Because git is unstable on the Mac platform, I've been utilizing a little time investigating the use of either SVN or CVS to download .git updates. This appears to not be working per the Wiki pages for SVN. Is CVS or SVN still being supported for Wine or is git the only supported download (I don't expect to do any patching for now) method for .git updates? Thank you. James McKenzie

5 4

re: Tools: Spelling fixes
by Dan Kegel 15 Jan '08

15 Jan '08

Austin wrote: > only used for optimization, so just check for a very small set of >- criteria that guarantee the types are equivalent; assume every thing >+ criteria that guarantees the types are equivalent; assume everything The original was correct, please don't change that. Firstly, it's not a spelling problem; secondly, in England, it's correct to consider a set of something plural. The rest of the changes in this patch seem ok. - Dan

1 0

d3dx9: Start implementation of d3dx9_36
by tony.wasserka＠freenet.de 15 Jan '08

15 Jan '08

What's wrong with it this time? Thought that it was okay this time :D

1 0

Good source for msvcr71?
by Dan Kegel 15 Jan '08

15 Jan '08

I finally ran into an app that wanted msvcr71 but didn't bundle it (supercopyright). After a few minutes of looking, I couldn't find it anywhere on microsoft.com. The best source I could find was the installer for spambayes 1.1, but that's inconvenient. Anyone know a better source, preferably at microsoft.com? I'd like to add it to winetricks. Thanks, Dan

3 4

Re: [advapi32] QueryServiceConfig2 (2nd try)
by Alexandre Julliard 15 Jan '08

15 Jan '08

Stefan Leichter <Stefan.Leichter(a)camline.com> writes: > + * Note > + * observed unter win2k: > + * 1. when the function is called to get the required buffer size, the value of > + * the returned parameter needed is big enough to hold the strings as WCHARs(!) It's not WCHARs, it's two A chars per W char to leave enough room for the conversion. I don't see you doing that in the code. > + case SERVICE_CONFIG_DESCRIPTION: > + { LPSERVICE_DESCRIPTIONA configA = (LPSERVICE_DESCRIPTIONA) buffer; > + LPSERVICE_DESCRIPTIONW configW = (LPSERVICE_DESCRIPTIONW) bufferW; > + *needed = sizeof(SERVICE_DESCRIPTIONA); > + if (configW->lpDescription) { > + DWORD sz; > + configA->lpDescription = (LPSTR)(configA + 1); > + sz = WideCharToMultiByte( CP_ACP, 0, configW->lpDescription, -1, > + configA->lpDescription, size - sizeof(SERVICE_DESCRIPTIONA), NULL, NULL ); > + if (!sz) { > + FIXME("WideCharToMultiByte failed for configW->lpDescription\n"); > + ret = FALSE; > + configA->lpDescription = NULL; > + goto cleanup; You need to update the needed size on buffer overflow. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [take 2] shell32: Check if token references the current user
by Alexandre Julliard 15 Jan '08

15 Jan '08

ge(a)gse.nl writes: > Incorporates feedback by Juan Lang > > Changelog: > Ge van Geldorp <ge(a)thinstall.com> Please either put your full name in the mail headers, or include the full git headers in the body of your message, so that my commit script can grab your name and email automatically. > @@ -1382,14 +1476,15 @@ static HRESULT _SHGetUserProfilePath(HANDLE hToken, DWORD dwFlags, BYTE folder, > return E_INVALIDARG; > > /* Only the current user and the default user are supported right now > - * I'm afraid. > + * I'm afraid. We do handle the case where the token references the > + * current user. > * FIXME: should be able to call GetTokenInformation on the token, > * then call ConvertSidToStringSidW on it to get the user prefix. > * But Wine's registry doesn't store user info by sid, it stores it > * by user name (and I don't know how to convert from a token to a > * user name). This comment is obsolete, we store the registry by sid now, so this is what you should use to open the user's key. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Do not allow to create too large device dependent bitmaps like Windows does
by Robert Shearman 15 Jan '08

15 Jan '08

Dmitry Timoshkov wrote: > + SetLastError(0xdeadbeef); > + hbmp = CreateBitmap(0x7ffffff, 9, 1, 1, NULL); > + ok(!hbmp, "CreateBitmap should fail\n"); > + ok(GetLastError() == ERROR_NOT_ENOUGH_MEMORY, > + "expected ERROR_INVALID_PARAMETER, got %u\n", GetLastError()); > The string here doesn't match the test. -- Rob Shearman

1 0