January 2008 - Wine-devel - list.winehq.org

Re: user32, wined3d: move refresh rate fallback to catch all cases (resend)
by Dmitry Timoshkov 15 Jan '08

15 Jan '08

"Erik Inge Bolsø" <knan-wine(a)anduin.net> wrote: > If requesting a refresh rate that isn't available, but a better one is, > ChangeDisplaySettings fails and some games fail to launch. This does > not seem to match WinXP behaviour with the same graphics card + lcd > monitor combination. If that's not what Windows does then this patch can't be accepted. In any case a test case showing Windows behaviour is required. -- Dmitry.

2 4

Re: [PATCH] check for array index overflows
by H. Verbeet 15 Jan '08

15 Jan '08

On 14/01/2008, Marcus Meissner <marcus(a)jet.franken.de> wrote: > Hi, > > This checks for overflowing the fixed size arrays. > > spotted by Coverity. > > (Submitted some months ago already, but left in my queue.) > > Ciao, Marcus > --- IIRC last time we tested this it was allowed on Windows, and simply causes memory corruption. If we want to prevent this, we should probably just return WINED3D_OK.

2 1

Re: [hlink] Skip tests if hlink couldn't be created
by Robert Shearman 14 Jan '08

14 Jan '08

Dan Kegel wrote: > This makes the test slightly more robust to operator error. > If we're striving to get zero test failures then converting a crash to some failures isn't really much of an improvement. -- Rob Shearman

2 1

Re: [PATCH] check for This->frame
by Jacek Caban 14 Jan '08

14 Jan '08

Hi Marcus, Marcus Meissner wrote: > Hi, > > Coverity 645 spotted missing This->frame > checks. > > Ciao, Marcus > --- > dlls/mshtml/olecmd.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/dlls/mshtml/olecmd.c b/dlls/mshtml/olecmd.c > index 326b0b0..02b5e83 100644 > --- a/dlls/mshtml/olecmd.c > +++ b/dlls/mshtml/olecmd.c > @@ -621,7 +621,7 @@ static HRESULT exec_editmode(HTMLDocument *This, DWORD cmdexecopt, VARIANT *in, > if(This->hostui) > IDocHostUIHandler_HideUI(This->hostui); > > - if(This->hostui) > + if(This->hostui && This->frame) > IDocHostUIHandler_ShowUI(This->hostui, DOCHOSTUITYPE_AUTHOR, ACTOBJ(This), CMDTARGET(This), > This->frame, This->ip_window); > There is no reason to test This->frame here (unless you have tested that native MSHTML doesn't call ShowUI with NULL frame). Coverity spotted an other bug, which you've fixed in other part of the patch. Thanks, Jacek

1 0

Improving Default Serial Port Configuration
by Forrest Samuels 14 Jan '08

14 Jan '08

I am looking to fix a bug causing serial ports to not show up in some applications. The problem is due to missing registry entries for the serial ports. I know what entries need to be created but I don't think they should go in wine.inf. They should get created dynamically, preferably on each run, based on what currently exists in .wine/dosdevices/ The bug I am working on is 9902 (http://bugs.winehq.org/show_bug.cgi?id=9902) Does anyone have any insight on where I should start looking to implement this? Implementation suggestions? In the bug, Juan Lang made the suggestion that "Explorer's hal.c should be extended to create new devices for all the ports it finds, using SetupDiCreateDeviceInfo followed by SetupDiRegisterDeviceInfo. For some devices it should also call SetupDiCreateDeviceInterface to register a particular interface." I've looked in programs/explorer/hal.c and I am not sure where to begin hooking something like that in. It was also suggested in #winehackers that this could go in the same place that other hardware like disk drives are detected and configured. I am not sure where that would be either or if that is the same as hal.c. I am new to wine development to please feel free to over explain. Thanks, -- Forrest Samuels (forrest(a)alumni.ncsu.edu)

3 4

WineD3D Spelling Fixes
by Austin English 14 Jan '08

14 Jan '08

Any reason this patch wasn't applied? I didn't see any feedback on wine-patches. http://www.winehq.org/pipermail/wine-patches/2008-January/048933.html -Austin

1 0

Re: Fix texture coordinate calculation in surface_blt_to_drawable
by Roderick Colenbrander 14 Jan '08

14 Jan '08

I just wanted to confirm that this patch is correct. Stefan and I talked about it and it should be right. Before the surface rewrite there were two codepaths like this and one of them used integers and the other texture one used floats. During the rewrite they were merged and the combined one used integers. That's what caused the regression. The use of floats makes much more sense. Roderick > This fixes a bug with the use of opengl to render direct draw in older > graphic cards. > > The problem is in dlls/wined3d/surface.c in surface_blt_to_drawable. > > 3547 coords[0].x = rect.left / This->pow2Width; > > 3550 coords[1].x = rect.left / This->pow2Width; > > 3553 coords[2].x = rect.right / This->pow2Width; > > 3556 coords[3].x = rect.right / This->pow2Width; > > 3559 coords[0].y = rect.top / This->pow2Height; > 3560 coords[1].y = rect.bottom / This->pow2Height; > 3561 coords[2].y = rect.bottom / This->pow2Height; > 3562 coords[3].y = rect.top / This->pow2Height; > > > All calculation are done with integers so when rect.right < pow2Wdith and > rect.bottom < pow2Height > all texture coordinates are set to 0 thus only the upper left pixel of the > image is displayed > scaled up to cover the entire window. -- GMX FreeMail: 1 GB Postfach, 5 E-Mail-Adressen, 10 Free SMS. Alle Infos und kostenlose Anmeldung: http://www.gmx.net/de/go/freemail

1 0

Overriding comctl32
by Dan Kegel 14 Jan '08

14 Jan '08

For future reference: It turns out that installing a native comctl32 and setting overrides for comctl32, as sh winetricks cc580 does, is no longer enough to override comctl32. You also have to remove Wine's sxs manifest for comctl32, too, e.g. rm -rf ~/.wine/drive_c/windows/winsxs/manifests/x86_microsoft.windows.common-controls_6595b64144ccf1df_6.0.2600.2982_none_deadbeef.manifest else wine continues loading the builtin one. - Dan

1 0

Re: [PATCH] [DbgHelp]: A couple of enhancements for writing minidumps
by Alexandre Julliard 14 Jan '08

14 Jan '08

Eric Pouech <eric.pouech(a)orange.fr> writes: > - returning (instead of passing a pointer to) the size of the blocks pointed by the directories > - now storing the PE version information in module blocks > - fixed an un-initialized field in minidump header > - fixed the suspend count value in thread block Please send separate fixes as separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

How to fix bug #11114?
by Markus 14 Jan '08

14 Jan '08

Hi, regarding bug #11114, can anyone knowledgable in the area tell me how difficult it would be to resolve the issue? As far as I can see, the game World in Conflict is using dxdiag.dll to determine whether a system is capable of running the game. Is there an implementation for this dll at all in Wine? The native library appears to not fool the game sufficiently enough to start without an error. Using plain Wine (no native dxdiag dll) leads to the error in line 44725 of the logfile in the report. Thanks. -- Markus

1 0