January 2008 - Wine-devel - list.winehq.org

Wine Test Shell - timeouts during test runs too short?
by Reece Dunn 27 Jan '08

27 Jan '08

Hi, When running the Wine Test Shell to run the tests as part of http://test.winehq.org/, there are several timeouts in different places. These may be valid timeouts, but on my Vista test machine ddraw:d3d and msi:install generate the timeout message box part way through the test run, even though they continue and complete. Those tests are just slow. The others (such as kernel32:debugger) may be the same - especially when you get mixed results from different runs. Because of this, the timeout length should be increased (I would say at least doubled, to allow the long-running tests to run through). Another thing... I find it breaks the idea of an automated test run to have to watch it to OK the timeout messages. I know that UAC and the shfileop tests bring up interactive dialogs, but these are from within Windows itself, and will be dealt with by the timeout/test killer part of the Wine Test Shell. This would help make it easier for people to run the tests more often. - Reece

2 3

Re: d3dx8: Implement D3DXCreateTextureFromFile
by Chris Robinson 27 Jan '08

27 Jan '08

On Sunday 27 January 2008 12:39:18 am Luis C. Busquets Pérez wrote: > +{ > + FIXME("(void): stub\n"); > + return D3D_OK; > +} You probably shouldn't return okay if you're not implementing the function. It's normal to return D3DERR_NOTIMPLEMENTED (or whatever it is). At the very least you don't want to leave the output parameters untouched.

1 0

MinGW cross compiler rpms available
by Hans Leidekker 26 Jan '08

26 Jan '08

Updated cross compiler rpms are available here: http://mirzam.it.vu.nl/mingw/ I can build the full test suite from Wine 0.9.54 with these. -Hans

1 0

Re: d3dx8, d3dx9_xx and d3dx10_xx
by tony.wasserka＠freenet.de 26 Jan '08

26 Jan '08

> Find attached some data on d3dx8, d3dx9_xx and d3dx10_xx implementations: > dll files by d3dx extension: > d3dx8 1 dll files > d3dx9_xx 13 dll files > d3dx10_xx 4 dll files > [...] > Nice work, how did you get the data? Did you run Dependency Walker on each dll or is there a more practical way? I'm creating stub dlls at the moment and need to get the parameters for each function on MSDN which is very time consuming and am looking for a faster way. However, to add a little more data, my list of the differences between the d3dx9 dlls: from d3dx9_24 to d3dx9_25: + D3DXUVAtlasCreate + D3DXUVAtlasPack + D3DXUVAtlasPartition from d3dx9_25 to d3dx9_26: + D3DXComputeIMTFromPerTexelSignal + D3DXComputeIMTFromPerVertexSignal + D3DXComputeIMTFromSignal + D3DXComputeIMTFromTexture from d3dx9_26 to d3dx9_27: (no changes) from d3dx9_27 to d3dx9_28: + D3DXPreprocessShader + D3DXPreprocessShaderFromFileA + D3DXPreprocessShaderFromFileW + D3DXPreprocessShaderFromResourceA + D3DXPreprocessShaderFromResourceW from d3dx9_28 to d3dx9_30: (no changes) from d3dx9_30 to d3dx9_31: - D3DXCpuOptimizations - D3DXGetTargetDescByName - D3DXGetTargetDescByVersion from d3dx9_31 to d3dx9_32: + D3DXSHMultiply2 + D3DXSHMultiply3 + D3DXSHMultiply4 + D3DXSHMultiply5 + D3DXSHMultiply6 from d3dx9_32 to d3dx9_35: (no changes) from d3dx9_35 to d3dx9_36: + D3DXCreateFragmentLinkerEx + D3DXGetShaderConstantTableEx They of course match to your reported number of function, great job. PS: My d3dx9_24 patch is on its way, just need to prove that everything is correct

1 0

gdiplus: bezier test question
by Reece Dunn 26 Jan '08

26 Jan '08

The patch that I have just submitted ("gdiplus: fix the bezier arc path test (on all platforms).") is a simple fix for the failing test in graphicspath.c. The failure highlights gdiplus behaviour that is not directly obvious: If you have a bezier arc: static path_test_t arc_path[] = { {600.0, 450.0, PathPointTypeStart, 0, 0}, /*0*/ {600.0, 643.3, PathPointTypeBezier, 0, 0}, /*1*/ {488.1, 800.0, PathPointTypeBezier, 0, 0}, /*2*/ }; the gdiplus code will make the last entry PathPointTypeBezier | PathPointTypeCloseSubpath. For the nature of the existing test, I believe the fix is correct (it is testing the basic arc path functionality). However, there should be another test to document the above behaviour. - Reece

2 2

Re: [PATCH] D3DXGetFVFVertexSize implementation
by Stefan Dösinger 25 Jan '08

25 Jan '08

Am Freitag, 25. Januar 2008 19:41:52 schrieb Victor: > This is a DX8 implementation of D3DXGetFVFVertexSize (i.e. D3DFVF_XYZW is > commented out).I must note that I've encountered a bug in original/natvie > D3DXGetFVFVertexSize - it returned wrong vertex size(one float less than > needed(?)) when it was used with D3DFVF_XYZB4.It was more than a year ago, > and I'm not sure if this bug still exists in native D3DX. > Anyway this bug isn't reproduced here. A few comments: Regarding the possible bug in d3dx8 I recommend to add a test for this, like you're testing other flags already in dlls/d3dx8/tests/math.c . This will shed more light on the issue. If you do not have a Windows box to test on I can run the test for you. If the bug still exists Wine should clone it as well. (I don't think this function belongs to math.c by the way, probably create a new file called vertex.c or fvf.c or something like that) Your code contains some C++ comments ("//"), please do not use them as Wine is plain C code. I think you can just remove the D3DFVF_XYZW block if this enumeration doesn't exist in d3d8. Also please watch out with the whitespaces: The code is mixing tabs and spaces. Preferably stick to the style that is used in the rest of the file.

1 0

system tray icon regression
by Lei Zhang 25 Jan '08

25 Jan '08

Hi, With today's wine-git, tray icons no longer work. There's a spot in the system tray where the icon should be, but nothing is displayed there and I can't interact with it. This occurred on both KDE and Gnome. I found this with Picasa, but you can also see the problem with this sample program: http://bugs.winehq.org/attachment.cgi?id=9725 - Lei

1 1

Re: dlls/d3d9/tests/visual.c -- address five compiler warnings (RESEND)
by Alexandre Julliard 25 Jan '08

25 Jan '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > @@ -4348,12 +4349,12 @@ static void vshader_version_varying_test > "vs_3_0 returned color 0x%08x, expected 0x00203366\n", color); > color = getPixelColor(device, 160, 360); > ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 && > - (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 && > + (color & 0x0000ff00) <= 0x00000000 && > (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00210068, > "vs_1_1 returned color 0x%08x, expected 0x00808080\n", color); > color = getPixelColor(device, 480, 360); > ok((color & 0x00ff0000) >= 0x003c0000 && (color & 0x00ff0000) <= 0x004e0000 && > - (color & 0x0000ff00) >= 0x00000000 && (color & 0x0000ff00) <= 0x00000000 && > + (color & 0x0000ff00) <= 0x00000000 && > (color & 0x000000ff) >= 0x00000066 && (color & 0x000000ff) <= 0x00210068, > "vs_2_0 returned color 0x%08x, expected 0x00000000\n", color); These tests don't make much sense, with or without your fix, plus the error messages don't match the tests. This needs more work. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: winex11.drv: Remove an incorrect FIXME
by Alexandre Julliard 25 Jan '08

25 Jan '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > diff --git a/dlls/winex11.drv/x11drv_main.c b/dlls/winex11.drv/x11drv_main.c > index f2bf12c..948c58c 100644 > --- a/dlls/winex11.drv/x11drv_main.c > +++ b/dlls/winex11.drv/x11drv_main.c > @@ -498,10 +498,7 @@ static BOOL process_attach(void) > break; > > case 15: > - /* Out tests suggest that windows does not support 15 bpp color depth. > - * X11 does, what should we do with these situations? > - */ > - FIXME("The X server is running at 15 bpp color depth\n"); > + /* It's the same thing as 16 bpp but with different bit fields */ > screen_bpp = 15; Shouldn't screen_bpp be set to 16 then? -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: msxml3: Implement IXMLDOMDocument IDispatch interface
by Alistair Leslie-Hughes 25 Jan '08

25 Jan '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:fnchqv$a5r$1(a)ger.gmane.org... > Hi, > > Fixes bug http://bugs.winehq.org/show_bug.cgi?id=11257 > Correction Fixes http://bugs.winehq.org/show_bug.cgi?id=8152 Best Regards Alistair Leslie-Hughes

1 0