January 2008 - Wine-devel - list.winehq.org

Re: comctl32: Vista sends an unidentified message when destroyingdatetime and monthcal windows.
by Dmitry Timoshkov 25 Jan '08

25 Jan '08

"Reece Dunn" <msclrhd(a)googlemail.com> wrote: > When destroying datetime and monthcal controls, Vista sends a message > with the value 0x0090. This messasge is not in winuser.h of the Vista > SDK. > +#define WM_UNKNOWN_VISTA1 0x0090 IMO just adding { 0x0090, sent|optional }, /* Vista */ is clear enough, WM_UNKNOWN_VISTA1 clutters the code. -- Dmitry.

2 1

re: system tray icon regression
by Dan Kegel 25 Jan '08

25 Jan '08

Lei wrote: > With today's wine-git, tray icons no longer work ... > http://bugs.winehq.org/attachment.cgi?id=9725 What bug number is that associated with, btw?

2 1

Re: user32: make the edit tests pass on Vista.
by Reece Dunn 24 Jan '08

24 Jan '08

On 24/01/2008, Reece Dunn <msclrhd(a)googlemail.com> wrote: > This adds a return code value returned by Vista in one of the test > cases to fix the uxtheme tests. > > - Reece Ignore this (sent the wrong patch). - Reece

1 0

re: Assorted spelling fixes
by Dan Kegel 24 Jan '08

24 Jan '08

Austin wrote: >- /* centred vertically and in the right side of the password edit control */ >+ /* centered vertically and in the right side of the password edit control */ I never thought about it before, but "centred" is perfectly fine English, at least in England. Guess I need to add that to stop.txt.

4 4

Re: [PATCH] fixed potential double free
by Alexandre Julliard 24 Jan '08

24 Jan '08

Marcus Meissner <marcus(a)jet.franken.de> writes: > Coverity spotted that set_window_pos() could call > free_region() on the same pointer twice. > > (CID 671 and 672) > > Check that they are different before freeing them twice. This can't happen, Coverity is confused. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [dbghelp 4/10] Rewrite much of the symbol lookup method to work with Optimized PDB files as well
by Jason Green 24 Jan '08

24 Jan '08

On Jan 22, 2008 4:00 PM, Eric Pouech <eric.pouech(a)orange.fr> wrote: > Jason Green a écrit : > > Re-responses from Eric van Beurden: > > > > > >> hmm I still don't get how, in a generic way symbols could overlap > >> the only think I could come up with if when static functions get > >> automatically inlined by the compiler, but that's rather a different > >> story (as I'd suspect the inlined function to be a single memory range > >> within a container => and in that case returning the shortest matching > >> symbol should be fine is there an existing exe/pdb file available for > >> further testings > >> > > > > > > in testing with one of our projects, i was seeing symbols lookups fail > > 85-90% of the time with the initial versions of dbghelp. The PDB > > files that were being used were generated along with the release build > > of the project (it was a C++ project as well). On further > > investigation i found that the lookups were failing because many > > symbol addresses and ranges were overlapping. This seemed to occur on > > even unrelated objects and symbols. I would suspect it was the result > > of the optimizations the compiler performed. > > > > I was able to generate PDBs that exhibited this behaviour with every > > test app i built under Visual Studio (v7.1 and 8.0Express); even apps > > that were only 25 lines long. Since it was very repeatable and the > > project in question would always be using PDBs generated from > > optimized release builds i decided to change the symbol lookup method > > to take the range into account and to be able to store a sublist of > > all symbols whose addresses fall into the same range (15-25% of the > > lookups still failed with just the range addition). > > > I'm still not convinced that the fix proposed is the correct one. Do you > have one of those examples handy so that I can have a look on it (src > file + .exe + .pdb) ? that would be great > TIA Re-re-responses from Eric van Beurden. I'll send the sample app to you off-list (and anyone else who wants a copy, just email me directly).: I tracked down one of my sample apps that showed the overlapping symbols issue in its PDB file. Many of the symbols in it are either coincident or overlapping. In some cases the overlap occurs between a C++ decorated name and its undecorated counterpart, but in several cases the overlapping symbols are unrelated. For some symbols it could be possible that their sizes are being read incorrectly from the PDB. The original symbol lookup method used a binary search on a symbol list that was sorted by starting address. The issue was that during the search it was skipping over the correct symbol because its starting address was the same as a previous symbol's address. This sent the search in the wrong direction after that and the lookup would fail. There was no fallback for handling the case of the symbol being coincident with another or the symbol being within the address space of another symbol. The attached archive contains 4 files: - 'emptyTest.exe': the optimized release build executable linked to 'emptyTest.pdb'. This should crash. - 'emptyTest.pdb': the PDB file - 'main.cpp': the source file for the test app. Some of the code is unused as the app has morphed over time. - 'emptyTest.vcproj': the VC++7.1 project file for the test app

3 5

What is the commit status of my test fixes?
by Reece Dunn 24 Jan '08

24 Jan '08

Hi, what is the status of my recent patches sent to the wine-patches list: ‎user32: make the class tests pass on Vista. [0001-user32-make-the-class-tests-pass-on-Vista.patch] 23 Jan user32: make the clipboard tests pass on Vista. [0001-user32-make-the-clipboard-tests-pass-on-Vista.patch] 23 Jan ‎user32: make the listbox tests pass in directories other than dlls/user32/tests. [0001-user32-make-the-listbox-tests-pass-in-directories-o.patch] 00:54 ‎gdi32: Vista returns UNICODE_NOCHAR if a character does not exist. [0001-gdi32-Vista-returns-UNICODE_NOCHAR-if-a-character-d.patch] 09:01 These have not been applied, although the others beyond them have (all the changes are independant of each other, except for the gitignore changes where the devenum.h one should be ignored). wine-dev ‎gitignore: ignore files generated by the Visual C++ compiler. [0001-gitignore-ignore-files-generated-by-the-Visual-C.patch] 09:08 I know that this is causing a bit of discussion at the moment. wine-dev ‎user32: make the edit tests pass on Vista. [0001-user32-make-the-edit-tests-pass-on-Vista.patch] 00:03 This one needs updating, so I'll repost it later today with the update. wine-dev ‎gitignore: added the missing include/devenum.h generated file. [0001-gitignore-added-the-missing-include-devenum.h-gener.patch] 23 Jan This one I have said is wrong, so this one can be ignored. - Reece

1 0

wpkg.org, taskkill, reg
by Dan Kegel 24 Jan '08

24 Jan '08

I just noticed http://wpkg.org, which has a big library of silent install scripts for many windows apps. Groovy! But the first one I looked at, http://wpkg.org/Picasa, requires the taskkill and reg utilities (part of Windows XP Professional), e.g. taskkill /F /IM "Picasa2.exe" reg delete "HKEY_LOCAL_MACHINE\SOFTWARE\Microsoft\Windows\CurrentVersion\Run" /v "Picasa Media Detector" /f' It ought to be easy to whip those up. Any takers? - Dan

1 0

Basis to accept someone as a maintainer
by Vitaliy Margolen 24 Jan '08

24 Jan '08

Recently I've noticed number of random people being accepted as maintainers of few apps I'm being a super-maintainer for. First, can the appDB send notifications that some one became a maintainer? Second, what are the basis that appDB admins accept some one as one? I've tried to search for a single message, test results, anything from the people in question and found none. Should we just make everyone a maintainer? If not, then could anyone spellout why we have some random people there? Vitaliy.

3 2

Re: user32: make the edit tests pass on Vista.
by Paul Vriens 24 Jan '08

24 Jan '08

Reece Dunn wrote: > The EM_CHARFROMPOS calls return different results on Vista. This patch > adds the values returned by Vista as expected results. > > - Reece > > > ------------------------------------------------------------------------ > > If you change the test for multiple correct answers, the corresponding text should reflect that as well (it now only say 'expected 0'). -- Cheers, Paul.

1 0