October 2008 - Wine-devel - list.winehq.org

Re: [PATCH 1/3] msxml3: Update orphant list in put_documentElement.
by Michael Karcher 16 Oct '08

16 Oct '08

Am Donnerstag, den 16.10.2008, 13:55 -0500 schrieb Jacek Caban: @@ -932,9 +933,17 @@ static HRESULT WINAPI domdoc_put_documentElement( return hr; xmlNode = impl_from_IXMLDOMNode( elementNode ); - xmlDocSetRootElement( get_doc(This), xmlNode->node); + + if(!xmlNode->node->parent) + if(xmldoc_remove_orphan(xmlNode->node->doc, xmlNode->node) != S_OK) + WARN("%p is not an orphan of %p\n", xmlNode->node->doc, xmlNode->node); + + oldRoot = xmlDocSetRootElement( get_doc(This), xmlNode->node); IXMLDOMNode_Release( elementNode ); + if(oldRoot) + xmldoc_add_orphan(oldRoot->doc, oldRoot); + return S_OK; } This patch is against my intention of the orphan list. The orphan list should contain nodes that are associated to the document, but are not in the tree (i.e. not an descendant of the document root element). The orphan list is used to not forget to free these nodes (that logically reference the document and have to keep the document alive) when the document itself (i.e. the root document element) is freed. Now oldRoot already *is* the root element, that is oldRoot->doc == oldRoot. Placeing the element itself on the orphan list causes it to be freed when freeing the orphans and a second time (some lines later) when the document element is freed. So, I doubt this patch is correct. Regards, Michael Karcher

2 2

Try #3 for IDirectDrawSurface_GetSurfaceDesc error checking in ddraw test
by chris ahrendt 16 Oct '08

16 Oct '08

Michael / All here is the third go at the ddraw test... and the patch for that... note I went ahead and used the goto. Also I found an error in the test where it was allocating the buffer in one place and it did not free it. Now here is the curious thing... When I did the first run of the ddraw test I got the output found in the no_ulimit_run attachment which did not seem right as nothing ran or didnt seem to. So I did the ulimit -s unlimited and then re-ran the test and got the second output... Now shouldn't the test run the same reguardless of the stack limit? Chris

3 2

Re: gdiplus: IPicture_SaveAsFile updates seek pointer, so put it back.
by Nikolay Sivov 16 Oct '08

16 Oct '08

It isn't obvious (your patch fot ret value). Why are you hiding all codes except E_FAIL? Tests are needed, but I think you're hiding something by this change. On 10/16/08, Kirill K. Smirnov <lich(a)math.spbu.ru> wrote: > This patch fixes gdiplus test failures revealed by patch: > [2/3] oleaut32: return correct error code > http://www.winehq.org/pipermail/wine-patches/2008-October/063221.html > > > > >

2 2

Re: gdiplus: IPicture_SaveAsFile updates seek pointer, so put it back.
by Kirill K. Smirnov 16 Oct '08

16 Oct '08

>It isn't obvious (your patch fot ret value). Why are you hiding all >codes except E_FAIL? Tests are needed, but I think you're hiding >something by this change. Please, clarify, what patch are you trying to blame: (1) [2/3] oleaut32: return correct error code. or (2) gdiplus: IPicture_SaveAsFile updates seek pointer, so put it back. Both of them are obvious and are not hiding anything. On the contrary, (1) reveals hidden bug in another module (gdiplus), and (2) fixes that bug. -- Kirill

1 0

Today's git improves Dragon NaturallySpeaking 10
by Susan Cragin 16 Oct '08

16 Oct '08

Today's git ads a significant functionality to Dragon NaturallySpeaking 10. After the program loads, there are a couple of options. One of them is to scan the Documents files for wordprocessing documents, and add them to its grammar model. I have always selected that option, but until today the checking only took about 1 second and didn't really work. It probably couldn't find my documents. Today it scanned for a good three minutes, and accuracy was significantly improved. I just thought I would let you know. Susan

1 0

Patchwatcher: failed regression tests: [2/3] oleaut32: return correct error code
by Kirill K. Smirnov 16 Oct '08

16 Oct '08

Hello >@@ -1802,7 +1802,7 @@ static HRESULT WINAPI >OLEPictureImpl_Load(IPersistStream* iface,IStream*pStm) { > hr=IStream_Read(pStm,header,8,&xread); > if (hr || xread!=8) { > ERR("Failure while reading picture header (hr is %x, nread is %d). \n",hr,xread); >- return hr; >+ return (hr?hr:E_FAIL); > } > headerread += xread; > xread = 0; Hmm... I've just got notification from patchwalker that this patch for oleaut32 breaks some tests for gdiplus. I do not know why it does happen. But since this patch fixes some bugs and it got accepted, please, do not revert it or do anything evil :-)) I hope I will find right solution soon. -- Kirill

1 0

Re: winhttp: tests/server.c[new]: Add basic internal server test (RESEND)
by Alexandre Julliard 16 Oct '08

16 Oct '08

Zac Brown <zac(a)zacbrown.org> writes: > + si.hEvent = CreateEvent(NULL, 0, 0, NULL); > + si.port = rand() + 8000; You need to search for an available port, rand() is not an appropriate mechanism. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: Wineg++ and structured exception handling
by Dan Kegel 16 Oct '08

16 Oct '08

See http://wiki.winehq.org/CompilerExceptionSupport

1 0

Re: shdocvw: [Patch 1/2] Implement URLSubRegQueryA [Resend]
by Alexandre Julliard 15 Oct '08

15 Oct '08

Detlef Riekenberg <wine.dev(a)web.de> writes: > + len = sizeof(buffer); > + res = SHRegGetUSValueA(regpath, name, NULL, buffer, &len, FALSE, NULL, 0); > + if (!res) { > + lstrcpynA(out, buffer, outlen); > + if (outlen > 0) { > + out[min(outlen-1,len)] = '\0'; > + } This doesn't look right. Why do you even need a separate buffer? -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Michael Stefaniuc : shlwapi: Remove break after return (Smatch).
by Michael Stefaniuc 15 Oct '08

15 Oct '08

Hello Alexandre, I'm pretty sure that my patch contained only the second chunk of the patch commited. The first part seems to have been credited to me by mistake. Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: d6359edd3cbe366c71f22e09e27d3e427520f609 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=d6359edd3cbe366c71f22e09e… > > Author: Michael Stefaniuc <mstefani(a)redhat.de> > Date: Tue Oct 14 16:32:33 2008 +0200 > > shlwapi: Remove break after return (Smatch). > > --- > > dlls/shlwapi/assoc.c | 27 +++++++++++++++++++++++++-- > 1 files changed, 25 insertions(+), 2 deletions(-) > > diff --git a/dlls/shlwapi/assoc.c b/dlls/shlwapi/assoc.c > index 7f71708..9e4b036 100644 > --- a/dlls/shlwapi/assoc.c > +++ b/dlls/shlwapi/assoc.c > @@ -627,7 +627,31 @@ static HRESULT ASSOC_GetExecutable(IQueryAssociationsImpl *This, > if (!pszExtra) > { > hr = ASSOC_GetValue(hkeyShell, &pszExtraFromReg); > - if (FAILED(hr)) > + /* if no default action */ > + if (hr == E_FAIL || hr == HRESULT_FROM_WIN32(ERROR_FILE_NOT_FOUND)) > + { > + DWORD rlen; > + ret = RegQueryInfoKeyW(hkeyShell, 0, 0, 0, 0, &rlen, 0, 0, 0, 0, 0, 0); > + if (ret != ERROR_SUCCESS) > + { > + RegCloseKey(hkeyShell); > + return HRESULT_FROM_WIN32(ret); > + } > + rlen++; > + pszExtraFromReg = HeapAlloc(GetProcessHeap(), 0, rlen * sizeof(WCHAR)); > + if (!pszExtraFromReg) > + { > + RegCloseKey(hkeyShell); > + return E_OUTOFMEMORY; > + } > + ret = RegEnumKeyExW(hkeyShell, 0, pszExtraFromReg, &rlen, 0, NULL, NULL, NULL); > + if (ret != ERROR_SUCCESS) > + { > + RegCloseKey(hkeyShell); > + return HRESULT_FROM_WIN32(ret); > + } > + } > + else if (FAILED(hr)) > { > RegCloseKey(hkeyShell); > return hr; > @@ -743,7 +767,6 @@ static HRESULT WINAPI IQueryAssociations_fnGetString( > return hr; > len++; > return ASSOC_ReturnData(pszOut, pcchOut, path, len); > - break; > } > > case ASSOCSTR_FRIENDLYAPPNAME: > > > bye michael

2 1