October 2008 - Wine-devel - list.winehq.org

Re: wininet: quiet a noisy fixme (try 2)
by Vincent Povirk 19 Oct '08

19 Oct '08

Uh, you're changing what the function does. *lpdwStatus = INTERNET_CONNECTION_LAN; will only happen the first time. Vincent Povirk 2008/10/18 Austin English <austinenglish(a)gmail.com>: > Didn't receive any feedback on this one last time... > > -- > -Austin > > > >

1 0

milestone: cygwin nearly working properly
by Dan Kegel 19 Oct '08

19 Oct '08

The main thing missing at the moment is cygwin's symlinks aren't working, http://bugs.winehq.org/show_bug.cgi?id=15679 and I couldn't find the file needed to start cygwin's X server. (And of course the thing that drives me nuts, it only works inside wineconsole. That might be harder to fix.) With just a little more work, we could do an awesome nesting demo, I bet.

1 0

Re: winex11.drv: Handle GetDeviceCaps COLORRES capability index (resend)
by Roderick Colenbrander 19 Oct '08

19 Oct '08

Hi, Since you mentioned in your first patch that this fix is inspired by behavior on Windows, please add a test to our test suite to prove it. Roderick > The previous patch returns the incorrect variable, so I've made the > correction in this resend. > --- > dlls/winex11.drv/init.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) -- GMX startet ShortView.de. Hier findest Du Leute mit Deinen Interessen! Jetzt dabei sein: http://www.shortview.de/wasistshortview.php?mc=sv_ext_mf(a)gmx

3 2

Re: msi: quiet a noisy err
by James Hawkins 18 Oct '08

18 Oct '08

On Sat, Oct 18, 2008 at 9:37 PM, Austin English <austinenglish(a)gmail.com> wrote: > -- Please don't commit this patch. The err is there for a reason. Each time this is output, it's a different insertion that fails. -- James Hawkins

1 0

Which graphics cards really pass the conformance tests, again?
by Dan Kegel 18 Oct '08

18 Oct '08

When I put together the current patchwatcher box, I made sure to get a graphics card based on a recent nvidia chip. http://www2.pny.com/8500-GT-512MB-PCIe-P2322C269.aspx seemed recent enough, but I still get buttloads of conformance test failures in d3d and ddraw. So, which graphics cards exactly don't get any d3d or ddraw conformance test failures? Are there any? If there are, I want to get one on the patchwatcher box so I can cut back the huge blacklist a bit. Thanks, Dan

3 2

Re: shell32: FOF_MULTIDESTFILES must be set when copying files into directory
by James Hawkins 18 Oct '08

18 Oct '08

2008/10/17 Vitaly Perov <vitperov(a)etersoft.ru>: > > > From e2eec69ff86960bd6729a3105747310ce9c256fd Mon Sep 17 00:00:00 2001 > From: Vitaly Perov <vitperov(a)etersoft.ru> > Date: Fri, 17 Oct 2008 16:56:46 +0400 > Subject: [PATCH] shell32: FOF_MULTIDESTFILES must be set when copying files into directory > > --- > dlls/shell32/shlfileop.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/shell32/shlfileop.c b/dlls/shell32/shlfileop.c > index 49f61d3..e6565ea 100644 > --- a/dlls/shell32/shlfileop.c > +++ b/dlls/shell32/shlfileop.c > @@ -1382,6 +1382,7 @@ static void move_dir_to_dir(LPSHFILEOPSTRUCTW lpFileOp, const FILE_ENTRY *feFrom > fileOp = *lpFileOp; > fileOp.pFrom = szFrom; > fileOp.pTo = szTo; > + fileOp.fFlags |= FOF_MULTIDESTFILES; > > SHFileOperationW(&fileOp); > RemoveDirectoryW(feFrom->szFullPath); > We've been over this before. This needs a test case. Either way, this doesn't look right. What are you trying to fix? -- James Hawkins

3 6

Re: wined3d: Add one more FBO error status code
by Henri Verbeet 18 Oct '08

18 Oct '08

2008/10/18 Vitaliy Margolen <wine-patches(a)kievinfo.com>: > diff --git a/include/wine/wined3d_gl.h b/include/wine/wined3d_gl.h > index 5e55a0d..b26ab78 100644 > --- a/include/wine/wined3d_gl.h > +++ b/include/wine/wined3d_gl.h > @@ -1819,6 +1819,7 @@ typedef void (WINE_GLAPI * PGLFNGLVERTEXBLENDARB) (GLint count); > #define GL_FRAMEBUFFER_INCOMPLETE_FORMATS_EXT 0x8CDA > #define GL_FRAMEBUFFER_INCOMPLETE_DRAW_BUFFER_EXT 0x8CDB > #define GL_FRAMEBUFFER_INCOMPLETE_READ_BUFFER_EXT 0x8CDC > +#define GL_FRAMEBUFFER_INCOMPLETE_MULTISAMPLE_EXT 0x8D56 > #define GL_FRAMEBUFFER_UNSUPPORTED_EXT 0x8CDD > #define GL_FRAMEBUFFER_BINDING_EXT 0x8CA6 > #define GL_RENDERBUFFER_BINDING_EXT 0x8CA7 That constant is part of EXT_framebuffer_multisample, not EXT_framebuffer_object.

2 6

Re: wpp: Check for overflows when parsing integer constants.
by Alexandre Julliard 18 Oct '08

18 Oct '08

"Rob Shearman" <robertshearman(a)gmail.com> writes: > diff --git a/libs/wpp/ppl.l b/libs/wpp/ppl.l > index 3e84a2e..829ac35 100644 > --- a/libs/wpp/ppl.l > +++ b/libs/wpp/ppl.l > @@ -163,6 +163,9 @@ ul [uUlL]|[uUlL][lL]|[lL][uU]|[lL][lL][uU]|[uU][lL][lL]|[lL][uU][lL] > #include <string.h> > #include <ctype.h> > #include <assert.h> > +#define __USE_ISOC99 > +#include <limits.h> > +#undef __USE_ISOC99 If you have to do that sort of thing it means you are using non-portable definitions. The right way is to provide them yourself if they are missing, not to rely on the system headers supporting C99. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: gdi32: Add job name field into CreateSpoolFile (try2)
by Michael Karcher 18 Oct '08

18 Oct '08

Am Samstag, den 18.10.2008, 15:58 +0400 schrieb Konstantin Kondratyuk: > Try 2: add quotes in parameter: -T'%s' That's the right way to go, but are you sure that pszTitle does not contain single quotes itself? If not, you have to escape them (for the shell, it should be "\" -> "'\''") or to replace them (for example by '_'). Regards, Michael Karcher

1 0

Re: [PATCH] include: fixed the tom constant values.
by Rob Shearman 18 Oct '08

18 Oct '08

2008/10/17 Reece Dunn <msclrhd(a)googlemail.com>: > The hexadecimal constants should be 8 characters long, not 9. Found by > building the include project (via msvcmaker) with VC9. Good catch. I'll fix widl and our other parsers to check for these kinds of overflows. -- Rob Shearman

1 0