October 2008 - Wine-devel - list.winehq.org

Re: gdi32/tests: Fix tests to not depend on 96 dpi
by Dmitry Timoshkov 12 Oct '08

12 Oct '08

"Detlef Riekenberg" <wine.dev(a)web.de> wrote: > @@ -101,7 +101,9 @@ static void test_world_transform(void) > > if (is_win9x) > { > - expect_viewport_ext(hdc, 96, 96); > + DWORD dpi; > + dpi = GetDeviceCaps(hdc, LOGPIXELSY); > + expect_viewport_ext(hdc, dpi, dpi); This is still not correct, not all displays have the same resolution in all dimensions. The below one should be slightly better: expect_viewport_ext(hdc, GetDeviceCaps(hdc, LOGPIXELSX), GetDeviceCaps(hdc, LOGPIXELSY)); -- Dmitry.

1 0

patchwatcher status
by Dan Kegel 12 Oct '08

12 Oct '08

The most pressing issue for patchwatcher is to finish the refactoring into libpatchwatcher.sh and wine-slave.sh. I made a tiny bit of progress there today by applying some typo fixes Rob sent me, and adding the missing timeout enforcement that was already in the monolithic patchwatcher. (Checked in to svn if anyone cares, but not yet useful.) I also added winhttp/tests/__test__ to the blacklist, since it's failed now for three unrelated patches. - Dan

1 0

Re: DIB engine status
by Detlef Riekenberg 12 Oct '08

12 Oct '08

On 9/29/08, Sergey Novosyolov <chi(a)etersoft.ru> wrote: >> The first thing, i like to see is a Design in the correct way: >> Inside gdi32 while using Eng* and friends. >> (Needed by Printer drivers, and any Display driver including mirror / >> remote display drivers) >> > why can't we release DIB-Engine as own driver? GDI32 functions are main and > GDI32 calls driver functions in dependence of which type of DC we have > (printer DC, Xwindow HDC or DIB DC) Any Driver can call the Graphic Rendering Engine (GRE) to do parts (or all) of the rendering (and native driver do that): 1: DDB (Driver managed: using any driver specific format) (The Driver should do Everything. When the driver call the GRE, the DDB is converted to a DIB, GDI renders into the DIB and then the DIB is converted back to a DDB) => like our winex11.drv and wineps.drv 2: DDB (GDI managed: using DIB format) (The driver render, what the driver want to render with hw-support and can call the GRE for all the other rendering without converting) => Needed for native printer drivers / mirror drivers or OpenGL accelerated rendering (stefan did some experiments) 3: DIB (GDI renders everything) => The current Code is using a X11-DDB (Driver Managed) with converting issues. With a winedib.drv (the experimental tree is a wrapper around a wine driver), native printer drivers / mirror drivers will never work without another (additional) wrapper. -- By by ... Detlef

1 0

Re: winex11.drv: Improve tracing of wintab WTInfo
by James Hawkins 12 Oct '08

12 Oct '08

On Sun, Oct 12, 2008 at 3:42 PM, John Klehm <xixsimplicityxix(a)gmail.com> wrote: > @@ -1079,6 +1079,7 @@ UINT X11DRV_WTInfoW(UINT wCategory, UINT nIndex, LPVOID lpOutput) switch(wCategory) { case 0: + TRACE("category: NULL. Asking for needed buffer size"); /* return largest necessary buffer */ TRACE("%i cursors\n",gNumCursors); if (gNumCursors>0) @@ -1088,29 +1089,35 @@ UINT X11DRV_WTInfoW(UINT wCategory, UINT nIndex, LPVOID lpOutput) } break; case WTI_INTERFACE: + TRACE("category: WTI_INTERFACE\n"); These are extremely superfluous traces. The value of wCategory is traced a few lines up. Why do you need to see anything more than that? Same goes for the rest of the traces you added throughout the patch. -- James Hawkins

1 0

Re: Added missing values to VGA Mode 19 (256 color) palette registers with comments for related VGA operations. Windows programs that access VGA directly or through BIOS that previously displayed black for many values should now show correct values f
by James Hawkins 12 Oct '08

12 Oct '08

On Sat, Oct 11, 2008 at 4:15 PM, Jeremiah Flerchinger <jeremiah.flerchinger(a)gmail.com> wrote: > > @@ -476,10 +743,12 @@ static void WINAPI VGA_DoSetMode(ULONG_PTR arg) > return; > } > IDirectDrawSurface_SetPalette(lpddsurf,lpddpal); > + > vga_retrace_vertical = vga_retrace_horizontal = FALSE; > /* poll every 20ms (50fps should provide adequate responsiveness) */ > VGA_InstallTimer(20); > } > + > par->ret=0; > return; > } > There are way too many unnecessary whitespace changes in this patch. Please take them out and resend. -- James Hawkins

1 0

Re: wordpad: do not try to close uninitialized handles
by James Hawkins 12 Oct '08

12 Oct '08

On Sun, Oct 12, 2008 at 6:09 AM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > > Fix some functions where CloseHandle was called not matter if previous > open succeeded or not. > HKEY hKey; DWORD size = sizeof(RECT); + BOOL succeeded = FALSE; - if(registry_get_handle(&hKey, 0, key_options) != ERROR_SUCCESS || - RegQueryValueExW(hKey, var_framerect, 0, NULL, (LPBYTE)rc, &size) != - ERROR_SUCCESS || size != sizeof(RECT)) + if(registry_get_handle(&hKey, 0, key_options) == ERROR_SUCCESS) + { + if (RegQueryValueExW(hKey, var_framerect, 0, NULL, (LPBYTE)rc, &size) == + ERROR_SUCCESS && size == sizeof(RECT)) + { + succeeded = TRUE; + } + + RegCloseKey(hKey); + } + if (!succeeded) { All of these changes would be a lot cleaner if you just initialize hKey to 0. -- James Hawkins

1 0

Re: wordpad: do not pass resource ids to MessageBox
by Dmitry Timoshkov 12 Oct '08

12 Oct '08

"Andrey Turkin" <andrey.turkin(a)gmail.com> wrote: > It seems that automatic loading of string from resources in MessageBox* > is Wine extension. Useful and logical one but still other platform does > not support it. That's not a Wine extension, looks like the author of that code just didn't test it. One need to use MessageBoxEx to make it work. -- Dmitry.

2 2

Proposal: switch Wine source tree to utf-8
by Dan Kegel 12 Oct '08

12 Oct '08

The Chinese resource files are already utf-8, but I suspect lots of other files are in obscure character sets, which complicates patch processing and display. Just how silly would it be for us to bite the bullet and set all source files to utf-8? We'd need to recode a bunch of files once, but after that, there'd be less confusion about how to view and edit various resource files. Not saying we should up and do it, just throwing out an idea for discussion...

3 3

Re: mshtml: Implement IHTMLStyle get/put posLeft
by Jacek Caban 12 Oct '08

12 Oct '08

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft > > Best Regards > Alistair Leslie-Hughes > > {attrMarginRight, DISPID_IHTMLSTYLE_MARGINRIGHT}, > {attrPaddingLeft, DISPID_IHTMLSTYLE_PADDINGLEFT}, > + {attrLeft, DISPID_IHTMLSTYLE_POSLEFT}, > {attrPosition, DISPID_IHTMLSTYLE2_POSITION}, > {attrTextAlign, DISPID_IHTMLSTYLE_TEXTALIGN}, You can't do this. style_tbl must be sorted because we do binary search on it. Jacek

1 0

Re: notoskrnl.exe: Fix the stack overflow bugs in raising exceptions(DLL_PROCESS_DETACH processing for DllMain in ntoskrnl.c)
by Dmitry Timoshkov 11 Oct '08

11 Oct '08

"Anton Rudnev" <mibori(a)etersoft.ru> wrote: > --- a/dlls/ntoskrnl.exe/ntoskrnl.c > +++ b/dlls/ntoskrnl.exe/ntoskrnl.c > @@ -886,14 +886,20 @@ NTSTATUS WINAPI PsSetCreateProcessNotifyRoutine( PCREATE_PROCESS_NOTIFY_ROUTINE > BOOL WINAPI DllMain( HINSTANCE inst, DWORD reason, LPVOID reserved ) > { > LARGE_INTEGER count; > + static vectored_handler_added = NULL; > > switch(reason) > { > case DLL_PROCESS_ATTACH: > DisableThreadLibraryCalls( inst ); > - RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); > + vectored_handler_added = RtlAddVectoredExceptionHandler( TRUE, vectored_handler ); > KeQueryTickCount( &count ); /* initialize the global KeTickCount */ > break; > + case DLL_PROCESS_DETACH: > + if(vectored_handler_added){ > + RtlRemoveVectoredExceptionHandler(vectored_handler_added); > + vectored_handler_added = NULL; > + } > } > return TRUE; > } What you want is find out why RtlAddVectoredExceptionHandler fails for you, because it shouldn't fail normally. -- Dmitry.

2 2