October 2008 - Wine-devel - list.winehq.org

Wineconf follow up: Wine Usage Data Collection
by Zachary Goldberg 11 Oct '08

11 Oct '08

Hello All, Just wanted to continue the thread from Wineconf about tracking usage data in Wine. We had discussed adding an opt-in system at first run where all invokations of Wine would send a token to WineHQ to track the number of times users run given applications to help direct development. Thoughts? --Zach

12 48

Sugared Wine
by Vincent Povirk 11 Oct '08

11 Oct '08

For those of you just tuning in, CodeWeavers has had me working on a project called Sugared Wine. The plan was that I would implement a taskbar (complete with start menu, window switcher, and system tray) in explorer for Wine's virtual desktop and fix some virtual desktop bugs. Jeremy White would package it for sugar, and the result would be a usable Wine activity. That didn't happen, but for my continued mental health I have to release something. On http://wiki.winehq.org/SugaredWine there is a link to a Wine activity (.xo file) and a git repository containing the source code I used to build it (which itself happens to contain a set of patches to wine). This is, to the best of my knowledge, a functional Wine activity that you can download and run on any computer that has sugar. It has a taskbar, and the start menu has shortcuts to some Wine programs. If you want to try the taskbar (it is nifty), apply all the patches except the last three or so (those are needed for the sugarizing) to Wine and start a virtual desktop. My plan remains to get this into Wine, perhaps before 1.2. Getting Wine to actually work in that environment was harder than anticipated, and taking a desktop that (in my opinion) is good for Wine generally and dropping it into sugar did not produce something that works well in sugar. I've listed the sugar problems I'm aware of on the wiki page. So if you care about the prospect of getting a taskbar into the Wine virtual desktop or of getting Wine into sugar, do take a look. Vincent Povirk

3 4

Re: [try2] advapi32: Implement CredReadDomainCredentials stub and tests
by James Hawkins 10 Oct '08

10 Oct '08

On Thu, Oct 9, 2008 at 4:14 PM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > > [now with tests, fixed and reformatted as per James' suggestions] > > Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW > stubs and few tests for them. Required for MSN Messenger 7.0 > --- > dlls/advapi32/advapi32.spec | 4 +- > dlls/advapi32/cred.c | 160 +++++++++++++++++++++++++++++++++++++++++++ > dlls/advapi32/tests/cred.c | 45 ++++++++++++ > include/wincred.h | 39 +++++++++++ > 4 files changed, 246 insertions(+), 2 deletions(-) > + *Size = 0; + *Credentials = NULL; + if (!TargetInformation) What if Size or Credentials is NULL? You should add a test for that and handle it appropriately. If the tests crash, you should comment out the tests and note that there is no handling in Windows. -- James Hawkins

3 9

Re: (try 2) gdi32: if a font substitution is given then only match tothat substitution not to the original family name.
by Dmitry Timoshkov 10 Oct '08

10 Oct '08

"Aric Stewart" <aric(a)codeweavers.com> wrote: > diff --git a/dlls/gdi32/freetype.c b/dlls/gdi32/freetype.c > index 145be9b..c427694 100644 > --- a/dlls/gdi32/freetype.c > +++ b/dlls/gdi32/freetype.c > @@ -3408,8 +3408,8 @@ GdiFont *WineEngCreateFontInstance(DC *dc, HFONT hfont) > */ > LIST_FOR_EACH(family_elem_ptr, &font_list) { > family = LIST_ENTRY(family_elem_ptr, Family, entry); > - if (!strcmpiW(family->FamilyName, FaceName) || > - (psub && !strcmpiW(family->FamilyName, psub->to.name))) > + if (( psub && !strcmpiW(family->FamilyName, psub->to.name)) || > + (!psub && !strcmpiW(family->FamilyName, FaceName))) > { > LIST_FOR_EACH(face_elem_ptr, &family->faces) { > face = LIST_ENTRY(face_elem_ptr, Face, entry); After loking at this change once more I think it's not correct. It will lead to failures to find a font if there is a substitution but a face specified by substitution doesn't exist. I'd suggest to test what Windows does in that case, and if Windows allows to substitute existing faces at all. Do you have a test cases which passes with your patch but doesn't without it? -- Dmitry.

2 2

Help testing a test on Win9x/NT4
by Juan Lang 10 Oct '08

10 Oct '08

Hi folks, could someone who has Win9x or NT4 and is capable of building the tests try the attached patch and email me the results if it fails? Also please tell me the Windows version if it's failing. Thanks, --Juan

2 1

Re: mshtml: avoid dereferencing a potental NULL (Coverity 633)
by Jacek Caban 10 Oct '08

10 Oct '08

Austin English wrote: > ret++; > - if(bound_pos && dompos_cmp(&tmp, bound_pos)) { > + if(bounded && bound_pos && dompos_cmp(&tmp, bound_pos)) { > *bounded = TRUE; It's a false error. bounded is never NULL if bound_pos is not NULL. Jacek

1 0

Re: [try3] advapi32: Implement CredReadDomainCredentials stub and tests
by James Hawkins 10 Oct '08

10 Oct '08

On Fri, Oct 10, 2008 at 2:52 PM, Andrey Turkin <andrey.turkin(a)gmail.com> wrote: > [few comments added as per James' suggestion] > > Implement CredReadDomainCredentialsA and CredReadDomainCredentialsW > stubs and few tests for them. Required for MSN Messenger 7.0 > --- > dlls/advapi32/advapi32.spec | 4 +- > dlls/advapi32/cred.c | 163 +++++++++++++++++++++++++++++++++++++++++++ > dlls/advapi32/tests/cred.c | 52 ++++++++++++++ > include/wincred.h | 39 ++++++++++ > 4 files changed, 256 insertions(+), 2 deletions(-) > + /* these two tests would crash on both native and Wine. Implementations + * does not check for NULL output pointers and try to zero them out early + ok(!pCredReadDomainCredentialsA(&info, 0, NULL, &creds) && + GetLastError() == ERROR_INVALID_PARAMETER, "!"); + ok(!pCredReadDomainCredentialsA(&info, 0, &count, NULL) && + GetLastError() == ERROR_INVALID_PARAMETER, "!"); */ + Please use if(0) instead of commenting them out. + if (pCredReadDomainCredentialsA) test_CredReadDomainCredentialsA(); This should be tested for in test_CredReadDomainCredentialsA, and a win_skip issued if the function is not available. -- James Hawkins

1 0

Do the menu tests work on any Windows version?
by Juan Lang 10 Oct '08

10 Oct '08

Looking over the results on test.winehq.org, the user32 menu tests are the worst in terms of failure count (though I suppose crashing tests are worse): they fail over 1000 times on NT4, over 600 times on Win9x, and over 300 times on Vista. The only operating systems on which they seem to succeed are Windows 2000 and XP, and they never succeeded for me on Windows XP, so I'm not sure the succeeding results are even representative. Basically, they're the worst offender in terms of reliable results. Is there anyone who knows anything about them that can take a look at the test failures? --Juan P.S. The crypt32 encode tests are the next-worst offender. I'm working on 'em.

3 2

Re: rpcrt4: Use pseudo-random numbers to generate UUIDs rather than using the (old, deprecated) MAC-address-and-time generation algorithm (try 2)
by Rob Shearman 10 Oct '08

10 Oct '08

Hi Juan, 2008/10/9 Juan Lang <juan.lang(a)gmail.com>: > + RtlGenRandom(Uuid, sizeof(*Uuid)); > + /* Clear the version bits and set the version (4) */ > + Uuid->Data3 &= 0x0fff; > + Uuid->Data3 |= (4 << 12); The RFC recommends the following: o Set the two most significant bits (bits 6 and 7) of the clock_seq_hi_and_reserved to zero and one, respectively. However, I don't see that done in your patch. Also, I don't know what compatibility effect changing the algorithm will have on applications. Have you checked which algorithm recent versions of Windows use and what bits are set? -- Rob Shearman

2 1

Adding timestamps to log output
by Michael Karcher 10 Oct '08

10 Oct '08

Hello developers, In http://www.winehq.org/pipermail/wine-patches/2008-June/056508.html Peter Urbanec sent a patch I like, that adds timing information to the log. It has been critized for having the wrong indentation style. As I would like to give that patch a second chance, I reindented the code to match the surrounding code. The question I have: How to give credit? The standard "based on a patch from" clause seems to weak to me, as it is aside from whitespace changes exactly that patch. But as I did these whitespace changes, it also seems wrong to just put Peter Urbanec into the From line. He did never submit in that form. I would be happy about any advice. The indentation-fixed patch is included, although the first two lines are munged to prevent the patch to get away with the "forged" attribution. Regards, Michael Karcher Based-on-From 37a6d97098fa8d4de70b125f6303de5b5fa92357 Mon Sep 17 00:00:00 2001 Based-on-From: Peter Urbanec <winehq.org(a)urbanec.net> Date: Wed, 25 Jun 2008 02:45:46 +1000 Subject: [PATCH] ntdll: Add timestamp channel to log output. This patch will prefix every line of log output with a time stamp if the "timestamps" debug channel is enabled. The time stamps are formatted as [seconds.microseconds] and measured as elapsed time from the epoch. This helps with tracking down time sensitive bugs and it may also come in handy when investigating performance. --- dlls/ntdll/debugtools.c | 12 +++++++++++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/dlls/ntdll/debugtools.c b/dlls/ntdll/debugtools.c index cb08285..324cff4 100644 --- a/dlls/ntdll/debugtools.c +++ b/dlls/ntdll/debugtools.c @@ -29,6 +29,7 @@ # include <unistd.h> #endif #include <ctype.h> +#include <sys/time.h> #include "wine/debug.h" #include "wine/exception.h" @@ -39,6 +40,7 @@ #include "ntdll_misc.h" WINE_DECLARE_DEBUG_CHANNEL(tid); +WINE_DECLARE_DEBUG_CHANNEL(timestamps); static struct __wine_debug_functions default_funcs; @@ -164,8 +166,16 @@ static int NTDLL_dbg_vlog( enum __wine_debug_class cls, struct __wine_debug_chan /* only print header if we are at the beginning of the line */ if (info->out_pos == info->output || info->out_pos[-1] == '\n') { + /* Prepend a timestamp to each line, if requested. */ + if (TRACE_ON(timestamps)) + { + struct timeval tv; + if (!gettimeofday(&tv, NULL)) + ret += wine_dbg_printf( "[%ld.%06ld] ", tv.tv_sec, tv.tv_usec); + } + if (TRACE_ON(tid)) - ret = wine_dbg_printf( "%04x:", GetCurrentThreadId() ); + ret += wine_dbg_printf( "%04x:", GetCurrentThreadId() ); if (cls < sizeof(classes)/sizeof(classes[0])) ret += wine_dbg_printf( "%s:%s:%s ", classes[cls], channel->name, function ); } -- 1.5.6.5

2 2