October 2008 - Wine-devel - list.winehq.org

Re: [PATCH] cabinet: support building with midl-generated headers.
by Reece Dunn 23 Oct '08

23 Oct '08

Please ignore this patch. The correct solution is to add EXTRADEFS = -DCOM_NO_WINDOWS_H to Makefile.in (e.g. see dlls/browseui/Makefile.in) - Reece

1 0

Re: ole32: quiet a ridiculously noisy fixme (resend)
by Huw Davies 23 Oct '08

23 Oct '08

On Wed, Oct 22, 2008 at 08:34:49PM -0500, Austin English wrote: > Reduces Open Office 3 application's output from infinity to 7 lines. > Last patch had an unnecessary whitespace change. > > -- > -Austin > From 0dead16d2588bce8330ed862f8e5b6d3c6bb71a7 Mon Sep 17 00:00:00 2001 > From: Austin English <austinenglish(a)gmail.com> > Date: Wed, 22 Oct 2008 20:28:37 -0500 > Subject: [PATCH] ole32: quiet a ridiculously noisy fixme > > --- > dlls/ole32/usrmarshal.c | 6 +++++- > 1 files changed, 5 insertions(+), 1 deletions(-) > > diff --git a/dlls/ole32/usrmarshal.c b/dlls/ole32/usrmarshal.c > index b8487c3..6886dfb 100644 > --- a/dlls/ole32/usrmarshal.c > +++ b/dlls/ole32/usrmarshal.c > @@ -2398,7 +2398,11 @@ HRESULT CALLBACK IEnumFORMATETC_Next_Proxy( > FORMATETC *rgelt, > ULONG *pceltFetched) > { > - FIXME(":stub\n"); > + static int quietfixme = 0; > + if (quietfixme == 0) { > + FIXME(":stub\n"); > + quietfixme = 1; > + } > return E_NOTIMPL; > } > The real implementation of this would actually result in fewer lines of code! See IEnumVARIANT_Next_Proxy / Stub (in oleaut32/usrmarshal.c) for an example. Huw. -- Huw Davies huw(a)codeweavers.com

2 1

Re: (try 4) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2twice in rapid seccesion. handle this error.
by Dmitry Timoshkov 23 Oct '08

23 Oct '08

"Aric Stewart" <aric(a)codeweavers.com> wrote: > + /* > + * Windows XP is unable to recreate the ViewWindow2 returning > + * A Catastrophic failure error > + */ > + if (broken(hr == 0x8000ffff || hr == E_FAIL)) > + { > + skip("second attempt is a Catastrophic failure\n"); > + goto cleanup; > + } broken() is supposed to be used exclusively inside of ok() calls. -- Dmitry.

3 3

Re: [PATCH] msvcmaker: added COM_NO_WINDOWS_H to support midl-generated headers for __WINESRC__ components.
by Rob Shearman 23 Oct '08

23 Oct '08

2008/10/18 Reece Dunn <msclrhd(a)googlemail.com>: > When building the wine solution generated by msvcmaker, the components > generate errors that projects that define __WINESRC__ should not > include windows.h. > > I tracked this error down to windows.h being included from unknwn.h > (generated from unknwn.idl). This is from the code generated by VC9's > midl compiler. > > The midl generated code allows you to define COM_NO_WINDOWS_H to > prevent the inclusion of windows.h. That define is thus added to those > provided by msvcmaker. Any reason why this hasn't been applied yet? I've been testing with this applied and I believe it is an improvement and gets more DLLs compiling. -- Rob Shearman

3 4

Re: (try 2) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Michael Karcher 23 Oct '08

23 Oct '08

[resend with subscribed from] Am Donnerstag, den 23.10.2008, 07:41 -0500 schrieb Aric Stewart: > + /* > + * Windows XP is unable to recreate the ViewWindow2 returning > + * A Catastrophic failure error > + */ > + if (broken(hr == 0x8000ffff || hr == E_FAIL)) Any reason you don't use E_UNEXPECTED instead of the numerical constant? Regards, MIchael Karcher

1 0

Re: (try 3) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Paul Vriens 23 Oct '08

23 Oct '08

Aric Stewart wrote: > > Switch the second test to be the first one as it is more important. > So if we get to do only one do that one > --- > dlls/comdlg32/tests/filedlg.c | 19 +++++++++++++++---- > 1 files changed, 15 insertions(+), 4 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Aric, + if (broken(hr == 0x8000ffff || hr == E_FAIL)) + { + win_skip("second attempt is a Catastrophic failure\n"); broken() and win_skip(), wow :) The win_skip is not needed in this case. A normal skip() would do fine. -- Cheers, Paul.

1 0

Re: ole32: Stub implementation for CoGetCallerTID
by Rob Shearman 23 Oct '08

23 Oct '08

2008/10/23 Sylvain Petreolle <spetreolle(a)yahoo.fr>: > Content-Type: application/octet-stream; name="CoGetCallerTID.diff" Please ensure attached patches have a content type of text/<anything> instead of application/octet-stream, as reviewing them is difficult otherwise. -- Rob Shearman

1 0

Re: (try 2) comdlg32/tests: Windows XP+ cannot do a CreateViewWindow2 twice in rapid seccesion. handle this error.
by Michael Karcher 23 Oct '08

23 Oct '08

Am Donnerstag, den 23.10.2008, 07:41 -0500 schrieb Aric Stewart: > + /* > + * Windows XP is unable to recreate the ViewWindow2 returning > + * A Catastrophic failure error > + */ > + if (broken(hr == 0x8000ffff || hr == E_FAIL)) Any reason you don't use E_UNEXPECTED instead of the numerical constant? Regards, MIchael Karcher

1 0

RE: [6/6] d3d10: d3d10 doesn't need wined3d.
by Stefan Dösinger 23 Oct '08

23 Oct '08

Do you have any long-time intentions with this? Or are you just changing it because we don't need wined3d right now because d3d10 is a stub? > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Henri Verbeet > Sent: Wednesday, October 22, 2008 5:47 PM > To: wine-patches(a)winehq.org > Subject: [6/6] d3d10: d3d10 doesn't need wined3d. >

2 2

Re: wine users forum registration issue
by Andreas Mohr 23 Oct '08

23 Oct '08

Hi, On Tue, Oct 21, 2008 at 11:37:22AM -0400, WDDT(a)aol.com wrote: > Hi-- > > I'm a new user of linux and wine and was looking for some help with a > database program that ALMOST runs. I found an entry on the forum with a problem > similar to mine and wanted to comment, so I decided to register. Unfortunately, > I was unable to get the sign-in page to recognize the characters I typed in. > I tried several times, including case-matching and entering numbers on the > number pad. In fact, I attempted it enough times to be ruled out as having > tried too often. Is there an end-run to joining the forum or some magic insider > voodoo in place to keep fogeys like me out? (Because I could USE some voodoo > at this point with my database!) Any help would be appreciated. Thanks for your input! This is now about the 30th time (no, REALLY, this __IS__ the 30th time, or possibly even 50th!) that someone has severe issues with WineHQ forum registration, in the last 12 or so months. Could someone _please_ finally do something practical about it? Doing severe cross-posting to make sure this does get noticed, thanks. (I should be doing entirely different things ATM, but I simply cannot let this huge usability and mailbox clogging issue linger any longer, thus I'm escalating it, sorry) Thanks, Andreas Mohr

7 7