October 2008 - Wine-devel - list.winehq.org

Re: crypt32: fix a test failure on Free/PC-BSD
by Francois Gouget 28 Oct '08

28 Oct '08

On Mon, 27 Oct 2008, Austin English wrote: > PC-BSD doesn't have root certificates installed by default. They're > available in ports/security/ca_root_nss, but even after installing > them, the test still fails. We need their location added to the list > of locations to search. So this means we don't need to worry about ca_root_nss on the build machine but that it must be installed on the machine where Wine runs, right? I'm asking because of the Recommended_Packages Wiki page. It mostly lists build dependencies so the question is whether it should really be added there. Maybe it means that page should better distinguish build-time dependencies from run-time dependencies. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ 145 = 1! + 4! + 5!

2 1

patchwatcher: the winehttp:notification tests are failing for some reason
by Reece Dunn 28 Oct '08

28 Oct '08

Hi, Does anyone have any ideas why these tests are failing (e.g. http://kegel.com/wine/patchwatcher/results/3644.log)? The patches in question don't touch that code at all. Looking at http://test.winehq.org (e.g. http://test.winehq.org/data/07fafa26a318a3da3185fcac71bfa6d3fba82787/xp_fg-…) there seems to be some variance on WinXP and 2003. Does anyone know if this is context dependant (e.g. network timing out)? Thanks, - Reece

3 4

Re: [oleacc/tests] Remove a test with different results on several platforms
by Paul Vriens 28 Oct '08

28 Oct '08

On Mon, Oct 27, 2008 at 4:18 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > This test shows different results on different platforms (and on W2K even on > the same platform). I don't think there is any value in the content of the > buffer as the call failed anyway (ret == 0). > > Changelog > Remove a test with different results on several platforms > > -- > Cheers, > > Paul. > Sorry, attached the wrong patch (thanks Dan and Michael). I'm not able to resend until next week. Cheers, Paul.

1 0

Re: mshtml: Implement HTMLDocument get/put designMode (try 2)
by Jacek Caban 28 Oct '08

28 Oct '08

Alistair Leslie-Hughes wrote: > Hi, > Initialize designmode > > Changelog: > mshtml: Implement HTMLDocument get/put designMode We need its true implementation. What you do is a step in wrong direction and it's obviously not implementation but stub. Jacek

1 0

Re: [PATCH] uxtheme: SetWindowTheme should return E_HANDLE when the HWND it is passed is invalid. [try 3]
by Alexandre Julliard 28 Oct '08

28 Oct '08

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > @@ -691,11 +691,21 @@ HRESULT WINAPI SetWindowTheme(HWND hwnd, LPCWSTR pszSubAppName, > HRESULT hr; > TRACE("(%p,%s,%s)\n", hwnd, debugstr_w(pszSubAppName), > debugstr_w(pszSubIdList)); > + > + if(!IsWindow(hwnd)) > + { > + hr = E_HANDLE; > + goto error; > + } You shouldn't add IsWindow() checks. The error must be detected and handled at the place where the window handle is actually used. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml/tests: skip some tests if gecko isn't installed
by Jacek Caban 28 Oct '08

28 Oct '08

Austin English wrote: - ok(hres == S_OK, "get_body failed: %08x\n", hres); + if(hres == E_UNEXPECTED) { + skip("Could not get document body. Assuming no Gecko installed.\n"); + } + else { + ok(hres == S_OK, "get_body failed: %08x\n", hres); + } You should fix existing skip to mach current mshtml changes, not add another one. Jacek

1 0

Re: advapi32/tests: Run a test on more platforms.
by Nicolas Le Cam 27 Oct '08

27 Oct '08

Hi, Should I consider second solution ? Or perhaps adding a comment explaining why we use the second provider type key would be enough ? Original patch is available at [1] for reference. [1] http://www.winehq.org/pipermail/wine-patches/2008-October/063475.html Bye, Nicolas Le Cam 2008/10/20 Nicolas Le Cam <niko.lecam(a)gmail.com>: > Hi, > > Sometimes, the first Provider Type key (Microsoft Base Cryptographic > Provider v1.0) doesn't have a TypeName subkey. It's the case on my Win2k > box and according to test.winehq.org it seems to be the case for some > other Win2k and Win98 boxes. So check for the second Provider Type > instead. > > Checked on Win2k SP4 and WinXP SP3. > > We can also get rid of that skip by enumerating the Provider Type keys > until we find one that fit our needs in FindProvTypesRegVals(). Tell me > if this way is preferred, I will provide a modified patch. > > Regards, > Nicolas Le Cam

1 0

Re: ws2_32: set correct error if lpOverlapped has an event of NULL and lpCompletionRoutine is also NULL
by Aric Stewart 27 Oct '08

27 Oct '08

Ignore this please. -aric Aric Stewart wrote: > --- > dlls/ws2_32/socket.c | 2 ++ > dlls/ws2_32/tests/sock.c | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 34 insertions(+), 0 deletions(-) > > > > ------------------------------------------------------------------------ > >

1 0

Patchwatcher status
by Dan Kegel 27 Oct '08

27 Oct '08

I'm running into http://bugs.winehq.org/show_bug.cgi?id=15716 more and more often. We really need to set up mock servers so test cases don't need to rely on the public internet. I'm slowly bringing up a second patchwatcher using the newly refactored code. I even wrote some documentation on how to set up a patchwatcher instance: http://code.google.com/p/winezeug/source/browse/trunk/patchwatcher/readme.t… I don't really recommend anybody (but Rob) try to do this until we finish working out the bugs, though.

4 5

Where's msrle.avi? (was: winmm: Add the tests for mmioOpen and mmioSetBuffer, make them pass under Wine)
by Dan Kegel 27 Oct '08

27 Oct '08

In http://www.winehq.org/pipermail/wine-patches/2008-June/056002.html Dmitry enabled a test that is skipped unless file msrle.avi is present. Where is that file? Why isn't it in git?

2 3