November 2008 - Wine-devel - list.winehq.org

Re: user32: TPM_ENTERIDLEEX needs to be set for popup windows (resend)
by David Adam 14 Nov '08

14 Nov '08

You need to est your email adress in your patches. David 2008/11/12 Nicholai Benalal <nicholai(a)t-online.de> > Changelog: > user32:TPM_ENTERIDLEEX needs to be set for popup windows since > applications expect the owner window to be set for WM_ENTERIDLE. A NULL > window made several applications, such as Fritz 9 - 11 crash (see bug 9615) > > Best regards, > > Nicholai Benalal (olympia(a)skydreams.org) > > > > > >

3 2

Users posting to wine-bugs
by Luke Bratch 13 Nov '08

13 Nov '08

Hi You may remember me as the person that does the mailing list moderation. Every day there are always several users posting directly to wine-bugs, as they are hitting reply to emails generated by Bugzilla instead of posting in Bugzilla itself. I added a message in the text that Bugzilla generates to make it clearer to not reply to the email a few months ago, which at the time seemed to improve things but as of late the number of emails has been going up again. Is anybody opposed to me setting up an auto-responder so that any mail going to wine-bugs(a)winehq.org gets auto responded to with a message to post in Bugzilla instead? I ask this in wine-devel as I'm not sure who is the actual administrator of the lists are. Thanks Luke Bratch

4 6

Re: DDRAW: ComputeSphereVisibility: Am I in the good way?
by paulo lesgaz 13 Nov '08

13 Nov '08

I need to use some functions implemented in d3dx8 to do the job. Can I link this dll to ddraw (even if it is not logical in a Windows point of view) or I need to reimplement all the needed math functions in wined3d? David --- En date de : Jeu 13.11.08, Henri Verbeet <hverbeet(a)gmail.com> a écrit : De: Henri Verbeet <hverbeet(a)gmail.com> Objet: Re: DDRAW: ComputeSphereVisibility: Am I in the good way? À: jeremielapuree(a)yahoo.fr Cc: wine-devel(a)winehq.org Date: Jeudi 13 Novembre 2008, 16h13 2008/11/13 paulo lesgaz <jeremielapuree(a)yahoo.fr>: > Hello > > I would like to implement ComputeSphereVisibility. The sting game is > completely black because of this stubbed function. Here is my idea to > implement it. Am I in the good way, or it is completely a bad idea? > > With GetViewport, I retrieve the viewport matrix V, and with GetTransform, > I retrieve projection P and world W matrices ofn the device. > > I multiply the three matrices in a matrice M: M=VPW > > If M is singular, function returns with a failing message > Otherwise, with the matrix M I retrieve the planes of the frustum view > (that's a little bit of math, but quite easy) > > Then for each sphere, > > Let Visibility=0 > for each plane of the frustum view > Let I be the intersection of the orthogonal projection of the center > sphere on the plane. > If I is in the frustum view, then I have the visibility.So > Visibility=Visibility|(flag for the visibility of the chosen plane) > > Once I did it for the 6 plane, I have the visibility of the sphere. > > Is it a good point of start? > > David > The basic idea sounds about right. I don't think you need to project the sphere onto the frustum planes, just using the plane normal to calculate the distance to the sphere center should do.

2 1

Only ~100 valgrind errors left?
by Dan Kegel 13 Nov '08

13 Nov '08

I'm getting back to valgrinding again. In preparation for adding valgrind runs to patchwatcher, I'm running the test suite through valgrind zillions of times, looking at how repeatable the results are. At the moment it looks like there is an annoyingly long tail of less likely failures, which is going to be a pain. On the bright side, it is looking like there aren't that many frequent valgrind errors left. See http://kegel.com/wine/valgrind/2008-11-13.txt for a manually deduplicated list. It only shows about 100 problems. Here's the breakdown by error type: 1 InvalidJump 3 InvalidWrite 7 Leak_DefinitelyLost 7 UninitValue 11 SyscallParam 25 InvalidRead 52 UninitCondition A word of warning: don't go fixing the problems behind these warnings unless you really know what you're doing. Superficial fixes are worse than no fix. That said, if anyone has a really good grasp of any of these problems, please go ahead and fix, or let me know which of these should be suppressed. For no particularly good reason, I've omiitted filenames, the list only includes function names and line numbers. That should have the unintended benefit of discouraging people unfamiliar with the code from jumping in and fixing things... Thanks, Dan

1 0

Re: user32: The default WM_CANCELMODE handler needs to call EndMenu() also in the case of a child window (resend)
by Vincent Povirk 13 Nov '08

13 Nov '08

Please write a test for this scenario. Vincent Povirk On Tue, Nov 11, 2008 at 6:40 PM, Nicholai Benalal <nicholai(a)t-online.de> wrote: > Changelog: > user32: The default WM_CANCELMODE handler needs to call EndMenu() also in > the case of a child window. With the previous condition, Chessbase > applications never closed their application menus and several would open > at the same time > > Best regards, > > Nicholai Benalal (olympia(a)skydreams.org) > > > > > >

2 1

DDRAW: ComputeSphereVisibility: Am I in the good way?
by paulo lesgaz 13 Nov '08

13 Nov '08

Hello I would like to implement ComputeSphereVisibility. The sting game is completely black because of this stubbed function. Here is my idea to implement it. Am I in the good way, or it is completely a bad idea? With GetViewport, I retrieve the viewport matrix V, and with GetTransform, I retrieve projection P and world W matrices ofn the device. I multiply the three matrices in a matrice M: M=VPW If M is singular, function returns with a failing message Otherwise, with the matrix M I retrieve the planes of the frustum view (that's a little bit of math, but quite easy) Then for each sphere, Let Visibility=0 for each plane of the frustum view Let I be the intersection of the orthogonal projection of the center sphere on the plane. If I is in the frustum view, then I have the visibility.So Visibility=Visibility|(flag for the visibility of the chosen plane) Once I did it for the 6 plane, I have the visibility of the sphere. Is it a good point of start? David

2 1

Making changes to Wiki
by Vitaliy Margolen 13 Nov '08

13 Nov '08

Whenever someone maks changes to wiki page please add comments indicating what was changed. Without comments it's the same as submitting patches without a description. Vitaliy.

1 0

Re: shdocvw: Correct tests
by Paul Vriens 13 Nov '08

13 Nov '08

Alistair Leslie-Hughes wrote: > Hi, > Corrected module the test are corrected in. > > Changelog: > shdocvw: Correct tests > > Best Regards > Alistair Leslie-Hughes > So shouldn't this be changed as well: - ok(site == NULL, "inplace=%p, ezpected NULL\n", runnable); + ok(site == NULL, "inplace=%p, ezpected NULL\n", site); (should be "site=%p....." and the ezpected typo is still there). -- Cheers, Paul.

1 0

Re: mshtml: Correct tests
by Alistair Leslie-Hughes 13 Nov '08

13 Nov '08

Ignore this. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:491BFA50.9050407(a)hotmail.com... > Hi, > > Changelog: > mshtml: Correct tests > > Best Regards > Alistair Leslie-Hughes > > > > -------------------------------------------------------------------------------- > From e6ba1638d427366350ab1b4269372479cd4a3476 Mon Sep 17 00:00:00 2001 > From: Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> > Date: Thu, 13 Nov 2008 20:55:59 +1100 > Subject: [PATCH] Correct tests > To: wine-patches <wine-patches(a)winehq.org> > > --- > dlls/shdocvw/tests/webbrowser.c | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > > diff --git a/dlls/shdocvw/tests/webbrowser.c > b/dlls/shdocvw/tests/webbrowser.c > index 3aa4bdd..484efe2 100644 > --- a/dlls/shdocvw/tests/webbrowser.c > +++ b/dlls/shdocvw/tests/webbrowser.c > @@ -1988,31 +1988,31 @@ static void test_QueryInterface(IUnknown *unk) > > hres = IUnknown_QueryInterface(unk, &IID_IQuickActivate, (void**)&qa); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(qa == NULL, "qa=%p, ezpected NULL\n", qa); > + ok(qa == NULL, "qa=%p, expected NULL\n", qa); > > hres = IUnknown_QueryInterface(unk, &IID_IRunnableObject, > (void**)&runnable); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(runnable == NULL, "runnable=%p, ezpected NULL\n", runnable); > + ok(runnable == NULL, "runnable=%p, expected NULL\n", runnable); > > hres = IUnknown_QueryInterface(unk, &IID_IPerPropertyBrowsing, > (void**)&propbrowse); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", runnable); > + ok(propbrowse == NULL, "propbrowse=%p, expected NULL\n", propbrowse); > > hres = IUnknown_QueryInterface(unk, &IID_IOleCache, (void**)&cache); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(cache == NULL, "cache=%p, ezpected NULL\n", runnable); > + ok(cache == NULL, "cache=%p, expected NULL\n", cache); > > hres = IUnknown_QueryInterface(unk, &IID_IOleInPlaceSite, > (void**)&inplace); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(inplace == NULL, "inplace=%p, ezpected NULL\n", runnable); > + ok(inplace == NULL, "inplace=%p, expected NULL\n", inplace); > > hres = IUnknown_QueryInterface(unk, &IID_IObjectWithSite, > (void**)&site); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(site == NULL, "inplace=%p, ezpected NULL\n", runnable); > + ok(site == NULL, "inplace=%p, ezpected NULL\n", site); > > hres = IUnknown_QueryInterface(unk, &IID_IViewObjectEx, > (void**)&viewex); > ok(hres == E_NOINTERFACE, "QueryInterface returned %08x, expected > E_NOINTERFACE\n", hres); > - ok(viewex == NULL, "viewex=%p, ezpected NULL\n", runnable); > + ok(viewex == NULL, "viewex=%p, expected NULL\n", viewex); > > } > > -- > 1.5.4.3 > > -------------------------------------------------------------------------------- > >

1 0

Re: Patch to build \\HKLM\HARDWARE\DEVICEMAP\SERIALCOMM entries for COM ports
by A C Hurst 13 Nov '08

13 Nov '08

Resending this as it didn't make the list (shef.ac.uk != sheffield.ac.uk) sorry Austin > > Follows example of create_scsi_entries() in oldconfig.c > > Addresses bug 11811 among others. > > docs at http://www.winehq.org/site/docs/wineusr-guide/misc-things-to-configure only mention > > lowercase names in dosdevices. > > Hopefully I'm not too far down the s**t list; only my 2nd wine patch, feedback very welcome. > > -/* create the hardware registry branch */ > -static void create_hardware_branch(void) > ... > +/* create the hardware registry branch */ > +void create_hardware_branch(void) > > Any particular reason you moved this? > > -- > -Austin > Yes, it started as: void convert_old_config(void) { <other stuff..> /* create some hardware keys (FIXME: should not be done here) */ create_hardware_branch(); } but create_hardware_branch() did all/only the scsi stuff. I renamed it create_scsi_branch and added my create_serialcomm_branch, then thought how should I call it? Could just as well be: void convert_old_config(void) { <other stuff..> /* create some hardware keys (FIXME: should not be done here) */ create_scsi_branch(); create_serialcomm_branch(); } Would this be better? Andy

1 0