November 2008 - Wine-devel - list.winehq.org

Re: wined3d: fix a compiler warning (2/10)
by Henri Verbeet 12 Nov '08

12 Nov '08

The fix is mostly correct (although obviously there's more wrong with that code), but please use a slightly more descriptive subject. "Fix a compiler warning" doesn't say a whole lot.

1 0

Re: winex11.drv: fix a compiler warning (4/10)
by Chris Robinson 12 Nov '08

12 Nov '08

On Tuesday 11 November 2008 07:28:11 pm Austin English wrote: > - TRACE(output); > + TRACE(output, "%s"); I think you put this on backwards. Some of the other patches seem to be the same way. This gets rid of the warning because you add an extra parameter, which the compiler takes to mean that you know what you're doing. But if the input string contains an %code, it'll interpret the value incorrectly.

1 0

Compiler warnings in gcc 4.3.2
by Austin English 12 Nov '08

12 Nov '08

I recently upgraded to intrepid, which has gcc 4.3.2. It gave a few new warnings, and I've got patches ready for all but this one. I started to write a patch to remove the check, since it's useless, but wasn't sure if it should instead be converted to a signed integer instead. austin(a)austin-desktop:~/wine-git/dlls/dnsapi$ make ccache gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strength-reduce -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -Werror -g -o ns_parse.o ns_parse.c cc1: warnings being treated as errors ns_parse.c: In function 'dns_ns_parserr': ns_parse.c:139: error: comparison of unsigned expression < 0 is always false make: *** [ns_parse.o] Error 1 Relevant code: int dns_ns_parserr(ns_msg *handle, ns_sect section, int rrnum, ns_rr *rr) { int b; /* Make section right. */ if (section < 0 || section >= ns_s_max) RETERR(ENODEV); -- -Austin

2 2

Re: Implements GradientFill /GdiGradientFill
by Austin English 11 Nov '08

11 Nov '08

On Tue, Nov 11, 2008 at 2:22 PM, joirge <jorgebendezu(a)viabcp.com> wrote: > I need it to run a program to change frequencuies to a radiomodem > satelline . > Many Thanks > > > You forgot the patch. -- -Austin

1 0

Re: shdocvw: Correct test for non-existing interfaces
by James Hawkins 11 Nov '08

11 Nov '08

On Tue, Nov 11, 2008 at 4:27 PM, Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> wrote: > Hi, > This add a test for the IViewObjectEx interface as well as correcting the > exiting tests. > > Changelog: > shdocvw: Correct test for non-existing interfaces > - ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", runnable); + ok(propbrowse == NULL, "propbrowse=%p, ezpected NULL\n", propbrowse); Might want to fix the other typos while you're at it: s/ezpected/expected/ -- James Hawkins

1 0

Re: shdocvw: Added Support for the IViewObjectEx interface
by Jacek Caban 11 Nov '08

11 Nov '08

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > shdocvw: Added Support for the IViewObjectEx interface Please check if interface you add is really supposed to be there. It's not the first time someone tries to add an interface to WebBrowser or HTMLDocument that shouldn't be there (this time the patch is already in Git). Please remember that the fact that an app queries for interface doesn't mean it should success! I keep adding tests for such cases, but it really easy to tests it before sending patch and it's something you *should* do. Jacek

2 2

Wine and relocation on not aligned section
by Alessandro 11 Nov '08

11 Nov '08

Hi list, while diving into wine sources i've noticed that wine does not apply relocation to section not aligned to page boundary. Is there any reason for this behaviour? If it is wrong i've put up a little patch that solves the issue. Greetings, Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

1 0

Re: d3dx9_38.dll: Add the dll.
by Tony Wasserka 11 Nov '08

11 Nov '08

Hi, > +#include "config.h" > +#include "wine/port.h" > + > +#include <stdarg.h> > + > +#include "windef.h" > +#include "winbase.h" > +#include "wingdi.h" > +#include "winuser.h" > +#include "wine/debug.h" > + > +#include "d3dx9.h" There's no point in including so many unneccessary header files. Also, we have the year 2008, so you may want to update the Copyright ;-)

1 0

Re: winspool.drv/tests: Fix a test on all platforms.
by Nicolas Le Cam 11 Nov '08

11 Nov '08

2008/11/6 Nicolas Le Cam <niko.lecam(a)gmail.com>: > Hi, > > DeviceCapabilities DC_FIELDS always sets the DM_FORMNAME flag. > Mark this test as a todo_wine. > > Nicolas Le Cam Is there something wrong with this one ? Should I fix wine too ? I didn't because I don't know where to fix it (in winspool.drv or in gdi32). There's no tests for this part of gdi32 and I really don't know if windows' winspool.drv calls gdi32 DeviceCapabilities function. Could someone familiar with this part can help me ? Nicolas Le Cam

1 0

Re: mlang: Implement IMultiLanguage2::ConvertStringInIStream.
by Dmitry Timoshkov 11 Nov '08

11 Nov '08

"Hans Leidekker" <hans(a)codeweavers.com> wrote: > + while (1) > + { > + hr = IStream_Read(pstmIn, src, sizeof(src), &bytes_read); > + if (FAILED(hr)) goto exit; > + > + srclen = bytes_read; > + dstlen = buffer_size; > + ConvertINetString(pdwMode, dwSrcEncoding, dwDstEncoding, src, &srclen, NULL, &dstlen); > + if (dstlen > buffer_size) > + { > + dst = HeapReAlloc(GetProcessHeap(), 0, dst, dstlen); > + if (!dst) return E_OUTOFMEMORY; > + buffer_size = dstlen; > + } > + > + hr = ConvertINetString(pdwMode, dwSrcEncoding, dwDstEncoding, src, &srclen, dst, &dstlen); > + if (FAILED(hr)) goto exit; > + > + hr = IStream_Write(pstmOut, dst, dstlen, NULL); > + if (FAILED(hr)) goto exit; > + > + if (bytes_read != sizeof(src)) break; > + } > + > +exit: 'break' instead of 'goto' would be cleaner IMO. -- Dmitry.

1 0