November 2008 - Wine-devel - list.winehq.org

Re: Vincent Povirk : setupapi: Implement ProfileItems directive.
by Rob Shearman 06 Nov '08

06 Nov '08

2008/11/5 Vincent Povirk <vincent(a)codeweavers.com>: > + CoInitialize(NULL); > + > + if (!SUCCEEDED(CoCreateInstance( &CLSID_ShellLink, NULL, > + CLSCTX_INPROC_SERVER, &IID_IShellLinkW, (LPVOID*)&shelllink))) > + goto done; > + > + IShellLinkW_SetPath( shelllink, cmdline ); > + SHPathPrepareForWriteW( NULL, NULL, lnkpath, SHPPFW_DIRCREATE|SHPPFW_IGNOREFILENAME ); > + if (SUCCEEDED(IShellLinkW_QueryInterface( shelllink, &IID_IPersistFile, (LPVOID*)&persistfile))) > + { > + TRACE( "writing link: %s\n", debugstr_w(lnkpath) ); > + IPersistFile_Save( persistfile, lnkpath, FALSE ); > + IPersistFile_Release( persistfile ); > + } > + IShellLinkW_Release( shelllink ); > + > +done: > + HeapFree( GetProcessHeap(), 0, cmdline ); > return TRUE; You've forgotten to call CoUninitialize(). -- Rob Shearman

1 0

Finish the implementation of ID3DXMatrixStack
by paulo lesgaz 06 Nov '08

06 Nov '08

Hello You should send one patch for one implementation of a function, not one patch for all the functions. Moreover, you should keep the style of the file. The semi-colon ; is placed just after the parenthesis ) not like this: ) ; David --- En date de : Mer 29.10.08, paulo lesgaz <jeremielapuree(a)yahoo.fr> a écrit : De: paulo lesgaz <jeremielapuree(a)yahoo.fr> Objet: D3DXMatrixstack: where to go.... À: "wine-devel" <wine-devel(a)winehq.org>, "Jérôme Gardou" <jerome.gardou(a)gmail.com> Date: Mercredi 29 Octobre 2008, 13h18 I did several patches about D3DXMAtrixStack. All were uncorrect. The idea of Henri to implement it is this one: it is very time -comsumming to allocate or to free memory. So one needs to do that as less as possible. So, we start with a stack with predefined size. When the stack is full, one multiplies by 2 its size. When one releases items enough of the stack, one divides its size by 2. Here are patches that implemented that idea. When looking at your patch, I saw that in my patch, in the D3dxMatrixstackImpl_release function, I do not free the memory of the array of matrix. It should be done. In the tests patch, I did not check if d3dxmatrixstackcreate fails. If it fails, tests should be skipped. At the end of the test, I did not call the _Release function. It should be done too. Maybe, you should use these patches and try to improve them. All the tests passed on my Windows XP box. David

1 0

Re: [2/2] WINED3D: Fix D3DCOLOR swizzling in shaders.
by Henri Verbeet 06 Nov '08

06 Nov '08

2008/11/6 Mark Kilgard <mjk(a)nvidia.com>: > > WineD3D, > > Please be aware of this new OpenGL extension: > > http://www.opengl.org/registry/specs/EXT/vertex_array_bgra.txt > http://www.opengl.org/registry/specs/EXT/vertex_array_bgra.txt > > This extension allows OpenGL implementations supporting the extension to > implement the D3DCOLOR swizzle without any special coding. This extension > is fully supported in hardware by NVIDIA's upcoming 180.xx series drivers > for both Linux and Windows. > > - Mark Kilgard, NVIDIA > Yeah, we noticed that extension a few weeks ago. It looks pretty useful (as well as some of the other new extensions), and we'll certainly start using it once there's driver support. Henri

1 0

Implementing WFP
by C.J. Adams-Collier 05 Nov '08

05 Nov '08

Hey all, What steps need to be taken to implement the WFP API using libwine? http://msdn.microsoft.com/en-us/library/bb427363(VS.85).aspx The first platform I'd like to see implementation on is Linux/iptables. *BSD/pf is next on the list followed by Solaris/ipf Cheers, C.J.

2 2

Re: [ddraw/tests] Fix a test on W2K3
by chris ahrendt 05 Nov '08

05 Nov '08

Paul Vriens wrote: > Henri Verbeet wrote: > >> 2008/11/4 Paul Vriens <paul.vriens.wine(a)gmail.com>: >> >>> Hi, >>> >>> I upgraded to VMware 6.5.0 this morning and overlay tests are run now on my >>> W2K3 >>> box. As the return value indicates E_NOTIMPL I decided to add a skip() for >>> one particular test. >>> >>> >> VMware is not a valid test platform for ddraw. >> >> >> >> > And how would you like to approach that? Most of us run tests on some piece of > virtualization software. Should we check for VMware and don't run d3d8/9/10 and > ddraw tests anymore at all? We do want to have a green test.winehq.org after all. > > I agree that we shouldn't use VMware as a valid test platform for ddraw but as > long as the skips are kept to a minimum can't we live with that? > > (What would have happened with the patch when I wouldn't have mentioned VMware?) > > Actually as of 6.5 of VMWARE direct draw 9c is 100% supported. So why couldn't we use vmware 6.5 as a valid platform for testing direct draw api's? chris

2 1

Wine support for win64
by Alessandro 05 Nov '08

05 Nov '08

Hi, i'd like to know if anyone knows the current status of wine's support fro win64. I've tried to build a git checkout with --enable-win64 configure switch. It has taken some tinkering to make it build, but after that i'm not able to run anything and ti seems that wineboot cannot start. Any suggestion? Alessandro Pignotti -- Vi Veri Veniversum Vivus Vici -Dr. Faustus - Marlowe Public GPG Key ID 0x650B3ED9 on subkeys.gpg.net Key Fingerprint 6243 AAD3 E3EC 52D8 DFAA 2A2F 9FCD 0457 650B 3ED9 Encrypted mails are welcome

9 9

Wine theming (follow up)
by Roderick Colenbrander 05 Nov '08

05 Nov '08

Hi, The way to go for Wine theming is to use Windows XP themes. Unfortunately the file format itself is not documented. Based on Wine its uxtheme code (BTW our uxtheme is quite complete) and an analysis of some 'free' XP themes like 'ClearLook' I was able to write my own theme template. First of all for I want to warn all people who want to write Wine themes. A Windows theme consists of colors, font sizes, bitmaps and dimensions of controls. Windows theme editors use XP themes as a template for creating new themes, so even if you find a 'free' theme it is in the end derived from a Microsoft theme and most of the time Luna. Myself I analyzed the clearlooks and some other free ones just to understand Wine's uxtheme code. If you want to write themes use the uxtheme code as your reference. For instance dlls/uxtheme/stylemap.c shows which properties are allowed on each control. If a property on lets say a button is called 'CONTENTMARGINS' themes useally type 'ContentMargins', Anyway now to the theme file I created. A theme file is a resource file which contains various sections. They contain the names of the builtin color schemes, font sizes and of course the actual theme data. The theme data itself is stored in ini files. Most themes offer differ font sizes and colors and for each combination there is a ini file. The theme file I made only consists of a 'SysMetrics' section which contains the 'classic' color names which can also be adjusted from the Control Panel\\Colors registry location. The difference is that in XP Microsoft cleaned up the names, so some of the names have changed. The theme is compiled using mingw because right now winecfg seems to need a real 'MZ' header. A lot of work is needed especially in comctl32 and also in uxtheme its drawing code to optimize the drawing performance and to properly render themes. For this purpose you should use some free native XP themes and try them to render properly in Wine. The uxtheme drawing code needs to handle margins, locations and positions properly. Right now in case of a button comctl32 is making assumptions about text locations and I don't think that belongs there. Hopefully some people will step up to create Wine themes and improve utheme and our theme drawing. Myself I envision a 'winetheme.msstyles' which contains some GTK and QT color themes. Roderick -- "Feel free" - 10 GB Mailbox, 100 FreeSMS/Monat ... Jetzt GMX TopMail testen: http://www.gmx.net/de/go/topmail

2 2

patchwatcher status: still coming up (ouch)
by Dan Kegel 05 Nov '08

05 Nov '08

The new patchwatcher is sort of up; I'm focusing on things like getting the load balancing and blacklist right before I even think about email output. You can look at the results at http://kegel.com/wine/patchwatcher/results2/ but they will probably not be very reliable for a few more days. (And if anybody wonders why the heck I'm looking at this at 4AM, it's because my 5 year old climbed into our bed upside-down a few minutes ago and kicked me out in his sleep. Those little legs can do a lot of damage when they're aimed at your head :-)

1 0

Re: server: Do not cast zero.
by Henri Verbeet 05 Nov '08

05 Nov '08

2008/11/4 Michael Stefaniuc <mstefani(a)redhat.de>: > --- > server/console.c | 2 +- > server/trace.c | 130 +++++++++++++++++++++++++++--------------------------- > 2 files changed, 66 insertions(+), 66 deletions(-) > server/trace.c is mostly auto generated, you'd have to modify tools/make_requests (line 341) instead.

2 1

Re: [PATCH 2/4] advapi32/tests: Simple tests of GetFileSecurity()/SetFileSecurity()
by James Hawkins 05 Nov '08

05 Nov '08

On Wed, Nov 5, 2008 at 1:01 AM, Paul Bryan Roberts <pbronline-wine(a)yahoo.co.uk> wrote: > This is a resubmission > > This patch has been reworked. > The changes in the Wine server is withdrawn. > Only a minimum of tests of GetFileSecurity() and SetFileSecuirty() for the > 'file case' are provided. > I haven't tried these tests myself, but as your are writing tests for your fixes, I can't imagine that these tests actually pass. If the tests fail, you have to wrap them in todo_wine. You can find examples of this all over the code base. -- James Hawkins

1 0