November 2008 - Wine-devel - list.winehq.org

Re: [1/3] xinput: Initial implementation of xinput xbox 360 joystick library
by Alexandre Julliard 07 Nov '08

07 Nov '08

"Andrew Fenn" <andrewfenn(a)gmail.com> writes: > +BOOL WINAPI DllMain(HINSTANCE inst, DWORD reason, LPVOID reserved) > +{ > + switch(reason) > + { > + case DLL_WINE_PREATTACH: > + return FALSE; /* prefer native version */ You need to do that for all the dlls, not just the 1_3 one. Also please send one patch per dll. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: d3dx9: Implement ID3DXSprite_Begin/End [PATCH 3/5]
by Alexandre Julliard 07 Nov '08

07 Nov '08

Tony Wasserka <tony.wasserka(a)freenet.de> writes: > + /* About This->flags: > + != D3DXSPRITE_FLAGLIMIT+1 means we have already called ID3DXSprite_Begin > + == D3DXSPRITE_FLAGLIMIT+1 means we have either called D3DXCreateSprite or ID3DXSprite_End > + In the first case we return D3DERR_INVALIDCALL, in the other one we can continue. > + For ID3DXSprite_Flush/Draw This->flags must be < D3DXSPRITE_FLAGLIMIT+1. */ > + if(flags>D3DXSPRITE_FLAGLIMIT || This->flags!=D3DXSPRITE_FLAGLIMIT+1) > + return D3DERR_INVALIDCALL; That's ugly, if you need to know if Begin has been called you should store a separate flag for that. -- Alexandre Julliard julliard(a)winehq.org

1 0

Launchpad Bugzilla plugin can allow us to share comment histories for forwarded bugs
by Scott Ritchie 06 Nov '08

06 Nov '08

There's a launchpad bugzilla plugin available now, made by bugzilla developers: https://help.launchpad.net/Bugs/BugzillaPlugin Having this seems like it would simplify things, as there wouldn't be a need to forward comments on a launchpad bug to the one posted at WineHQ. It can be quite annoying checking both pages once a bugzilla bug and a launchpad bug are linked to eachother. Thoughts? Thanks, Scott Ritchie

2 1

Re: [2/3] comctl32: toolbar: Improve text layout in TBSTYLE_LIST toolbars.
by Paul Vriens 06 Nov '08

06 Nov '08

Sergey Khodych wrote: > > > ------------------------------------------------------------------------ > > Sorry for the previous email (replied to the wrong patch email). Hi, Could you have a look at http://test.winehq.org/data/3f4333d70c27a813b4d99e0daeeb613e9e941a9a/ as this patch introduced a failure on all Windows platforms. I guess it's just changing 183 to 185. But that 183 is there for a reason, not? -- Cheers, Paul.

1 0

Re: [1/3] comctl32: toolbar: Calculate a correct size for empty buttons with the BTNS_AUTOSIZE style.
by Paul Vriens 06 Nov '08

06 Nov '08

Sergey Khodych wrote: > > > ------------------------------------------------------------------------ > > Hi, Could you have a look at http://test.winehq.org/data/3f4333d70c27a813b4d99e0daeeb613e9e941a9a/ as this patch introduced a failure on all Windows platforms. I guess it's just changing 183 to 185. But that 183 is there for a reason, not? -- Cheers, Paul.

1 0

Re: mshtml: Implement IHTMLStyle get/put posLeft (try 8)
by Jacek Caban 06 Nov '08

06 Nov '08

Alistair Leslie-Hughes wrote: > Hi, > Made functions for get/set. > > Changelog: > mshtml: Implement IHTMLStyle get/put posLeft + for(ptr=value; isdigitW(*ptr); ptr++) + { + if(*ptr && !strcmpW(ptr, pxW)) { This if expression will never be true. You should move it after for loop and change !strcmpW to strcmpW. Jacek

1 0

Re: winmm: Increase tolerance range in tests
by Alistair Leslie-Hughes 06 Nov '08

06 Nov '08

Hi Robert -------------------------------------------------- From: "Robert Reif" <reif(a)earthlink.net> Sent: Thursday, November 06, 2008 11:00 PM To: "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> Cc: <wine-devel(a)winehq.org> Subject: Re: winmm: Increase tolerance range in tests >> > On real hardware or on a virtual machine? The data I was looking at comes from http://test.winehq.org/data/ Some of these will be virtual machines but I cannot tell. Best Regards Alistair Leslie-Hughes

1 0

patchwatcher status: online but no email
by Dan Kegel 06 Nov '08

06 Nov '08

Patchwatcher is now working well enough to depend on, I think, but doesn't send email yet. You should see your patch appear at http://kegel.com/wine/patchwatcher/results under a minute after you post, and if your patch is simple, test results should show up about ten minutes later. (Long patch series take longer, since patchwatcher runs the test suite after each patch in the series.) Today's changes (from http://code.google.com/p/winezeug/source/list ): - Update the dashboard immediately upon receiving patches. - Added qmgr timeout and winhttp:notification.c to blacklist. Full blacklist at http://winezeug.googlecode.com/svn/trunk/patchwatcher/blacklist.txt Please fix your tests so I don't have to blacklist them. (The d3d tests should start passing once I move to the latest nvidia drivers, so don't worry about them.)

2 3

What happened to __TRY?
by Michael Ost 06 Nov '08

06 Nov '08

Hi all, When I upgraded wine-develfrom 1.0 to 1.1.7, my winelib app that uses __TRY no longer links. It complains that RtlUnwind cannot be found. I can see that RtlUnwind was added to wine/exception.h, but I am not sure how to fix it. I tried adding -lntdll and -lwine to the link command line but it didn't help. Any suggestions? Thanks! ... mo PS: Here's the linker line I am using and the error returns... wineg++ -DNDEBUG=1 -O3 -DBOOST_POSIX_API -DBOOST_POSIX_PATH -DALSA=1 -DMUSE_SSE -Wall -Werror -D__STDC_LIMIT_MACROS=1 -I/home/most/Desktop/cvs/muse/receptor2/rm-host -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/hotspot -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/medioid -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/uniwire -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/muselock -I/home/most/Desktop/cvs/muse/receptor2/rm-host/../../../external/vst/vstsdk2.4 -I/usr/include/xmlwrapp -I/usr/include/libxml2 -Wb,--3gb -o rm-host.exe.so ChildView.o IsFileOpen.o SerialDevice.o SystemInterface.o Alert.o AudioFader.o AutoAddPage.o Balancer.o BankButton.o BankPatch.o BankPatchPanel.o BufferSizePanel.o BypassPanel.o ChannelDetail.o ChannelStrip.o CopyPanel.o CopyPatchPanel.o CopySwitch.o CPUGauge.o DeletePanel.o Dial.o DualCorePanel.o EditorMenu.o EditPage.o EditParametersPanel.o EditStrip.o EffectPage.o FacelessPage.o FrontPanel.o FrontPanelPage.o GeberDevice.o GeberFrontPanel.o GuitarMonitor.o HostApp.o Host.o HostHandleMidi.o HostInput.o HostLevels.o HostMixer.o HostPage.o HostPlugin.o HostPluginList.o HostPluginOutput.o HostTrack.o Icon.o InformationPanel.o InitializePanel.o InputLevelPanel.o InstallPanel.o InstStrip.o ListenToMidiPanel.o LoadBlankPanel.o LockPanel.o MasterStack.o MetersPanel.o MidiFilterPopup.o MidiMonitorPanel.o MixerStatus.o MixPage.o MultiPage.o MutePanel.o Navigation_hotspot.o OneColumnPopup.o OutputAssignmentPanel.o OutputPopup.o OtherProgramChangesPanel.o PanelParameters.o PanicPanel.o ParameterPanel.o PatchButton.o PatchReport.o PluginControllersPanel.o PluginMenu.o PluginPanel.o PluginsToIgnore.o PluginTypePanel.o Preferences.o PrePostPanel.o ProgramChannelPanel.o ProgramChangeModePanel.o ReceptorAudioControl.o ReceptorNamePanel.o ReceptorXmlRpc.o RemapPanel.o RenamePanel.o RenamePatchPanel.o ReorderPopup.o RoutePanel.o RouteStack.o SampleClockPanel.o SampleClockPopup.o SampleRatePanel.o SampleRatePopup.o SavePatch.o SavePatchPanel.o SelectChannelPanel.o SendStack.o SendStrip.o SetupPage.o SignalLevel.o SinglePage.o SoloPanel.o SourcePage.o SwitchPanel.o TcpipPanel.o TempoAndTransport.o TempoPanel.o TempoPopups.o TempoSourcePanel.o TimeSignaturePanel.o TrackNamePopup.o TrackStack.o TransposePanel.o TransposePopup.o UninstallPluginsPanel.o UninstallPopup.o UniWirePanel.o UniWireXmlRpcServer.o UnsupportedPlugins.o ViewBankPanel.o ViewBar.o ViewPopup.o VstSettingsCache.o VstSettings.o XmlRpcServer.o XmlSupport.o ZloadPanel.o ZombiePlugins.o ZonePanel.o /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/uniwire/wine-release/libuniwire.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/medioid/wine-release/libmedioid.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/hotspot/wine-release/libhotspot.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/muselock/wine-release/libmuselock.a /home/most/Desktop/cvs/muse/receptor2/rm-host/../../../muse/libraries/muselock/source/win32/PlugInLib.a -ldl -lrt -lasound -lpng -lusb -lcomdlg32 -lxml2 -lxslt -lxmlwrapp -lboost_filesystem -lboost_thread-mt -lgdi32 -lshell32 HostApp.o: In function `__wine_exception_handler(_EXCEPTION_RECORD*, _EXCEPTION_REGISTRATION_RECORD*, _CONTEXT86*, _EXCEPTION_REGISTRATION_RECORD**)': HostApp.cpp:(.text+0x4cb): undefined reference to `RtlUnwind(void*, void*, _EXCEPTION_RECORD*, void*)' HostMixer.o: In function `__wine_exception_handler(_EXCEPTION_RECORD*, _EXCEPTION_REGISTRATION_RECORD*, _CONTEXT86*, _EXCEPTION_REGISTRATION_RECORD**)': HostMixer.cpp:(.text+0x60b): undefined reference to `RtlUnwind(void*, void*, _EXCEPTION_RECORD*, void*)' collect2: ld returned 1 exit status winegcc: g++ failed

5 6

Re: winmm: Increase tolerance range in tests
by Robert Reif 06 Nov '08

06 Nov '08

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > winmm: Increase tolerance range in tests > > Best Regards > Alistair Leslie-Hughes > Please give an explanation why? If it's just to make the test pass, then we need to know why the test is failing. Is it only needed for wine? Could be a wine problem. Is it only needed for specific versions of Windows or specific hardware or drivers? Is it only needed for Windows running on a virtual machine? Then it could be a a virtual machine hardware emulation problem. I think all Windows hardware test failures that only happen on virtual machines should be considered suspect. It would be nice to detect if Windows is running on real hardware or a virtual machine because of this type of problem.

4 4