December 2008 - Wine-devel - list.winehq.org

Re: [PATCH 5/6] dinput: Fix usage of HeapReAlloc.
by Alexandre Julliard 28 Dec '08

28 Dec '08

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > + if (!have_joydevs) > + joydevs = HeapAlloc(GetProcessHeap(), 0, sizeof(struct JoyDev)); > + else > + joydevs = HeapReAlloc(GetProcessHeap(), 0, joydevs, (1 + have_joydevs) * sizeof(struct JoyDev)); > + > + if (!joydevs) > + { > + close(fd); > + continue; > + } While you are fixing it you should fix it properly by preserving the old pointer on failure. -- Alexandre Julliard julliard(a)winehq.org

2 1

wined3d: Do not treat oversized textures as failure
by Vincent Pelletier 28 Dec '08

28 Dec '08

Hi. Attached patch is enough to cure the failure in "Operation Flashpoint" when its menu is displayed on my little i945GM card. As the oversised case is (was) explicitely treated as a failure, I think there is some reasone for it. Does someone remember what it is for ? Regards, -- Vincent Pelletier

3 9

Re: xinput: Add stub XInputEnable
by Henri Verbeet 28 Dec '08

28 Dec '08

2008/12/28 Andrew Fenn <andrewfenn(a)gmail.com>: > +void WINAPI XInputEnable(bool enable) Does this compile? "bool" is a C++ type. Also, don't forget to add the prototype to the header, I noticed they're missing for all the other xinput functions as well.

4 6

Re: [RFC] wined3d: Avoid triggering OPENGL errors when setting point size
by Vincent Pelletier 28 Dec '08

28 Dec '08

Woops, re-sending to list this time... On Wed, Dec 24, 2008 at 4:01 PM, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > I think henri sent a reply. He recommended to clamp the new pointsize > instead of leaving the old one set. Found it. Wasn't subscribed here at that time (only to -patches). New version of previous patch is attached. > Of course a test would be interesting too, to see how windows behaves here. I'm not sure where to add it. I've added some line in d3d9/tests/visual.c:pointsize_test (attached too). As I wrote that test to succeed on wine and did not run it on any windows version, I would be happy if someone could try it. Note that this patch also contains a change from fix explained below (I'm not used to git enough yet to split patches...). Also, runing that test I had an unrelated failure in autogen_mipmap_test because texture creation failed in IWineD3DDeviceImpl_CreateTexture due to SFLAG_OVERSIZE being set at D3DCB_CreateSurface return. As I guess IWineD3DDeviceImpl_CreateTexture should then return a failure code, I patched it and made the test give up if texture allocation failed. (patch attached) I'm not sure if I chose the right error code. From MSDN, it can return: D3DERR_INVALIDCALL, D3DERR_OUTOFVIDEOMEMORY, E_OUTOFMEMORY If this change is OK, I will submit it separately from pointsize clamping. -- Vincent Pelletier

1 2

Re: wined3d: Make WARN about oversized texture output surface and texture sizes
by Henri Verbeet 28 Dec '08

28 Dec '08

2008/12/28 Vincent Pelletier <plr.vincent(a)gmail.com>: > + WARN("(%p) Creating an oversized surface: %ix%i\n", This, This->pow2Height, This->pow2Width); pow2Height and pow2Width are unsigned, so you'd want to use %u there.

2 1

Re: Assorted spelling fixes.
by Henri Verbeet 28 Dec '08

28 Dec '08

2008/12/28 Francois Gouget <fgouget(a)free.fr>: > - FIXME("No free constant found to load environemnt bump mapping matrix into the shader. texbem instruction will not apply bump mapping\n"); > + FIXME("No free constant found to load environement bump mapping matrix into the shader. texbem instruction will not apply bump mapping\n"); Shouldn't that be "environment"?

1 0

winecfg: Add dll override on return key press in combobox [resend]
by Andre Wisplinghoff 28 Dec '08

28 Dec '08

Thanks a lot for your hints, Reece and Dmitry. I didn't realize the difference between WndProcs and DlgProcs. I send a new try and hope everything is okay now :) http://www.winehq.org/pipermail/wine-patches/2008-December/066762.html -- Andre

1 0

Combining Fuse and Wine - What's the best way?
by Richard Stitz 28 Dec '08

28 Dec '08

I'm writing a program in which I have a Windows DLL that I need to load. The DLL contains a function that returns a pointer to some data, and I want to expose that data as file data in a Fuse file system. My first thought was that I could have the program load the DLL using winelib, but I'm not sure what's involved in this and whether the resulting program could also use the Fuse libraries. I'm a bit of a novice to Wine, and Linux programming in general, so I'd appreciate any expert opinions you guys have about the best way to do this. Thanks in advance, Richard

3 8

wine.budgetdedicated.com down?
by Dustin M. Jackson 28 Dec '08

28 Dec '08

Hi Scott, I'm trying to install Wine, but I cannot connect to the server. Just thought I would let you know. Regards, Dustin

1 0

Minimal patches to try win64?
by Dan Kegel 27 Dec '08

27 Dec '08

Out of curiosity, I finally bit the bullet, installed 64 bit Ubuntu 8.10, updated http://wiki.winehq.org/Wine64 to show how to build gcc, and built wine with win64 support enabled. It built successfully on the first try, but starting any conformance test or win64 app fails with wineserver: request.c:744: open_master_socket: Assertion `sizeof(union generic_request) == sizeof(struct request_max_size)' failed. I tried grabbing the patch that seems to fix that, http://repo.or.cz/w/wine/wine64.git?a=commitdiff_plain;h=6e77a4879d5e62a977… but then I got other errors. What's the minimal set of patches needed to start trying win64? I'd rather not pull Maarten's whole repo, I have no idea how closely that tracks winehq... - Dan

1 0