December 2008 - Wine-devel - list.winehq.org

USB device drivers support
by Alexander Morozov 01 Dec '08

01 Dec '08

Hello, I sent patch "Add support of WDM drivers for USB devices." in October and received such reply from Alexandre Julliard: > Your design needs a lot more thought. You can't add all these > Wine-specific modules, or make winedevice special-case usb devices, or > poll the server for the add_device request like you do. All this needs > to be properly integrated in the existing infrastructure. I`d like to ask about better way of modifying patches which add USB device drivers support before doing something. Wineusb and wineusbhub can be moved to usbhub.sys. This driver creates a device which is used as second argument for AddDevice on Windows XP. So no wine-specific modules will be added. Using wineserver to call AddDevice can be avoided if move code which loads device drivers and code which enumerates devices and call AddDevice to one process. This can be made if use one winedevice process for all drivers. This will allow every driver to use IRP, DEVICE_OBJECTs and other structures created by other driver and will help to implement such functions as IoGetDeviceObjectPointer. Can I do so? Or there are some reasons which do not allow? Thanks, Alexander

1 0

Re: [advapi32/tests] Fix some crashes on NT4 (Try2)
by Paul Vriens 01 Dec '08

01 Dec '08

On Sat, Nov 29, 2008 at 12:52 PM, Paul Vriens <paul.vriens.wine(a)gmail.com> wrote: > Hi, > > (Try2 removes some useless LocalFree's when NewAcl is NULL, duh). > > NT4 crashes at 3 distinct places. The first two we can get rid of by > removing > the LocalFree on failure. The third one we can skip as we can detect NT4 > easily. > Just to be a little bit more precise. NT4 doesn't crash at those LocalFree's but leaving either of them in will make sure the test crashes a bit later. -- Cheers, Paul.

1 0

Error Message and Office 2000
by SWEETSKY＠ROCKETMAIL.COM 01 Dec '08

01 Dec '08

Hi, I'm in Southern California. I did a search for the event when my Office 2000 Professional gave me an error message. It won't setup. The event was 1000 and the fault address is the same as a read out of your computer that you posted online. http://www.winehq.org/pipermail/wine-devel/2003-July/018313.html Did you ever figure out how to get it to work? Thanks! Ciao! Connie

2 1

Re: ole32: implement CoGetCallContext and CoSwitchCallContext
by Rob Shearman 01 Dec '08

01 Dec '08

2008/11/30 Austin English <austinenglish(a)gmail.com>: > + if( !ppv) > + return E_INVALIDARG; > + > + /* get COM tls */ > + info = COM_CurrentInfo(); > + if( !info) Please try to keep the style consistent here. The style that the rest of the file uses is a space after the "if" and no space inside the brackets. > + return E_OUTOFMEMORY; > + > + hr = RPC_E_CALL_COMPLETE; > + if( info->ctx_call) > + { > + hr = IUnknown_QueryInterface( info->ctx_call, riid, ppv); > + } > + > + if (FAILED(hr)) ... > + /* Receives a pointer to the call context object of the call currently > + in progress. This value is returned so that the original call context > + can be restored by the custom marshaller. > + The returned pointer will be NULL if there was no call in progress. */ > + *ppOldObject = info->ctx_call; > + > + /* It may be NULL if you are calling CoSwitchCallContext to switch back > + to the original call context and there was no original call context. */ > + info->ctx_call = pNewObject; You don't take a reference to the object that is passed-in. This is against COM semantics and so requires a test case to prove that this is indeed what the function does. -- Rob Shearman

1 0

Re: X11DRV: GetKeyNameTextW returns a wrong length
by Vincent Povirk 01 Dec '08

01 Dec '08

I don't think "lpBuffer[nSize - 1] = 0;" is safe to remove. If nSize is too small, the resulting string may not be NULL-terminated. Patch-sending guidelines are at http://www.winehq.org/site/sending_patches. Your patch is more likely to be committed if you write a conformance test (although it may be enough in this case to send a patch that obviously works, since this is documented behavior). The appropriate place for that in the wine source is probably dlls/user32/tests. See http://www.winehq.org/site/docs/winedev-guide/testing for guidelines on conformance tests. Vincent Povirk On Thu, Nov 27, 2008 at 3:42 PM, Nils Hoyer <Privat(a)nils-hoyer.de> wrote: > http://bugs.winehq.org/show_bug.cgi?id=16195#c0 > > > This is my first sending of a Wine patch - and first usage of a patch at > all. I'm sorry, if I made any mistake... > > > GetKeyNameTextW results a 1 instead of a the lengh of the Text. This patch > fixes this bug. > > --- keyboard.old 2008-11-27 16:53:15.000000000 +0100 > +++ keyboard.c 2008-11-26 21:19:01.000000000 +0100 > @@ -2328,11 +2328,7 @@ > TRACE("found scan=%04x keyc=%04x keysym=%04x string=%s\n", > scanCode, keyc, (int)keys, name); > if (lpBuffer && nSize && name) > - { > - MultiByteToWideChar(CP_UNIXCP, 0, name, -1, lpBuffer, nSize); > - lpBuffer[nSize - 1] = 0; > - return 1; > - } > + return MultiByteToWideChar(CP_UNIXCP, 0, name, -1, lpBuffer, nSize) > - 1; > } > > /* Finally issue WARN for unknown keys */ > > > >

2 1