February 2008 - Wine-devel - list.winehq.org

[PATCH] Environment variable to specify X11 window for desktop
by Timothy Lee 13 Feb '08

13 Feb '08

Dear all, The attached patch allows the WINE desktop to be embedded within an existing X11 window, and is similar to the windowed mode in WINE. I've tested this feature using MS PowerPoint Viewer 2007, so that a fullscreen slideshow can be fitted inside any X11 window. Regards, Timothy Lee

2 1

Re: user32: correct the caption bar and it's buttons' sizes
by Peter Oberndorfer 13 Feb '08

13 Feb '08

On Mittwoch 13 Februar 2008, Divan Burger wrote: > What is the problem without the patch? is the caption bar drawn too high 1 pixel? I ask because i have a patch that restores the 1 pixel high line between the caption bar and the client area (and at the same time decreases the height of the caption bar) see it attached for the NC_DrawXXXButton functions: you also need to update hittest calculation else the wrong buttons are activated. For example when you press the mouse down on the left side of the close button, but maximize gets activated > case SM_CYCAPTION: > if (!spi_loaded[SPI_NONCLIENTMETRICS_IDX]) load_nonclient_metrics(); >- return nonclient_metrics.iCaptionHeight + 1; >+ return nonclient_metrics.iCaptionHeight; this breaks a test in sysparams.c:2416 ok_gsm( SM_CYCAPTION, ncm.iCaptionHeight+1); and 5 other tests Greetings Peter

1 0

missed systray patches
by Kirill K. Smirnov 13 Feb '08

13 Feb '08

Hello, Is there anything wrong with the serie of patches? systray[0/4]: systray improvements [try 2] http://www.winehq.org/pipermail/wine-patches/2008-February/049772.html -- Kirill

1 0

Re: Fixing the last failing tests
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

Hello M. What is wrong with detecting the version, and branching the test code accordingly? Other tests do that IIRC. I think that is a better solution, if the version selector in winecfg is still going to be meaningful (registry). How about fixing the functions as well (like IsWindowUnicode), so it returns the correct data according to the version in winecfg (registry). However, i do like the irony in your example :-) /pedro On Tue, 2008-02-12 at 18:09 -0800, Maarten Lankhorst wrote: > Hi all, > > I'm very close to passing the whole wine conformance suite on my pc. > The only tests failing are in user32. These tests are failing in any > version of windows though. How do I make them pass on at least 1 > version of windows and wine? Would patches to make it run on xp and > wine be accepted? > > And if I can succeed with that, how do I make it work with other > versions of windows as well. > > Cheers, > Maarten. > > An example is IsWindowUnicode. It always returns TRUE on XP, but it > won't do that on 9x. That would mean something like: > ok(IsWindowUnicode() || !IsWindowUnicode(), "How can this fail?"); > >

3 2

How is the testsuite built for windows
by Maarten Lankhorst 13 Feb '08

13 Feb '08

Hi all, I'm trying to get the tests to run in windows, but I'm not sure how to build them. Any attempt to do mingw cross compiling fails badly. Who managed to compile all wine tests for windows, and how is it done? Cheers, Maarten.

3 2

Re: [PATCH #1] wininet: Added beginning support for HTTP cache files.
by Robert Shearman 13 Feb '08

13 Feb '08

Jacek Caban wrote: > + /* FIXME: Better check, when we have to create the cache file */ > + if(bSuccess && (lpwhr->hdr.dwFlags & INTERNET_FLAG_NEED_FILE)) { > + WCHAR url[INTERNET_MAX_URL_LENGTH]; > + WCHAR cacheFileName[MAX_PATH+1]; > + BOOL b; > + > + b = HTTP_GetRequestURL(lpwhr, url); > + if(!b) { > + WARN("Could not get URL\n"); > + goto lend; > + } > + > + b = CreateUrlCacheEntryW(url, lpwhr->dwContentLength > 0 ? lpwhr->dwContentLength : 0, NULL, cacheFileName, 0); > + if(b) { > + lpwhr->lpszCacheFile = WININET_strdupW(cacheFileName); > + lpwhr->hCacheFile = CreateFileW(lpwhr->lpszCacheFile, GENERIC_WRITE, FILE_SHARE_READ|FILE_SHARE_WRITE, > + NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL); > + if(lpwhr->hCacheFile == INVALID_HANDLE_VALUE) { > + WARN("Could not create file: %u\n", GetLastError()); > + lpwhr->hCacheFile = NULL; > + } > + }else { > + WARN("Could not create cache entry: %08x\n", GetLastError()); > + } > + } > > It may be beyond the scope of your patch, but you're creating the cache file without committing the entry elsewhere so that it can be found at a later time. According to MSDN, this should be done in HTTP_FinishedReading. -- Rob Shearman

1 0

Re: d3d: Add a slight delay before testing the ddraw and d3d9 visual tests
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

Eh, this does not seem like a proper way to get a unit test to pass. Sleep()... that leads to the dark side! :-) Why does it need a Sleep()? If its failing on Wine, then shouldn't it be fixed in the libs? And if its on orig-winxp-vista then there must be a better way to wait? Or no? The string "This makes the tests pass on my pc" isn't very good either. What system? In general, introducing magic Sleep() values in code is not a good idea. If the test system is stressed, you will start getting failures again = bad idea. /p On Wed, 2008-02-13 at 02:26 +0100, Stefan Dösinger wrote: > Am Mittwoch, 13. Februar 2008 02:25:30 schrieb Maarten Lankhorst: > > This makes the tests pass on my pc. > > d3d8 might need it as well > >

3 2

Re: Patch: create a WinHttpDetectAutoProxyConfigUrl function
by Dmitry Timoshkov 13 Feb '08

13 Feb '08

"Joshua Hudson" <joshudson(a)gmail.com> wrote: > --- wine-0.9.54/dlls/winhttp/winhttp.spec 2008-02-11 20:54:39.000000000 > -0800 > +++ wine-0.9.54/dlls/winhttp/winhttp.spec.bak 2008-02-11 20:52:39.000000000 > -0800 The patch is wrapped. > @@ -8,7 +8,7 @@ > @ stub WinHttpConnect > @ stub WinHttpCrackUrl > @ stub WinHttpCreateUrl > -@ stdcall WinHttpDetectAutoProxyConfigUrl(long ptr) > +@ stub WinHttpDetectAutoProxyConfigUrl And this part seems to be reverted. -- Dmitry.

1 0

Alsa spitting out warnings every time Wine runs.
by Peter Dons Tychsen 13 Feb '08

13 Feb '08

Hi Maarten & Devs. Great to see that audio is so much better in Wine now. But.... On fedora core 6 and 8 i get this every time i start Wine: ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 ALSA lib conf.c:3949:(snd_config_expand) Unknown parameters 0 ALSA lib pcm.c:2145:(snd_pcm_open_noupdate) Unknown PCM default:0 I think its harmless, but what do you it means? How do i stop it? Should i fix it in Wine or Alsa? /p

2 1

Fwd: Congratulation!!!
by Maarten Lankhorst 13 Feb '08

13 Feb '08

Hooray! I won the Microsoft e-mail award! And I thought my wine efforts would go unnoticed, but here I am winning the grand prize! ---------- Forwarded message ---------- From: marinamg(a)esplugues.org <marinamg(a)esplugues.org> Date: 12 feb. 2008 18:33 Subject: Congratulation!!! To: undisclosed-recipients Microsoft Award Team 22 Garden Close,PE9 2YP, London Date: 13th Feb 2008. Finally, Today we announce this year winners of the MICROSOFT E-MAIL AWARD held on the 13/02/2008, Your Email has won (£1,000,000.00) (CSC) Claims Security Code: CSC-74162007-04-LV-UK,Your Ref: MSC990/678. Contact your Fudiciary agent Mr. Steve Wallace along with your information via email. Sir. John Smith Email: johnsmithm(a)live.com

2 1