February 2008 - Wine-devel - list.winehq.org

Re: Gdiplus: Implement GdipDrawArcI based on GdipDrawArc
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 4:04 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -Added GdipDrawArcI as GdipDrawArc that takes INT arguments > -Added a very similar conformance test to the one I did for GdipDrawArc > -Corresponding change to gdiplus.spec > No patch. -- James Hawkins

1 0

? on Repositories for Unaccept Patches and (work in Progress).
by Joseph Stein 10 Feb '08

10 Feb '08

Is there a Git Repositories for Unaccept Patches or (work in Progress)? If not (which i think is the case and why I posting here instead of the user mailing list.), could you create one(along with a text file explain what need to be done to be accepted)? Here are some reason I think It is Needed. 1.) It would allow developer and users to see what the source done. I have read a very good article about usb support in wine an winehq.org here http://www.winehq.org/?issue=331 wich said that >An ntoskrnl.exe was written a couple of years ago to load drivers, >specifically the Safedisc Windows kernel driver, but it still hasn't been >accepted. Apparently there's some low-level internal Wine issues >and Alexandre wants those fixed before accepting the patch. 2.) Allow people two git possibly some things work that would other wise not work. using the patch for ntoskrnl.exe that was not accept as an example, (please correct me if i wrong), could possible git some drivers working (usb driver may be?) program to work. which is currently not possible with wine from what i read. Yes It dose cause other wine problem which is not big deal, if you compile and run wine form the source directory from which it is compiled instead of installing it (the multiple wine install way). In other words you code use the patch version of wine just for the program that need the patch to work .(Is it not better to have a broken wine (with partal diver) support, then a stable wine with-out (partal diver) support when The program you are running requires a driver.) 3.)If done right in my humble opinion would help prevent developer from getting discurage becuase all there work has be chuck out the window. Giving more Light to what i said above, What I mean buy "if done right",Is that if a developer(who is looking for something to do) would go look at what patches Have not be accepted (but have almost all basic done) and help the developer git it accepted ,Would in my humble opinion encourage more developer to join which is need for a complicated project such as wine. Basically threat unaccepted patch as bugs(while keeping the patch out of wine), instead of chucking it out the window. This type of thing is done in boost project i be-leave, but I taking it one step further and asking for a text file on "what need to be done to be include which each unaccepted patches". Thank you for any reply, Please forgive me if I got any of what i said above wrong, I'm not a real good developer and only have a real basic idea of wine and have not work on wine because it to confusing to me(but have download and looked at from git Repositories) --------------------------------- Be a better friend, newshound, and know-it-all with Yahoo! Mobile. Try it now.

4 3

Re: Gdiplus: conformance test for GdipDrawLineI in graphics.c
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 3:46 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added conformance test mainly checking for input parameters > You forgot the patch again. -- James Hawkins

1 0

Re: Gdiplus: GdipDrawArc in graphics.c does not return InvalidParameter for bad values of height and width
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 3:19 PM, Royal Chan <chanroyal(a)gmail.com> wrote: > Change Log: > -added two checks for non-positive values of width and height > -added a conformance test for invalid parameters > You forgot the patch. -- James Hawkins

1 0

winecfg improvements
by Reece Dunn 10 Feb '08

10 Feb '08

Hi, I have just submitted 4 patches that make it possible to import a colour theme from winecfg and have it correctly apply the colours. One example is the Ubuntu Human theme (see attachment), adapted from http://tombuntu.com/wp-content/uploads/2008/01/winehumancolours.txt. Enjoy, - Reece

1 0

Re: dlls/gdi32/font.c warning removal (RESEND)
by Alexandre Julliard 10 Feb '08

10 Feb '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > The reason is that we have > > #define HDPTOLP(y) ((y<0)? \ > (-abs(INTERNAL_YDSTOWS(dc, (y)))): \ > (abs(INTERNAL_YDSTOWS(dc, (y))))) > > which is overly complicated for unsigned types. We can avoid these > warnings by using plain INTERNAL_YDSTOWS instead of HDPTOLP here. No, you still need the abs(). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: WineD3D: split framebuffer -> texture path from LoadLocation
by Stefan Dösinger 10 Feb '08

10 Feb '08

Am Sonntag, 10. Februar 2008 17:37:25 schrieb Roderick Colenbrander: > Hi, > > This patch puts the framebuffer -> texture from LoadLocation in a separate > function in a similar way to read_from_framebuffer. It borrows some code > from LoadLocation and read_from_framebuffer. > > Regards, > Roderick Colenbrander You're mixing tabs and spaces in this patch

2 2

Re: Implemented a stub for MsiSetExternalUIRecord in msi.dll
by James Hawkins 10 Feb '08

10 Feb '08

On Feb 10, 2008 1:11 PM, Luke Benstead <kazade(a)gmail.com> wrote: > This unimplemented function causes the .NET framework 3.0 installer to fail > (and also Visual C++ express 8.0) with this patch the installer continues > further before crashing. This is my first ever patch on Wine (and working > with GIT) so I'm sure I've done something wrong, if so I apologize in > advance :) > > diff --git a/dlls/msi/msi.c b/dlls/msi/msi.c > index 643f9cc..9fb6906 100644 > --- a/dlls/msi/msi.c > +++ b/dlls/msi/msi.c > @@ -992,6 +992,7 @@ end: > return state; > } > > + > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > { > INSTALLUILEVEL old = gUILevel; Random whitespace change -> bad. > @@ -1008,6 +1009,18 @@ INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL dwUILevel, HWND *phWnd) > return old; > } > > +/*********************************************************************** > + * MsiSetExternalUIRecord [MSI.@] > + */ > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER puiHandler, > + DWORD dwMessageFilter, LPVOID pvContext, > + PINSTALLUI_RECORD_HANDLER ppuiPrevHandler ) > +{ > + FIXME("%p %08x %p %p", > + puiHandler, dwMessageFilter, pvContext, ppuiPrevHandler); > + return ERROR_CALL_NOT_IMPLEMENTED; > +} > + > INSTALLUI_HANDLERA WINAPI MsiSetExternalUIA(INSTALLUI_HANDLERA puiHandler, > DWORD dwMessageFilter, LPVOID pvContext) > { Used tabs -> bad. > @@ -2452,3 +2465,5 @@ UINT WINAPI MsiAdvertiseScriptA( LPCSTR szScriptFile, DWORD dwFlags, > debugstr_a( szScriptFile ), dwFlags, phRegData, fRemoveItems ); > return ERROR_CALL_NOT_IMPLEMENTED; > } > + > + More random whitespace changes. > @@ -573,6 +576,7 @@ UINT WINAPI MsiAdvertiseScriptW(LPCWSTR, DWORD, PHKEY, BOOL); > UINT WINAPI MsiCloseHandle(MSIHANDLE); > UINT WINAPI MsiCloseAllHandles(void); > INSTALLUILEVEL WINAPI MsiSetInternalUI(INSTALLUILEVEL, HWND*); > +UINT WINAPI MsiSetExternalUIRecord( INSTALLUI_RECORD_HANDLER, DWORD, LPVOID, PINSTALLUI_RECORD_HANDLER); Inconsistent whitespace. The rest of the file does not have spaces after parentheses. -- James Hawkins

1 0

gecko download not robust?
by Dan Kegel 10 Feb '08

10 Feb '08

Hmm. gecko download hung for me once. I saw fixme:urlmon:ProtocolStream_Read Read failed: 800c0008 in the log, which makes me wonder if our download code doesn't handle transient network errors well. Time to get rid of the download, and just bundle gecko outright, I say...

2 1

Re: Is wine reporting the right value for MaxVertexBlendMatrices ?
by Alex Jackson 10 Feb '08

10 Feb '08

> That said, GL_ARB_vertex_blend is not very common. Only MacOS supports it, and > it is software emulated there. The Linux ATI driver used to support it until > ATI switched to a different codebase. So this constant ends up beeing 0 > almost everywhere. The extension was dropped in favor of vertex programs, > since vertex programs appeared shortly after vertex blending and no gl app > was using it at this time. On Windows drivers emulate vertex blending using > vertex shaders. > > I am not sure if 0 is the correct value to return in case of no vertex > blending support. What happens if you set it to 1? 1 would be a reasonable > default as well, because we're still able to transform vertices with one > matrix(ie, unblened transformation). It could also be that this game silently > expects vertex blending to be supported: For one part, all dx8+ cards support > this feature on Windows, and on older cards Windows has software vertex > processing which can perform blending in a slow, but working fashion. > > I have a patch for software emulated vertex blending somewhere, but I dropped > it because I didn't come across an app which uses this function. Maybe its > time to revive it, and continue the work on a fixed function replacement > shader. Even on Windows, no OpenGL implementation that I know of supports GL_ARB_vertex_blend other than ATI's (and as you've pointed out, the new OpenGL stack that the Radeon HD's use on Windows and that all Radeons now use on Linux has dropped it). History lesson: Both GL_ARB_vertex_blend and D3D vertex blending are historically tied to a specific piece of hardware: the original ATI Radeon (GL_ARB_vertex_blend started out as GL_ATI_vertex_blend). Presumably, due to ATI's historically spotty OpenGL driver performance (okay, "historically" is being kind to ATI), any game developer who wanted to use the Radeon's capabilities targeted their game for D3D rather than OpenGL. Consequently, when nVidia released the GeForce 3 (the first video card with vertex shaders) they did implement D3D vertex blending via shaders in their D3D driver (since games were using it, and it wouldn't do if the "new" GF3 couldn't handle effects that the "old" Radeon could), but they didn't bother to implement it in their OpenGL driver, even though ATI had gotten it ARB-approved some months before the GF3 came out, since no games/apps were using it. The other video hardware makers (the few that were left by the DX8 era) followed NV's example: implement D3D vertex blending via shaders or in software (for entry-level and onboard hardware without vertex shaders), but don't bother with GL_ARB_vertex_blend since no one uses it. The upshot is that GL_ARB_vertex_blend is an ARB extension In Name Only; it's effectively ATI-only--and even ATI has abandoned it now. On the other hand, D3D vertex blending is universally available on modern and semi-modern hardware regardless of maker, and it looks like even some D3D9 games still use it instead of using vertex shaders. So it's better for WINE to implement vertex blending via vertex programs rather than depending on GL_ARB_vertex_blend. --AWJ-- _________________________________________________________________

3 2