February 2008 - Wine-devel - list.winehq.org

regression in worms2
by luis.busquets＠ilidium.com 07 Feb '08

07 Feb '08

The same bug happens in Patrician3.exe If you apply the attached patch if should be ok. Please let me know, if that worked also for you.

3 2

Re: systray[2/4]: correctly handle icon addition/deletion
by Kirill K. Smirnov 07 Feb '08

07 Feb '08

В сообщении от Thursday 07 February 2008 02:58:42 вы написали: > Kirill K. Smirnov wrote: > > @@ -71,6 +71,12 @@ struct icon > > static struct tray tray; > > static BOOL hide_systray; > > > > +static BOOL add_icon(NOTIFYICONDATAW *nid); > > +static BOOL modify_icon(NOTIFYICONDATAW *nid); > > +static BOOL delete_icon(const NOTIFYICONDATAW *nid); > > +static BOOL delete_icon_directly(struct icon *icon); > > +static BOOL display_icon(struct icon *icon, BOOL hide); > > + > > /* adaptor code */ > > > > #define ICON_SIZE GetSystemMetrics(SM_CXSMICON) > > I don't see any reason why you need to add forward declarations for all > of these functions. Hmmmm..... It may be an artifact from my development when I need to call them from places before they defined.... Anyway, is it really bad to have them declared here? If so I'll remove it. -- Kirill

2 1

Re: systray[2/4]: correctly handle icon addition/deletion
by Robert Shearman 06 Feb '08

06 Feb '08

Kirill K. Smirnov wrote: > @@ -71,6 +71,12 @@ struct icon > static struct tray tray; > static BOOL hide_systray; > > +static BOOL add_icon(NOTIFYICONDATAW *nid); > +static BOOL modify_icon(NOTIFYICONDATAW *nid); > +static BOOL delete_icon(const NOTIFYICONDATAW *nid); > +static BOOL delete_icon_directly(struct icon *icon); > +static BOOL display_icon(struct icon *icon, BOOL hide); > + > /* adaptor code */ > > #define ICON_SIZE GetSystemMetrics(SM_CXSMICON) > I don't see any reason why you need to add forward declarations for all of these functions. -- Rob Shearman

1 0

Re: systray[1/4]: rewrite tooltips support
by Kirill K. Smirnov 06 Feb '08

06 Feb '08

> Please explain better what you are doing, "rewrite tooltips support" > doesn't say what is changing or why the change is needed (and "rewrite" > is an exaggeration, you are mostly just moving code around). The main issue this patch fixes is an "attempt to set/modify a tooltip to a nonexistent window". This may happen when application modifies tip text while icon is hidden (e.g. when adding initially disabled icon with tooltip). [verbose] The change I did: 1) Store tip text in the icon structure. 2) Move tooltip creation code to the separate function. 3) Immediately bind tooltip to icon window at creation. We can bind empty tooltip text with icon window and further just update text when needed. 4) set_tooltip function was renamed to update_tooltip_text and simplified. Since tooltip support code is relatively small, this was enough for me to exaggeratedly proclaim tooltip support be rewritten ;-) [/verbose] So this ChangeLog is better: Avoid modifying non-existent tooltip windows of non-existent icon windows when application updates tip of hidden icon. -- Kirill

1 0

Re: systray[1/4]: rewrite tooltips support
by Alexandre Julliard 06 Feb '08

06 Feb '08

"Kirill K. Smirnov" <lich(a)math.spbu.ru> writes: > diff --git a/programs/explorer/systray.c b/programs/explorer/systray.c Please explain better what you are doing, "rewrite tooltips support" doesn't say what is changing or why the change is needed (and "rewrite" is an exaggeration, you are mostly just moving code around). -- Alexandre Julliard julliard(a)winehq.org

1 0

Building tests with Visual Studio 2005 Express
by Dan Kegel 06 Feb '08

06 Feb '08

After giving up for the moment on building with Visual C 6, I tried Visual Studio 2005. First hitch: Boy, does it spew out lots of warnings about deprecated functions! http://forums.microsoft.com/MSDN/ShowPost.aspx?PostID=87401&SiteID=1 talks about this a bit; defining _CRT_SECURE_NO_DEPRECATE and _CRT_NONSTDC_NO_DEPRECATE suppresses the warnings. Fix: You can't set them via corewin_express.vsprops because our project is converted from an older visual studio version, so you have to add those two defines to all the .dsp files, e.g. perl -p -i -e 's,/D "WIN32",/D "WIN32" /D "_CRT_NONSTDC_NO_DEPRECATE" /D "_CRT_SECURE_NO_DEPRECATE",' `find . -iname '*.dsp'` Second hitch: For some reason, the imported projects lose their list of .lib files to link against. Fix: As suggested at http://msdn2.microsoft.com/en-us/express/aa700755.aspx add user32.lib gdi32.lib winspool.lib comdlg32.lib advapi32.lib shell32.lib ole32.lib oleaut32.lib uuid.lib to the "Additional Dependencies" setting in the file corewin_express.vsprops. Third hitch: error C2065: 'PFORM_INFO_2A': undeclared identifier See http://msdn2.microsoft.com/en-us/library/aa383745(VS.85).aspx and http://blogs.msdn.com/oldnewthing/archive/2007/04/11/2079137.aspx winspool.h only defines the new symbol if NTDDI_VERSION is NTDDI_LONGHORN or higher. NTDDI_LONGHORN is 0x06000000. Fix: add /D _WIN32_WINNT=0x0600 to that list of changes to all the .dsp files in hitch #1 above. Fourth hitch: urlmon_test.exe refers to CLSID_IdentityUnmarshal, but that symbol is not defined. ?? Fifth hitch: generated.c refers to CS_STUB_INFO, which is not defined in Microsoft's rpcndr.h. ?? Sixth hitch: it can't find server.h Seventh hitch: can't find tmarshal.h Fix: Not sure, but maybe these files need to be generated by midl, and msvcmaker doesn't know about that yet? See http://www.mail-archive.com/wine-devel(a)winehq.org/msg37442.html Eighth hitch: riched20/tests/editor.c fails to compile because in GETTEXTEX, the field is named lpUsedDefChar, not lpUsedDefaultChar Fix: fix our richedit.h? ... Seventy-seventh hitch: gdiplus/tests/brush.c includes Microsoft's gdiplus.h, but that's not safe to include from C, so you get an error on the namespace. Golly. I guess I won't be building the tests with any flavor of microsoft C any time soon! - Dan

5 6

Re: added wgl_bind_to_texture_depth_nv to ConvertAttribWGLtoGLX
by Chris Robinson 06 Feb '08

06 Feb '08

On Wednesday 06 February 2008 11:44:58 am you wrote: > Chris Robinson wrote: > > I don't think it's correct to add this since it's not supported (the > > extension string isn't exported and it can't be easilly emulated). If an > > app is trying to set that attribute without the extension being > > advertised, I'd say the app is broken. If you're intending on adding > > support, you may want to familiarize yourself with how wine emulates > > render_to_texture and look over the extension: > > http://opengl.org/registry/specs/NV/render_depth_texture.txt > > "I don't think it's correct to add this since it's not supported" > The > > case WGL_BIND_TO_TEXTURE_RGB_ARB: > case WGL_BIND_TO_TEXTURE_RGBA_ARB: > case WGL_BIND_TO_TEXTURE_RECTANGLE_FLOAT_R_NV: > are not supported either. The WGL_BIND_TO_TEXTURE_DEPTH_NV came up as a > fixme since it isn't in the switch. The formats are supported in X11DRV_wglGetPixelFormatAttribivARB, X11DRV_wglCreatePbufferARB and the other render-to-texture functions, and the render-to-texture extension is advertised.. There's just nothing to do in that function for them since the hint will always be accepted. But I don't see the point in supporting a pbuffer creation hint that an app shouldn't be using without the extension being advertised (actually, I think pbuffer creation is supposed to fail if an unsupported attribute is specified). Which app is trying to use it? > Again, just trying to learn, not annoy > people with tiny fixes. No annoyance to me, just explaining why I don't think it's something to handle. :)

1 0

Stupid new winetricks: added a trivial GUI
by Dan Kegel 06 Feb '08

06 Feb '08

Some users freak at the thought of a commandline, so I threw together a trivial GUI using whatever gui-from-shell tool is appropriate for the current desktop. Unfortunately, that means the default action is to put up a gui, not show help. You have to say winetricks -h or the like to get help. It's ugly, so shoot me :-) As always, it's available at http://kegel.com/wine/winetricks and the svn repository is http://code.google.com/p/winezeug/

2 2

Re: RegOverridePredefKey stub - Take 2
by Dmitry Timoshkov 06 Feb '08

06 Feb '08

"Jens Nestler" <nessi(a)nessi-online.de> wrote: > Stub implementation for RegOverridePredefKey. > The added prototype in the winreg.h is now in alphabetical order. Please review yuor patches before sending, this one contains not related changes. -- Dmitry.

1 0

Re: [5/8] WineD3D: Add infrastructure for faking driver versions
by Alexandre Julliard 06 Feb '08

06 Feb '08

Stefan Dösinger <stefan(a)codeweavers.com> writes: > +/* Certain applications(Steam) complain if we report an outdated driver version. In general, > + * reporting a driver version is moot because we are not the Windows driver, and we have different > + * bugs, features, etc. > + * > + * Some drivers(ATI, Nvidia Linux drivers) have a shared codebase with the Windows driver, so we're > + * reading the Linux driver version and report it to the app. Some drivers(Apple drivers, Mesa) don't > + * have the version match, so we overwrite the OpenGL driver version with a hardcoded one. Obviously > + * the hardcoded driver version is outdated once a new Windows driver is released, so we'll have to > + * keep them in sync manually. > + * > + * If a card is not found in this table, the gl driver version is reported > + */ > +struct driver_version_information { > + WORD vendor; /* reported PCI card vendor ID */ > + WORD card; /* reported PCI card device ID */ > + BOOL loword_matches_apple; /* Are Mac and Win driver versions matching? */ > + BOOL loword_matches_linux; /* Are Lin and Win driver versions matching? */ The world is not limited to Mac and Linux, this sort of thing can't scale. -- Alexandre Julliard julliard(a)winehq.org

3 6