February 2008 - Wine-devel - list.winehq.org

Re: uxtheme: fix the system tests so they pass on Vista. [try 2] [RESEND]
by Alexandre Julliard 06 Feb '08

06 Feb '08

"Reece Dunn" <msclrhd(a)googlemail.com> writes: > The Vista return code is what wine is returning, so remove the todo > block as well. Not for me: ../../../tools/runtest -q -P wine -M uxtheme.dll -T ../../.. -p uxtheme_test.exe.so system.c && touch system.ok system.c:420: Test failed: Expected E_POINTER or S_OK, got 0x80070490 make: *** [system.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

winedbg - using pdb from Visual Studio 2005
by Michel Jacques 06 Feb '08

06 Feb '08

Hello, I am using PDBs generated with 2005 with wine version 0.9.54. I get errors related to my PDBs and I am wondering if I need to change the pdb format? Anything special to do when using 2005? Here are the errors I get, each time one of my pdb gets loaded: 0009:trace:dbghelp:SymFindFileInPathW (hProcess = 0x30, searchPath = (null), full_path = L"C:\\master\\x86\\debug\\bin\\mydll.pdb", id = 0x34c160, two = 0x00000002, three = 0x00000000, flags = 0x00000008, buffer = 0x34b718, cb = 0x6020fb50, user = 0x34bd30) 0009:err:dbghelp_msc:pdb_process_types -Unknown type info version 20040203 0009:err:dbghelp_msc:pe_load_debug_directory Got a page fault while loading symbols 0009:trace:dbghelp:pcs_callback 0x111998 2 0x34c378 0009:trace:dbghelp:pcs_callback 0x111998 1 0x34c378 0009:trace:dbghelp:pe_load_stabs failed to load the STABS debug info Thanks, Michel Jacques Découvrez les styles qui font sensation sur Yahoo! Québec Avatars. http://cf.avatars.yahoo.com/

4 5

Re: [winetest] Add a new utility to simply running + submitting tests via winetest when run from the Wine tree.
by Alexandre Julliard 06 Feb '08

06 Feb '08

Jeremy White <jwhite(a)winehq.org> writes: > +date +%Y%m%d >build.id > +gcc --version >build.nfo > +uname -a >>build.nfo > +/lib/libc.so.6 >>build.nfo > +echo N/A >tests.url > +make dist > +make > +export WINEPREFIX=`mktemp -d` > +wineprefixcreate > + > +type winetricks >/dev/null 2>&1 > +if [ $? -eq 0 ] ; then > + winetricks gecko > +fi > + > +./winetest-dist -c -t "$1" None of that should be necessary. The make dist stuff is supposed to be for people who want to distribute a winetest binary. If what you want is simply run the tests then you should just have to run winetest; if some things don't work in that mode they should be fixed. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Bug in patch winex11.drv: Don't create a win_data structure for the desktop window, except in the process that owns it.
by Vitaliy Margolen 06 Feb '08

06 Feb '08

What bug # is this? Please note this is not bugzilla, you will be expected to debug this problem yourself and provide technical information. Vitaliy Luis C. Busquets Pérez wrote: > There is a bug in the patch: > > c19af910ebafa9b1928b0f67bee68f6b0b237e8e is first bad commit > commit c19af910ebafa9b1928b0f67bee68f6b0b237e8e > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Thu Jan 17 19:53:59 2008 +0100 > > winex11.drv: Don't create a win_data structure for the desktop > window, except in the process that owns it. > > Handle desktop size changes by sending a message to the desktop owner. > > :040000 040000 b7c030353fe92121bb999481724a3689429b2e8a > 80fd2c5f4ace2707abb01648bd61663a6c9d7626 M dlls > > > It affects to Patrician3.exe. When initiating, it hangs and does not > allow to play the movie. Actually, the programm changes the screen > resolution and hangs. I understand that the problem is that it does not > send the appropiate message for binkplayer.exe to play the movie. > >

3 2

New winetricks: msxml6, riched30
by Dan Kegel 06 Feb '08

06 Feb '08

Johan Dahlin sent in a patch to add msxml6, and said "It's enough to make msi2xml.exe to at least start-up (before failing in msi later)." Tom Wickline some time ago sent in a suggestion for adding riched30. I didn't know any apps it helped, but apparantly Novell thinks it helps Groupwise a bit. So it's in now. Caution, it doesn't update riched32, no idea what happens if apps try to use it after this... As always, it's available at http://kegel.com/wine/winetricks and the svn repository is http://code.google.com/p/winezeug/

1 0

regression in worms2
by Olaf Leidinger 06 Feb '08

06 Feb '08

Hello! I noticed that the game "worms 2" broke between wine-0.9.53 and wine-0.9.54. A git-bisect revealed the guilty patches. The game includes a frontend.exe which starts game.exe and controls the settings of the game (the map and teams etc.). Running game.exe directly works but you can't alter the settings. When running game.exe via frontend the game doesn't show up but hangs after changing resolution. Before the following commit the game starts and is playable: 2921f5c156b368b4ce6e615eb61dad5c5f423bf8 is first bad commit commit 2921f5c156b368b4ce6e615eb61dad5c5f423bf8 Author: Alexandre Julliard <julliard(a)winehq.org> Date: Tue Jan 22 20:06:35 2008 +0100 server: Invalidate the correct region when custom valid rects are specified. :040000 040000 1385d5899b5b6affd5da84328e1bc15985406976 5c8756013a67c0402f3bb5fb9f3ee7b4a50e124a M server And this one makes worms2 hang after exiting the game: c19af910ebafa9b1928b0f67bee68f6b0b237e8e is first bad commit commit c19af910ebafa9b1928b0f67bee68f6b0b237e8e Author: Alexandre Julliard <julliard(a)winehq.org> Date: Thu Jan 17 19:53:59 2008 +0100 winex11.drv: Don't create a win_data structure for the desktop window, except in the process that owns it. Handle desktop size changes by sending a message to the desktop owner. :040000 040000 b7c030353fe92121bb999481724a3689429b2e8a 80fd2c5f4ace2707abb01648bd61663a6c9d7626 M dlls Thanks for your attention! Ciao, Olaf

3 7

Re: RegOverridePredefKey stub
by Dmitry Timoshkov 05 Feb '08

05 Feb '08

"Jens Nestler" <nessi(a)nessi-online.de> wrote: > diff -urN wine-0.9.54_org/include/winreg.h wine-0.9.54/include/winreg.h > --- wine-0.9.54_org/include/winreg.h 2008-01-25 17:05:38.000000000 +0100 > +++ wine-0.9.54/include/winreg.h 2008-01-28 22:07:55.000000000 +0100 > @@ -131,6 +131,7 @@ > WINADVAPI LSTATUS WINAPI RegLoadKeyA(HKEY,LPCSTR,LPCSTR); > WINADVAPI LSTATUS WINAPI RegLoadKeyW(HKEY,LPCWSTR,LPCWSTR); > #define RegLoadKey WINELIB_NAME_AW(RegLoadKey) > +WINADVAPI LSTATUS WINAPI RegOverridePredefKey(HKEY,HKEY); > WINADVAPI LSTATUS WINAPI RegLoadMUIStringA(HKEY,LPCSTR,LPSTR,DWORD,LPDWORD,DWORD,LPCSTR); > WINADVAPI LSTATUS WINAPI RegLoadMUIStringW(HKEY,LPCWSTR,LPWSTR,DWORD,LPDWORD,DWORD,LPCWSTR); > #define RegLoadMUIString WINELIB_NAME_AW(RegLoadMUIString) Isn't there something that suggests that the entries are alphabetically sorted? -- Dmitry.

2 4

Building tests with MSVC 6 broken?
by Dan Kegel 05 Feb '08

05 Feb '08

Call me an oldtimer, but I decided to try building winetest with MSVC 6 today. I installed cygwin's git and perl, grabbed wine from git, and used msvcmaker as described at http://winehq.org/site/docs/winedev-guide/testing-windows I downloaded and installed the Platform SDK from the first google hit, the Windows Server 2003 SP1 Platform SDK, http://www.microsoft.com/downloads/details.aspx?FamilyId=A55B6B43-E24F-4EA3… (although the latest is Windows Server 2003 R2 Platform SDK, I thought the slightly older one would be ok). Oddly, Microsoft's Platform SDK page lists the SP1 SDK as the latest. Pffft. I then used Tools/ Options / Directories to tell msdev about include and lib in both msvc6 and the platform SDK. Then I tried building wineruntests. First hitch: error C2065: 'RRF_RT_REG_DWORD' : undeclared identifier Fix: Move Platform SDK higher in the priority list in Tools / Options / Directories. msdev will then use the newer headers, which have that symbol. Second hitch: Linking... uuid.lib(cguid_i.obj) : fatal error LNK1103: debugging information corrupt; recompile module Error executing link.exe. Fix: From http://blogs.msdn.com/stephen_griffin/archive/2006/08/03/building-mfcmapi-w… In the platform SDK's lib directory, rename uuid.lib to uuid.lib.bad. msdev will then use the older library. (Microsoft intentionally removed VC6 support from the newer one, whoops.) Third hitch: http://www.winehq.org/pipermail/wine-patches/2007-September/043988.html introduced a type LSTATUS into winreg.h. This isn't present in the 2003 SP1 platform sdk, nor in the newer 2003 R2 platform SDK, but as long as only our winreg.h uses it, that's fine. Sadly, that patch uses it elsewhere, so compilation breaks. A google search for LSTATUS at microsoft.com finds nothing. Fix: change the LSTATUS in comctl32/tests/mru.c to LONG (gee, maybe we should move the definition of LSTATUS from winreg.h to advapi32/registry.c, too). (But see below.) Fourth hitch: comdlg32\tests\printdlg.c: error C2064: 'LPPRINTDLGEXW' : undeclared identifier Turns out commdlg.h in the platform sdk only defines LPPRINTDLGEXW if STDMETHOD is declared. STDMETHOD is declared in basetyps.h, but including that file makes commdlg.h not even compile. Bleah. Fix: replace the #include "windef.h" ... "winuser.h" with #include "windows.h" in comdlg32/tests/printdlg.h. Fifth hitch: crypt32/tests/cert.c: error C2081: 'HCRYPTPROV_OR_NCRYPT_KEY_HANDLE': name in formal parameter list illegal Turns out that identifier was introduced in Vista, and added to Wine here: http://www.winehq.org/pipermail/wine-patches/2007-August/042250.html Fix: Uninstall the platform SDK and install the Windows SDK! http://www.microsoft.com/downloads/details.aspx?familyid=c2b1e300-f358-4523… Sixth hitch: c:\program files\microsoft sdks\windows\v6.0\include\specstrings.h: fatal error C1083: cannot open include file 'sal.h' I think sal.h comes with Visual Studio 8 and higher. Crap. Thus it looks like you can't build wine's tests with Visual C 6 and the Microsoft headers anymore. So I tried building with the Wine headers. That blows up with "can't find stdio.h". So I'm stuck. What's the recommended way to build the wine test suite with Visual C 6, if any? - Dan

3 5

re: [Patch for Bug 8551] MoveFileWithProgressW unconditional fails for directories with flag MOVEFILE_REPLACE_EXISTING
by Dan Kegel 05 Feb '08

05 Feb '08

James McKenzie wrote: > Please submit a git diff not a UNIX diff. Now, hang on there. Jens submitted a perfectly good unified diff patch taken from the right directory. There is no reason to turn up our noses at it. It will apply using patch in exactly the same way as a diff generated by git. Jens, you're fine, I wouldn't bother rediffing. You might however resend your patch next week when Alexandre the maintainer is back from vacation! - Dan

2 1

Re: added wgl_bind_to_texture_depth_nv to ConvertAttribWGLtoGLX
by Chris Robinson 05 Feb '08

05 Feb '08

On Tuesday 05 February 2008 02:09:09 pm Christopher Harvey wrote: > @@ -758,6 +758,7 @@ static int ConvertAttribWGLtoGLX(const int* iWGLAttr, > int* oGLXAttr, Wine_GLPBuf nvfloatattrib = iWGLAttr[++cur]; > TRACE("pAttr[%d] = WGL_FLOAT_COMPONENTS_NV: %x\n", cur, > nvfloatattrib); break ; > + case WGL_BIND_TO_TEXTURE_DEPTH_NV: > case WGL_BIND_TO_TEXTURE_RGB_ARB: > case WGL_BIND_TO_TEXTURE_RGBA_ARB: > case WGL_BIND_TO_TEXTURE_RECTANGLE_FLOAT_R_NV: I don't think it's correct to add this since it's not supported (the extension string isn't exported and it can't be easilly emulated). If an app is trying to set that attribute without the extension being advertised, I'd say the app is broken. If you're intending on adding support, you may want to familiarize yourself with how wine emulates render_to_texture and look over the extension: http://opengl.org/registry/specs/NV/render_depth_texture.txt

1 0