April 2008 - Wine-devel - list.winehq.org

Re: WGL: WGL_WINE_pixel_format_passthrough [attempt 2]
by Alexandre Julliard 23 Apr '08

23 Apr '08

"Roderick Colenbrander" <thunderbird2k(a)gmx.net> writes: > +BOOL X11DRV_wglSetPixelFormatWINE(X11DRV_PDEVICE *physDev, int iPixelFormat, const PIXELFORMATDESCRIPTOR *ppfd) > +{ > + TRACE("(%p,%d,%p)\n", physDev, iPixelFormat, ppfd); > + > + /* When the requested pixel format differs from the physDev its pixel format AND > + * the physDev has a pixel format set, clear current_pf, so that SetPixelFormat > + * will set the pixel format again. */ > + if((physDev->current_pf != 0) && (physDev->current_pf != iPixelFormat)) { > + TRACE("Changing iPixelFormat from %d to %d\n", physDev->current_pf, iPixelFormat); > + physDev->current_pf = 0; > + } You shouldn't set the format to 0 first, this will break if changing to the new format fails for some reason. -- Alexandre Julliard julliard(a)winehq.org

1 0

wine-announce and wine-users getting hammered
by Luke Bratch 23 Apr '08

23 Apr '08

Hi I do the moderation for these lists, and wine-accounce and wine-users are getting absolutely hammered with notification error messages today (in the order of around 15 per minute all day long). I've been clearing these out, but perhaps this is an indication of someone targeting these lists? Luke __________________________________________________________ Sent from Yahoo! Mail. A Smarter Email http://uk.docs.yahoo.com/nowyoucan.html

2 2

Re: gdi32: Make the bitmap test pass under Windows 2000. Take 2
by Paul Vriens 23 Apr '08

23 Apr '08

Dmitry Timoshkov wrote: > Hello, > > here is another version of the patch. > -- > > According to test.winehq.ord data Windows 2000 behaves weird in some tests, > this looks like a bug to me. This patch addresses these failures. > > Changelog: > gdi32: Make the bitmap test pass under Windows 2000. > --- > dlls/gdi32/tests/bitmap.c | 28 ++++++++++++++++------------ > 1 files changed, 16 insertions(+), 12 deletions(-) > > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index f7bfdfd..ba4f8bd 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -276,7 +276,7 @@ static void test_dib_info(HBITMAP hbm, const void *bits, const BITMAPINFOHEADER > { > BITMAP bm; > DIBSECTION ds; > - INT ret, width_bytes; > + INT ret, bm_width_bytes, dib_width_bytes; > BYTE *buf; > > ret = GetObject(hbm, sizeof(bm), &bm); > @@ -285,23 +285,25 @@ static void test_dib_info(HBITMAP hbm, const void *bits, const BITMAPINFOHEADER > ok(bm.bmType == 0, "wrong bm.bmType %d\n", bm.bmType); > ok(bm.bmWidth == bmih->biWidth, "wrong bm.bmWidth %d\n", bm.bmWidth); > ok(bm.bmHeight == bmih->biHeight, "wrong bm.bmHeight %d\n", bm.bmHeight); > - width_bytes = DIB_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > - ok(bm.bmWidthBytes == width_bytes, "wrong bm.bmWidthBytes %d != %d\n", bm.bmWidthBytes, width_bytes); > + dib_width_bytes = DIB_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > + bm_width_bytes = BITMAP_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > + if (bm.bmWidthBytes != dib_width_bytes) /* Win2k bug */ > + ok(bm.bmWidthBytes == bm_width_bytes, "wrong bm.bmWidthBytes %d != %d\n", bm.bmWidthBytes, bm_width_bytes); > + else > + ok(bm.bmWidthBytes == dib_width_bytes, "wrong bm.bmWidthBytes %d != %d\n", bm.bmWidthBytes, dib_width_bytes); > ok(bm.bmPlanes == bmih->biPlanes, "wrong bm.bmPlanes %d\n", bm.bmPlanes); > ok(bm.bmBitsPixel == bmih->biBitCount, "bm.bmBitsPixel %d != %d\n", bm.bmBitsPixel, bmih->biBitCount); > ok(bm.bmBits == bits, "wrong bm.bmBits %p != %p\n", bm.bmBits, bits); > > buf = HeapAlloc(GetProcessHeap(), 0, bm.bmWidthBytes * bm.bmHeight + 4096); > > - width_bytes = BITMAP_GetWidthBytes(bm.bmWidth, bm.bmBitsPixel); > - > /* GetBitmapBits returns not 32-bit aligned data */ > ret = GetBitmapBits(hbm, 0, NULL); > - ok(ret == width_bytes * bm.bmHeight, "%d != %d\n", ret, width_bytes * bm.bmHeight); > + ok(ret == bm_width_bytes * bm.bmHeight, "%d != %d\n", ret, bm_width_bytes * bm.bmHeight); > > memset(buf, 0xAA, bm.bmWidthBytes * bm.bmHeight + 4096); > ret = GetBitmapBits(hbm, bm.bmWidthBytes * bm.bmHeight + 4096, buf); > - ok(ret == width_bytes * bm.bmHeight, "%d != %d\n", ret, width_bytes * bm.bmHeight); > + ok(ret == bm_width_bytes * bm.bmHeight, "%d != %d\n", ret, bm_width_bytes * bm.bmHeight); > > HeapFree(GetProcessHeap(), 0, buf); > > @@ -331,8 +333,9 @@ static void test_dib_info(HBITMAP hbm, const void *bits, const BITMAPINFOHEADER > ok(ret == sizeof(ds), "wrong size %d\n", ret); > > ok(ds.dsBm.bmBits == bits, "wrong bm.bmBits %p != %p\n", ds.dsBm.bmBits, bits); > - ok(ds.dsBmih.biSizeImage == ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight, "%u != %u\n", > - ds.dsBmih.biSizeImage, ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight); > + if (ds.dsBm.bmWidthBytes != bm_width_bytes) /* Win2k bug */ > + ok(ds.dsBmih.biSizeImage == ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight, "%u != %u\n", > + ds.dsBmih.biSizeImage, ds.dsBm.bmWidthBytes * ds.dsBm.bmHeight); > ok(bmih->biSizeImage == 0, "%u != 0\n", bmih->biSizeImage); > ds.dsBmih.biSizeImage = 0; > > @@ -968,14 +971,15 @@ static void test_bitmap(void) > assert(hdc != 0); > > SetLastError(0xdeadbeef); > - hbmp = CreateBitmap(0x7ffffff, 1, 1, 1, NULL); > - ok(hbmp != 0, "CreateBitmap should not fail\n"); > + hbmp = CreateBitmap(0x7fff, 0x7fff, 1, 1, NULL); > + ok(hbmp != 0, "CreateBitmap error %u\n", GetLastError()); > DeleteObject(hbmp); > Hi Dmitry, This one will fail at least on my VMware box. Shouldn't the test (and it's confirmed by James and me) include something like: ok(hbmp!=0 || (hbmp == 0 && GetLastError() == ERROR_NOT_ENOUGH_MEMORY), ....) -- Cheers, Paul.

4 8

Re: Alex Villacís Lasso : uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an appropriately-sized memory bitmap out of the tile instead of iterating with UXTHEME_Blt () directly.
by Frank Richter 23 Apr '08

23 Apr '08

On 22.04.2008 13:47, Alexandre Julliard wrote: > uxtheme: Speed up UXTHEME_SizedBlt in the ST_TILE by building an appropriately-sized memory bitmap out of the tile instead of iterating with UXTHEME_Blt() directly. But does that keep the alpha channel intact? -f.r.

3 3

Wine t-shirts?
by Maarten Lankhorst 23 Apr '08

23 Apr '08

Hi all, Why don't we have wine t-shirts any more? Cheers, Maarten.

1 0

Wine64 : initializer element is not computable at load time?
by Erik de Castro Lopo 22 Apr '08

22 Apr '08

Hi all, I'm compiling wine on x86-64 after configuring with --enable-win64 and I get the error: irotp.c:54: error: initializer element is not computable at load time irotp.c:54: error: (near initialization for 'critsect_debug.Spare[0]') on this this code: 51: static CRITICAL_SECTION_DEBUG critsect_debug = 52: { 53: 0, 0, &csRunningObjectTable, 53: { &critsect_debug.ProcessLocksList, &critsect_debug.ProcessLocksList }, 54: 0, 0, { (DWORD_PTR)(__FILE__ ": csRunningObjectTable") } 55: }; Anybody understand why? Cheers, Erik -- ----------------------------------------------------------------- Erik de Castro Lopo ----------------------------------------------------------------- "I'm not even an atheist so much as I am an antitheist; I not only maintain that all religions are versions of the same untruth, but I hold that the influence of churches, and the effect of religious belief, is positively harmful." -- Christopher Hitchens in "Letters to a Young Contrarian" 2001

2 3

Re: [PATCH 01/21] [WinHelp]: get rid of the reuse concept for Windows and refactor the code a bit for window creation / deletion
by Alexandre Julliard 22 Apr '08

22 Apr '08

Eric Pouech <eric.pouech(a)orange.fr> writes: > programs/winhelp/winhelp.c | 257 ++++++++++++++++++++------------------------ > 1 files changed, 116 insertions(+), 141 deletions(-) This breaks window repaints for me, when switching pages the window is not repainted and still shows the old page. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [PATCH 05/21] [WinHelp]: properly handle the back button (in multiple windows, in empty stack...)
by Juan Lang 22 Apr '08

22 Apr '08

+ * WINHELP_DeleteButtons + * + */ +void WINHELP_DeleteBackSet(WINHELP_WINDOW* win) Nit: the comment should match the function. --Juan

1 0

Re: Spelling fixes
by H. Verbeet 22 Apr '08

22 Apr '08

On 22/04/2008, Austin English <austinenglish(a)gmail.com> wrote: > - /* Declare loop registers aLx */ > + /* Declare loop registers alx */ > for (i = 0; i < reg_maps->loop_depth; i++) { > shader_addline(buffer, "int aL%u;\n", i); > shader_addline(buffer, "int tmpInt%u;\n", i); As can be seen a few lines down, the registers are declared as "aL%u".

1 0

Wine countdown?
by Dan Kegel 22 Apr '08

22 Apr '08

Anybody seen the nifty countdown logo that Ubuntu is using? http://www.ubuntu.com/getubuntu/countdown Maybe we should do something similar for Wine. FWIW, here's a snippet that does something similar, but with text: <h1>Wine Release Countdown</h1> <script type='text/javascript'> function days_between(date1, date2) { // The number of milliseconds in one day var ONE_DAY = 1000 * 60 * 60 * 24; // Convert both dates to milliseconds var date1_ms = date1.getTime(); var date2_ms = date2.getTime(); // Calculate the difference in milliseconds var difference_ms = date2_ms - date1_ms; // Convert back to days and return return Math.round(difference_ms/ONE_DAY); } var d = new Date(); var release = new Date(); // see http://wiki.winehq.org/WineReleasePlan release.setTime(Date.parse("Jun 13, 2008")); document.write('<a href="http://www.winehq.org/">Wine 1.0 countdown: ' +days_between(d, release)+' days to release!</a>'); </script>

3 2