April 2008 - Wine-devel - list.winehq.org

Re: msxml3: Correct transformNode from failing on windows
by Alexandre Julliard 21 Apr '08

21 Apr '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > diff --git a/dlls/msxml3/tests/domdoc.c b/dlls/msxml3/tests/domdoc.c > index 6f790fe..b06e57e 100644 > --- a/dlls/msxml3/tests/domdoc.c > +++ b/dlls/msxml3/tests/domdoc.c > @@ -143,7 +143,11 @@ static const CHAR szTransformSSXML[] = > "</xsl:stylesheet>"; > > static const CHAR szTransformOutput[] = > -"<?xml version=\"1.0\" encoding=\"UTF-8\" standalone=\"yes\"?>\n" > +"<html>\r\n<body>\r\n<h1>\r\n" > +"Hello World\r\n" > +"</h1>\r\n</body>\r\n</html>\r\n"; > + > +static const CHAR szTransformOutputWine[] = > "<html><body><h1>\n" > "Hello World\n" > "</h1></body></html>\n"; > @@ -3193,7 +3197,8 @@ static void test_testTransforms(void) > > hr = IXMLDOMDocument_transformNode(doc, pNode, &bOut); > ok(hr == S_OK, "ret %08x\n", hr ); > - ok( !lstrcmpW( bOut, _bstr_(szTransformOutput) ), "Stylesheet output not correct\n"); > + ok( !lstrcmpW( bOut, _bstr_(szTransformOutput)) || /* Windows */ > + !lstrcmpW( bOut, _bstr_(szTransformOutputWine)) /* Wine */, "Stylesheet output not correct\n"); You shouldn't need a special case for Wine. What you need is a smarter comparison function that ignores EOL characters. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: imm32: Fix a test that fails on all systems
by Aric Stewart 21 Apr '08

21 Apr '08

Are this tests failing on windows? When I did my recent IME work I was working to make sure that these tests succeeded at that time. have they started failing on wine as well? thanks, -aric James Hawkins wrote: > Hi, > > Changelog: > * Fix a test that fails on all systems. > > dlls/imm32/tests/imm32.c | 30 +++++++++++++++++++++--------- > 1 files changed, 21 insertions(+), 9 deletions(-) > > > > ------------------------------------------------------------------------ > >

2 1

Re: [PATCH 09/17] widl: Split the expr rule up into multiple rules to fix operator precedence.
by Alexandre Julliard 21 Apr '08

21 Apr '08

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -263,8 +263,14 @@ static void add_explicit_handle_if_necessary(func_t *func); > %type <attr> attribute > %type <attr_list> m_attributes attributes attrib_list > %type <str_list> str_list > -%type <expr> m_expr expr expr_const > -%type <expr_list> m_exprs /* exprs expr_list */ expr_list_const > +%type <expr> m_expr expr_const expression conditional_expression > +%type <expr> conditional_expression logical_OR_expression logical_AND_expression > +%type <expr> inclusive_OR_expression exclusive_OR_expression AND_expression > +%type <expr> equality_expression relational_expression shift_expression > +%type <expr> additive_expression additive_expression multiplicative_expression > +%type <expr> cast_expression unary_expression postfix_expression > +%type <expr> primary_expression > +%type <expr_list> m_exprs expr_list_const > %type <array_dims> array array_list > %type <ifinfo> interfacehdr > %type <type> inherit interface interfacedef interfacedec You shouldn't need that, the %left/%right declarations should define the correct precedence already. Why doesn't this work for you? -- Alexandre Julliard julliard(a)winehq.org

2 1

Question about openning html document in new window
by Ivan Sinitsin 21 Apr '08

21 Apr '08

Hello, I have a question. I make a patch, that fix problem with open html document in new window. I tested it on "MyIE 2" and it works. But I am not assured, whether it is possible to solve a problem in this way. What do you think about it? -- Sinitsin Ivan

1 0

Re: user32: Use the PostMessage() for WM_IME_KEY{DOWN|UP} message
by Dmitry Timoshkov 21 Apr '08

21 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > * MS Spi++ test result, PostMessage is right. > * Message generation sequence: > WM_IME_KEYDOWN -> WM_KEYDOWN -> WM_CHAR > WM_CHAR is genetated in the TranslateMessage() when we use > PostMessage() function. > * Real case: MS IME 2002, MS IME 2003, Saenaru > In the preedit mode, when we press the "ENTER" key, Korean > Native IME generate the WM_IME_KEYDOWN(wParam==VK_RETURN) message. > This message is translated to the WM_CHAR(wParam==VK_RETURN) > message finally. You should add the tests to dlls/user32/tests/msg.c for the above changes. -- Dmitry.

1 0

Regressions: the enemy of 1.0
by Dan Kegel 20 Apr '08

20 Apr '08

There's been lots of progress in Wine lately; many important applications work better than ever. But the inevitable cost of such progress is that some applications are now broken and/or wine has odd problems. For instance, as of the last two versions of Wine, StarUML can't be unminimized ( http://bugs.winehq.org/show_bug.cgi?id=12697 ), and as of 0.9.60, the IME support seems to be making wine apps run dog slow on at least one of my machines ( http://www.winehq.org/pipermail/wine-devel/2008-April/064999.html ). These seem like regressions that ought to be fixed before 1.0. So... I guess my point is: the code freeze is starting soon, which is good; that will help coax developers into looking for and fixing recently introduced bugs rather than old ones. i.e. fight to hang on to what we've got (or had recently) rather than pushing to conquer new ground. Those who absolutely have to work on risky new stuff in the meantime will increasingly have to keep their work outside the main tree for now. Once 1.0 is out, those patches can land, and the fight for new ground can resume.

3 2

Re: [4/4] Add test for IDirectInputDevice_GetProperty of keyboard device for unicode and ascii case.
by Vitaliy Margolen 20 Apr '08

20 Apr '08

Sergey Khodych wrote: > > > ------------------------------------------------------------------------ > > > + result = wcsncmp( dipsw.wsz, dipsa.wsz, sizeof( dipsw.wsz )/sizeof( dipsw.wsz[0] ) ); UNIX unicode and windows unicode are two separate things. Don't use functions that work with wchar_t - they are not compatible with Wine. Use Wine's own unicode functions instead. For example here you can use lstrcmpW(). Vitaliy.

1 0

Wine 1.0 status: T minus 54 days, 63 bugs to go. Code freeze in 12 days.
by Dan Kegel 20 Apr '08

20 Apr '08

See http://kegel.com/wine/countdown.html for a current (and clickable) status report. Here's what it says now: Wine Release Countdown Wine 1.0 countdown: 54 days to release, 12 days to freeze! See WineReleasePlan for details. wine-0.9.60 was released on Friday, April 20th, 2008. According to http://wiki.winehq.org/WineReleasePlan wine-0.9.61, due out Friday, May 2, 2008, will be the first release candidate for 1.0, and mark the start of the code freeze. During the code freeze, patches that * are simple * come with a conformance test * fix a regression * are low risk are more likely to get in than other patches. (Heck, that's always true, but it's even truer during a freeze.) We will actively discourage patches that might endanger the 1.0 release date (June 13th). Bug Status There are 63 open 1.0 bugs as of 20 April. Most of these will simply be rolled over to be fixed for a later release; we only have time to fix a few, and much as we'd like to fix the rest, most are not showstoppers. Changes since last week (with category and votes): New (!): 12666 -unknown 0 Wine should refuse to run if pointed at a real Windows Fixed: 7477 -unknown 1 Uplink demo crashes 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 12561 -unknown 0 Photoshop CS alt key for clone/healing - possible regression Duplicate: 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 6607 ole 10 Drag and Drop not working Deferred: 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 9484 kernel32 19 Program refuses to run because of ProtectCD/ProtectDISC copy-protection Here's the full list of current bugs: 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 5402 -unknown 0 Trying to run PhotoStitch 3.1 5844 -unknown 12 tray minimize 5948 -unknown 1 Star Trek: Armada does not install 7404 -unknown 3 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 8125 -unknown 0 Marratech 6.1 crashes on start 9178 -unknown 8 "hello world" dos program hangs 9916 -unknown 6 "make test" usually fails 9959 -unknown 9 Make wine updates work even if the registry changed 10815 -unknown 5 Cannot drag images into Adobe Photoshop 7 from the web / desktop 11281 -unknown 4 CJK input many issues 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 12246 -unknown 2 "make test" gives different results with and without warn+heap 12666 -unknown 0 Wine should refuse to run if pointed at a real Windows 11420 advapi32 0 service control manager API problem: name of named objects might differ (client vs. service process) 556 build-en 1 Reconcile the Windows and Wine spec files 1114 comctl32 3 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 4372 comctl32 1 listview: cannot drag several items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 5535 directx- 17 Planescape:Torment doesn't work 9030 directx- 0 army men hangs on black screen 11681 directx- 17 Add support for video overlay 3270 gdi32 15 Problem with minimized top-level windows 6519 gdi32 7 Wine blacks out rotated font bitmap 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9771 gdi32 45 Steam Friends doesn't work (fails to render correctly or refresh) 5024 kernel32 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5351 kernel32 11 Windows Installer 3.1 cannot install because of non-standard drive labeling 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 10147 msi 1 Word Viewer 2003 - Tab behavior differs from Windows 8783 ntdll 13 USB serial ports do not work 9356 ntdll 8 Serial communication not working since wine-0.9.33 8095 ole 0 PQ Teaching toy crashes 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 5926 programs 1 Wine does not provide an implementation of winhlp32.exe 5163 setupapi 13 Office XP 2002 crashes on installation 3546 shdocvw 2 CLSID_InternetShortcut not available... 6095 shdocvw 15 MOTD in counter-strike 1.6 and counter-strike source does not render 8898 shdocvw 1 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 9304 shdocvw 4 Temple of Elemental Evil demo doesn't start - gui irresponsive 8439 shell32 8 Visual Studio .NET (7) install fails 10905 shell32 0 thinstall firefox demo requires native msvcrt 11742 shlwapi 9 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 3 Ship icons for the wine-tools that can be used in .desktop files 664 user32 7 The help menu functionality inside programs is broken (messaging problem) 3023 user32 6 Orcad - "Place Part" never tries to put down a part 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 3297 winex11. 13 UpdateWindow() doesn't call XFlush() 5623 winex11. 4 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 25 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 10984 winex11. 6 sun jre 5 update 10 installer hangs in 0.9.52 11019 winex11. 4 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5625 wininet 4 Wine does not handle internet proxy settings conveniently 9787 winsock 50 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 1 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

Re: kernel32: Skip the screen buffer tests if codepage 866 is notavailable
by Dmitry Timoshkov 20 Apr '08

20 Apr '08

"James Hawkins" <jhawkins(a)codeweavers.com> wrote: > + res = RegOpenKeyA(HKEY_LOCAL_MACHINE, > + "System\\CurrentControlSet\\Control\\Nls\\CodePage", &hkey); > + if (res == ERROR_SUCCESS) > + { > + len = 20; > + res = RegQueryValueExA(HKEY_LOCAL_MACHINE, "866", NULL, > + NULL, (LPBYTE)str_buf, &len); > + } Could IsValidCodePage() be used instead? -- Dmitry.

2 1

Re: WINED3D: Fix a possible null dereference (try 2)
by H. Verbeet 19 Apr '08

19 Apr '08

On 19/04/2008, David Adam <david.adam.cnrs(a)gmail.com> wrote: > This time, with tests for d3d8 and d3d9. > > David Adam > Looks mostly ok, but you do need a \n at the end of these ok messages: > + ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %s", DXGetErrorString8(hr)); > + ok(hr == D3DERR_INVALIDCALL, "Expected D3DERR_INVALIDCALL, got %s", DXGetErrorString9(hr)); > - * Copyright (C) 2006-2007 Stefan Dösinger(For CodeWeavers) > + * Copyright (C) 2006-2007 Stefan Dï¿½singer(For CodeWeavers) Try not to change the encoding of the file. I'm not sure if we ever considered simply using UTF-8 for source files, but it would probably prevent some issues like this.

2 1