April 2008 - Wine-devel - list.winehq.org

Wine booth/BOF and Linuxworld San Francisco, Aug 2008?
by Dan Kegel 10 Apr '08

10 Apr '08

Wine has come a long way, and will have just had its 1.0 release (knock on wood). So perhaps this is a good year to have a .org booth. What do folks think?

4 3

Microsoft Tax Day Wine Tasting & Networking Event
by Dan Kegel 10 Apr '08

10 Apr '08

It's an April 15th event sponsored by Microsoft, but it sure sounds like something we should be holding on our own terms :-) http://www.microsoft.com/events/EventDetails.aspx?CMTYSvcSource=MSCOMMedia&…

2 1

RE: [PATCH] winecfg => control panel applets patch
by pure_evil＠mail.bg 10 Apr '08

10 Apr '08

> You patch is wrapped. Also please for new files follow standard Wine codding > style - 4 spaces indentation, no tabs. Sorry about that, I'll fix it in the morning. (I should've attached it as a text file :( ) > This is ugly and redundant. yes, but at least it's easily readable - same local variable name within one function serves to store the temporal result, and an *input* variable by the same name is used in the other function (to catch that same result). > However with all this you removing really big functionality from the winecfg - ability to set this on per application basis. + if (display_what_tabs == 1) + { Do_App = TRUE; /*well, application settings do require more tabs.*/ + Do_Lib = TRUE; + NUM_PROPERTY_PAGES = 3; + } ^^This (a few lines below) took care of that.^^ This piece of code explains why I went for bools in the first place - for example, you draw the library tab A.) when you want to draw only them (general library settings), B.) when you want application-specific settings ("winecfg applications") and C.) when you want the entire winecfg. That would've been a lot messier with a triple "or" rather than a simple IF (Do_Lib) { }.

1 0

RE: [PATCH] winecfg => control panel applets patch
by Vijay Kiran Kamuju 10 Apr '08

10 Apr '08

Hi, This is regarding the control panel applet patch you have submitted to wine-patches. I would like to have the applets should be part of wine's control program. They would be better be as files in the /programs/control/ And you should extend the existing control.exe and winecfg in wine to open these applets. Please correct me if I am wrong. Just my 2 cents. ---- VJ

2 1

Re: msdmo: Array parameter is passed to function as pointer so loses size information
by Robert Shearman 10 Apr '08

10 Apr '08

Andrew Talbot wrote: > @@ -291,8 +291,9 @@ lend: > * > * Get DMP Name from the registry > */ > -HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[80]) > +HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[]) > { > +#define NAME_SIZE 80 /* Size of szName[] */ > WCHAR szguid[64]; > HRESULT hres; > HKEY hrkey = 0; > @@ -311,7 +312,7 @@ HRESULT WINAPI DMOGetName(REFCLSID clsidDMO, WCHAR szName[80]) > if (ERROR_SUCCESS != hres) > goto lend; > > - count = sizeof(szName); > + count = NAME_SIZE; > hres = RegQueryValueExW(hkey, NULL, NULL, NULL, > (LPBYTE) szName, &count); > This is incorrect. count is the size in bytes of the buffer passed in (szName) and so should be sizeof(szName) not sizeof(szName)/sizeof(szName[0]) (i.e. 80). I see this patch has already been committed, so a9200b24014607c4c82fb052b97de88daa804a81 should be reverted. If you want to pick up errors like passing the wrong size into functions then I would suggest using an automatic checker that is able to use semantic information, like Microsoft's PREfast. -- Rob Shearman

3 5

Re: tools: Add Spanish Translation to wine.desktop
by Ivan Gyurdiev 10 Apr '08

10 Apr '08

> Name=Wine Windows Emulator I like the expanded version better: "Wine is not an emulator windows emulator". Should help clear up any questions people might have :)

1 0

Re: [PATCH] winecfg => control panel applets patch
by Vitaliy Margolen 10 Apr '08

10 Apr '08

pure_evil(a)mail.bg wrote: > Allows access to different winecfg tabs via control-panel applets (without > showing all of the cfg's tabs when accessed thusly) > > +LONG APIENTRY EXECUTE_APPLET(HWND hwndCpl, UINT message, LPARAM lParam1, > LPARAM lParam2) > +{ > + > + int NumOfApplet = (int)lParam1; > + > + switch (NumOfApplet) > + { > + > + case 0: You patch is wrapped. Also please for new files follow standard Wine codding style - 4 spaces indentation, no tabs. > + /*It would get messier with an or statement everywhere, so...*/ > + BOOL Do_App = FALSE; > + BOOL Do_Lib = FALSE; > + BOOL Do_Graph = FALSE; > + BOOL Do_Desktop = FALSE; > + BOOL Do_Drives = FALSE; > + BOOL Do_Audio = FALSE; > + if (display_what_tabs == 2) { Do_Lib = TRUE; } > + if (display_what_tabs == 3) { Do_Graph = TRUE; } > + if (display_what_tabs == 4) { Do_Desktop = TRUE; } > + if (display_what_tabs == 5) { Do_Drives = TRUE; } > + if (display_what_tabs == 6) { Do_Audio = TRUE; } > + if ( lstrcmpi(CommandLine,"applications") == 0 ) display_what_tabs = 1; > + if ( lstrcmpi(CommandLine,"libraries") == 0 ) display_what_tabs = 2; > + if ( lstrcmpi(CommandLine,"graphics") == 0 ) display_what_tabs = 3; > + if ( lstrcmpi(CommandLine,"desktop") == 0 ) display_what_tabs = 4; > + if ( lstrcmpi(CommandLine,"drives") == 0 ) display_what_tabs = 5; > + if ( lstrcmpi(CommandLine,"audio") == 0 ) display_what_tabs = 6; This is ugly and redundant. You should make it a bit-mask instead. However with all this you removing really big functionality from the winecfg - ability to set this on per application basis. Vitaliy.

1 0

Re: shell32: Implement ParseDisplayName for EntireNetwork in the Network Places shell folder.
by Juan Lang 10 Apr '08

10 Apr '08

Hi Rob, + strcpy(pData->u.network.szNames, "Entire Network"); Is this not locale-dependent? --Juan

2 2

make install broken
by Stefan Leichter 10 Apr '08

10 Apr '08

Hello, installing wine does not longer work for me. It fails with: make[2]: Entering directory `/usr/src/wine/wine-build/programs/xcopy' /usr/bin/install -c xcopy.exe.so /usr/local/lib/wine/xcopy.exe.so make[2]: Leaving directory `/usr/src/wine/wine-build/programs/xcopy' make[1]: *** Keine Regel vorhanden, um das Target »winelauncher«, benötigt von »install«, zu erstellen. Schluss. make[1]: Leaving directory `/usr/src/wine/wine-build/programs' make: *** [programs/__install__] Fehler 2 The difference from my build system to the most others is, that i do out of tree builds. Bye Stefan

3 2

Re: conflict between Wine and Solaris list.h fixed by AlekZ's workaround (Bug 11463)
by Alexandre Julliard 10 Apr '08

10 Apr '08

Petr Sumbera <Petr.Sumbera(a)Sun.COM> writes: > diff --git a/server/fd.c b/server/fd.c > index 41e404c..0010bab 100644 > --- a/server/fd.c > +++ b/server/fd.c > @@ -71,6 +71,18 @@ > #include <sys/types.h> > #include <unistd.h> > > +/* > + struct list is defined at sys/list_impl.h on solaris > + this patches work around it. > +*/ > +#define list WINELIST > +#define list_remove WINELIST_REMOVE > +#define list_next WINELIST_NEXT > +#define list_prev WINELIST_PREV > +#define list_head WINELIST_HEAD > +#define list_tail WINELIST_TAIL > +#define list_move_tail WINELIST_MOVE_TAIL > + You should do this the other way around, by defining list to solaris_list before including the offending header, and undefining it afterwards. This way the Wine code itself isn't impacted by redefinitions. -- Alexandre Julliard julliard(a)winehq.org

1 0