April 2008 - Wine-devel - list.winehq.org

Re: kernel32: Fix for WritePrivateProfileString Sharing Problem [1/2] (ATTEMPT 3)
by Alexandre Julliard 11 Apr '08

11 Apr '08

"Erich Hoover" <ehoover(a)mines.edu> writes: > Description: > Fixes incorrect file sharing mode in PROFILE_FlushFile and PROFILE_Open > that result in WritePrivateProfileString failing under certain > circumstances. This problem is specifically evident in the "Thief: Deadly > Shadows" installer (demo and full), which writes an empty config file that > later causes the game to crash (Bug #5024). This version is functionally > equivalent to Attempt 2; however, it uses NtCreateFile so there is no need > to push and pop the error code. This version also sets ERROR_SUCCESS, as > opposed to S_OK, for Get* functions. Conformance test included in part 2. There's no need to use ntdll functions, last error doesn't matter on success, and if it does it should be set at the end of the function anyway (with test cases showing that it's really supposed to). -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: Add a test to highlight the CreateCompatibleDC problemdescribed in bug #12493
by Dmitry Timoshkov 11 Apr '08

11 Apr '08

"Colin Finck" <mail(a)colinfinck.de> wrote: > Changelog: > Add a gdi32 test to highlight the CreateCompatibleDC problem described in > bug #12493 If the test fails in current Wine code you need to use todo_wine so that 'make test' still passes. -- Dmitry.

2 1

Re: [PATCH 1/2] winecfg: Add option to let wine decorate windows
by Alexandre Julliard 11 Apr '08

11 Apr '08

Matthew D'Asaro <medasaro(a)comcast.net> writes: > Some applications such as iTunes, Winamp, Windows Media Player, Office > 2007, etc. look best without the Linux windows manager decorations on > them. This patch adds an option to winecfg which > allows an application's windows to be managed by the Linux window > manager, but to be decorated by wine. This can also be useful for > debugging some window management problems. The modification to the > winecfg dialog is only in English as I don't know any of the other > languages. I put the patch in, but this winecfg page really needs to be redesigned, the decorated/managed/desktop options are mutually exclusive, so it should use radio buttons. Also the explanations should be moved out to a tooltip or some sort of help option. Any volunteer? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/3] setupapi: Add a test for SetupDiGetDeviceRegistryProperty and SetupDiSetDeviceRegistryProperty
by Alexandre Julliard 11 Apr '08

11 Apr '08

Alexander Morozov <amorozov(a)etersoft.ru> writes: > + if (wide) > + { > + pSetupDiGetClassDevs = (void *)pSetupDiGetClassDevsW; > + pSetupDiSetDeviceRegistryProperty = (void *)pSetupDiSetDeviceRegistryPropertyW; > + pSetupDiGetDeviceRegistryProperty = (void *)pSetupDiGetDeviceRegistryPropertyW; > + pSetupDiCreateDeviceInfo = (void *)pSetupDiCreateDeviceInfoW; > + devName = (void *)devNameW; > + friendlyName = (void *)friendlyNameW; > + buflen = 6 * sizeof(WCHAR); > + buf = (void *)bufW; > + } > + else > + { > + pSetupDiGetClassDevs = (void *)pSetupDiGetClassDevsA; > + pSetupDiSetDeviceRegistryProperty = (void *)pSetupDiSetDeviceRegistryPropertyA; > + pSetupDiGetDeviceRegistryProperty = (void *)pSetupDiGetDeviceRegistryPropertyA; > + pSetupDiCreateDeviceInfo = (void *)pSetupDiCreateDeviceInfoA; > + devName = (void *)devNameA; > + friendlyName = (void *)friendlyNameA; > + buflen = 6; > + buf = (void *)bufA; > + } That's ugly, it's bypassing all type checking. There's no reason to test everything twice, in most cases the A function calls the W one, so testing the A one automatically tests both. If there are differences you really need to test, please do that explicitly by duplicating the test. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: tools: Fix font structure layout for 64-bit mode
by Dmitry Timoshkov 11 Apr '08

11 Apr '08

"Erik de Castro Lopo" <mle+win(a)mega-nerd.com> wrote: > I quick question from someone relatively new to wine development. > > Are these 64-bit fixes aimed at compiling wine for 64 bit CPUs > but running win32 apps or for running win64 apps? Both. -- Dmitry.

1 0

Re: ntdll: Fix a test that fails on both win2k and winxp
by Alexandre Julliard 11 Apr '08

11 Apr '08

"James Hawkins" <jhawkins(a)codeweavers.com> writes: > Changelog: > * Fix a test that fails on both win2k and winxp. This will break the test for win9x. -- Alexandre Julliard julliard(a)winehq.org

1 0

WineConf 2008
by Jeremy White 11 Apr '08

11 Apr '08

Hi Folks, I'd like to start the planning for WineConf 2008. My sense is that 3 years in Europe and 1 year in the US is a reasonable balance, so I feel it makes sense to try to have it over here this year. Further, I would like to host WineConf this year in St. Paul, Minnesota, for a variety of reasons. First, it's a lot easier for me to help plan if it's here. Second, it's nice for CodeWeavers; it means we can have everyone, not just the developers, all together. Having Mandi able to physically intimidate people is very helpful for us, after all <grin>. My thought was to do it in late September, early October, so that the weather would not be so extreme. I realize that veterans of our last Minnesota meeting will be disappointed at the lack of the Ice Palace, but we'll try to find a way to make it up to you. Also, I know the travel costs will be hard for many people, given current travel costs, so I'm hoping to contribute funds (and perhaps do some fund raising) to help cover travel costs for Wine contributors. At any rate, that's my idea. I'm willing to be swayed if people object violently, or if a clear consensus for an alternate emerges. Thoughts? Comments? Cheers, Jeremy

6 5

Reference information on CreateScalableFontResource
by Jeremy White 11 Apr '08

11 Apr '08

I'm doing a brain dump for posterity on this task; you can tune out of this email; it's mostly meant for Google archiving purposes. I've spent far more time than I should on this implementation; I originally did a quick + dirty version that was not binary compatible with Windows .fot files. Worked like a charm; I could run Civ III (yay!). But Alexandre said, gee, it should be easy to make it create a binary compatible .fot file, take an afternoon and do that, why don't you, Jer? Several weeks and a lot of swearing later, I now know far more about the format of .fot files and fontdir resource structures than I care to. I'm attaching a program that was useful to me; it dumped many chunks of info about a .ttf file from FreeType. Comparing that to a .fot file generated on Windows was helpful. I'm also attaching a hex dump of a .fot file with my annotation on the basic structure. The hard parts were that the .fot format seems to be an NE image, but it seems to have subtle bugs in it and that the FONTDIR resource structure is not well documented. I've mostly sussed out how to use Freetype to replicate most of the members; there are still a few I don't have quite right. (And I probably get this all wrong in non US or double byte locales. :-/) The previous patches contain essentially all of my hard won knowledge of the FONTDIR structure. Cheers, Jeremy Annotated hex dump of lucon.fot, a file created on Windows with CreateScalableFontResource against lucon.ttf. Useful for determining the structure of .fot files. DOS 00000000 4d 5a 01 00 02 00 00 00 04 00 0f 00 ff ff 00 00 |MZ..............| 00000010 b8 00 00 00 00 00 00 00 40 00 00 00 00 00 00 00 |........(a).......| 00000020 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000030 00 00 00 00 00 00 00 00 00 00 00 00 80 00 00 00 |................| 00000040 0e 1f ba 0e 00 b4 09 cd 21 b8 01 4c cd 21 54 68 |........!..L.!Th| 00000050 69 73 20 69 73 20 61 20 54 72 75 65 54 79 70 65 |is is a TrueType| 00000060 20 66 6f 6e 74 2c 20 6e 6f 74 20 61 20 70 72 6f | font, not a pro| 00000070 67 72 61 6d 2e 0d 0d 0a 24 00 4b 69 65 73 61 00 |gram....$.Kiesa.| NE 00000080 4e 45 05 10 8a 00 02 00 00 00 00 00 00 80 00 00 |NE..............| 00000090 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000000a0 1a 00 40 00 40 00 74 00 7f 00 7f 00 0e 01 00 00 |..(a).@.t.........| 000000b0 00 00 04 00 02 00 02 00 00 00 00 00 00 00 00 03 |................| START RESOURCE TABLE Shift 000000c0 04 00 Type + Name 0 07 80 01 00 00 00 00 00 48 00 0a 00 50 0c |..........H...P.| 000000d0 2c 00 00 00 00 00 Type + Name 1 cc 80 01 00 00 00 00 00 40 00 |,.............(a).| 000000e0 08 00 50 0c 01 80 00 00 00 00 Flag to end all types + names 00 00 07 46 4f 4e |..P..........FON| 000000f0 54 44 49 52 05 4c 55 43 4f 4e 00 |TDIR.LUCON. | END RESOURCE TABLE ^^^ This is odd. That's fairly clearly the last string in the name/type string part of the resource table. Further, just a little further along, we have a clear place where the resident name table should start. But the header says it starts at 0x74 relative, which is right there. And the clear place for it to start is at 0x7f. Mystery bytes: (0xf9, 0x79 relative) 00 00 00 00 Apparent resident name table: (0xff, 0x7f relative) 0a | .| 00000100 4c 55 43 4f 4e 2e 54 54 46 00 |LUCON.TTF. | Apparent module reference table: (0x10a, 0x8a relative) 00 00 00 00 Non resident name table: (0x10e) 1a 46 | .F| 00000110 4f 4e 54 52 45 53 3a 4c 75 63 69 64 61 20 43 6f |ONTRES:Lucida Co| 00000120 6e 73 6f 6c 65 00 00 00 00 00 00 00 00 00 00 00 |nsole...........| 00000130 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000140 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000150 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000160 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000170 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000180 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000190 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000001f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000200 c3 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| ^^^ What the hell!?!?! 00000210 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000220 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000230 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000240 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000250 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000260 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000270 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000280 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000290 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000002f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000300 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000310 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000320 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000330 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000340 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000350 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000360 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000370 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000380 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000390 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003a0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003c0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003d0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003e0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000003f0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000400 43 3a 5c 57 49 4e 44 4f 57 53 5c 66 6f 6e 74 73 |C:\WINDOWS\fonts| 00000410 5c 4c 55 43 4f 4e 2e 54 54 46 00 00 00 00 00 00 |\LUCON.TTF......| 00000420 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000430 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000440 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000450 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000460 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000470 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000480 01 00 00 00 00 02 95 00 00 00 57 69 6e 64 6f 77 |..........Window| 00000490 73 21 20 57 69 6e 64 6f 77 73 21 20 57 69 6e 64 |s! Windows! Wind| 000004a0 6f 77 73 21 00 10 03 01 01 00 00 00 00 00 00 00 |ows!............| 000004b0 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 000004c0 00 00 00 00 00 00 03 40 00 08 48 00 48 00 50 06 |.......(a)..H.H.P.| 000004d0 00 00 00 00 00 00 00 90 01 00 00 00 00 08 36 d2 |..............6.| 000004e0 04 d2 04 1e ff 01 02 00 00 00 00 00 00 76 00 00 |.............v..| 000004f0 00 0c 00 00 00 ff 4c 75 63 69 64 61 20 43 6f 6e |......Lucida Con| 00000500 73 6f 6c 65 00 4c 75 63 69 64 61 20 43 6f 6e 73 |sole.Lucida Cons| 00000510 6f 6c 65 00 52 65 67 75 6c 61 72 00 00 00 00 00 |ole.Regular.....| 00000520 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000530 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000540 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000550 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000560 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000570 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| 00000580 00 |.| 00000581

2 3

re: Valgrind false positive or?
by Dan Kegel 11 Apr '08

11 Apr '08

Vitaliy wrote: >==22938== Invalid write of size 1 >==22938== at 0x4024D55: memcpy (mc_replace_strmem.c:402) >==22938== by 0x7BC64405: setup_exception_record (signal_i386.c:795) >==22938== by 0x7BC65793: segv_handler (signal_i386.c:1310) What test was this? Sometimes a little more context helps.

2 2

Valgrind false positive or?
by Vitaliy Margolen 11 Apr '08

11 Apr '08

Trying to understand what is that valgrind doesn't like? ==22938== Invalid write of size 1 ==22938== at 0x4024D55: memcpy (mc_replace_strmem.c:402) ==22938== by 0x7BC64405: setup_exception_record (signal_i386.c:795) ==22938== by 0x7BC65793: segv_handler (signal_i386.c:1310) ==22938== by 0x419160F: (within /lib/libpthread-2.6.1.so) ==22938== Address 0x7f22c7de is not stack'd, malloc'd or (recently) free'd http://source.winehq.org/source/dlls/ntdll/signal_i386.c#L756 http://source.winehq.org/source/dlls/ntdll/signal_i386.c#L1093 http://source.winehq.org/source/dlls/ntdll/signal_i386.c#L1310 Everything seems to be correct. Any ideas? Vitaliy.

1 0