April 2008 - Wine-devel - list.winehq.org

Re: [Resend 3] user32: Post the WM_KEY{DOWN|UP}messagewhenWM_IME_KEY{DOWN|UP} message is generated by IME.
by Dmitry Timoshkov 30 Apr '08

30 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > I have attached new one. Looks good to me. -- Dmitry.

1 0

Documentation updating / XML?
by Austin English 30 Apr '08

30 Apr '08

I've been working on some of the documentation, then remembered that Scott requested a move to XML: http://bugs.winehq.org/show_bug.cgi?id=12217 There are quite a few programs to convert SGML to XML, and I've got a bit of time to kill. Alexandre, would you accept a move to XML, or would this be a waste of time? -Austin

3 3

Re: [Resend 2] user32: Post the WM_KEY{DOWN|UP} messagewhenWM_IME_KEY{DOWN|UP} message is generated by IME.
by Dmitry Timoshkov 30 Apr '08

30 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > + while (TRUE) > + { > + if ( PeekMessage(&msg, 0, 0, 0, PM_REMOVE) ) > + { > + struct message posted_msg; > + > + msg_count++; > + > + trace("posted message[%d]: %p, %04x, %08lx, %08lx\n", > + msg_count, msg.hwnd, msg.message, msg.wParam, msg.lParam); > + > + posted_msg.message = msg.message; > + posted_msg.flags = posted|wparam|lparam; > + posted_msg.wParam = msg.wParam; > + posted_msg.lParam = msg.lParam; > + add_message(&posted_msg); > + > + TranslateMessage(&msg); > + DispatchMessage(&msg); > + > + if ( msg.message == WM_CHAR && msg.wParam == VK_RETURN ) > + break; > + } > + } You need to fetch all available messages, not just the selected ones. In order to do that replace 'while (TRUE)' loop by the 'while (PeekMeessage())' one, and as I pointed out earlier add_message() should be done only inside of the message proc. So the whole code above should be simplified to just while (PeekMeessage(&msg)) { TranslateMessage(&msg); DispatchMessage(&msg); } -- Dmitry.

1 0

Switching threads in winedbg
by Maarten Lankhorst 30 Apr '08

30 Apr '08

Hi all, I was trying to switch to a different thread in winedbg, however I don't see any command for that in the winedbg online reference at http://www.winehq.org/site/docs/winedev-guide/dbg-commands . Does anyone know if it's possible? Cheers, Maarten.

2 1

Re: wined3d: Fix for buggy programs using ortho matrix with no z range
by Stefan Dösinger 30 Apr '08

30 Apr '08

Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > Changelog: > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > other word with no range, which does'nt make any sense but they do it > anyway. I think a test case for this would be good.

2 2

Re: [Resend] user32: Post the WM_KEY{DOWN|UP} message whenWM_IME_KEY{DOWN|UP} message is generated by IME.
by Dmitry Timoshkov 30 Apr '08

30 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > @@ -4496,6 +4551,9 @@ static void test_messages(void) > > DestroyWindow(hwnd); > flush_sequence(); > + > + /* Message sequences by WM_IME_KEYDOWN */ > + test_wm_ime_keydown(); > } test_messages() is not a proper place to add new tests. Please have a look at test_combobox_messages() how to test key down/up behaviour. In order to check posted messages, you need to do what other tests do: run a GetMessage/TranslateMessage/DispatchMessage loop, and let the window proc handle the messages. -- Dmitry.

1 1

Re: winmm/tests: waveOutGetDevCaps called with invalid size
by Robert Reif 30 Apr '08

30 Apr '08

Peter Åstrand wrote: > Changelog: > > Calling waveOutGetDevCapsA/waveOutGetDevCapsW with size 4 is wrong, the > size should be the sizeof the structure used. waveOutGetDevCapsA needs to > succeed since the capsA structure is used later. > > Index: wave.c > =================================================================== > RCS file: /home/wine/wine/dlls/winmm/tests/wave.c,v > retrieving revision 1.67 > diff -u -r1.67 wave.c > --- wave.c 29 Feb 2008 12:18:36 -0000 1.67 > +++ wave.c 18 Apr 2008 08:43:54 -0000 > @@ -853,15 +853,13 @@ > "expected, got %s\n",dev_name(device),wave_out_error(rc)); > } > > - rc=waveOutGetDevCapsA(device,&capsA,4); > + /* Final call must succeed, capsA will be used below */ > + rc=waveOutGetDevCapsA(device,&capsA,sizeof(capsA)); > ok(rc==MMSYSERR_NOERROR, > "waveOutGetDevCapsA(%s): MMSYSERR_NOERROR expected, got %s\n", > dev_name(device),wave_out_error(rc)); > - > - rc=waveOutGetDevCapsW(device,&capsW,4); > - ok(rc==MMSYSERR_NOERROR || rc==MMSYSERR_NOTSUPPORTED, > - "waveOutGetDevCapsW(%s): MMSYSERR_NOERROR or MMSYSERR_NOTSUPPORTED " > - "expected, got %s\n",dev_name(device),wave_out_error(rc)); > + if (rc!=MMSYSERR_NOERROR) > + return; > > nameA=NULL; > rc=waveOutMessage((HWAVEOUT)device, DRV_QUERYDEVICEINTERFACESIZE, > > > --- > Peter Åstrand ThinLinc Chief Developer > Cendio AB http://www.cendio.se > Wallenbergs gata 4 > 583 30 Linköping Phone: +46-13-21 46 00 > ------------------------------------------------------------------------ > > > That's the whole point of the test, to check what happens with an invalid argument.

2 13

Re: [Resend] user32: Post the WM_KEY{DOWN|UP} message whenWM_IME_KEY{DOWN|UP} message is generated by IME.
by Dmitry Timoshkov 30 Apr '08

30 Apr '08

"ByeongSik Jeon" <bsjeon(a)hanmail.net> wrote: > I have added the test code. Your test doesn't confirm that the message is posted and not sent. You need to use SendMessage and examine the resulting messages, then run the message loop and see what messages got posted. -- Dmitry.

1 0

Re: wined3d: Fix for buggy programs using ortho matrix with no z range
by Jens Albretsen 30 Apr '08

30 Apr '08

On Tuesday 29 April 2008 22:25:48 Stefan Dösinger wrote: > Am Dienstag, 29. April 2008 19:04:55 schrieb Jens Albretsen: > > Changelog: > > Fix for old games that sets a Ortho matrix with z range from 0-0 or in > > other word with no range, which does'nt make any sense but they do it > > anyway. > > I think a test case for this would be good. A quick one is Lego Island, just forget to put in the disc a there is black screen, with this patch is shows a message to put the cdrom in the drive. Is it something like this? create (1,1) rendertarget clear rendertarget with black setup ortho with no range draw something with white check rendertarget for any pixel drawn, if black test fails or what? -------------------------------------------------------

1 0

Re: [PATCH] usp10: Use passed hdc instead of cached one for ScriptTextOut with test to check
by Hans Leidekker 30 Apr '08

30 Apr '08

On Tuesday 29 April 2008 06:15:23 Guy Albertelli wrote: > Application does most of the Script... calls under one hdc then deletes it > prior to calling the ScriptTextOut with the original hdc. Out of curiosity, which app is that? What are the symptoms? I tested your patch on some of the apps I know that use usp10 (TomTom HOME, Firefox, PAF5) and didn't see any obvious regressions. > - if (!ExtTextOutW(get_cache_hdc(psc), x, y, fuOptions, lprc, pwGlyphs, cGlyphs, NULL)) > + if (!ExtTextOutW(hdc, x, y, fuOptions, lprc, pwGlyphs, cGlyphs, NULL)) You should also get rid of the calls to get_script_cache and un/select_cached_font; they are redundant now. -Hans

2 1