April 2008 - Wine-devel - list.winehq.org

Re: wine.inf.in: use lowercase for Microsoft Video 1
by Dmitry Timoshkov 27 Apr '08

27 Apr '08

"Jeff Zaroyko" <jeffzaroyko(a)gmail.com> wrote: > system.ini, drivers32,,"vidc.MRLE=msrle32.dll" > -system.ini, drivers32,,"vidc.MSVC=msvidc32.dll" > +system.ini, drivers32,,"vidc.msvc=msvidc32.dll" > system.ini, drivers32,,"vidc.CVID=iccvid.dll" > system.ini, drivers32,,"; vidc.IV50=ir50_32.dll" > system.ini, drivers32,,"; vidc.IV31=ir32_32.dll" MRLE and CVID are also in lower case in XP, so they should be fixed too (as well as removed trailing spaces in many entries in [SystemIni] section). -- Dmitry.

2 1

Side affects from running wineprefixcreate
by Vitaliy Margolen 27 Apr '08

27 Apr '08

So for one notable problems is some file types being reset by Wine. Looks like it comes from dlls/mshtml/mshtml.inf. At a minimum all the created registry entries should not overwrite already existing ones. Vitaliy.

2 2

Re: [dinput] initial support for BSD's usbhid joysticks
by Vitaliy Margolen 26 Apr '08

26 Apr '08

Christoph Frick wrote: > From 7618ceb6941c0dffac9c48c1fa1aeb7e821673a2 Mon Sep 17 00:00:00 2001 > From: Christoph Frick <frick(a)sc-networks.com> > Date: Sat, 26 Apr 2008 02:50:01 +0200 > Subject: [PATCH] Initial support for BSD's usbhid joysticks > > Please consider this a tracer bullet. I had only time to test it with a > 4-axis/4-button wheel in LFS in FreeBSD 7.0. I will take further tests using a > flight stick and other games soon. But for now i just want to see, what others > have to say about it. > --- Please use 4 spaces indentation, no tabs. > + snprintf(buf, MAX_PATH, FMT_UHIDDEVS, i); > + buf[MAX_PATH - 1] = 0; snprintf always writes terminating '\0' character at the end of the string. You don't need to explicitly do that yourself. > + if ((fd = open(buf, O_RDWR | O_NDELAY, 0)) == -1) { > + TRACE("Unable to open %s read/write: %s\n", buf, strerror(errno)); > + continue; > + } Do you really have to open it read/write? Shouldn't read only be enough for not FF joystick? The only way I can think of to remove code duplication is to create base joystick class. There were no reason for that with only 2 joystick drivers. With third one should really do it. Vitaliy.

3 4

Re: [dinput] move the common joystick_map_.* methods from joystick_linuxinput.c into device.c
by Vitaliy Margolen 26 Apr '08

26 Apr '08

Christoph Frick wrote: > diff --git a/dlls/dinput/device.c b/dlls/dinput/device.c > index 5f927d0..baca0b3 100644 > --- a/dlls/dinput/device.c > +++ b/dlls/dinput/device.c > @@ -1400,3 +1400,54 @@ HRESULT WINAPI IDirectInputDevice8WImpl_GetImageInfo(LPDIRECTINPUTDEVICE8W iface > Please don't. Device is common for everything (keyboard, mouse, joysticks). Joystick specific code should not be there. Vitaliy.

2 1

Re: [Try 3] [1/2] cabinet.dll -> FDICopy: Test added
by James Hawkins 26 Apr '08

26 Apr '08

2008/4/5 Vitaly Perov <vitperov(a)etersoft.ru>: > This test checks if function FDICopy() of cabinet.dll correctly works with an > empty cabinet file (It's correct cab-file, but it has no files and folders > inside). > In this case Windows return TRUE, but WINE return FALSE. So the installation > of certain software finishes with an error in WINE > > Changelog: > - Added a test for cabinet.dll FDICopy function. This test checks if it > works correctly with an empty cab-files > --- dlls/cabinet/tests/fdi.c 6 Feb 2008 13:29:17 -0000 1.3 +++ dlls/cabinet/tests/fdi.c 5 Apr 2008 15:16:55 -0000 @@ -20,6 +20,7 @@ #include <stdio.h> #include <windows.h> +#include <assert.h> #include "fci.h" #include "fdi.h" #include "wine/test.h" You forgot to remove this. -- James Hawkins

2 1

[GSoC][RFC] Case Insensitive Filesystem
by Marc Andre Tanner 26 Apr '08

26 Apr '08

Hi, During the last week i have been playing around with the idea of writing a case insensitive fuse filesystem and i am know at the point were i can demonstrate a proof of concept implementation. And yes i have seen that there is already someone else interested in doing this but i thought it was fun anyways. The filesystem converts every path to lower case before further operations take place. On file creation the original filename is stored in an extended attribute and later returned upon request. This means you will have a directory on a regular POSIX filesystem with all filenames in lower case, this directory can then be mounted in case insensitive fashion. In order to compile the code you will need the fuse and libattr[1] development files. Furthermore you will have to make sure that the underlying filesystem supports extended attributes (for example for ext{2,3} you need a kernel with CONFIG_EXT{2,3}_FS_XATTR enabled). You probably also want to mount the underlying filesystem with the user_xattr option which allows non root users to create extended attributes. So fetch the code from the url below, extract the archive and type make. This should generate a binary named ciopfs (which stands for Case Insenstive On Purpose File System, alternative naming suggestions are welcome ;). http://www.brain-dump.org/projects/ciopfs/ciopfs-25.03.2008.tar.gz Mounting the file system is straight forward, see `ciopfs -h` for further options. But be carefull i haven't yet done any serious testing, so only use it with unimportant data [insert standard warning about possible data loss here]. ciopfs /path/to/my/directory /path/to/my/mountpoint As i said before the current implementation is just a proof of concept. That's why it currently only supports ascii filenames, or whatever tolower(3) can cope with. This brings us to another problem[2,3], in certain languages there isn't a direct mapping between upper and lower case characters and case insensitivity in filesystem is generally a bad thing. Any comments are appreciated. Regards, Marc [1] http://acl.bestbits.at/download.html#Attr [2] http://www.somethinkodd.com/oddthinking/2005/10/25/the-world-of-upper-lower… [3] http://drewthaler.blogspot.com/2007/12/case-against-insensitivity.html -- Marc Andre Tanner >< http://www.brain-dump.org/ >< GPG key: CF7D56C0

6 10

Re: ddraw: Remove a test that fails in VMs
by Reece Dunn 26 Apr '08

26 Apr '08

2008/4/26 James Hawkins <jhawkins(a)codeweavers.com>: > Hi, > > The tests aren't run anyway in this case. > > Changelog: > * Remove a test that fails in VMs. ... > hr = IDirect3D7_CreateDevice(Direct3D, &IID_IDirect3DRefDevice, Surface, &Direct3DDevice); > } > } > - ok(hr == D3D_OK, "IDirect3D7_CreateDevice failed with %08x\n", hr); Wouldn't it be better to move the ok line to directly after the IDirect3D7_CreateDevice call? That way, on VM machines the test will not get run and on non-VM machines it will, as it is a valid test in that case. - Reece

2 2

Re: cabinet: Revert "cabinet: Fix for FDICopy with an empty cabinet file."
by Reece Dunn 26 Apr '08

26 Apr '08

2008/4/26 James Hawkins <jhawkins(a)codeweavers.com>: > Hi, > > The test was incorrect and failed on all platforms. Vitaly, please > ask someone to test your patches on a real windows system in the > future if you don't have access to one. Wouldn't it be better to actually fix the test case than revert it all together? Just simply change line 630: - ok(ret, "Expected FDICopy to succeed\n"); + ok(!ret, "Expected FDICopy to fail\n"); and remove the todo_wine. Adding a GetLastError check would be good as well. - Reece

2 2

download.template: Update Mandriva download info (try 2)
by Austin English 26 Apr '08

26 Apr '08

Any reason this patch wasn't applied? http://www.winehq.org/pipermail/wine-patches/2008-April/053911.html

1 0

Re: Kusanagi Kouichi : winex11: Destroy the handle to the composition string after it is cancelled.
by Aric Stewart 25 Apr '08

25 Apr '08

Comming in a bit late on this one, (missed the patch submission) I do not think this is correct as far as i know hCompStr should never be NULL. Much of our code depends on that not being NULL. I would recommend using ImeCreateBlankCompStr instead. (something like below) diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c index f50549f..8fa6f6f 100644 --- a/dlls/winex11.drv/ime.c +++ b/dlls/winex11.drv/ime.c @@ -778,7 +778,7 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwInd if (lpIMC->hCompStr) { ImmDestroyIMCC(lpIMC->hCompStr); - lpIMC->hCompStr = NULL; + lpIMC->hCompStr = ImeCreateBlankCompStr(); } myPrivate = (LPIMEPRIVATE)ImmLockIMCC(lpIMC->hPrivate); -aric Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: 4f2330ac0c951ec5fb05e2fb152c59723c3af336 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=4f2330ac0c951ec5fb05e2fb1… > > Author: Kusanagi Kouichi <slash(a)ma.neweb.ne.jp> > Date: Fri Apr 25 12:08:24 2008 +0900 > > winex11: Destroy the handle to the composition string after it is cancelled. > > --- > > dlls/winex11.drv/ime.c | 6 ++++++ > 1 files changed, 6 insertions(+), 0 deletions(-) > > diff --git a/dlls/winex11.drv/ime.c b/dlls/winex11.drv/ime.c > index 6614213..f50549f 100644 > --- a/dlls/winex11.drv/ime.c > +++ b/dlls/winex11.drv/ime.c > @@ -775,6 +775,12 @@ BOOL WINAPI NotifyIME(HIMC hIMC, DWORD dwAction, DWORD dwIndex, DWORD dwValue) > > X11DRV_ForceXIMReset(lpIMC->hWnd); > > + if (lpIMC->hCompStr) > + { > + ImmDestroyIMCC(lpIMC->hCompStr); > + lpIMC->hCompStr = NULL; > + } > + > myPrivate = (LPIMEPRIVATE)ImmLockIMCC(lpIMC->hPrivate); > if (myPrivate->bInComposition) > { > > >

2 3