June 2008 - Wine-devel - list.winehq.org

Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests
by Alexandre Julliard 26 Jun '08

26 Jun '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> writes: > + FIXME("Waiting for %u to terminate\n", x); > + /* Make the thread return first */ > + SetEvent(stream->packet_queued); > + if (WaitForSingleObject(stream->thread, 10000) == WAIT_TIMEOUT) > + exit(1); Don't use exit(). If you absolutely need to kill the whole process you should use ExitProcess, and you have to print an error so that users know what happened. But I doubt you need such a drastic action here. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: opengl32: work around a crash in glGetString
by Roderick Colenbrander 26 Jun '08

26 Jun '08

As I mentioned before this requires a test case. I remember from the gl log that the program didn't create a WGL context at all. It isn't allowed to make opengl calls because of that. You should figure out why that is done. Either some other check in the program failed due to which it wasn't able to create a context OR the application is looking for some strange behavior. Perhaps without a context (if Windows allows it) you get some GDI software renderer string back or so. Anyway at this point it sounds like a workaround instead of a fix for the real bug. Roderick > Hi this fixes http://bugs.winehq.org/show_bug.cgi?id=13599 > > A +relay trace shows glGetString is crashing inside glGetString. The cause > is _not_ a lacking opengl context setup around glGetString. I did some > testing and both on windows and wine glGetString just returns NULL if this > is the case, but it never crashes inside glGetString: > > /* glGetString without opengl context: */ > 0009:Call opengl32.glGetString(00001f01) ret=004016bc > 0009:Ret opengl32.glGetString() retval=00000000 ret=004016bc > > /* Crash from Autocad */ > > 0064:Call opengl32.glGetString(00001f01) ret=1000cd58 > 0064:trace:seh:raise_exception code=c0000005 flags=0 addr=0x60ec12f6 > 0064:trace:seh:raise_exception info[0]=00000000 > /* and never returns*/ > > > This bug has been reproduced by several other people , so it's also not > due to a bad gl-setup on my side. In case you want to try , Autocad trial > 2004 can be downloaded from http://www.brothersoft.com/autocad-78351.html. > It's the main issue that prevent autocad 2004 up to 2008 from running. > > So for now my conclusion is, this is a nasty bug outside wine, and an > exception handler is needed to work around the crash. If the patch is rejected > i would appreciate some input. Thanks and regards > > > > __________________________________________________________ > Not happy with your email address?. > Get the one you really want - millions of new email addresses available > now at Yahoo! http://uk.docs.yahoo.com/ymail/new.html -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

1 0

RE: opengl32: work around a crash in glGetString
by Stefan Dösinger 26 Jun '08

26 Jun '08

Does this crash occur with Mesa as well? If yes, it might be interesting to step through the Mesa code to see what is going wrong in there. Otherwise, drivers are never bug free of course. This could be a bug in the Nvidia driver From: wine-patches-bounces(a)winehq.org [mailto:wine-patches-bounces(a)winehq.org] On Behalf Of Louis. Lenders Sent: Thursday, June 26, 2008 9:06 AM To: wine-patches(a)winehq.org Subject: opengl32: work around a crash in glGetString Hi this fixes http://bugs.winehq.org/show_bug.cgi?id=13599 A +relay trace shows glGetString is crashing inside glGetString. The cause is _not_ a lacking opengl context setup around glGetString. I did some testing and both on windows and wine glGetString just returns NULL if this is the case, but it never crashes inside glGetString: /* glGetString without opengl context: */ 0009:Call opengl32.glGetString(00001f01) ret=004016bc 0009:Ret opengl32.glGetString() retval=00000000 ret=004016bc /* Crash from Autocad */ 0064:Call opengl32.glGetString(00001f01) ret=1000cd58 0064:trace:seh:raise_exception code=c0000005 flags=0 addr=0x60ec12f6 0064:trace:seh:raise_exception info[0]=00000000 /* and never returns*/ This bug has been reproduced by several other people , so it's also not due to a bad gl-setup on my side. In case you want to try , Autocad trial 2004 can be downloaded from http://www.brothersoft.com/autocad-78351.html. It's the main issue that prevent autocad 2004 up to 2008 from running. So for now my conclusion is, this is a nasty bug outside wine, and an exception handler is needed to work around the crash. If the patch is rejected i would appreciate some input. Thanks and regards _____ Not happy with your email address? Get the one you really want <http://uk.docs.yahoo.com/ymail/new.html> - millions of new email addresses available now at Yahoo! <http://uk.docs.yahoo.com/ymail/new.html>

1 0

App non running with +relay enabled
by Massimo 26 Jun '08

26 Jun '08

What could be the reason of an app running fine with no relay enabled, but exiting very soon with it enabled ? Best Regards Max

2 1

Re: shell32: iconcache.c: Add stub implementation for SHGetIconOverlayIndex[AW] (RESEND)
by Zac Brown 26 Jun '08

26 Jun '08

Zac Brown wrote: > Add stub implementation for SHGetIconOverlayIndex[AW]. > > Mentioned in Bug 7447, though it does not seem to need a full > implementation yet. Since its documented in MSDN, may as well add the > stub implementation of it. > > > ------------------------------------------------------------------------ > > Error in my comments. Scratch it, sending another...

1 0

Re: shell32: iconcache.c: Add stub implementation for SHGetIconOverlayIndex[AW]
by Zac Brown 26 Jun '08

26 Jun '08

Zac Brown wrote: > Add stub implementation for SHGetIconOverlayIndex[AW]. > > --Zac > > > ------------------------------------------------------------------------ > > scratch this one.

1 0

"remote" start/stop of relay/snoop output
by max＠veneto.com 25 Jun '08

25 Jun '08

I asked that question some years ago, and IIRC then it was not possible, so I resorted to add an external filter app in order to start/stop relays on an already running app. Filter app solved partially the problem : I could get the relay part I needed, but the speed was about the same as dumping the full relay on file. Now (as it was years ago for autocad r14...) I'm trying to trace some calls in autocad2005, but relay log becomes easily 10-20 GB in size, so quite useless. I think the log start/stop feature could be a *very* useful way to isolate needed relay part and to speed up tests. Is it still not possible nor faisible ? Max

3 4

Re: rasapi32: return an error for invalid paramaters
by James Hawkins 25 Jun '08

25 Jun '08

On Tue, Jun 24, 2008 at 3:47 PM, Austin English <austinenglish(a)gmail.com> wrote: > Changes like these are so simple that you really should go the extra 5 feet and write simple tests for them. -- James Hawkins

3 4

Re: [1/3] wininet/tests: add InternetErrorDlg tests
by James Hawkins 25 Jun '08

25 Jun '08

On Wed, Jun 25, 2008 at 11:00 AM, Alexander Morozov <amorozov(a)etersoft.ru> wrote: > Changelog: > Add InternetErrorDlg tests > > I ran these tests on Win98 and WinXP > > From 687f7d365b97d1da95db222e5bd5bbdf5c62c76f Mon Sep 17 00:00:00 2001 > From: Alexander Morozov <amorozov(a)builder.office.etersoft.ru> > Date: Wed, 25 Jun 2008 19:01:42 +0400 > Subject: [PATCH] wininet/tests: add InternetErrorDlg tests > > --- > dlls/wininet/tests/Makefile.in | 3 +- > dlls/wininet/tests/dialogs.c | 194 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 196 insertions(+), 1 deletions(-) > create mode 100644 dlls/wininet/tests/dialogs.c > > diff --git a/dlls/wininet/tests/Makefile.in b/dlls/wininet/tests/Makefile.in > index ba8f662..92d875b 100644 > --- a/dlls/wininet/tests/Makefile.in > +++ b/dlls/wininet/tests/Makefile.in > @@ -3,9 +3,10 @@ TOPOBJDIR = ../../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > TESTDLL = wininet.dll > -IMPORTS = wininet ws2_32 kernel32 > +IMPORTS = wininet ws2_32 kernel32 user32 > > CTESTS = \ > + dialogs.c \ > ftp.c \ > generated.c \ > http.c \ > diff --git a/dlls/wininet/tests/dialogs.c b/dlls/wininet/tests/dialogs.c > new file mode 100644 > index 0000000..c2f3878 > --- /dev/null > +++ b/dlls/wininet/tests/dialogs.c > @@ -0,0 +1,194 @@ > +/* > + * Wininet - dialog tests > + * > + * Copyright 2008 Alexander Morozov for Etersoft > + * > + * This library is free software; you can redistribute it and/or > + * modify it under the terms of the GNU Lesser General Public > + * License as published by the Free Software Foundation; either > + * version 2.1 of the License, or (at your option) any later version. > + * > + * This library is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this library; if not, write to the Free Software > + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > + */ > + > +#include "windows.h" > +#include "wininet.h" > + > +#include "wine/test.h" > + > +static LONG end_thread; > + > +static BOOL CALLBACK enum_wnd_proc(HWND hwnd, LPARAM lparam) > +{ > + SendMessageA(hwnd, WM_CLOSE, 0, 0); > + InterlockedIncrement(&end_thread); > + return TRUE; > +} > + > +static DWORD CALLBACK killer_thread(LPVOID param) > +{ > + /* Without Sleep(50) a window failed to close sometimes */ > + Sleep(50); > + while (!end_thread) > + EnumThreadWindows((DWORD)param, enum_wnd_proc, 0); > + return 0; > +} > + > +static void test_InternetErrorDlg(void) > +{ > + HANDLE hThread; > + HINTERNET hi, hc, hr; > + DWORD ret, id; > + > + hi = InternetOpenA("winetest", 0, NULL, NULL, 0); > + ok(hi != NULL, "InternetOpen failed\n"); > + hc = InternetConnectA(hi, "localhost", INTERNET_DEFAULT_HTTP_PORT, > + NULL, NULL, INTERNET_SERVICE_HTTP, 0, 0); > + ok(hc != NULL, "InternetConnect failed\n"); > + hr = HttpOpenRequestA(hc, "GET", "/", NULL, NULL, NULL, 0, 0); > + ok(hr != NULL, "HttpOpenRequest failed\n"); > + > + ret = InternetErrorDlg(NULL, NULL, ERROR_SUCCESS, 0, NULL); > + todo_wine > + ok(ret == ERROR_INVALID_HANDLE, "InternetErrorDlg failed\n"); > + > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_SUCCESS, 0, NULL); > + todo_wine > + ok(ret == ERROR_NOT_SUPPORTED, "InternetErrorDlg failed\n"); > + > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_FILE_NOT_FOUND, 0, NULL); > + todo_wine > + ok(ret == ERROR_NOT_SUPPORTED, "InternetErrorDlg failed\n"); > + > + end_thread = 0; > + hThread = CreateThread(NULL, 0, killer_thread, > + (LPVOID)GetCurrentThreadId(), 0, &id); > + ok(hThread != NULL, "create thread failed\n"); > + if (NULL != hThread) > + { > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_INTERNET_HTTP_TO_HTTPS_ON_REDIR, 0, NULL); > + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, > + "InternetErrorDlg failed\n"); > + InterlockedIncrement(&end_thread); > + ret = WaitForSingleObject(hThread, 3000); > + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); > + CloseHandle(hThread); > + } > + > + end_thread = 0; > + hThread = CreateThread(NULL, 0, killer_thread, > + (LPVOID)GetCurrentThreadId(), 0, &id); > + ok(hThread != NULL, "create thread failed\n"); > + if (NULL != hThread) > + { > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_INTERNET_POST_IS_NON_SECURE, 0, NULL); > + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, > + "InternetErrorDlg failed\n"); > + InterlockedIncrement(&end_thread); > + ret = WaitForSingleObject(hThread, 3000); > + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); > + CloseHandle(hThread); > + } > + > + end_thread = 0; > + hThread = CreateThread(NULL, 0, killer_thread, > + (LPVOID)GetCurrentThreadId(), 0, &id); > + ok(hThread != NULL, "create thread failed\n"); > + if (NULL != hThread) > + { > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_INTERNET_CLIENT_AUTH_CERT_NEEDED, 0, NULL); > + todo_wine > + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, > + "InternetErrorDlg failed\n"); > + InterlockedIncrement(&end_thread); > + ret = WaitForSingleObject(hThread, 3000); > + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); > + CloseHandle(hThread); > + } > + > + end_thread = 0; > + hThread = CreateThread(NULL, 0, killer_thread, > + (LPVOID)GetCurrentThreadId(), 0, &id); > + ok(hThread != NULL, "create thread failed\n"); > + if (NULL != hThread) > + { > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_INTERNET_INVALID_CA, 0, NULL); > + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, > + "InternetErrorDlg failed\n"); > + InterlockedIncrement(&end_thread); > + ret = WaitForSingleObject(hThread, 3000); > + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); > + CloseHandle(hThread); > + } > + > + end_thread = 0; > + hThread = CreateThread(NULL, 0, killer_thread, > + (LPVOID)GetCurrentThreadId(), 0, &id); > + ok(hThread != NULL, "create thread failed\n"); > + if (NULL != hThread) > + { > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_INTERNET_SEC_CERT_CN_INVALID, 0, NULL); > + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, > + "InternetErrorDlg failed\n"); > + InterlockedIncrement(&end_thread); > + ret = WaitForSingleObject(hThread, 3000); > + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); > + CloseHandle(hThread); > + } > + > + end_thread = 0; > + hThread = CreateThread(NULL, 0, killer_thread, > + (LPVOID)GetCurrentThreadId(), 0, &id); > + ok(hThread != NULL, "create thread failed\n"); > + if (NULL != hThread) > + { > + ret = InternetErrorDlg(GetDesktopWindow(), hr, > + ERROR_INTERNET_SEC_CERT_DATE_INVALID, 0, NULL); > + ok(ret == ERROR_CANCELLED || ret == ERROR_SUCCESS, > + "InternetErrorDlg failed\n"); > + InterlockedIncrement(&end_thread); > + ret = WaitForSingleObject(hThread, 3000); > + ok(ret == WAIT_OBJECT_0, "thread wait failed\n"); > + CloseHandle(hThread); > + } > + > + /* This crashes Crashes what? Wine? Windows? If it crashes Windows, the test needs to be if-def'ed out, not commented out. If it crashes on Wine but not Windows, then this patch is wrong. You can't submit a test that crashes in Wine, even if it's commented out. The part that crashes has to be fixed first. -- James Hawkins

1 0

richedit: fix failing EM_GETCHARFORMAT test on all platforms
by Alex Villacís Lasso 25 Jun '08

25 Jun '08

Default richedit font (System) in Windows causes native richedit to report CFM_BOLD as always set, regardless of selection, or previous calls to EM_SETCHARFORMAT. Switch to Courier New in order to see that richedit really sets the CFM_BOLD attribute in the correct selection. This fix was successful in removing failure in WinXP-SP2 (real machine) and in Win98 (QEMU virtual machine). However, could you please test on other platforms (win2k, win2k3, Vista) to see whether it removes the failure there too? I want to be extra sure that this test actually passes on all platforms. Changelog: * Fix failing EM_GETCHARFORMAT test on all platforms -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1