June 2008 - Wine-devel - list.winehq.org

RE: ddraw: Stop crash when dd7 isnt installed
by Stefan Dösinger 24 Jun '08

24 Jun '08

> Changelog: > ddraw: Stop crash when dd7 isnt installed Do you really think it is worth polluting the code for this case? I haven't seen a windows box without dx7 since a LONG time. If you want to prevent a crash I think it is better to add some santiy checks at the beginning of the test and skip all the tests rather than polluting every test with lots and lots of possible error conditions coming from old dx versions

1 0

[PATCH] WM_IME_SETCONTEXT is sent when a window is activated
by Christopher GAUTIER 24 Jun '08

24 Jun '08

Hello, Following up on http://www.winehq.org/pipermail/wine-patches/2008-May/055400.html >> Description: >> The WM_IME_SETCONTEXT message should be sent when a window is >> (de)activated >> (source: >> http://msdn.microsoft.com/en-us/library/ms776117(VS.85).aspx) >> The value for lParam was obtained by spying on the messages when >> activating and deactivating the window. On Sat May 31, Vitaliy Margolen wrote: >Please add a test for this to user32/test/msg.c test Having read user32/test/msg.c, it seems to me that the test is already written, since the WM_IME_SETCONTEXT message is in many cases specified as following WM_ACTIVATE in the various 'message Wm*[]' structures. Please tell me if something more needs to be done. Cheers, Christopher

1 0

Re: user32:tests:msg.c Remove TODO flag from a test.
by Alexandre Julliard 24 Jun '08

24 Jun '08

Anatoly Lyutin <vostok(a)etersoft.ru> writes: > The test does not falls at the current Wine. Yes it does: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so msg.c && touch msg.ok msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0046 was expected, but got msg 0x0086 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0086 was expected, but got msg 0x0006 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0006 was expected, but got msg 0x0009 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0009 was expected, but got msg 0x0008 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg 0x0008 was expected, but got msg 0x0007 instead msg.c:4334: Test failed: SetWindowPos:show_visible_popup_3: the msg sequence is not complete: expected 0007 - actual 0000 msg.c:10040: Tests skipped: Skipping DBCS WM_CHAR test in SBCS codepage 'ANSI Latin 1' msg.c:10859: Tests skipped: UnhookWinEvent is not available make[2]: *** [msg.ok] Error 6 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: [2/2] gdi32: implementation of CreateFontIndirectEx (fix for13064) (resent)
by Dmitry Timoshkov 24 Jun '08

24 Jun '08

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: > +/*********************************************************************** > + * CreateFontIndirectExA (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectA(&(plf->elfEnumLogfontEx.elfLogFont)); > +} > + > +/*********************************************************************** > + * CreateFontIndirectExW (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExW( const ENUMLOGFONTEXDVW *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectW(&(plf->elfEnumLogfontEx.elfLogFont)); > +} You neither removed the 'if(!plf)' check, nor added a test or an explanation for this. > + if(!pCreateFontIndirectExA) > + skip("CreateFontIndirectExA not implemeted on this platform\n"); > + else > + { > + memcpy(&lfex.elfEnumLogfontEx.elfLogFont, &lf, sizeof(lf)); > + hfont = create_font_ex("Arial", &lfex); > + DeleteObject(hfont); > + } Presumably CreateFontIndirectEx uses the whole ENUMLOGFONTEXDVA structure, not just LOGFONT, so you need to fully initialize it. Also please remove trailing line spaces. -- Dmitry.

2 4

Re: [PATCH 5/7] widl: Fix type_memsize to follow aliases so that the correct size is calculated.
by Dan Hipschman 24 Jun '08

24 Jun '08

On Mon, Jun 23, 2008 at 10:29:11PM +0100, Rob Shearman wrote: > diff --git a/tools/widl/typegen.c b/tools/widl/typegen.c > index 1f8695a..84115fd 100644 > --- a/tools/widl/typegen.c > +++ b/tools/widl/typegen.c > @@ -809,7 +809,9 @@ size_t type_memsize(const type_t *t, unsigned int *align) > { > size_t size = 0; > > - if (t->declarray && is_conformant_array(t)) > + if (t->kind == TKIND_ALIAS) > + size = type_memsize(t->orig, align); > + else if (t->declarray && is_conformant_array(t)) > { > type_memsize(t->ref, align); > size = 0; What type of thing is this needed for? A typedef'd type should have all the same fields as the original except for the attributes, so for most cases in type_memsize it shouldn't be necessary to check whether the type is an alias. For anything that needs to check attributes, I would think it would be better to fix the predicates (such as is_conformant_array, etc.) if they do not detect that correctly 100% of the time.

2 1

Re: [2/8] gdi32: Implementation of CreateFontIndirectEx with test(fixes bug 13064)
by Dmitry Timoshkov 24 Jun '08

24 Jun '08

"Nikolay Sivov" <bunglehead(a)gmail.com> wrote: > +/*********************************************************************** > + * CreateFontIndirectExA (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExA( const ENUMLOGFONTEXDVA *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectA(&(plf->elfEnumLogfontEx.elfLogFont)); > +} > + > +/*********************************************************************** > + * CreateFontIndirectExW (GDI32.@) > + */ > +HFONT WINAPI CreateFontIndirectExW( const ENUMLOGFONTEXDVW *plf ) > +{ > + if(!plf) return NULL; > + > + return CreateFontIndirectW(&(plf->elfEnumLogfontEx.elfLogFont)); Why did you add the if(!plf) check? > +static HFONT create_font_ex(const char* test, const ENUMLOGFONTEXDV* lfex) > +{ > + HFONT hfont = CreateFontIndirectExA(lfex); > + ok(hfont != 0, "CreateFontIndirectEx failed\n"); > + if (hfont) > + check_font(test, &(lfex->elfEnumLogfontEx.elfLogFont), hfont); > + return hfont; > +} You need to load CreateFontIndirectExA dynamically, otherwise the test won't run under NT4/Win9x. > static void test_logfont(void) > { > LOGFONTA lf; > + ENUMLOGFONTEXDVA lfex; > HFONT hfont; > > memset(&lf, 0, sizeof lf); > @@ -137,6 +147,10 @@ static void test_logfont(void) > hfont = create_font("Arial", &lf); > DeleteObject(hfont); > > + lstrcpyA(lfex.elfEnumLogfontEx.elfLogFont.lfFaceName, "Arial"); > + hfont = create_font_ex("Arial", &lfex); > + DeleteObject(hfont); All the code in test_logfont() fully initializes the LOGFONT before passing it to an API, the test above doesn't, is there any reason for that? -- Dmitry.

1 0

Re: richedit: Ensure caret is seen if moved past end of view over trailing spaces
by Dylan Smith 23 Jun '08

23 Jun '08

You can ignore this patch, I will resend it as a series with just what is dependant on it. Sorry about sending such a such a large series of patches before (44 of them) that seemed to be dependant on each other. They actually didn't contain many dependencies on each other. I'll try to make the dependancies clearer next time. On Mon, Jun 23, 2008 at 5:10 PM, Dylan Smith <dylan.ah.smith(a)gmail.com> wrote: > To test the bug, open up Wine's wordpad (try with native and builtin > riched20), then enter a line of text that ends with enough trailing > spaces to go past the end of the richedit control. In native richedit > controls the cursor is prevented from going past end of the richedit > control so that it stays visisble while still being moved over the > spaces that continue off the end of the view. This patch makes sure > Wine's builtin richedit controls do the same thing as Windows. > > The above steps will also show another bug that I have just submitted a > patch for, with a subject "richedit: Spaces at the end of a line should > not affect alignment shift length". > > For this patch will depends on a previous patch I submitted on June 17th > in order to apply cleanly. The email for the patch had a subject > "[38/44] richedit: Hide cursor when text is selected". > --- > dlls/riched20/caret.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) >

1 0

Re: [updated] winecfg: Added Windows registration information setting
by Alex Villacís Lasso 23 Jun '08

23 Jun '08

Filipe Ferreira escribió: > This is a combination of both patches from my earlier submission. The > reason I made them separate was because I am unable to test other > languages besides > English. Though, if anyone could tell me how to run wine under a > different language, I would test them. > Find out the corresponding language and country code for the particular country and language combination you want to test, then run like this in a terminal: LANG=ja_JP.UTF-8 winecfg The above example runs winecfg with Japanese resources. It is what I used to run Japanese dating sims under Wine (just to test DirectSound and msacm32 support - I hereby disclaim any implied or explicit assertion of knowledge of the Japanese language). -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

1 0

Re: widl: The offset to the pointer layout in complex structures must be positive so add an assert and fix the format string.
by Alexandre Julliard 23 Jun '08

23 Jun '08

"Rob Shearman" <robertshearman(a)gmail.com> writes: > Otherwise we could generate an incorrect format string and crash in a > weird way at runtime instead. Looks like the assert works ;) ../../tools/widl/widl -I. -I. -I../../include -I../../include -D__WINESRC__ -D_OLEAUT32_ -DCOM_NO_WINDOWS_H -p -P oleaut32_oaidl_p.c oleaut32_oaidl.idl widl: typegen.c:1856: write_struct_tfs: Assertion `absoff >= *tfsoff' failed. make[2]: *** [oleaut32_oaidl_p.c] Aborted -- Alexandre Julliard julliard(a)winehq.org

2 1

how to run wine under a different language
by Detlef Riekenberg 23 Jun '08

23 Jun '08

On Mo, 2008-06-23 at 02:41 -0400, Filipe Ferreira wrote: > (Anyone care to share how to run wine under a different language?) - Install the language - Select the language from "locale -a" LC_ALL=de_DE.utf8 wine winecfg LC_ALL=en_US.utf8 wine winecfg LC_ALL=it_IT.utf8 wine winecfg -- By by ... Detlef

1 0