June 2008 - Wine-devel - list.winehq.org

programs: add rudimentary dxdiag
by Louis. Lenders 08 Jul '08

08 Jul '08

Hi, any comments on this one? btw, is there a reason i never ever receive any comments on my patches when they are rejected? If so, please tell me, that'll save me a lot of time of sending them in... ----- Forwarded Message ---- From: Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> To: wine-patches(a)winehq.org Sent: Thursday, 26 June, 2008 3:20:04 AM Subject: Re: programs: add rudimentary dxdiag Hi, some apps like Gameshadow (http://www.gameshadow.com/) check for dxdiag.exe, and give an error if it's not found, so wine needs its own. Instead of simple stub, this patch also adds the (simplified) d3d test like seen in native dxdiag, so users can test if their d3d is setup correctly. Screenshot can be seen here: http://bugs.winehq.org/attachment.cgi?id=14342 A few remarks: -patch contains binary code for a bitmap, so to apply again i had to do git apply dx.patch git add programs/dxdiag/ tools/make_makefiles autoconf maybe there's a simpler way, but i dunno - code for spinning cube was partially based on spinning cube code scattered all over the internet -rest was ripped of winecfg - There' s a problem while minizing the d3d-window, but running it in wine-0.9.22 it all goes fine, so this must be a regression somewhere, and not a bug in the attached code. I'll go after that later. - Hopefully you're not to picky on this patch, it 's quite some line's of code,and i'm sure things need to be improved, but this does not affect wine's core code but os rather an enhancement, and it 's not really possible to send it in in small chuncks. ________________________________ Not happy with your email address? Get the one you really want - millions of new email addresses available now at Yahoo! __________________________________________________________ Not happy with your email address?. Get the one you really want - millions of new email addresses available now at Yahoo! http://uk.docs.yahoo.com/ymail/new.html

8 15

Lots of input messages lingering in server slowing down wine tremendously?
by Alexander Dorofeyev 08 Jul '08

08 Jul '08

Hi. There was a problem found recently in a fan-made mod of Forsaken (game), that certain input combinations were slowing wine very seriously. Holding down a keyboard button and moving mouse was found to be especially devastating to performance (200 fps to 10fps in a matter of 10-20 seconds). With help from people who develop this mod, I was able to isolate it in a very small and simplistic testcase, which shows this same problem. It will be included as attachment. Holding a key and moving mouse over the window steadily increases main loop latency from 10 to 50 (and even 100) in a short time, especially so if quickly clicking both mouse buttons as well. In a game this means going from 100 fps to 20 or 10 just because of input messages. Has to be noted that in the actual game the rate of slowdown seemed at least 2-3 times faster for reasons I don't know, but the testcase still should enough to show the problem. Now, I do realize that what the testcase is doing is bad practice, it's basically refusing to process certain types of messages, and PeekMessage just once during a loop is probably bad as well, but that's what the game was originally doing in its main game loop. They do plan to fix it in the game. Still, there are several concerns about it: 1) No slowdown happens of Windows as far as I can tell. No matter how much I move the mouse holding key and clicking madly, it shows same stable 15-16 ticks latency in the testcase. I don't know what it does, but somehow it handles this situation better than Wine. 2) Can this (broken) way of doing things be exposing some inefficiency in message handling, maybe something that could use optimization? I tried to put debug hacks into queue_hardware_message(), it seems that when slowdown is already VERY bad in Forsaken (10fps), message queue in wine server has about 400 or maybe 600 messages. Is that kind of processing overhead per message inevitable? (This is happening on AMD Athlon(tm) 3200+). Perhaps somebody who knows that part of code well may be interested in looking into performance issues in this case. Because, if 400-600 messages in the queue slow down the application to a crawl, then who knows, perhaps it decreases performance of more well-behaved but input-intensive apps as well, just less drastically (holding one or several keys to move, all the while aiming with mouse and abusing mouse buttons is a common thing in games, so there can be quite a few input messages flooding the server). The reason I decided to post it to wine-devel is because I'm not sure if this kind of thing is expected and unavoidable or a bug that can be fixed, so better to hear some comments first, then a bug entry can be opened if needed. #include <windows.h> HWND window; int PASCAL WinMain(HINSTANCE hInstance, HINSTANCE hPrevInstance, LPSTR lpCmdLine, int nCmdShow) { WNDCLASS wc = {0}; MSG msg; DWORD ticks, ticks2; HHOOK kbd_hook, mouse_hook; wc.lpfnWndProc = &DefWindowProc; wc.lpszClassName = "testwc"; RegisterClass(&wc); window = CreateWindow("testwc", "test", WS_OVERLAPPED | WS_VISIBLE | WS_CAPTION , 0, 0, 640, 480, 0, 0, 0, 0); ticks = GetTickCount(); for (;;) { if (PeekMessage(&msg, NULL, WM_NULL, WM_KEYFIRST, PM_REMOVE)) { if (msg.message == WM_QUIT) { DestroyWindow(window); break; } TranslateMessage(&msg); DispatchMessage(&msg); } //simulated work ticks2 = GetTickCount(); for (;;) { UINT i; volatile int dummy = 1; for (; i < 10000 && dummy; i++) ; if (GetTickCount() - ticks2 >= 10) break; } printf("main loop %u tick latency\n", GetTickCount() - ticks); ticks = GetTickCount(); } }

2 1

Alternate shell?
by Dan Kegel 06 Jul '08

06 Jul '08

For a maximal dogfood experience, I was looking around for a way to use a replacement Windows shell with Wine as my desktop environment instead of gnome or kde. So far, all the ones I've found are either broken, hard to use, or just plain weird. I've been working through the list at http://www.dmoz.org/Computers/Software/Operating_Systems/Microsoft_Windows/… http://www.astonshell.com/aston/ - couldn't figure out how to run it? http://www.emergedesktop.org/ - kind of works, but very minimal, no start menu http://www.labyrinth.net.au/~mosses/rob/liteshell.html - works, but very minimal, no start menu http://purels.org - no help, just exits, saying "ha ha, you didn't configure me". Obviously not meant for me :-) http://www.lighttek.com/talisman.htm - pretty, but no Programs menu?! (Maybe that's there but broken, wine bug?) http://www.sky.franken.de/explorer/download.html - ROS explorer - prebuilt binary there is 3 years out of date, doesn't work too well Anyone have a favorite I should try? - Dan

11 19

New winetricks 20080402: new verbs dotnet20, win2k, flash, msls31; updated mono, liberation
by Dan Kegel 03 Jul '08

03 Jul '08

Big news: as of today or so, wine doesn't need any patches to install the .net 2.0 runtime or run trivial .net 2.0 apps, so I've added a dotnet20 verb. No more futzing with recipes to try out simple .net 2 apps, huzzah! There are lots of other little changes, too: 20080402 r21 Added dotnet20, removed one kludge from dotnet11, added win2k verb, plus shorthand for winver=foo r20 Updated liberation fonts. 20080328 r19 Added flash. 20080326 r18 Fix i18n problem reported by Ricardo Cabral 20080321 r17 Added msls31 (seems to be needed by e-Sword) 20080317 r16 update mono12 to 1.2.9 ... As always, winetricks is downloadable from http://kegel.com/wine/winetricks and change history is at http://code.google.com/p/winezeug Thanks to the folks who keep feeding me improvements and suggestions! - Dan

4 3

richedit: do not read actual scrollbar state for scrollbar update, use internal state instead
by Alex Villacís Lasso 02 Jul '08

02 Jul '08

This is supposed to be a fix for bug #12311 . This bug involves a recursive message loop where the application forces visibility of scrollbars for the richedit control, which causes a WM_SIZE that triggers an update of the window size and re-hiding of the scrollbar. However, just after exiting the richedit winproc, the app forces visibility again, which again triggers a WM_SIZE, and so on. Native is oblivious to the fact that an external agent is messing with the scrollbar visibility, and is therefore unaffected by recursion. This patch attempts to fix this behavior in builtin and test for it. I have tried to test it on WinXP-SP2 and Win98, but testing on other platforms is helpful too. Changelog: * Use internal copy of scrollbar state instead of directly reading state from scrollbars, just as native does. * Tests for ability to externally modify scrollbars. * Test for behavior that caused recursion until builtin richedit was fixed. -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 2

re: secur32: Allow loading external schannel.dll.
by Juan Lang 02 Jul '08

02 Jul '08

Hi Zhangrong, your patch looks fine, but I'd appreciate it if you could update the comment for SECUR32_addProvider in secur32_priv.h to reflect your changes. --Juan

4 5

Made ENTER_GL() - LEAVE_GL() free X11 lock on exception inside opengl, code
by Louis. Lenders 01 Jul '08

01 Jul '08

>And as was shown, Wine correctly returns NULL when its called without a context, so there is >something else making it crash. It may be a buggy driver. It may be memory corruption Wine is >causing.. who knows. i don't think it's buggy driver, this happens as far as i know for various people, so i'd guess various cards/drivers. Is there a way to track down what AutoCAD returns in this call to glGetString on Windows? Btw, the installer even finishes fine with native opengl32.dll ( no, this is not a joke!), so somehow i have the feeling that an exception handler is the right way anyway, but i lack knowledge of opengl, so i'll shut up for now ;) ) __________________________________________________________ Not happy with your email address?. Get the one you really want - millions of new email addresses available now at Yahoo! http://uk.docs.yahoo.com/ymail/new.html

4 3

Re: richedit: Store richedit version rather than boolean bEmulateVersion10 value.
by Phil Krylov 01 Jul '08

01 Jul '08

Hi, 2008/6/27 Dylan Smith <dylan.ah.smith(a)gmail.com>: > riched20.dll is implementing all the versions of richedit controls (1.0, 2.0, > 3.0, and 4.1), so it is better to store the version that is being emulated. > The bEmulateVersion10 value is replaced with dwEmulatedVersion. I thought it implements 1.0 emulation for riched32.dll usage and latest possible version for other usages - just like native. Or are you planning to add some functionality depending on the actual emulated version, not on (dwEmulatedVersion < 0x200) boolean flag? -- Ph.

3 5

source.google.com/git author search broken?
by Dan Kegel 30 Jun '08

30 Jun '08

I've been reduced to running 'git log --author=foo' locally because the author search on source.winehq.org isn't returning any results. For instance, http://source.winehq.org/git/wine.git/?a=search&h=HEAD&st=author&s=Julliard returns zero hits. Not really a huge problem, but it'd be nice if that worked again.

2 1

user32: Add additional tests for scroll state, make them pass under Wine
by Alex Villacís Lasso 30 Jun '08

30 Jun '08

This patch adds a few tests for scrollbar behavior in Windows. It shows that if the window was created with at least WS_VSCROLL or WS_HSCROLL styles, WinXP returns default information for scrollbar range, but Win98 returns an error, until first initialized. This error does not change if styles are set or cleared before initializing ranges. On both versions, setting either scrollbar range automatically initializes both if required (Wine still returned error for the other scrollbar - fix included). I have tried to test this on Win98 and WinXP-SP2, but maybe other versions are different. Could you please test this patch? Also, is it OK to tell apart Win9x vs. WinXP behavior in the way it is done in this patch? Once either behavior is identified, it is consistent on all future tests, as shown by the tests. Wine fixed to implement Win98 behavior. Changelog: * Document and test differences between WinXP and Win98 scrollbar behavior * Make tests pass under Wine (Win98 behavior) -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

3 3