June 2008 - Wine-devel - list.winehq.org

DX6 more compatibility.
by slawek 29 Jun '08

29 Jun '08

I have one game, that needs DX6, but lowest clone version of DX is 7. The game don't run, because in <source>dlls/ddraw/surface.c:IDirectDrawSurface7Impl_AddAttachedSurface is check the surface have z-buffer. There's a notice, that the check been added, because of information in msdn about this function. This information suggested, that DX returning error if surface don't have z-buffer. If I remove this block and " Caps.dwCaps |= DDSCAPS_BACKBUFFER;" line in IDirectDrawSurfaceImpl_Flip, the game will run and there's no graphics issue. I think, that game written for DX7 won't give surface without z-buffer as parameter to this functions, but code, that i removed is bad for dx less 7 games. I read in winehq.org, that some games(like capitalism) have the same issue(displaying the same error message), so my hack will repair it. Sorry for my english, I still learning.

5 8

sound3d patch
by Martin 29 Jun '08

29 Jun '08

Hi. I am working on a patch to fix a bug which prevents certain games from starting. The bug will make wine spit out: fixme:dsound3d:IDirectSound3DListenerImpl_QueryInterface Unknown IID {31efac30-515c-11d0-a9aa-00aa0061be93} right before it crashes(see bug 12240). I am working on implementing the ability to return this interface by calling the function that fails(IDirectSound3DListenerImpl_QueryInterface()) with an already acquired (dsound?) interface and IID being IKsPropertySet. I was able to make a patch which helped me get around this bug in one game, but I don't have very deep knowledge of how wine works internally. Because of that, I am not sure if I should implement something more to prevent other issues. Also, I don't know if I need to make some changes to make the patch more "correct" or complete. If somebody could have a look at the patch, or try it out or give me any other feedback, that would be appreciated. Thanks for any feedback! Martin

4 4

OFN_ENABLESIZING support in standard dialogs
by Chris Howe 29 Jun '08

29 Jun '08

Bugs 5034, 10284 and 10394 relate to un-resizable file open dialogs in various programs - to be honest I came across this discrepancy running native NOTEPAD.EXE. The file open dialogs are implemented in comctl32, specifically filedlg.c and the templates live in cdlg_xx.rc In Windows, to make them resizable one uses the OFN_ENABLESIZING flag, which is amongst Wine's UNHANDLED_FLAGS, so it has no effect in Wine. Reading the history this flag has been available in all versions of Windows from 98 up. I am wondering how to go about supporting this flag though, weather the dialog templates need changing, or if we could add the support purely in the dialog creation code? -- Chris

1 0

Bad links in 1.1.0 announce
by Alexei 29 Jun '08

29 Jun '08

There are two links: http://ibiblio.org/pub/linux/system/emulators/wine/wine-1.0.tar.bz2 http://prdownloads.sourceforge.net/wine/wine-1.0.tar.bz2 in http://winehq.org/?announce=1.1.0, but it's stable version, normal link is: http://ibiblio.org/pub/linux/system/emulators/wine/wine-1.1.0.tar.bz2

1 0

Re: quartz Rewrite the avi splitter so that video and sound run in separate threads, with tests
by Detlef Riekenberg 29 Jun '08

29 Jun '08

On Mi, 2008-06-25 at 21:34 -0700, Maarten Lankhorst wrote: > Because of the magnitude of the change I cannot split this patc hup, > my apologies for this. Without any view at your code, the sentense above is wrong by design. A Test is always independant from the implementation, and what permit a seperate patch for test_threads() to split the tests? -- By by ... Detlef

2 3

Re: README: Add Russian translation (3rd try)
by Nikolay Sivov 28 Jun '08

28 Jun '08

Vladimir Pankratov wrote: > You wrote: > >>> > Другие операционные системы которые поддерживают нити ядра могут >>> поддерживаться в будущем. >>> >>> "системы, которые поддерживают нити ядра, могут" >>> >> "нити"? I thought it should be "потоки". > > How to translate: "потоки ядра" or "потоки в ядре"? > > Thanks. > I think "потоки ядра" is better. It better corresponds to "kernel thread".

2 1

Re: Made ENTER_GL() - LEAVE_GL() free X11 lock on exception inside opengl, code
by Chris Robinson 28 Jun '08

28 Jun '08

On Saturday 28 June 2008 07:51:53 am Massimo Del Fedele wrote: > Roderick Colenbrander ha scritto: > > Hi, > > > > I don't think we want to go this way. First of all we want to emulate > > win32 opengl. If windows does this we MIGHT have to do something like > > this. > > Well, I've never seen windows hang for an opengl call exception... But I > can be wrong. IMHO the exception should be catched and/or propagated, > not allowed to block the whole app..... > Here the problem is that an exception thrown by gl code skips the > wine_tsx11_unlock() call, blocking all following X11 code. I think the issue is that it shouldn't be crashing. Especially if we don't know why it's crashing, this patch is just hiding the error more than anything. For all we know it can be a buffer overrun somewhere, and you don't want to just work around things like that. > > Second all opengl calls hit ENTER_GL / LEAVE_GL and these few extra calls > > affect performance. > > which extra calls ? The __TRY stuff. It's rather expensive to set up an exception block, even in C++ where it's part of the language (let alone how Wine does it in C). But we do know D3D doesn't catch exceptions in most cases (it can crash in plenty of ways), so I don't think this is correct anyway.

2 2

Re: crypt32: CertComparePublicKeyInfo must ignore the leading zero
by Juan Lang 28 Jun '08

28 Jun '08

Hi Michael, this patch causes the chain tests to fail for me: ../../../tools/runtest -q -P wine -M crypt32.dll -T ../../.. -p crypt32_test.exe.so chain.c && touch chain.ok fixme:crypt:CertVerifyCertificateChainPolicy unimplemented for 0 chain.c:1769: Test failed: 13: expected 800b0109, got 800b010d make: *** [chain.ok] Error 1 You have a typo: + pblob2 = CryptMemAlloc(length); + if (CryptDecodeObject(dwCertEncodingType, RSA_CSP_PUBLICKEYBLOB, + pPublicKey1->PublicKey.pbData, pPublicKey1->PublicKey.cbData, + 0, pblob2, &length)) I believe you mean: + pblob2 = CryptMemAlloc(length); + if (CryptDecodeObject(dwCertEncodingType, RSA_CSP_PUBLICKEYBLOB, + pPublicKey2->PublicKey.pbData, pPublicKey2->PublicKey.cbData, + 0, pblob2, &length)) With that change, the tests pass for me (and makecert works too.) Would you mind fixing it and resending? --Juan

1 0

Re: inetmib1(3/31): Add tests for SnmpExtensionInit
by Paul Vriens 28 Jun '08

28 Jun '08

Juan Lang wrote: > --Juan > > These tests import snmpapi, which isn't available on win95. Do we need to cater for that and do LoadLibrary/GetProcAddress ? -- Cheers, Paul.

3 4

Re: [Gdiplus 6/6] Don't check for succeeding functions, they always do
by James Hawkins 28 Jun '08

28 Jun '08

On Fri, Jun 27, 2008 at 7:16 PM, Adam Petaccia <adam(a)tpetaccia.com> wrote: > > Subject: [Gdiplus 6/6] We're not checking to see if these functions > succeed or not, they all just return Ok. > The point of regression tests is to prove that this is always the case... -- James Hawkins

2 3