June 2008 - Wine-devel - list.winehq.org

Re: [31/44] richedit: Set error codes and stop parsing for some rtf syntax errors.
by Rob Shearman 18 Jun '08

18 Jun '08

Dylan Smith wrote: > + if (!inStream.editstream->dwError && parser.stackTop > 0) > + inStream.editstream->dwError = -2147024858; This should be HRESULT_FROM_WIN32(ERROR_HANDLE_EOF). -- Rob Shearman

2 1

Re: [19/44] user32: Increased area for scrolling via mouse drag outside scrollbar
by Rob Shearman 18 Jun '08

18 Jun '08

Dylan Smith wrote: > + /* Distance beside or past the ends the scrollbar for the mouse can be dragged > + * away from scrollbar and still be considered in the scrollbar. */ > +#define SCROLL_DRAG_ZONE_PADDING_BESIDE 138 > +#define SCROLL_DRAG_ZONE_PADDING_PAST_END 34 This should be a proportion of the scrollbar width/height instead of absolute values in pixels. -- Rob Shearman

2 1

Re: [PATCH 2/2] shell32: SHFileOperation can move several files into one directory
by Vitaly Perov 18 Jun '08

18 Jun '08

> The move operation can already do this. Why is this patch necessary? > The test you sent in already passes, so this 'fix' is not being tested > at all. I've checked my test again. It fails! $ wine shell32_test.exe.so shlfileop So, the result is: shlfileop.c:171: Test failed: SHGetFileInfoA(c:\nonexistent | SHGFI_ATTRIBUTES) failed shlfileop.c:178: Test failed: SHGetFileInfoA(c:\nonexistent | SHGFI_EXETYPE) returned 0 shlfileop.c:1230: Test failed: Expected ERROR_SUCCESS, got 1223 shlfileop.c:1231: Test failed: Expected one.txt to not exist shlfileop.c:1232: Test failed: Expected one2.txt to not exist shlfileop.c:1233: Test failed: Expected one.txt to exist shlfileop.c:1234: Test failed: Expected one.txt to exist shlfileop: 582 tests executed (0 marked as todo, 7 failures), 0 skipped. Could you check it again, please. -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

2 1

Re: gdi32: Add a test for outline text metrics
by Alexandre Julliard 18 Jun '08

18 Jun '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Changelog: > gdi32: Add a test for outline text metrics. This doesn't work for me: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:248: Test failed: expected scale_x 1, scale_y 1, got cx 0, cy 1 font.c:254: Test failed: max width 5502 != 5515 font.c:267: Test failed: cx 9878 != 9902 font.c:1459: Tests skipped: Symbol or Wingdings is not installed font.c:1475: Tests skipped: Symbol or Wingdings is not installed font.c:1583: Tests skipped: Symbol is not installed font.c:2237: Tests skipped: Arial Black or Symbol/Wingdings is not installed font.c:1793: Tests skipped: Font DejaVu Sans doesn't contain 'x', skipping the test font.c:1793: Tests skipped: Font DejaVu Sans Condensed doesn't contain 'x', skipping the test font.c:1793: Tests skipped: Font OpenSymbol doesn't contain 'x', skipping the test make[2]: *** [font.ok] Error 3 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: richedit: resend 01 [Fwd: richedit: fix misreporting of match offset for EM_FINDTEXT and EM_FINDTEXTEX]
by Alexandre Julliard 18 Jun '08

18 Jun '08

Alex Villacís Lasso <a_villacis(a)palosanto.com> writes: > -- > perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);' > > From: Alex Villacís Lasso <a_villacis(a)palosanto.com> > Subject: richedit: fix misreporting of match offset for EM_FINDTEXT and EM_FINDTEXTEX > To: wine-patches(a)winehq.org > Date: Fri, 2 May 2008 13:01:49 -0500 (ECT) > > Forward search that spans across more than one run in a single paragraph > could report with an incorrect offset, due to the use of the last examined > run rather than the start-of-search run. > > Changelog: > * Fix misreporting of match offset for EM_FINDTEXT and EM_FINDTEXTEX > * Added test that failed until bug was fixed. Could you please resend the patches from scratch instead of forwarding your previous mail to the list again? It's a pain to extract the proper data from the embedded mail. Thanks. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] shell32: SHFileOperation can move several files into one directory
by Vitaly Perov 18 Jun '08

18 Jun '08

> The move operation can already do this. Why is this patch necessary? > The test you sent in already passes, so this 'fix' is not being tested > at all. Really? I'm sorry! I was testing at old version of wine. Thank you very much! I'll test it again! -- Best wishes, Vitaly Perov Russia, Saint-Petersburg. www.etersoft.ru

1 0

Valgrind status: 142 errors left
by Dan Kegel 18 Jun '08

18 Jun '08

Changes since yesterday: - added suppression for one more load order memory leak - added one patch by Lei, one by Andrew Tablot, and one by me This gets us down from 205 to 142. The huge reduction was due to http://kegel.com/wine/valgrind/logs-2008-06-17-patches/dank/dsound-primary-… which exposes a problem to the dsound unit tests, and lets them fail instead of continuing with invalid data. That's the last of the huge reductions, I think. (Please join the party! We can use all the help we can get getting rid of these bugs; though many are innocuous to users, a few aren't, and they're all annoying to anyone using valgrind. It remains to be seen how many of these patches Alexandre will accept after 1.0 is out, but I'm hopeful we can get most of them up to his standards.) Report showing unique nonleak errors: http://kegel.com/wine/valgrind/logs-2008-06-17.counts.txt Logs: http://kegel.com/wine/valgrind/logs-2008-06-17.log.gz http://kegel.com/wine/valgrind/logs-2008-06-17/ Pending wine patches: http://kegel.com/wine/valgrind/logs-2008-06-17-patches/ http://kegel.com/wine/valgrind/logs-2008-06-17-patches.tgz http://kegel.com/wine/valgrind/logs-2008-06-17-patch.txt Suppression file: http://kegel.com/wine/valgrind/valgrind-suppressions

1 0

Re: gdi32: stop font tests crashing under win98 (try 2)
by Dmitry Timoshkov 18 Jun '08

18 Jun '08

"Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote: > - if (!*font_name && font_charset == DEFAULT_CHARSET) /* do it only once */ > + /* EnumFontFamilies with the NULL parameter crashes win98 */ > + if (pGetCharABCWidthsW && !*font_name && font_charset == DEFAULT_CHARSET) /* do it only once */ Have you actually tested this? GetCharABCWidthsW is exported by gdi32.dll in Win9x. -- Dmitry.

1 0

Re: gdi32: stop font tests crashing under win98 (try 2)
by Paul Vriens 18 Jun '08

18 Jun '08

Alistair Leslie-Hughes wrote: > Hi, > use a unicode mapped function to stop a test from running under win98 > > Changelog: > gdi32: stop font tests crashing under win98 > > Best Regards > Alistair Leslie-Hughes > > > ------------------------------------------------------------------------ > > + + if(!pGetGlyphIndicesA) + return; Could you add a win_skip to this? -- Cheers, Paul.

1 0

Re: msxml3: Improved checking of failed case
by Paul Vriens 18 Jun '08

18 Jun '08

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > msxml3: Improved checking of failed case > > Best Regards > Alistair Leslie-Hughes > > > ------------------------------------------------------------------------ > > - /* Win98 returns ERROR_URL_NOT_FOUND */ - ok(hr == S_OK || hr == ERROR_URL_NOT_FOUND, "Expected S_OK, got 0x%08x\n", hr); + ok(hr == S_OK, "Expected S_OK, got 0x%08x\n", hr); But this means the test will fail on Win98, is that on purpose? -- Cheers, Paul.

2 1