June 2008 - Wine-devel - list.winehq.org

Re: [PATCH] shell32: SHFileOperation can move several files into one directory
by James Hawkins 18 Jun '08

18 Jun '08

2008/6/17 Vitaly Perov <vitperov(a)etersoft.ru>: > The test was sent 2 hours ago > If FOF_MULTIDESTFILES flag is set it's not olny mean that pTo contains > multiple destination files, it also can contain one folder. > > Changelog: > - shell32: SHFileOperation can move several files into one directory > --- a/dlls/shell32/shlfileop.c +++ b/dlls/shell32/shlfileop.c @@ -1426,7 +1426,8 @@ static HRESULT move_files(LPSHFILEOPSTRUCTW lpFileOp, const FILE_LIST *flFrom, c return ERROR_CANCELLED; if ((lpFileOp->fFlags & FOF_MULTIDESTFILES) && - flFrom->dwNumFiles != flTo->dwNumFiles) + flFrom->dwNumFiles != flTo->dwNumFiles && + !IsAttribDir(fileDest->attributes)) { return ERROR_CANCELLED; } There is a glaring error right here. For one, you should heed compiler warnings: wine/dlls/shell32/shlfileop.c: In function 'SHFileOperationW': wine/dlls/shell32/shlfileop.c:1428: warning: 'fileDest' is used uninitialized in this function wine/dlls/shell32/shlfileop.c:1407: note: 'fileDest' was declared here You're using fileDest when it hasn't been initialized (as the warning says). Second, the tests fail: shlfileop.c:1132: Test failed: The file is not moved - many files are specified as a target shlfileop.c:1206: Test failed: Expected d.txt to not exist make: *** [shlfileop.ok] Error 2 -- James Hawkins

2 1

Remove LATER and REMIND bug resolutions
by Lei Zhang 18 Jun '08

18 Jun '08

Hi, It's been a week and nobody has responded to Dmitry's bug report [1] yet, so I'm going to bring it up here. I am all for it, does anyone have objections? - Lei [1] http://bugs.winehq.org/show_bug.cgi?id=13794

1 0

re: Fix DirectSound's primary buffer Volume and Pan handling
by Dan Kegel 18 Jun '08

18 Jun '08

On Jul 23, 2004, Francois Gouget wrote: > The patch removes the primary buffer's 'volpan' variable and instead > uses waveOutGetVolume() on dsound->hwo to get the current volume. This seems to be failing for me here on three different machines during the primary part of test_secondary() in dsound/tests/ds3d.c. You can see evidence of this in valgrind logs, e.g. http://kegel.com/wine/valgrind/logs-2007-12-06/vg-dsound_ds3d.txt or http://kegel.com/wine/valgrind/logs-2008-06-16/vg-dsound_ds3d.txt you can see valgrind getting annoyed that waveOutGetVolume didn't actually retrieve anything: Conditional jump or move depends on uninitialised value(s) at DSOUND_AmpFactorToVolPan (mixer.c:66) by PrimaryBufferImpl_GetVolume (primary.c:646) by test_secondary (ds3d.c:864) by dsenum_callback (ds3d.c:1303) by DirectSoundEnumerateA (dsound_main.c:315) by ds3d_tests (ds3d.c:1324) by func_ds3d (ds3d.c:1344) by run_test (test.h:449) by main (test.h:498) Uninitialised value was created by a stack allocation at PrimaryBufferImpl_GetVolume (primary.c:627) The test nevertheless happens to succeed on some machines, but not others. One machine it fails on (even without valgrind) says ds3d.c:896: Test failed: The primary pan changed from 673 to 656 because, I think, it's calculating the pan based on random values on the stack. A +dsound,+alsa,+wave log (and a few extra trace statements) shows trace:dsound:PrimaryBufferImpl_GetPan (0x132258,0x32fa48) trace:wave:ALSA_wodMessage (0, WODM_GETVOLUME, 00000000, 0032F8E4, 00000000); trace:wave:wodGetVolume (0, 0x32f8e4); trace:wave:wodGetVolume wDevId 0, hctl (nil) trace:alsa:ALSA_CheckSetVolume line 470; hctl (nil) trace:wave:wodGetVolume CheckSetVolume failed; rc 8 trace:dsound:DSOUND_AmpFactorToVolPan (0x32f8c8) trace:dsound:DSOUND_AmpFactorToVolPan left=3b34, right=7e59 trace:dsound:DSOUND_AmpFactorToVolPan Vol=-611 Pan=656 ds3d.c:896: Test failed: The primary pan changed from 673 to 656 ALSA_CheckSetVolume returns right early because hctl is NULL. I threw together a small test illustrating the problem; see the attached patch and log from problem machine. (Note that sound works on this machine, and running the main ds3d tests with WINETEST_INTERACTIVE=1 yields many tones in the headphones.) Could somebody who knows this code have a look? Thanks! - Dan

2 1

Re: Wine release 1.0
by John Freed 17 Jun '08

17 Jun '08

Congratulations!!!!!!!!! On Tue, Jun 17, 2008 at 4:20 PM, Alexandre Julliard <julliard(a)winehq.org> wrote: > The Wine team is proud to announce that Wine 1.0 is now available. > This is the first stable release of Wine after 15 years of development > and beta testing. Many thanks to everybody who helped us along that > long road! > > While compatibility is not perfect yet, thousands of applications have > been reported to work very well. Check http://appdb.winehq.org to see > the details for your favorite applications. > > The source is available from the following locations: > > http://ibiblio.org/pub/linux/system/emulators/wine/wine-1.0.tar.bz2 > http://prdownloads.sourceforge.net/wine/wine-1.0.tar.bz2 > > Binary packages for various distributions will be available from: > > http://www.winehq.org/site/download > > You will find documentation on http://www.winehq.org/site/documentation > > You can also get the current source directly from the git > repository. Check http://www.winehq.org/site/git for details. > > Wine is available thanks to the work of many people. See the file > AUTHORS in the distribution for the complete list. > > ---------------------------------------------------------------- > > Bugs fixed in 1.0: > > 3838 The Punisher demo crashes after the introduction movies > 3898 Counter-Strike 1.6 performance issue > 4755 X Error of failed request: BadDrawable (X_PolyFillRectangle) when > switching to Virtual Desktop > 6315 Starlancer draws ships as white when direct3d is enabled > 7268 Oni not opening after install > 8185 can't login in Skype 3.1 on wine/kubuntu 7 > 8634 antialiasing disabled in gtasa menu > 9555 Wine crash when I click help in Stata 10 > 9589 Static / Scratchy Sound with OSS in Call of Duty > 9903 WinRAR with NXServer - black icons > 10009 QIP: window z-order is still wrong > 10268 Robot Wars: Arena of Destruction crashes while quitting (causing > resolution to stay 640 x 480) > 10322 Eve-online (video memory misaddressed?) > 10700 Dragon Naturally Speaking 9 needs gdiplus.GdipDrawArcI, > gdiplus.GdipCreatePen2, ... > 11011 Call of Duty 1.0 doesn't run after install. > 11104 Dance Praise 2: Does not respond to input > 12415 Can not leave fullscreen Warcraft 3x (Regression) > 12963 Moto Racer 2 works with wine 0.9.60 and crashes with wine 0.9.61 > 13271 The demo of the punisher fails to install > 13740 winebrowser gets wrong URL, problem with unicode > > ---------------------------------------------------------------- > > Changes since 1.0-rc5: > > Alexandre Julliard (1): > Updated the authors list. > > Francois Gouget (3): > Remove spaces before '...' in the Danish resources. > regedit: Remove spaces before '...'. > winecfg: Remove spaces before '...'. > > Jaime Rave (1): > wineconsole: Update Spanish translation. > > Matthias Kupfer (1): > wordpad: Small typo fix for German translation. > > -- > Alexandre Julliard > julliard(a)winehq.org > >

1 0

Celebrating Wine 1.0
by Jeremy White 17 Jun '08

17 Jun '08

Woohoo!!!! Alexandre just posted the Wine 1.0 commit! I eagerly did my git update and enjoyed running 'wine --version'. Ooo. I'm going to do it again... Let us all have a moment of silence to mourn the passing of the Wine 1.0 jokes <grin>. Seriously, this is a major milestone for the Wine project. It is no small undertaking to create a complex Free Software project, and to bring it to a state of general usefulness. There are literally millions - if not more - people using this software we have built. This is a great accomplishment, and we all should be deeply proud of what we've accomplished. I think it's particularly important to thank each and every one of the 1076 AUTHORS and to recognize the support and work of the many people that have contributed to Wine without having their name in that file. I also think we should particularly take a moment to recognize the incredible work of our fearless leader - Alexandre Julliard - without whom none of this would have been possible. And then we should celebrate! I realize that any real large communal celebration will have to wait until we can gather for Wineconf. But I intend to gather up a gang of folks and go out for a meal to celebrate. I will lift a glass of Wine in toast to Alexandre and the many people that have worked on Wine, and I encourage everyone else to do the same. Ideally, people will become sufficiently happy to wax maudlin and we can capture all kinds of embarrassing stories on #winehackers <grin>. Cheers, Jeremy

3 3

About code freeze...
by Alex Villacís Lasso 17 Jun '08

17 Jun '08

Wine 1.0 is out! Great! Does this mean we are now out of code freeze? I have a bunch of richedit patches I submitted previously but were held up because of the code freeze. Is it time to submit them again? -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: ole32: Fix a failed call to DllGetClassObject while retrieving class object interface pointer.
by Robert Shearman 17 Jun '08

17 Jun '08

Huang, Zhangrong wrote: > See dlls/ole32/compobj.c, > > static HRESULT apartment_getclassobject(struct apartment *apt, LPCWSTR dllpath, > BOOL apartment_threaded, > REFCLSID rclsid, REFIID riid, > void **ppv) > { > ................... > if (SUCCEEDED(hr)) > { > .................. > TRACE("calling DllGetClassObject %p\n", > apartment_loaded_dll->dll->DllGetClassObject); > /* OK: get the ClassObject */ > hr = apartment_loaded_dll->dll->DllGetClassObject(rclsid, riid, ppv); > ^^^^ > if (hr != S_OK) > ERR("DllGetClassObject returned error 0x%08x\n", hr); > } > .............. > } > > Reference to http://msdn2.microsoft.com/en-us/library/ms680760.aspx, > > riid > > [in] Reference to the identifier of the interface that the caller > is to use to communicate with the class object. Usually, this is > IID_IClassFactory (defined in the OLE headers as the interface > identifier for IClassFactory). > This doesn't mean anything other than CoCreateInstance is usually used instead of CoGetClassObject (and CoCreateInstance always passes in IID_IClassFactory for the IID). > We can't pass riid to DllGetClassObject directly sometimes, causes some dlls' > DllGetClassObject (like native adsldp.dll) can only return reference-counted > pointer to class factory via IID_IClassFactory, for retrieving the > pointer to the > class object interface requested in riid, we must try another way. > Thank you for your patch, but this behaviour seems a little strange and needs a little more investigation before I am happy that it is correct. What parameters are being passed in to CoGetClassObject to cause the call to fail for you? -- Rob Shearman

5 12

Only 205 nonleak valgrind errors left!
by Dan Kegel 17 Jun '08

17 Jun '08

Changes since yesterday: - added suppression for glibc bug in if_nameindex - added two patches by Huw, one by Rob, one by Jon, one by Roy - fixed split script; broken out error files now more complete This gets us down from 218 to 205 or so. (Please join the party! We can use all the help we can get getting rid of these bugs; though many are innocuous to users, a few aren't, and they're all annoying to anyone using valgrind. It remains to be seen how many of these patches Alexandre will accept after 1.0 is out, but I'm hopeful we can get most of them up to his standards.) Report showing unique nonleak errors: http://kegel.com/wine/valgrind/logs-2008-06-16.counts.txt Logs: http://kegel.com/wine/valgrind/logs-2008-06-16.log.gz http://kegel.com/wine/valgrind/logs-2008-06-16/ Pending wine patches: http://kegel.com/wine/valgrind/logs-2008-06-16-patches/ http://kegel.com/wine/valgrind/logs-2008-06-16-patches.tgz http://kegel.com/wine/valgrind/logs-2008-06-16-patch.txt Suppression file: http://kegel.com/wine/valgrind/valgrind-suppressions

1 0

Re: Update generated packing tests using current headers.
by Paul Vriens 17 Jun '08

17 Jun '08

Rob Shearman wrote: > --- > dlls/rpcrt4/tests/generated.c | 47 ++++++++++++++++++++++++++------------- > dlls/wininet/tests/generated.c | 4 +- > 2 files changed, 33 insertions(+), 18 deletions(-) > > > ------------------------------------------------------------------------ > > Aren't these files generated (as apart from the name, the first line in those files tells us)? So does this patch miss the tools/winapi/tests.dat part? -- Cheers, Paul.

2 1

When submitting valgrind patches...
by Dan Kegel 17 Jun '08

17 Jun '08

... please include the magic phrase Fixes valgrind warnings like: in the body, followed by an example of the valgrind warnings in question, with addresses and boring parts removed. For example, see http://www.winehq.org/pipermail/wine-patches/2008-June/055658.html That will make it a lot easier to search for the patches. Thanks!

1 0