July 2008 - Wine-devel - list.winehq.org

Re: mshtml.dll:Add implementation of HTMLDocument_(Get|Set)Title
by Jacek Caban 09 Jul '08

09 Jul '08

Ivan Sinitsin wrote: > Changelog: > mshtml.dll:Add implementation of HTMLDocument_(Get|Set)Title > First of all it would be nice if you could add a test case for these. >static HRESULT WINAPI HTMLDocument_put_title(IHTMLDocument2 *iface, BSTR v) > { > HTMLDocument *This = HTMLDOC_THIS(iface); >- FIXME("(%p)->(%s)\n", This, debugstr_w(v)); >- return E_NOTIMPL; >+ nsIDOMDocument *nsdoc; >+ nsIDOMHTMLDocument *nshtmldoc; >+ nsAString nsstr; >+ nsresult nsres; >+ >+ TRACE("(%p)->(%s)\n", This, debugstr_w(v)); >+ >+ if(!This->nscontainer) >+ return E_POINTER; >+ >+ nsres = nsIWebNavigation_GetDocument(This->nscontainer->navigation, &nsdoc); >+ if(NS_FAILED(nsres)) { >+ ERR("GetDocument failed: %08x\n", nsres); >+ return nsres; >+ } >+ >+ if(NS_FAILED(nsres) || !nsdoc). >+ return E_FAIL; >+ >+ nsIDOMDocument_QueryInterface(nsdoc, &IID_nsIDOMHTMLDocument, (void**)&nshtmldoc); >+ nsIDOMDocument_Release(nsdoc); >+ >+ nsAString_Init(&nsstr, NULL); >+ nsAString_SetData(&nsstr, v); Use second argument of nsAString_Init instead of nsAString_SetData. >+ >+ nsres = nsIDOMHTMLDocument_SetTitle(nshtmldoc, &nsstr); >+ nsIDOMHTMLDocument_Release(nshtmldoc); >+ You leak nsstr here. >+ return nsres; Don't mix nsresult with HRESULT. You should return S_OK here. > } > > static HRESULT WINAPI HTMLDocument_get_title(IHTMLDocument2 *iface, BSTR *p) > { > HTMLDocument *This = HTMLDOC_THIS(iface); >- FIXME("(%p)->(%p)\n", This, p); >- return E_NOTIMPL; >+ nsIDOMDocument *nsdoc; >+ nsIDOMHTMLDocument *nshtmldoc; >+ nsAString nsstr; >+ const PRUnichar *ret; >+ nsresult nsres; >+ >+ TRACE("(%p)->(%p)\n", This, p); >+ >+ if (!p). >+ return E_POINTER; >+ >+ if(!This->nscontainer) >+ return E_POINTER; >+ >+ nsres = nsIWebNavigation_GetDocument(This->nscontainer->navigation, &nsdoc); >+ if(NS_FAILED(nsres)) { >+ ERR("GetDocument failed: %08x\n", nsres); >+ return nsres; >+ } >+ >+ if(NS_FAILED(nsres) || !nsdoc). >+ return E_FAIL; >+ >+ nsIDOMDocument_QueryInterface(nsdoc, &IID_nsIDOMHTMLDocument, (void**)&nshtmldoc); >+ nsIDOMDocument_Release(nsdoc); >+ >+ nsAString_Init(&nsstr, NULL); >+ >+ nsres = nsIDOMHTMLDocument_GetTitle(nshtmldoc, &nsstr); >+ nsIDOMHTMLDocument_Release(nshtmldoc); >+ >+ if (NS_FAILED(nsres)) >+ return nsres; Don't mix nsresult with HRESULT. Also ERR would be nice in this case. >+ >+ nsAString_GetData(&nsstr, &ret); >+ *p = SysAllocString(ret); DOM API usually returns NULL instead of empty string. That's worth testing. >+ >+ return nsres; > } Again, don't mix nsresult with HRESULT. Jacek

2 1

Re: msvcrt: Fix printf exponent with tests (resend/update)
by Alexandre Julliard 09 Jul '08

09 Jul '08

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > diff --git a/dlls/msvcrt/wcs.c b/dlls/msvcrt/wcs.c > index 14daf90..bbbc3f1 100644 > --- a/dlls/msvcrt/wcs.c > +++ b/dlls/msvcrt/wcs.c > @@ -481,6 +481,44 @@ static void pf_integer_conv( char *buf, int buf_len, pf_flags *flags, > return; > } > > +/* pf_fixup_exponent: convert a string containing a 1 or 2 digit exponent > + to 3 digits, accounting for padding, in place */ The comments don't match the code, you don't handle a 1 digit exponent. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 2/2] user32: Set WM_NOSIZE for windows smaller than SM_CXMINTRACK/SM_CYMINTRACK.
by Alexandre Julliard 09 Jul '08

09 Jul '08

"Lei Zhang" <thestig(a)google.com> writes: > I'm trying to make the test in patch 1/2 pass. > > - I want DEFWND_HandleWindowPosChanged to see SWP_NOCLIENTSIZE = 1. > - SWP_NOCLIENTSIZE gets set to 0 in SWP_DoNCCalcSize because the > client size has changed. > - the client size has changed because the window size has changed? > - the window size changed because it was 100, and > GetSystemMetrics(SM_CXMINTRACK) returns 112. > > so it looks like I just need to set SWP_NOSIZE. That's certainly wrong too, I think you are still on the wrong track. You need to write more test cases. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Gdiplus 07/15] Stub GdipFillRegion
by Huw Davies 09 Jul '08

09 Jul '08

On Wed, Jul 09, 2008 at 03:33:47AM -0400, Adam Petaccia wrote: > --- > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/region.c | 11 +++++++++++ > 2 files changed, 12 insertions(+), 1 deletions(-) > > diff --git a/dlls/gdiplus/region.c b/dlls/gdiplus/region.c > index 3d95723..717119f 100644 > --- a/dlls/gdiplus/region.c > +++ b/dlls/gdiplus/region.c > @@ -156,6 +156,17 @@ GpStatus WINGDIPAPI GdipDeleteRegion(GpRegion *region) > return NotImplemented; > } > > +GpStatus WINGDIPAPI GdipFillRegion(GpGraphics* graphics, GpBrush* brush, > + GpRegion* region) > +{ > + if (!(graphics && brush && region)) > + return InvalidParameter; > + > + FIXME("(%p, %p, %p): stub\n", graphics, brush, region); > + > + return NotImplemented; > +} > + Msdn lists this in the 'graphics' section of the gdiplus flat api, so I'd suggest it goes in graphics.c Huw. -- Huw Davies huw(a)codeweavers.com

1 0

Re: [1/2] richedit: Prevented cursor flicker while moving over selection bar
by Alexandre Julliard 09 Jul '08

09 Jul '08

"Dylan Smith" <dylan.ah.smith(a)gmail.com> writes: > diff --git a/dlls/riched20/editor.c b/dlls/riched20/editor.c > index 7e90096..96ab4aa 100644 > --- a/dlls/riched20/editor.c > +++ b/dlls/riched20/editor.c > @@ -1663,10 +1663,13 @@ static int ME_CalculateClickCount(HWND hWnd, UINT msg, WPARAM wParam, > return clickNum; > } > > -static BOOL ME_SetCursor(ME_TextEditor *editor, int x) > +static BOOL ME_SetCursor(ME_TextEditor *editor) > { > + POINT pt; > + GetCursorPos(&pt); > + ScreenToClient(editor->hWnd, &pt); In general GetCursorPos should be avoided. It incurs an X server round-trip, and it's asynchronous so the position may not match the message you are currently processing. Something like GetMessagePos is usually better. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: bug 14361: co-operate with valgrind at execv
by Alexandre Julliard 09 Jul '08

09 Jul '08

John Reiser <jreiser(a)BitWagon.com> writes: > Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14361 > co-operate with valgrind at execv You shouldn't need anything like that, running the whole thing including the preloader under valgrind should work fine. At worst some reservations will fail but that shouldn't be an issue for the apps that we'd want to valgrind. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: wininet: tests/http.c: Improve HttpOpenRequest test
by Alexandre Julliard 09 Jul '08

09 Jul '08

Zac Brown <zac(a)zacbrown.org> writes: > + SetLastError(0xdeadbeef); > ret = HttpSendRequest(request, NULL, 0, NULL, 0); > ok(ret, "HttpSendRequest failed: %u\n", GetLastError()); > + ok(GetLastError() == ERROR_FILE_NOT_FOUND || > + GetLastError() == ERROR_SUCCESS, > + "HttpSendRequest failed, got %u.\n", GetLastError()); > ok(InternetCloseHandle(request), "Close request handle failed\n"); Testing last error on success is not useful, unless it's explicitly specified that last error is set, or there is an app that depends on it. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32: Add test for GetDC
by Alexandre Julliard 09 Jul '08

09 Jul '08

Ilya Shpigor <shpigor(a)etersoft.ru> writes: > Add test for GetDC. This test check is WM_PAINT message send by GetDC > function. There isn't even a GetDC call in that test. Most likely all you are seeing is that expose events generate WM_PAINT, which is as it should be. What are you trying to test? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Alexandre Julliard : dinput: Don' t depend on the dxerr8 static library in the tests.
by Vitaliy Margolen 09 Jul '08

09 Jul '08

Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: b648dac7e12f593589661d03449e0f092b363f87 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=b648dac7e12f593589661d034… > > Author: Alexandre Julliard <julliard(a)winehq.org> > Date: Tue Jul 8 17:49:03 2008 +0200 > > dinput: Don't depend on the dxerr8 static library in the tests. > > --- > > dlls/dinput/tests/Makefile.in | 2 +- > dlls/dinput/tests/device.c | 27 ++++++------ > dlls/dinput/tests/joystick.c | 95 ++++++++++++++++------------------------- > dlls/dinput/tests/keyboard.c | 39 ++++++++--------- > dlls/dinput/tests/mouse.c | 27 ++++++------ > 5 files changed, 83 insertions(+), 107 deletions(-) > > Diff: http://source.winehq.org/git/wine.git/?a=commitdiff;h=b648dac7e12f593589661… > > > Any particular reason for this patch? It makes it that much more complicated to decipher what the error code is. Vitaliy.

2 1

Re: Slovak translation for shlwapi
by Vladimir Pankratov 09 Jul '08

09 Jul '08

Kario wrote: > hi, i write slovak translation for shlwapi, > > if there is needed GPL header, feel free to append it > > and write me if i must include GPL > > please commit, thanks, bye > > > > see attachment > > > > btw. if you want that i send to you diff/patch file, > > please write me the full command for git > > > > === reklama ====================================== > http://mail.szm.com - e-mail a priestor na www stranku zadarmo > http://webhosting.szm.com - domeny a webhosting za najnizsie ceny > > > > ------------------------------------------------------------------------ > > Hello. Instruction for translate. Copy the English file as your file (let's say Sk.rc). Modify the LANGUAGE line. Lookup you language code in include/winnt.h and the sublangage rule for your language on SublangNeutral (or copy them from another file in your langauge) Translate the string If you havn't GIT, use diff -u. If you need more information please visit http://www.winehq.org/site/sending_patches, or feel free to write letter to me... Good luck.

1 0