July 2008 - Wine-devel - list.winehq.org

Re: msxml3/test: Added ISAXXMLReader test. (4/18) (resend)
by Alistair Leslie-Hughes 08 Jul '08

08 Jul '08

"Piotr Caban" <piotr.caban(a)gmail.com> wrote in message news:200807082053.43537.piotr.caban(a)gmail.com... > --- > dlls/msxml3/tests/Makefile.in | 3 +- > dlls/msxml3/tests/saxreader.c | 225 > +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 227 insertions(+), 1 deletions(-) > create mode 100644 dlls/msxml3/tests/saxreader.c > >hr = ISAXXMLReader_putContentHandler(reader, &contentHandler); >+ ok(hr == S_OK, "Expected S_OK, got %08x\n", hr); > Hi Piotr, What about more tests for invalid parameters? eg. hr = ISAXXMLReader_putContentHandler(reader, NULL); Add some tests for get_contentHandler to confirm that putContentHandler works. Best Regards Alistair Leslie-Hughes

2 4

Re: msxml3: Implemented domdoc_put_documentElement. (6/18) (resend)
by Alistair Leslie-Hughes 08 Jul '08

08 Jul '08

"Piotr Caban" <piotr.caban(a)gmail.com> wrote in message news:200807082054.16342.piotr.caban(a)gmail.com... > --- > dlls/msxml3/domdoc.c | 22 ++++++++++++++++++---- > 1 files changed, 18 insertions(+), 4 deletions(-) > -------------------------------------------------------------------------------- Hi Piotr, Your missing test cases. Best Regards Alistair Leslie-Hughes

1 0

Re: msxml3: Added ISAXMLReader_getContentHandler implementation (2/18)(resend)
by Alistair Leslie-Hughes 08 Jul '08

08 Jul '08

"Piotr Caban" <piotr.caban(a)gmail.com> wrote in message news:200807082052.26353.piotr.caban(a)gmail.com... > --- > dlls/msxml3/saxreader.c | 8 ++++++-- > 1 files changed, 6 insertions(+), 2 deletions(-) > -------------------------------------------------------------------------------- Hi Piotr, You need to check the parameter is not NULL, and add tests cases. Best Regards Alistair Leslie-Hughes

1 0

Re: [PATCH 2/5] dinput: Stop and unload effect when freeing it.
by Daniel Remenak 08 Jul '08

08 Jul '08

On Sat, Jul 5, 2008 at 9:24 PM, Vitaliy Margolen <wine-patches(a)kievinfo.com> wrote: <snip> > + LinuxInputEffectImpl_Stop(iface); > + LinuxInputEffectImpl_Unload(iface); <snip> Vitaliy, Native behavior is for Unload to stop the effect also (see msdn or test it yourself), so the call to Stop here is unnecessary. If the call to Stop is required, it must be done in Unload, not Release, as it's not unusual to unload an effect without releasing it when a game has a large number of available effect instances. It is my understanding that no explicit call to Stop is needed, either in Release or Unload, as evdev has the same behavior documented (see section 3.3 of ff.txt in the kernel docs). The call to Unload is certainly correct, and I don't think there's anything strictly wrong with calling Stop; just make sure it's not covering up a bug in Unload. Regards, Daniel Remenak

2 1

Re: Slovak translation for comctl32
by Vitaliy Margolen 08 Jul '08

08 Jul '08

Kario wrote: > hi, my name is Mario Kacmar and I am from Slovakia > > I made Slovak translation for comctl32 > > please commit this patch > > if there is needed GPL header, feel free to append it > > You have to explicitly state the license of your contribution. Not the GPL will not work, as Wine is LGPL v2. All patches should be in unified diff format diffed from the top of the tree. Use of GIT highly encouraged but not required. See here for more details: http://wiki.winehq.org/SubmittingPatches Vitaliy.

1 0

Re: bug 14370: adjust timeout interval for virtulaizers
by Vitaliy Margolen 08 Jul '08

08 Jul '08

John Reiser wrote: > Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14370 > adjust timeout interval for virtulaizers This should go into registry not environment. See other discussion about the same topic. Vitaliy.

1 0

Re: bug 14365: do not touch high address space (initial stack, user_space_limit)
by Vitaliy Margolen 08 Jul '08

08 Jul '08

John Reiser wrote: > Attached is the patch for http://bugs.winehq.org/show_bug.cgi?id=14365 > do not touch high address space (initial stack, user_space_limit) So what's wrong with what Wine doing now? The part you removed states what it's there for - to prevent needless allocation attempts at the end of the address space. > > -- John Reiser, jreiser(a)BitWagon.com > > --- wine-1.0/libs/wine/mmap.c 2008-06-17 07:07:31.000000000 -0700 > +++ po49996-2008-06-30/wine-1.0/libs/wine/mmap.c 2008-06-30 17:18:29.000000000 -0700 > @@ -233,7 +233,9 @@ > return try_mmap_fixed( addr, size, PROT_NONE, flags, get_fdzero(), 0 ); > #endif > ptr = mmap( addr, size, PROT_NONE, flags, get_fdzero(), 0 ); > - if (ptr != addr && ptr != (void *)-1) munmap( ptr, size ); > + if (ptr != addr && ptr != (void *)-1) { > + munmap( ptr, size ); > + } > return (ptr == addr); > } What's the point of this change? > > @@ -321,8 +323,8 @@ > struct reserved_area *area; > struct list *ptr; > #if defined(__i386__) && !defined(__FreeBSD__) && !defined(__FreeBSD_kernel__) /* commented out until FreeBSD gets fixed */ > - char stack; > - char * const stack_ptr = &stack; > + //char stack; > + //char * const stack_ptr = &stack - (10*1024*1024); // 10M stack expansion > char *user_space_limit = (char *)0x7ffe0000; No C++ comments please. If you removing something - remove it don't comment it. Vitaliy.

1 0

Re: Slovak translation for shlwapi
by Owen Rudge 08 Jul '08

08 Jul '08

Hi Kario, > btw. if you want that i send to you diff/patch file, > please write me the full command for git You should avoid sending messages in HTML to the mailing lists. Send them in plain text instead. With regards to generating a patch, see this wiki page: http://wiki.winehq.org/GitWine#head-f7a29e7ed999b5924748a60c5a1cd4a019032d26 Regards, -- Owen Rudge http://www.owenrudge.net/

1 0

Re: [1 of 2] comctl32: add test for disabling owner of modal property sheets
by Roy Shea 08 Jul '08

08 Jul '08

Hello Vincent, Looks like you've some DOS line breaks mixed into this patch through the register_parent_wnd_class function. Not sure if you meant to do that. Peace, -Roy On Tue, Jul 8, 2008 at 3:22 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > >

2 1

RE: [PATCH 1/4] ddraw: Force surfaces without memory flags to video memory on creation.
by Stefan Dösinger 08 Jul '08

08 Jul '08

I think there's code that does that for render targets. It would be good if those are combined, or the render target flag adjustment just removed if it is not needed any longer > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Alexander Dorofeyev > Sent: Tuesday, July 08, 2008 3:52 PM > To: wine-patches(a)winehq.org > Subject: [PATCH 1/4] ddraw: Force surfaces without memory flags to > video memory on creation. > > This fixes some missing textures in Forsaken, where renderer expects to > see that texture is in video memory and gets confused otherwise. > > Tested in patch 2/4. > --- > dlls/ddraw/ddraw.c | 9 ++++++--- > dlls/ddraw/texture.c | 6 ------ > 2 files changed, 6 insertions(+), 9 deletions(-)

2 1